)]}'
{"neutron/plugins/ml2/drivers/ovn/mech_driver/mech_driver.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6d702190a1e63f4d50b2b5fafc34d8d994ec955d","unresolved":true,"context_lines":[{"line_number":1157,"context_line":"            return False"},{"line_number":1158,"context_line":""},{"line_number":1159,"context_line":"        br_mappings \u003d (agent.get(\u0027configurations\u0027, {}).get(\u0027bridge-mappings\u0027)"},{"line_number":1160,"context_line":"                       or \u0027\u0027)"},{"line_number":1161,"context_line":"        mapping_dict \u003d helpers.parse_mappings(br_mappings.split(\u0027,\u0027),"},{"line_number":1162,"context_line":"                                              unique_values\u003dFalse)"},{"line_number":1163,"context_line":"        return segment[\u0027physical_network\u0027] in mapping_dict"}],"source_content_type":"text/x-python","patch_set":3,"id":"2191dcb9_b6211522","line":1160,"updated":"2021-11-10 14:36:12.000000000","message":"nit: it can be simply:\n\n    br_mappings \u003d agent.get(\u0027configurations\u0027, {}).get(\u0027bridge-mappings\u0027, \u0027\u0027)","commit_id":"43e9e8ee0fced15318b9f4a48b00dcf2d37ad5c5"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"82934a59ec219b331ea5a91034d809474496d9a0","unresolved":true,"context_lines":[{"line_number":1157,"context_line":"            return False"},{"line_number":1158,"context_line":""},{"line_number":1159,"context_line":"        br_mappings \u003d (agent.get(\u0027configurations\u0027, {}).get(\u0027bridge-mappings\u0027)"},{"line_number":1160,"context_line":"                       or \u0027\u0027)"},{"line_number":1161,"context_line":"        mapping_dict \u003d helpers.parse_mappings(br_mappings.split(\u0027,\u0027),"},{"line_number":1162,"context_line":"                                              unique_values\u003dFalse)"},{"line_number":1163,"context_line":"        return segment[\u0027physical_network\u0027] in mapping_dict"}],"source_content_type":"text/x-python","patch_set":3,"id":"4ee67b1c_11bdf03c","line":1160,"in_reply_to":"2191dcb9_b6211522","updated":"2021-11-27 12:44:58.000000000","message":"If we assume that the default value stored in \"bridge-mappings\" is an empty string, yes.\n\nI\u0027ll change it.","commit_id":"43e9e8ee0fced15318b9f4a48b00dcf2d37ad5c5"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"3b4d0d5d331d7e085795450dfc7d13ba2d02ffe4","unresolved":false,"context_lines":[{"line_number":1157,"context_line":"            return False"},{"line_number":1158,"context_line":""},{"line_number":1159,"context_line":"        br_mappings \u003d (agent.get(\u0027configurations\u0027, {}).get(\u0027bridge-mappings\u0027)"},{"line_number":1160,"context_line":"                       or \u0027\u0027)"},{"line_number":1161,"context_line":"        mapping_dict \u003d helpers.parse_mappings(br_mappings.split(\u0027,\u0027),"},{"line_number":1162,"context_line":"                                              unique_values\u003dFalse)"},{"line_number":1163,"context_line":"        return segment[\u0027physical_network\u0027] in mapping_dict"}],"source_content_type":"text/x-python","patch_set":3,"id":"79944a80_718747cb","line":1160,"in_reply_to":"4ee67b1c_11bdf03c","updated":"2021-12-16 16:55:58.000000000","message":"Done","commit_id":"43e9e8ee0fced15318b9f4a48b00dcf2d37ad5c5"}]}
