)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"766c44d06291fe035d593b8c86b1e736c6a43e70","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Oleg Bondarev \u003cobondarev@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-03-20 15:23:21 +0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"agent report_states tests should consider parallel execution"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: #1294980"},{"line_number":10,"context_line":"Change-Id: I579fd1f51097e49417b609cb70b32fb9cdd1fe5c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAWH%2F%2FCFY%3D","line":7,"updated":"2014-03-20 19:23:44.000000000","message":"Can you put a little more \"meat\" on this commit message please? :) It would be great to have a sentence or two on what this patch is fixing and the strategy you took to fix it.","commit_id":"91cdc5ffa457649ae21abd5a8e9b6b21b61afbb2"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"d380b0d56e9d1744032cd4a680625e1542d02d81","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Oleg Bondarev \u003cobondarev@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-03-20 15:23:21 +0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"agent report_states tests should consider parallel execution"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: #1294980"},{"line_number":10,"context_line":"Change-Id: I579fd1f51097e49417b609cb70b32fb9cdd1fe5c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAWH%2F%2B%2Bw0%3D","line":7,"in_reply_to":"AAAAWH%2F%2FCFY%3D","updated":"2014-03-24 07:08:37.000000000","message":"Sure","commit_id":"91cdc5ffa457649ae21abd5a8e9b6b21b61afbb2"}],"neutron/tests/unit/openvswitch/test_agent_scheduler.py":[{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"a340a0fa9885cc1bc38b6b0345f3f87f70f2e7ab","unresolved":false,"context_lines":[{"line_number":236,"context_line":"        agents \u003d self._list_agents()"},{"line_number":237,"context_line":"        # with parallel execution there might be agents registered by"},{"line_number":238,"context_line":"        # other tests, hence using assertGreaterEqual"},{"line_number":239,"context_line":"        self.assertGreaterEqual(4, len(agents[\u0027agents\u0027]))"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def test_network_scheduling_on_network_creation(self):"},{"line_number":242,"context_line":"        self._register_agent_states()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2FGKQ%3D","line":239,"updated":"2014-03-20 09:53:00.000000000","message":"Could it be a good idea:\n\"\"\n _register_agent_states accepted an optional UUID to use as the host id, for example.\n\nand then _list_agents to accept that UUID also, making sure that we list only the agents related to this test\n\"\"\n\n?\n\n   Then we could assertEqual(4).\n\nBtw, this is not a generic solution for other objects, unless we start including some test_id along with objects that are created.\n\n\nI\u0027m setting my -1 just to get feedback on my question, not that I find the GreaterEqual solution unacceptable. But I wonder if the GreaterEqual solution could come with side effects. For example, if other tests is deleting all agents... or if our logic fails and we register more agents (unlikely?)","commit_id":"f489ed2fbf18785f32f3eaa556dbaf715c4105fb"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"05ffb65523f26e34d5b2a2798fec3c0c9785dd17","unresolved":false,"context_lines":[{"line_number":236,"context_line":"        agents \u003d self._list_agents()"},{"line_number":237,"context_line":"        # with parallel execution there might be agents registered by"},{"line_number":238,"context_line":"        # other tests, hence using assertGreaterEqual"},{"line_number":239,"context_line":"        self.assertGreaterEqual(4, len(agents[\u0027agents\u0027]))"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def test_network_scheduling_on_network_creation(self):"},{"line_number":242,"context_line":"        self._register_agent_states()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2FGDU%3D","line":239,"in_reply_to":"AAAAWH%2F%2FGKQ%3D","updated":"2014-03-20 10:08:22.000000000","message":"This is a good idea, however I\u0027m not sure how it addresses the concerns you\u0027ve mentioned regarding GreaterEqual approach. Also I think the main purpose of this test is to check that agent reporting results in agents being added to db and IMO the exact number of agents doesn\u0027t matter much.","commit_id":"f489ed2fbf18785f32f3eaa556dbaf715c4105fb"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e41939f9a2ad077c485c784ebe0b73b856aae384","unresolved":false,"context_lines":[{"line_number":236,"context_line":"        agents \u003d self._list_agents()"},{"line_number":237,"context_line":"        # with parallel execution there might be agents registered by"},{"line_number":238,"context_line":"        # other tests, hence checking for greater or equal"},{"line_number":239,"context_line":"        self.assertTrue(len(agents[\u0027agents\u0027]) \u003e\u003d len(agents_registered))"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def test_network_scheduling_on_network_creation(self):"},{"line_number":242,"context_line":"        self._register_agent_states()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2B3Vk%3D","line":239,"updated":"2014-03-22 13:55:36.000000000","message":"This is a unit test and in unit tests each will be run in a separate process. I am not sure why it is required. Could you explain more detail?","commit_id":"91cdc5ffa457649ae21abd5a8e9b6b21b61afbb2"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"d380b0d56e9d1744032cd4a680625e1542d02d81","unresolved":false,"context_lines":[{"line_number":236,"context_line":"        agents \u003d self._list_agents()"},{"line_number":237,"context_line":"        # with parallel execution there might be agents registered by"},{"line_number":238,"context_line":"        # other tests, hence checking for greater or equal"},{"line_number":239,"context_line":"        self.assertTrue(len(agents[\u0027agents\u0027]) \u003e\u003d len(agents_registered))"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def test_network_scheduling_on_network_creation(self):"},{"line_number":242,"context_line":"        self._register_agent_states()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2BznQ%3D","line":239,"in_reply_to":"AAAAWH%2F%2B3Vk%3D","updated":"2014-03-24 07:08:37.000000000","message":"Yeah, seems I was mistaken regarding the root cause, need to investigate more","commit_id":"91cdc5ffa457649ae21abd5a8e9b6b21b61afbb2"}]}