)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"83a1f665093cb3fc17ffe585a4204ce3b8f852e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"e7578ae9_37dec1c4","updated":"2022-01-28 11:24:45.000000000","message":"Should we add release note here or maybe You will do it later in follow up patch?","commit_id":"c0409f7aa86aa7ac3c542edef156fff56289fd2d"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"72d0e30bd974cd5a8a870d69a50b22135ad5445b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"273d10f8_3a1bb9bb","updated":"2022-01-04 16:21:19.000000000","message":"recheck","commit_id":"c0409f7aa86aa7ac3c542edef156fff56289fd2d"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"689dde0e71e0c1c334dd763eab492e28ea35f4f5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"43111302_76003acc","updated":"2022-01-12 08:37:27.000000000","message":"recheck","commit_id":"c0409f7aa86aa7ac3c542edef156fff56289fd2d"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f8dc9e388d54cca4ad79a561e319f3e65881bebc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"02dd24b5_4e78f1b1","in_reply_to":"e7578ae9_37dec1c4","updated":"2022-01-28 13:46:46.000000000","message":"I\u0027ll add a reno in this one. At this end of this series, I\u0027ll update the QoS documentation.","commit_id":"c0409f7aa86aa7ac3c542edef156fff56289fd2d"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"87e7396f8db84b7b7717bcf1c420b86ebda79d43","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"05913b3b_558e387b","updated":"2022-01-31 17:38:57.000000000","message":"recheck","commit_id":"8dfe5cc95ba8d27ff59f710a34418d46a0d25144"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6a3262fe9375afa1ee0aba11c3a43e098857163f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"607b81d5_ffca88c3","updated":"2022-01-28 17:32:04.000000000","message":"recheck","commit_id":"8dfe5cc95ba8d27ff59f710a34418d46a0d25144"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"873f6071cc6e0a27b66c65ffecd1c0e60a939ed5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"d94cd0ab_571b097e","updated":"2022-02-02 16:49:53.000000000","message":"recheck","commit_id":"8dfe5cc95ba8d27ff59f710a34418d46a0d25144"}],"neutron/objects/qos/binding.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"83a1f665093cb3fc17ffe585a4204ce3b8f852e6","unresolved":true,"context_lines":[{"line_number":103,"context_line":"    _bound_model_id \u003d db_model.fip_id"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    @classmethod"},{"line_number":106,"context_line":"    def get_fips_by_network_id(cls, context, network_id, policy_id\u003dNone):"},{"line_number":107,"context_line":"        query \u003d context.session.query(models_l3.FloatingIP).filter("},{"line_number":108,"context_line":"            models_l3.FloatingIP.floating_network_id \u003d\u003d network_id)"},{"line_number":109,"context_line":"        if policy_id:"}],"source_content_type":"text/x-python","patch_set":7,"id":"a61f4a96_1488cda6","line":106,"range":{"start_line":106,"start_character":57,"end_line":106,"end_character":71},"updated":"2022-01-28 11:24:45.000000000","message":"where this is used? I didn\u0027t found it anywhere in this patch","commit_id":"c0409f7aa86aa7ac3c542edef156fff56289fd2d"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a1e96d9b156c731b50454abd60d713d79af72406","unresolved":true,"context_lines":[{"line_number":103,"context_line":"    _bound_model_id \u003d db_model.fip_id"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    @classmethod"},{"line_number":106,"context_line":"    def get_fips_by_network_id(cls, context, network_id, policy_id\u003dNone):"},{"line_number":107,"context_line":"        query \u003d context.session.query(models_l3.FloatingIP).filter("},{"line_number":108,"context_line":"            models_l3.FloatingIP.floating_network_id \u003d\u003d network_id)"},{"line_number":109,"context_line":"        if policy_id:"}],"source_content_type":"text/x-python","patch_set":7,"id":"b7587b68_920ea85a","line":106,"range":{"start_line":106,"start_character":57,"end_line":106,"end_character":71},"in_reply_to":"89ee8f98_7783fb2f","updated":"2022-02-01 09:33:47.000000000","message":"ok, thx for explanation","commit_id":"c0409f7aa86aa7ac3c542edef156fff56289fd2d"},{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"12bb74d44379eefd200b03286a216825bf6c55a5","unresolved":true,"context_lines":[{"line_number":103,"context_line":"    _bound_model_id \u003d db_model.fip_id"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    @classmethod"},{"line_number":106,"context_line":"    def get_fips_by_network_id(cls, context, network_id, policy_id\u003dNone):"},{"line_number":107,"context_line":"        query \u003d context.session.query(models_l3.FloatingIP).filter("},{"line_number":108,"context_line":"            models_l3.FloatingIP.floating_network_id \u003d\u003d network_id)"},{"line_number":109,"context_line":"        if policy_id:"}],"source_content_type":"text/x-python","patch_set":7,"id":"685ab271_09258f91","line":106,"range":{"start_line":106,"start_character":57,"end_line":106,"end_character":71},"in_reply_to":"a61f4a96_1488cda6","updated":"2022-01-28 12:08:34.000000000","message":"+1. As far as I can see this will always be assigned to None in the code.","commit_id":"c0409f7aa86aa7ac3c542edef156fff56289fd2d"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f8dc9e388d54cca4ad79a561e319f3e65881bebc","unresolved":true,"context_lines":[{"line_number":103,"context_line":"    _bound_model_id \u003d db_model.fip_id"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    @classmethod"},{"line_number":106,"context_line":"    def get_fips_by_network_id(cls, context, network_id, policy_id\u003dNone):"},{"line_number":107,"context_line":"        query \u003d context.session.query(models_l3.FloatingIP).filter("},{"line_number":108,"context_line":"            models_l3.FloatingIP.floating_network_id \u003d\u003d network_id)"},{"line_number":109,"context_line":"        if policy_id:"}],"source_content_type":"text/x-python","patch_set":7,"id":"89ee8f98_7783fb2f","line":106,"range":{"start_line":106,"start_character":57,"end_line":106,"end_character":71},"in_reply_to":"a61f4a96_1488cda6","updated":"2022-01-28 13:46:46.000000000","message":"It is not, but it make sense because of the filtering done. If no policy_id is passed, then method returns only the FIPs **without** QoS policy. This is the key point of this method.\n\nIt makes sense to provide the \"policy_id\" input parameter because of this filtering we are doing. And because we accept this parameter, makes sense to implement the correct logic for it.\n\nI\u0027ll document the method.","commit_id":"c0409f7aa86aa7ac3c542edef156fff56289fd2d"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"a2aeea369cd5f70b931322394f8c1935a7e25553","unresolved":true,"context_lines":[{"line_number":103,"context_line":"    _bound_model_id \u003d db_model.fip_id"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    @classmethod"},{"line_number":106,"context_line":"    def get_fips_by_network_id(cls, context, network_id, policy_id\u003dNone):"},{"line_number":107,"context_line":"        query \u003d context.session.query(models_l3.FloatingIP).filter("},{"line_number":108,"context_line":"            models_l3.FloatingIP.floating_network_id \u003d\u003d network_id)"},{"line_number":109,"context_line":"        if policy_id:"}],"source_content_type":"text/x-python","patch_set":7,"id":"bc24c096_48d7a3fb","line":106,"range":{"start_line":106,"start_character":57,"end_line":106,"end_character":71},"in_reply_to":"b7587b68_920ea85a","updated":"2022-02-02 10:19:18.000000000","message":"++\n\nthanks for explaining it rodolfo","commit_id":"c0409f7aa86aa7ac3c542edef156fff56289fd2d"}],"neutron/objects/qos/policy.py":[{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"12bb74d44379eefd200b03286a216825bf6c55a5","unresolved":true,"context_lines":[{"line_number":333,"context_line":"                                                          self.id)"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"    def get_bound_floatingips(self):"},{"line_number":336,"context_line":"        return binding.QosPolicyFloatingIPBinding.get_bound_ids("},{"line_number":337,"context_line":"            self.obj_context, self.id)"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"    def get_bound_routers(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba133fb4_b8ba46ce","line":336,"range":{"start_line":336,"start_character":50,"end_line":336,"end_character":64},"updated":"2022-01-28 12:08:34.000000000","message":"This looks better like this, nice one :)","commit_id":"8dfe5cc95ba8d27ff59f710a34418d46a0d25144"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/extensions/qos.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"a2aeea369cd5f70b931322394f8c1935a7e25553","unresolved":true,"context_lines":[{"line_number":247,"context_line":"    def update_network(self, txn, network, original_network, reset\u003dFalse,"},{"line_number":248,"context_line":"                       qos_rules\u003dNone):"},{"line_number":249,"context_line":"        updated_port_ids \u003d set([])"},{"line_number":250,"context_line":"        updated_fip_ids \u003d set([])"},{"line_number":251,"context_line":"        if not reset and not original_network:"},{"line_number":252,"context_line":"            # If there is no information about the previous QoS policy, do not"},{"line_number":253,"context_line":"            # make any change."}],"source_content_type":"text/x-python","patch_set":8,"id":"178a71c9_5be05017","line":250,"updated":"2022-02-02 10:19:18.000000000","message":"nit: don\u0027t need to pass an empty list when initializing a set()","commit_id":"8dfe5cc95ba8d27ff59f710a34418d46a0d25144"}]}