)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"62e515b4559799e84746873d812803856439df30","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"da354bfb_b46a393f","updated":"2021-11-20 01:11:09.000000000","message":"recheck Neutron agent not present. I think this is not related to the patch.","commit_id":"eb6f536d5e5be0231442750a2999055e4476af56"},{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"318ae39d101abd34e3c921390cf0723c381273c3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"c5b30ff2_68526ae6","updated":"2021-11-24 16:12:34.000000000","message":"Thanks for all your comments Rodolfo. I think it\u0027s fixed now!!","commit_id":"0725533a6fa6a42d361e518b027f69da8e1e1ec5"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"96a9700c7006fa9dc0f7266ff00b1a5a099caffc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"063e37ef_25f0ef47","updated":"2021-11-27 10:11:54.000000000","message":"recheck","commit_id":"0725533a6fa6a42d361e518b027f69da8e1e1ec5"},{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"204275c4e1469700ec56eedeabc02aad484dfee8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"2b86ddc5_bb73235d","updated":"2021-11-24 20:54:53.000000000","message":"recheck","commit_id":"0725533a6fa6a42d361e518b027f69da8e1e1ec5"},{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"867fee53a8a79dbe745404685ded432387356a0c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"2efcd671_126521b3","updated":"2021-11-25 08:13:51.000000000","message":"recheck","commit_id":"0725533a6fa6a42d361e518b027f69da8e1e1ec5"},{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"a700746ce4200b787d13eedb921d81b4ab2ddd9a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"c4da51f4_441f0132","updated":"2021-11-26 16:57:08.000000000","message":"recheck","commit_id":"0725533a6fa6a42d361e518b027f69da8e1e1ec5"},{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"8ca63befd61cbb00f71fac7c13291f6e85b1db6e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"fed07226_f069cad7","updated":"2021-11-26 08:57:55.000000000","message":"recheck \"ovn-northd did not start\"","commit_id":"0725533a6fa6a42d361e518b027f69da8e1e1ec5"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"3153c598436036c859444d6808a8dbf5e8069fb3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"1a22a5cf_85e880bc","updated":"2021-11-26 05:42:53.000000000","message":"recheck python39 timeout update will be taken care by https://review.opendev.org/c/openstack/neutron/+/819201","commit_id":"0725533a6fa6a42d361e518b027f69da8e1e1ec5"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8165f8cde811400e2170cf5db190cfbeb60dea32","unresolved":true,"context_lines":[{"line_number":399,"context_line":""},{"line_number":400,"context_line":"        return ha_ch_grp.uuid"},{"line_number":401,"context_line":""},{"line_number":402,"context_line":"    def create_port(self, context, port):"},{"line_number":403,"context_line":"        if utils.is_lsp_ignored(port):"},{"line_number":404,"context_line":"            return"},{"line_number":405,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7eeb0623_49ac1143","line":402,"range":{"start_line":402,"start_character":8,"end_line":402,"end_character":19},"updated":"2021-11-19 08:51:36.000000000","message":"Shouldn\u0027t those checks be executed inside \"create_router_port\", \"update_router_port\" and \"delete_router_port\"?","commit_id":"923b1d7c0dec0c60e769daa55c27d093ba231739"},{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"1a64eea62246acca3521cf41697dbc3a2177fbcc","unresolved":false,"context_lines":[{"line_number":399,"context_line":""},{"line_number":400,"context_line":"        return ha_ch_grp.uuid"},{"line_number":401,"context_line":""},{"line_number":402,"context_line":"    def create_port(self, context, port):"},{"line_number":403,"context_line":"        if utils.is_lsp_ignored(port):"},{"line_number":404,"context_line":"            return"},{"line_number":405,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"978f20e3_45fbfbcf","line":402,"range":{"start_line":402,"start_character":8,"end_line":402,"end_character":19},"in_reply_to":"7eeb0623_49ac1143","updated":"2021-11-19 19:06:03.000000000","message":"you are totally right. I did not realize about how these change_router_port() functions worked. I restructured the code and proposed an approach that I think is better","commit_id":"923b1d7c0dec0c60e769daa55c27d093ba231739"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8165f8cde811400e2170cf5db190cfbeb60dea32","unresolved":true,"context_lines":[{"line_number":505,"context_line":""},{"line_number":506,"context_line":"        db_rev.bump_revision(context, port, ovn_const.TYPE_PORTS)"},{"line_number":507,"context_line":""},{"line_number":508,"context_line":"        if ovn_conf.is_ovn_emit_need_to_frag_enabled() and \\"},{"line_number":509,"context_line":"                port.get(\u0027device_owner\u0027) \u003d\u003d const.DEVICE_OWNER_ROUTER_INTF:"},{"line_number":510,"context_line":"            router \u003d self._l3_plugin.get_router(context, port[\u0027device_id\u0027])"},{"line_number":511,"context_line":"            gw_port_id \u003d router.get(\u0027gw_port_id\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"aa77b822_bdecb667","line":508,"updated":"2021-11-19 08:51:36.000000000","message":"Why don\u0027t you execute this code inside the DB txn started in L431?","commit_id":"923b1d7c0dec0c60e769daa55c27d093ba231739"},{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"1a64eea62246acca3521cf41697dbc3a2177fbcc","unresolved":false,"context_lines":[{"line_number":505,"context_line":""},{"line_number":506,"context_line":"        db_rev.bump_revision(context, port, ovn_const.TYPE_PORTS)"},{"line_number":507,"context_line":""},{"line_number":508,"context_line":"        if ovn_conf.is_ovn_emit_need_to_frag_enabled() and \\"},{"line_number":509,"context_line":"                port.get(\u0027device_owner\u0027) \u003d\u003d const.DEVICE_OWNER_ROUTER_INTF:"},{"line_number":510,"context_line":"            router \u003d self._l3_plugin.get_router(context, port[\u0027device_id\u0027])"},{"line_number":511,"context_line":"            gw_port_id \u003d router.get(\u0027gw_port_id\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9c17a07d_78300d8a","line":508,"in_reply_to":"aa77b822_bdecb667","updated":"2021-11-19 19:06:03.000000000","message":"It should be inside, it\u0027s fixed now (in create_router_port)","commit_id":"923b1d7c0dec0c60e769daa55c27d093ba231739"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"0ef27961a8af0150f5bdd043ab2a96ef328710c1","unresolved":true,"context_lines":[{"line_number":705,"context_line":""},{"line_number":706,"context_line":"            if ovn_conf.is_ovn_emit_need_to_frag_enabled() and \\"},{"line_number":707,"context_line":"                    ovn_port.external_ids.get(\u0027neutron:device_owner\u0027) \u003d\u003d \\"},{"line_number":708,"context_line":"                    const.DEVICE_OWNER_ROUTER_INTF:"},{"line_number":709,"context_line":"                router \u003d self._l3_plugin.get_router(context,"},{"line_number":710,"context_line":"                        ovn_port.external_ids[\u0027neutron:device_id\u0027])"},{"line_number":711,"context_line":"                gw_port_id \u003d router.get(\u0027gw_port_id\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"672d5922_955b6f17","line":708,"updated":"2021-11-19 14:24:58.000000000","message":"Would be more consistent with other code in this file to not use \\ but instead wrap the conditionals in parens like L719.  Same comment would apply above as well.","commit_id":"923b1d7c0dec0c60e769daa55c27d093ba231739"},{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"1a64eea62246acca3521cf41697dbc3a2177fbcc","unresolved":false,"context_lines":[{"line_number":705,"context_line":""},{"line_number":706,"context_line":"            if ovn_conf.is_ovn_emit_need_to_frag_enabled() and \\"},{"line_number":707,"context_line":"                    ovn_port.external_ids.get(\u0027neutron:device_owner\u0027) \u003d\u003d \\"},{"line_number":708,"context_line":"                    const.DEVICE_OWNER_ROUTER_INTF:"},{"line_number":709,"context_line":"                router \u003d self._l3_plugin.get_router(context,"},{"line_number":710,"context_line":"                        ovn_port.external_ids[\u0027neutron:device_id\u0027])"},{"line_number":711,"context_line":"                gw_port_id \u003d router.get(\u0027gw_port_id\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"2cd21bff_47067816","line":708,"in_reply_to":"672d5922_955b6f17","updated":"2021-11-19 19:06:03.000000000","message":"Thanks for the review! I think you are right, I did not see other \\s in the code. I\u0027m not using them anymore on the new patch!","commit_id":"923b1d7c0dec0c60e769daa55c27d093ba231739"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"264377e94d192e24211e99b94d49936d4ab595f1","unresolved":true,"context_lines":[{"line_number":669,"context_line":"        if check_rev_cmd.result \u003d\u003d ovn_const.TXN_COMMITTED:"},{"line_number":670,"context_line":"            db_rev.bump_revision(context, port, ovn_const.TYPE_PORTS)"},{"line_number":671,"context_line":""},{"line_number":672,"context_line":"    def _delete_port(self, context, port_id, port_object\u003dNone):"},{"line_number":673,"context_line":"        ovn_port \u003d self._nb_idl.lookup("},{"line_number":674,"context_line":"            \u0027Logical_Switch_Port\u0027, port_id, default\u003dNone)"},{"line_number":675,"context_line":"        if ovn_port is None:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3b59088c_5204c821","line":672,"range":{"start_line":672,"start_character":27,"end_line":672,"end_character":34},"updated":"2021-11-24 12:31:38.000000000","message":"unrelated (and not used)","commit_id":"28d442d4b71dd1fcfb2428fda2cf45c3ba9d8568"},{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"318ae39d101abd34e3c921390cf0723c381273c3","unresolved":false,"context_lines":[{"line_number":669,"context_line":"        if check_rev_cmd.result \u003d\u003d ovn_const.TXN_COMMITTED:"},{"line_number":670,"context_line":"            db_rev.bump_revision(context, port, ovn_const.TYPE_PORTS)"},{"line_number":671,"context_line":""},{"line_number":672,"context_line":"    def _delete_port(self, context, port_id, port_object\u003dNone):"},{"line_number":673,"context_line":"        ovn_port \u003d self._nb_idl.lookup("},{"line_number":674,"context_line":"            \u0027Logical_Switch_Port\u0027, port_id, default\u003dNone)"},{"line_number":675,"context_line":"        if ovn_port is None:"}],"source_content_type":"text/x-python","patch_set":6,"id":"5c4f717a_f8b4aa47","line":672,"range":{"start_line":672,"start_character":27,"end_line":672,"end_character":34},"in_reply_to":"3b59088c_5204c821","updated":"2021-11-24 16:12:34.000000000","message":"you are 100% right","commit_id":"28d442d4b71dd1fcfb2428fda2cf45c3ba9d8568"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"264377e94d192e24211e99b94d49936d4ab595f1","unresolved":true,"context_lines":[{"line_number":707,"context_line":"    # keep things backward compatible. Remove it in the Rocky release."},{"line_number":708,"context_line":"    def delete_port(self, context, port_id, port_object\u003dNone):"},{"line_number":709,"context_line":"        try:"},{"line_number":710,"context_line":"            self._delete_port(context, port_id, port_object\u003dport_object)"},{"line_number":711,"context_line":"        except Exception as e:"},{"line_number":712,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":713,"context_line":"                LOG.error(\u0027Failed to delete port %(port)s. Error: \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"4930fe15_34776218","line":710,"range":{"start_line":710,"start_character":30,"end_line":710,"end_character":37},"updated":"2021-11-24 12:31:38.000000000","message":"unrelated (and not used)","commit_id":"28d442d4b71dd1fcfb2428fda2cf45c3ba9d8568"},{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"318ae39d101abd34e3c921390cf0723c381273c3","unresolved":false,"context_lines":[{"line_number":707,"context_line":"    # keep things backward compatible. Remove it in the Rocky release."},{"line_number":708,"context_line":"    def delete_port(self, context, port_id, port_object\u003dNone):"},{"line_number":709,"context_line":"        try:"},{"line_number":710,"context_line":"            self._delete_port(context, port_id, port_object\u003dport_object)"},{"line_number":711,"context_line":"        except Exception as e:"},{"line_number":712,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":713,"context_line":"                LOG.error(\u0027Failed to delete port %(port)s. Error: \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"d5567988_4393f208","line":710,"range":{"start_line":710,"start_character":30,"end_line":710,"end_character":37},"in_reply_to":"4930fe15_34776218","updated":"2021-11-24 16:12:34.000000000","message":"Done","commit_id":"28d442d4b71dd1fcfb2428fda2cf45c3ba9d8568"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"264377e94d192e24211e99b94d49936d4ab595f1","unresolved":true,"context_lines":[{"line_number":1421,"context_line":""},{"line_number":1422,"context_line":"        return ext_ids"},{"line_number":1423,"context_line":""},{"line_number":1424,"context_line":"    def _gen_router_port_options(self, context, port, network\u003dNone):"},{"line_number":1425,"context_line":"        options \u003d {}"},{"line_number":1426,"context_line":"        if network is None:"},{"line_number":1427,"context_line":"            network \u003d self._plugin.get_network(n_context.get_admin_context(),"}],"source_content_type":"text/x-python","patch_set":6,"id":"d46e7821_4c2d04ac","line":1424,"range":{"start_line":1424,"start_character":39,"end_line":1424,"end_character":46},"updated":"2021-11-24 12:31:38.000000000","message":"Not all networks can be accessible with this context. For example, in L1427 we are using admin context due to this circumstance. You should use admin context when retrieving the networks in L1445","commit_id":"28d442d4b71dd1fcfb2428fda2cf45c3ba9d8568"},{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"318ae39d101abd34e3c921390cf0723c381273c3","unresolved":false,"context_lines":[{"line_number":1421,"context_line":""},{"line_number":1422,"context_line":"        return ext_ids"},{"line_number":1423,"context_line":""},{"line_number":1424,"context_line":"    def _gen_router_port_options(self, context, port, network\u003dNone):"},{"line_number":1425,"context_line":"        options \u003d {}"},{"line_number":1426,"context_line":"        if network is None:"},{"line_number":1427,"context_line":"            network \u003d self._plugin.get_network(n_context.get_admin_context(),"}],"source_content_type":"text/x-python","patch_set":6,"id":"49b46a2c_c4b1e050","line":1424,"range":{"start_line":1424,"start_character":39,"end_line":1424,"end_character":46},"in_reply_to":"d46e7821_4c2d04ac","updated":"2021-11-24 16:12:34.000000000","message":"Done","commit_id":"28d442d4b71dd1fcfb2428fda2cf45c3ba9d8568"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"264377e94d192e24211e99b94d49936d4ab595f1","unresolved":true,"context_lines":[{"line_number":1442,"context_line":"                            self._get_router_ports(context,"},{"line_number":1443,"context_line":"                                port[\u0027device_id\u0027])])"},{"line_number":1444,"context_line":"            for net_id in network_ids:"},{"line_number":1445,"context_line":"                net \u003d self._plugin.get_network(context, net_id)"},{"line_number":1446,"context_line":"                if net[\u0027mtu\u0027] \u003e network[\u0027mtu\u0027]:"},{"line_number":1447,"context_line":"                    options[ovn_const.OVN_ROUTER_PORT_GW_MTU_OPTION] \u003d str("},{"line_number":1448,"context_line":"                            network[\u0027mtu\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"453db4d2_64452464","line":1445,"range":{"start_line":1445,"start_character":16,"end_line":1445,"end_character":63},"updated":"2021-11-24 12:31:38.000000000","message":"Instead of issuing one DB request per network, it is more efficient to request all networks in one command:\n\nfor net in self._plugin.get_networks(context, filters\u003d{\u0027id\u0027: network_ids}):\n  if net[\u0027mtu\u0027] \u003e network[\u0027mtu\u0027]: ...","commit_id":"28d442d4b71dd1fcfb2428fda2cf45c3ba9d8568"},{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"318ae39d101abd34e3c921390cf0723c381273c3","unresolved":false,"context_lines":[{"line_number":1442,"context_line":"                            self._get_router_ports(context,"},{"line_number":1443,"context_line":"                                port[\u0027device_id\u0027])])"},{"line_number":1444,"context_line":"            for net_id in network_ids:"},{"line_number":1445,"context_line":"                net \u003d self._plugin.get_network(context, net_id)"},{"line_number":1446,"context_line":"                if net[\u0027mtu\u0027] \u003e network[\u0027mtu\u0027]:"},{"line_number":1447,"context_line":"                    options[ovn_const.OVN_ROUTER_PORT_GW_MTU_OPTION] \u003d str("},{"line_number":1448,"context_line":"                            network[\u0027mtu\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"a855ce15_1752b633","line":1445,"range":{"start_line":1445,"start_character":16,"end_line":1445,"end_character":63},"in_reply_to":"453db4d2_64452464","updated":"2021-11-24 16:12:34.000000000","message":"Done","commit_id":"28d442d4b71dd1fcfb2428fda2cf45c3ba9d8568"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"264377e94d192e24211e99b94d49936d4ab595f1","unresolved":true,"context_lines":[{"line_number":1577,"context_line":""},{"line_number":1578,"context_line":"    def delete_router_port(self, context, port_id, router_id\u003dNone,"},{"line_number":1579,"context_line":"                           subnet_ids\u003dNone):"},{"line_number":1580,"context_line":"        print(\"DELETE ROUTER PORT\")"},{"line_number":1581,"context_line":"        try:"},{"line_number":1582,"context_line":"            ovn_port \u003d self._nb_idl.lookup("},{"line_number":1583,"context_line":"                \u0027Logical_Router_Port\u0027, utils.ovn_lrouter_port_name(port_id))"}],"source_content_type":"text/x-python","patch_set":6,"id":"4e8ef94a_7c1ece25","line":1580,"range":{"start_line":1580,"start_character":0,"end_line":1580,"end_character":5},"updated":"2021-11-24 12:31:38.000000000","message":"to remove","commit_id":"28d442d4b71dd1fcfb2428fda2cf45c3ba9d8568"},{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"318ae39d101abd34e3c921390cf0723c381273c3","unresolved":false,"context_lines":[{"line_number":1577,"context_line":""},{"line_number":1578,"context_line":"    def delete_router_port(self, context, port_id, router_id\u003dNone,"},{"line_number":1579,"context_line":"                           subnet_ids\u003dNone):"},{"line_number":1580,"context_line":"        print(\"DELETE ROUTER PORT\")"},{"line_number":1581,"context_line":"        try:"},{"line_number":1582,"context_line":"            ovn_port \u003d self._nb_idl.lookup("},{"line_number":1583,"context_line":"                \u0027Logical_Router_Port\u0027, utils.ovn_lrouter_port_name(port_id))"}],"source_content_type":"text/x-python","patch_set":6,"id":"7e1068a4_e3493e0f","line":1580,"range":{"start_line":1580,"start_character":0,"end_line":1580,"end_character":5},"in_reply_to":"4e8ef94a_7c1ece25","updated":"2021-11-24 16:12:34.000000000","message":"Done","commit_id":"28d442d4b71dd1fcfb2428fda2cf45c3ba9d8568"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"264377e94d192e24211e99b94d49936d4ab595f1","unresolved":true,"context_lines":[{"line_number":1625,"context_line":"            elif port:"},{"line_number":1626,"context_line":"                subnet_ids \u003d utils.get_port_subnet_ids(port)"},{"line_number":1627,"context_line":""},{"line_number":1628,"context_line":"            if ovn_conf.is_ovn_emit_need_to_frag_enabled():"},{"line_number":1629,"context_line":"                if router.get(\u0027gw_port_id\u0027):"},{"line_number":1630,"context_line":"                    provider_net \u003d self._plugin.get_network(context,"},{"line_number":1631,"context_line":"                            router[l3.EXTERNAL_GW_INFO][\u0027network_id\u0027])"},{"line_number":1632,"context_line":"                    self.set_gateway_mtu(context, provider_net, txn\u003dtxn)"}],"source_content_type":"text/x-python","patch_set":6,"id":"f83af744_8e9c811b","line":1629,"range":{"start_line":1628,"start_character":12,"end_line":1629,"end_character":43},"updated":"2021-11-24 12:31:38.000000000","message":"nit: in the same line:\n\nif (ovn_conf.is_ovn_emit_need_to_frag_enabled() and\n         router.get(\u0027gw_port_id\u0027)):","commit_id":"28d442d4b71dd1fcfb2428fda2cf45c3ba9d8568"},{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"318ae39d101abd34e3c921390cf0723c381273c3","unresolved":false,"context_lines":[{"line_number":1625,"context_line":"            elif port:"},{"line_number":1626,"context_line":"                subnet_ids \u003d utils.get_port_subnet_ids(port)"},{"line_number":1627,"context_line":""},{"line_number":1628,"context_line":"            if ovn_conf.is_ovn_emit_need_to_frag_enabled():"},{"line_number":1629,"context_line":"                if router.get(\u0027gw_port_id\u0027):"},{"line_number":1630,"context_line":"                    provider_net \u003d self._plugin.get_network(context,"},{"line_number":1631,"context_line":"                            router[l3.EXTERNAL_GW_INFO][\u0027network_id\u0027])"},{"line_number":1632,"context_line":"                    self.set_gateway_mtu(context, provider_net, txn\u003dtxn)"}],"source_content_type":"text/x-python","patch_set":6,"id":"12591a1f_36944cb1","line":1629,"range":{"start_line":1628,"start_character":12,"end_line":1629,"end_character":43},"in_reply_to":"f83af744_8e9c811b","updated":"2021-11-24 16:12:34.000000000","message":"Done","commit_id":"28d442d4b71dd1fcfb2428fda2cf45c3ba9d8568"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"264377e94d192e24211e99b94d49936d4ab595f1","unresolved":true,"context_lines":[{"line_number":1654,"context_line":"                # otherwise, we just update the revision database"},{"line_number":1655,"context_line":"                db_rev.bump_revision("},{"line_number":1656,"context_line":"                    context, port, ovn_const.TYPE_ROUTER_PORTS)"},{"line_number":1657,"context_line":"        print(\"END DELETE ROUTER PORT\")"},{"line_number":1658,"context_line":""},{"line_number":1659,"context_line":"    def update_nat_rules(self, router, networks, enable_snat, txn\u003dNone):"},{"line_number":1660,"context_line":"        \"\"\"Update the NAT rules in a logical router.\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"331a7216_98c0a391","line":1657,"range":{"start_line":1657,"start_character":0,"end_line":1657,"end_character":5},"updated":"2021-11-24 12:31:38.000000000","message":"Hmmmm, nice to know!","commit_id":"28d442d4b71dd1fcfb2428fda2cf45c3ba9d8568"},{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"318ae39d101abd34e3c921390cf0723c381273c3","unresolved":false,"context_lines":[{"line_number":1654,"context_line":"                # otherwise, we just update the revision database"},{"line_number":1655,"context_line":"                db_rev.bump_revision("},{"line_number":1656,"context_line":"                    context, port, ovn_const.TYPE_ROUTER_PORTS)"},{"line_number":1657,"context_line":"        print(\"END DELETE ROUTER PORT\")"},{"line_number":1658,"context_line":""},{"line_number":1659,"context_line":"    def update_nat_rules(self, router, networks, enable_snat, txn\u003dNone):"},{"line_number":1660,"context_line":"        \"\"\"Update the NAT rules in a logical router.\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"9863382c_ef565c78","line":1657,"range":{"start_line":1657,"start_character":0,"end_line":1657,"end_character":5},"in_reply_to":"331a7216_98c0a391","updated":"2021-11-24 16:12:34.000000000","message":"oh thanks a lot for this. I totally forgot to remove these two prints out.","commit_id":"28d442d4b71dd1fcfb2428fda2cf45c3ba9d8568"}]}