)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"a02116081fa356a8bbe44f85fc1ecf7f2cb138be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"dfe1633e_2f795ee8","updated":"2021-11-23 19:47:51.000000000","message":"The flaky agent_change test I think is because even though I\u0027m using a WaitEvent in the test to wait for the Chassis_Private creation...it can be run *before* the other event that waits for the event that creates the db object. Yay threads. Just doing a wait_until() on get_agent returning is probably the only real course of action.","commit_id":"3aecdaee8003fb2c4122709051ae031e9e505f6f"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"aba88bd5939e2db950a016ea83faedebc9341422","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"80647c73_56e8b5cd","updated":"2021-11-23 16:23:23.000000000","message":"note: the agent_change test failure here: https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_53d/818850/1/check/neutron-functional-with-uwsgi/53dc8c1/testr_results.html\n\nis the one I get that is flaky. Haven\u0027t seen it with the other agent tests.","commit_id":"3aecdaee8003fb2c4122709051ae031e9e505f6f"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"509a44bf2c1cb5905c29c2219733f87b8a459fa7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"e6c2a682_24af6b07","updated":"2022-01-06 20:13:24.000000000","message":"recheck","commit_id":"d0c5eb0b28fd7b54e9b7072b2bfb8ca1197f78dd"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c2501ad363a55116c64e351f771a5e82cfd68f7e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"cb6ed36e_c7368cac","updated":"2022-01-28 10:33:26.000000000","message":"I\u0027ve rebased this patch because zuul was not checking it.","commit_id":"87521dc70bf295ff0f9e31dca97b241c615a69e6"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/mech_driver.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6f1bb48ab849ec9a78f97989ca529140d6191085","unresolved":true,"context_lines":[{"line_number":392,"context_line":""},{"line_number":393,"context_line":"    def _report_state(self):"},{"line_number":394,"context_line":"        # write nb_cfg if we haven\u0027t updated in a while"},{"line_number":395,"context_line":"        self.ping_all_chassis()"},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"    def _create_security_group_precommit(self, resource, event, trigger,"},{"line_number":398,"context_line":"                                         payload):"}],"source_content_type":"text/x-python","patch_set":13,"id":"53549748_b7b56091","line":395,"updated":"2022-01-26 10:57:30.000000000","message":"sorry for maybe dummy question, but it periodically will ping all chassis from the neutron-server and where result of that will be stored?\nAlso, IIUC this will be done from all neutron-server workers, right? Is that really needed?","commit_id":"cad952553ca28c39022bfde12fb2b6b33ce31177"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"c929af9abd5de82e6ef68e1398e8c2c3b68002d1","unresolved":false,"context_lines":[{"line_number":392,"context_line":""},{"line_number":393,"context_line":"    def _report_state(self):"},{"line_number":394,"context_line":"        # write nb_cfg if we haven\u0027t updated in a while"},{"line_number":395,"context_line":"        self.ping_all_chassis()"},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"    def _create_security_group_precommit(self, resource, event, trigger,"},{"line_number":398,"context_line":"                                         payload):"}],"source_content_type":"text/x-python","patch_set":13,"id":"26800d84_23b800e4","line":395,"in_reply_to":"53549748_b7b56091","updated":"2022-06-23 21:25:02.000000000","message":"It\u0027ll periodically call ping_all_chassis() which will only do things if there hasn\u0027t been if enough time passed (agent_down_time / 2).\n\nIt is under the check for:\n\n    if worker_class \u003d worker.MaintenanceWorker:\n    \nso it should only happen on that one worker (which IIRC has an ovsdb lock so it only does things on one worker on one server--but I should double check that).\n\nThere is some other stuff that I need to move to monitoring only on the MaintenanceWorker though.","commit_id":"cad952553ca28c39022bfde12fb2b6b33ce31177"}],"neutron/tests/functional/plugins/ml2/drivers/ovn/mech_driver/ovsdb/test_ovsdb_monitor.py":[{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"8c2f9da31896b9be6e5e53359e851d43b00a6053","unresolved":false,"context_lines":[{"line_number":306,"context_line":"        self.chassis_name \u003d self.add_fake_chassis(self.FAKE_CHASSIS_HOST,"},{"line_number":307,"context_line":"                external_ids\u003d{\u0027ovn-cms-options\u0027: \u0027enable-chassis-as-gw\u0027},"},{"line_number":308,"context_line":"                name\u003dname)"},{"line_number":309,"context_line":"        #import time;time.sleep(0.1)"},{"line_number":310,"context_line":"        n_utils.wait_until_true(self._get_agent, timeout\u003d3, sleep\u003d1)"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"    def _get_agent(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a461195_5629b2d9","line":309,"in_reply_to":"15b1c315_83278aa9","updated":"2021-11-24 14:32:52.000000000","message":"\u003e pep8: E265 block comment should start with \u0027# \u0027\nDone","commit_id":"73d58350945d751cece9eeedda785230d496c764"}]}
