)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"9af93fd62c57181bb6032309b2808740beba1896","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d00b1fab_dde45e9f","updated":"2022-01-05 17:35:55.000000000","message":"Thanks","commit_id":"bedd24caff476c949bbd105a558f6ad2d4c5fa89"}],"tools/configure_for_func_testing.sh":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d5d833b371037744d6331b00e53556c4fef4a44d","unresolved":true,"context_lines":[{"line_number":117,"context_line":"        compile_ovs False /usr /var"},{"line_number":118,"context_line":"        if [[ \"$INSTALL_OVN\" \u003d\u003d \"True\" ]]; then"},{"line_number":119,"context_line":"            echo_summary \"OVN_BRANCH: ${OVN_BRANCH}\""},{"line_number":120,"context_line":"            compile_ovn False /usr /var"},{"line_number":121,"context_line":"        fi"},{"line_number":122,"context_line":"    else"},{"line_number":123,"context_line":"        PACKAGES\u003d$(get_packages general,neutron,q-agt,q-l3,openvswitch)"}],"source_content_type":"text/x-sh","patch_set":1,"id":"02492f1d_2ef98075","line":120,"range":{"start_line":120,"start_character":24,"end_line":120,"end_character":29},"updated":"2021-11-23 15:01:17.000000000","message":"So I was curious if this was correct, but seems compile_ovn() ignores the first argument anyways and always builds OVN.","commit_id":"bedd24caff476c949bbd105a558f6ad2d4c5fa89"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"8a241e5e09d28fc31b366f780f378f79ef69b02f","unresolved":true,"context_lines":[{"line_number":117,"context_line":"        compile_ovs False /usr /var"},{"line_number":118,"context_line":"        if [[ \"$INSTALL_OVN\" \u003d\u003d \"True\" ]]; then"},{"line_number":119,"context_line":"            echo_summary \"OVN_BRANCH: ${OVN_BRANCH}\""},{"line_number":120,"context_line":"            compile_ovn False /usr /var"},{"line_number":121,"context_line":"        fi"},{"line_number":122,"context_line":"    else"},{"line_number":123,"context_line":"        PACKAGES\u003d$(get_packages general,neutron,q-agt,q-l3,openvswitch)"}],"source_content_type":"text/x-sh","patch_set":1,"id":"dfc502b2_21abe2fe","line":120,"range":{"start_line":120,"start_character":24,"end_line":120,"end_character":29},"in_reply_to":"02492f1d_2ef98075","updated":"2021-11-23 15:16:36.000000000","message":"This parameter is to build_modules or not to build_modules :) See https://opendev.org/openstack/devstack/src/branch/master/lib/neutron_plugins/ovn_agent#L298","commit_id":"bedd24caff476c949bbd105a558f6ad2d4c5fa89"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"eada2e7906342891e8b14165caeb125da30338b7","unresolved":true,"context_lines":[{"line_number":117,"context_line":"        compile_ovs False /usr /var"},{"line_number":118,"context_line":"        if [[ \"$INSTALL_OVN\" \u003d\u003d \"True\" ]]; then"},{"line_number":119,"context_line":"            echo_summary \"OVN_BRANCH: ${OVN_BRANCH}\""},{"line_number":120,"context_line":"            compile_ovn False /usr /var"},{"line_number":121,"context_line":"        fi"},{"line_number":122,"context_line":"    else"},{"line_number":123,"context_line":"        PACKAGES\u003d$(get_packages general,neutron,q-agt,q-l3,openvswitch)"}],"source_content_type":"text/x-sh","patch_set":1,"id":"42b5e969_c51517f7","line":120,"range":{"start_line":120,"start_character":24,"end_line":120,"end_character":29},"in_reply_to":"1dd5dd22_e6a4ae92","updated":"2021-12-20 07:38:55.000000000","message":"Yeah, we can clean it a bit but I will do it in separate patches","commit_id":"bedd24caff476c949bbd105a558f6ad2d4c5fa89"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"3d89c54754a7d913c0c4e3453388bc79b58be577","unresolved":true,"context_lines":[{"line_number":117,"context_line":"        compile_ovs False /usr /var"},{"line_number":118,"context_line":"        if [[ \"$INSTALL_OVN\" \u003d\u003d \"True\" ]]; then"},{"line_number":119,"context_line":"            echo_summary \"OVN_BRANCH: ${OVN_BRANCH}\""},{"line_number":120,"context_line":"            compile_ovn False /usr /var"},{"line_number":121,"context_line":"        fi"},{"line_number":122,"context_line":"    else"},{"line_number":123,"context_line":"        PACKAGES\u003d$(get_packages general,neutron,q-agt,q-l3,openvswitch)"}],"source_content_type":"text/x-sh","patch_set":1,"id":"b0c3c940_8b5d4f89","line":120,"range":{"start_line":120,"start_character":24,"end_line":120,"end_character":29},"in_reply_to":"42b5e969_c51517f7","updated":"2021-12-22 15:05:22.000000000","message":"I proposed cleanup in https://review.opendev.org/q/topic:%22clean-compile-ovn-function%22+(status:open%20OR%20status:merged)","commit_id":"bedd24caff476c949bbd105a558f6ad2d4c5fa89"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"537fefcaa78e61b480caa9c990f547267cbdb7bd","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        compile_ovs False /usr /var"},{"line_number":118,"context_line":"        if [[ \"$INSTALL_OVN\" \u003d\u003d \"True\" ]]; then"},{"line_number":119,"context_line":"            echo_summary \"OVN_BRANCH: ${OVN_BRANCH}\""},{"line_number":120,"context_line":"            compile_ovn False /usr /var"},{"line_number":121,"context_line":"        fi"},{"line_number":122,"context_line":"    else"},{"line_number":123,"context_line":"        PACKAGES\u003d$(get_packages general,neutron,q-agt,q-l3,openvswitch)"}],"source_content_type":"text/x-sh","patch_set":1,"id":"5b6425a6_94443e48","line":120,"range":{"start_line":120,"start_character":24,"end_line":120,"end_character":29},"in_reply_to":"b0c3c940_8b5d4f89","updated":"2021-12-22 15:06:29.000000000","message":"Ahh, one more thing: IMO it was used in the past as compile_ovn was calling compile_ovs: https://github.com/openstack/networking-ovn/blob/933c1ba7eb20431348eb64e2c1611e540b35cbf8/devstack/lib/ovn#L151","commit_id":"bedd24caff476c949bbd105a558f6ad2d4c5fa89"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"12b687f7848a868729b847fe74d692f966f489ec","unresolved":true,"context_lines":[{"line_number":117,"context_line":"        compile_ovs False /usr /var"},{"line_number":118,"context_line":"        if [[ \"$INSTALL_OVN\" \u003d\u003d \"True\" ]]; then"},{"line_number":119,"context_line":"            echo_summary \"OVN_BRANCH: ${OVN_BRANCH}\""},{"line_number":120,"context_line":"            compile_ovn False /usr /var"},{"line_number":121,"context_line":"        fi"},{"line_number":122,"context_line":"    else"},{"line_number":123,"context_line":"        PACKAGES\u003d$(get_packages general,neutron,q-agt,q-l3,openvswitch)"}],"source_content_type":"text/x-sh","patch_set":1,"id":"1dd5dd22_e6a4ae92","line":120,"range":{"start_line":120,"start_character":24,"end_line":120,"end_character":29},"in_reply_to":"dfc502b2_21abe2fe","updated":"2021-11-23 16:03:47.000000000","message":"Right, but build_modules is never used after L298 :-o  Maybe it was at some point, or this was just copied from compile_ovs()","commit_id":"bedd24caff476c949bbd105a558f6ad2d4c5fa89"}]}