)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"9617df9b0d9c6e0f022857c3a220bc66f2b6bd44","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1f4fe609_53e0f372","updated":"2022-02-09 07:26:48.000000000","message":"Sorry, change in master is https://review.opendev.org/c/openstack/neutron/+/827315 - please note that current patch should not only set tag early but also clear \"vlan_mode\" and \"trunks\" attributes","commit_id":"2875069bd069a5ea2083efeda50e16c50e559b42"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"bfab8ff27e8d8722c6e4875b49ff2f496911cb26","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f427ee67_b1bf0556","updated":"2021-11-30 07:39:00.000000000","message":"Thanks!","commit_id":"2875069bd069a5ea2083efeda50e16c50e559b42"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"18714fc8e98b0bd34b69d3b31274b4f13e7836dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ef0bff8d_1bf2a37d","updated":"2022-02-09 07:22:47.000000000","message":"This should be rebased now after https://review.opendev.org/c/openstack/neutron/+/828231 was merged","commit_id":"2875069bd069a5ea2083efeda50e16c50e559b42"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"6f1c8036b19bfc42b7d5f94b9000bdb5c1d6aeb8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9c7a7bcc_4ff25ac1","updated":"2022-02-08 15:25:41.000000000","message":"ping","commit_id":"2875069bd069a5ea2083efeda50e16c50e559b42"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"51a250c2a0410c37683cae4933e03f5c08668439","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c524dd3b_69685a93","in_reply_to":"18cd8781_cf2d8f65","updated":"2022-03-22 13:30:41.000000000","message":"Alright, I see this line: https://review.opendev.org/c/openstack/neutron/+/827315/12/neutron/agent/common/ovs_lib.py#402\n\nIndeed, this also needs to clear \"vlan_mode\" and \"trunks\".\n\nFor ovs Interface lib, the plug_new function will finally call the replace_port which is going to add \"vlan_mode\" and \"trunks\".\n\nhttps://github.com/openstack/neutron/blob/master/neutron/agent/linux/interface.py#L343","commit_id":"2875069bd069a5ea2083efeda50e16c50e559b42"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"31968a1323bfd98d4e03a68070ebf9de1acc7555","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"18cd8781_cf2d8f65","in_reply_to":"1f4fe609_53e0f372","updated":"2022-03-22 13:06:42.000000000","message":"Never touch that line of code: https://review.opendev.org/c/openstack/neutron/+/827315/12/neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py","commit_id":"2875069bd069a5ea2083efeda50e16c50e559b42"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"31968a1323bfd98d4e03a68070ebf9de1acc7555","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2dc8d15e_435a9d83","updated":"2022-03-22 13:06:42.000000000","message":"Seems this is not work anymore after rebase on master? Interesting...","commit_id":"74bf79a1e6daa5545b8875a90acc8b1bd7e70057"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"4b186be89b6548d421ae121b23ea170fbbdd0bff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a6a9e749_a05a4fdd","updated":"2022-03-23 12:45:10.000000000","message":"Fuctional cases get failed, not sure if they are related:\nhttps://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_e91/819567/4/check/neutron-functional-with-uwsgi/e917c4c/testr_results.html","commit_id":"ef6f21a0d658a79ccd05bc2171fdefb463a53838"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"bd140d5967a91cc4e318fa68f82be04a38f7447f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"bb61d6a9_f8da207f","updated":"2022-03-23 12:45:17.000000000","message":"recheck","commit_id":"ef6f21a0d658a79ccd05bc2171fdefb463a53838"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"8ae2cc3ccfcc7760b544f981d401dda6eed326a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"31e3d53a_1d42f4b5","updated":"2022-03-31 00:54:28.000000000","message":"recheck","commit_id":"869aeb542c971eb4e07dee1d9a71731621296ee5"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"fb3d89c1f241b7676564d3da46a5b357684d8833","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7b4c9d82_5fade8bf","updated":"2022-04-01 13:27:39.000000000","message":"recheck","commit_id":"869aeb542c971eb4e07dee1d9a71731621296ee5"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"e83fbffe8fe00f8369027d3c483630f09c51ca0b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"abf06ab2_dcf54a52","updated":"2022-04-06 07:03:17.000000000","message":"Thanks!","commit_id":"c63ebef2d58e15f4388cf064066f77b503a2f841"}],"neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"f43a211f02f4f8c4319723fce80a51a7fb45756e","unresolved":true,"context_lines":[{"line_number":1155,"context_line":"        if segmentation_id is not None:"},{"line_number":1156,"context_line":"            vlan_mapping[\u0027segmentation_id\u0027] \u003d str(segmentation_id)"},{"line_number":1157,"context_line":"        port_other_config.update(vlan_mapping)"},{"line_number":1158,"context_line":"        self.int_br.set_db_attribute(\"Port\", port.port_name, \"tag\", lvm.vlan)"},{"line_number":1159,"context_line":"        self.int_br.set_db_attribute(\"Port\", port.port_name, \"other_config\","},{"line_number":1160,"context_line":"                                     port_other_config)"},{"line_number":1161,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ffc2326_e661bafe","line":1158,"range":{"start_line":1158,"start_character":8,"end_line":1158,"end_character":77},"updated":"2021-11-29 11:08:56.000000000","message":"When is it set currently? Should we remove duplicate set there?","commit_id":"2875069bd069a5ea2083efeda50e16c50e559b42"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"c43977a130430f9e7a9090cf60ad7500c7009324","unresolved":true,"context_lines":[{"line_number":1155,"context_line":"        if segmentation_id is not None:"},{"line_number":1156,"context_line":"            vlan_mapping[\u0027segmentation_id\u0027] \u003d str(segmentation_id)"},{"line_number":1157,"context_line":"        port_other_config.update(vlan_mapping)"},{"line_number":1158,"context_line":"        self.int_br.set_db_attribute(\"Port\", port.port_name, \"tag\", lvm.vlan)"},{"line_number":1159,"context_line":"        self.int_br.set_db_attribute(\"Port\", port.port_name, \"other_config\","},{"line_number":1160,"context_line":"                                     port_other_config)"},{"line_number":1161,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":2,"id":"c7f9af08_bd1784fb","line":1158,"range":{"start_line":1158,"start_character":8,"end_line":1158,"end_character":77},"in_reply_to":"1ffc2326_e661bafe","updated":"2021-11-30 06:44:27.000000000","message":"It is in line 1227. Although LVM will not be changed from here to line 1127, it\u0027s better to remain that in case of some extreme corner cases. And if LVM has no change, the condition of line 1125 will not be True, so the set_db_attribute will not run.","commit_id":"2875069bd069a5ea2083efeda50e16c50e559b42"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"f6e0ee13af9eb021156c990a6084505428314fef","unresolved":false,"context_lines":[{"line_number":1155,"context_line":"        if segmentation_id is not None:"},{"line_number":1156,"context_line":"            vlan_mapping[\u0027segmentation_id\u0027] \u003d str(segmentation_id)"},{"line_number":1157,"context_line":"        port_other_config.update(vlan_mapping)"},{"line_number":1158,"context_line":"        self.int_br.set_db_attribute(\"Port\", port.port_name, \"tag\", lvm.vlan)"},{"line_number":1159,"context_line":"        self.int_br.set_db_attribute(\"Port\", port.port_name, \"other_config\","},{"line_number":1160,"context_line":"                                     port_other_config)"},{"line_number":1161,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":2,"id":"6fde334e_0234a0cd","line":1158,"range":{"start_line":1158,"start_character":8,"end_line":1158,"end_character":77},"in_reply_to":"c7f9af08_bd1784fb","updated":"2022-03-25 08:40:18.000000000","message":"Ack","commit_id":"2875069bd069a5ea2083efeda50e16c50e559b42"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"c43977a130430f9e7a9090cf60ad7500c7009324","unresolved":true,"context_lines":[{"line_number":1222,"context_line":"            if self.prevent_arp_spoofing:"},{"line_number":1223,"context_line":"                self.setup_arp_spoofing_protection(self.int_br,"},{"line_number":1224,"context_line":"                                                   port, port_detail)"},{"line_number":1225,"context_line":"            if cur_tag !\u003d lvm.vlan:"},{"line_number":1226,"context_line":"                self.int_br.set_db_attribute("},{"line_number":1227,"context_line":"                    \"Port\", port.port_name, \"tag\", lvm.vlan)"},{"line_number":1228,"context_line":""},{"line_number":1229,"context_line":"            # update plugin about port status"},{"line_number":1230,"context_line":"            # FIXME(salv-orlando): Failures while updating device status"}],"source_content_type":"text/x-python","patch_set":2,"id":"7b30b1d8_27da90a9","line":1227,"range":{"start_line":1225,"start_character":0,"end_line":1227,"end_character":60},"updated":"2021-11-30 06:44:27.000000000","message":"For new added ports, cur_tag will be an empty list [], so here sets the tag to it.","commit_id":"2875069bd069a5ea2083efeda50e16c50e559b42"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"f6e0ee13af9eb021156c990a6084505428314fef","unresolved":false,"context_lines":[{"line_number":1222,"context_line":"            if self.prevent_arp_spoofing:"},{"line_number":1223,"context_line":"                self.setup_arp_spoofing_protection(self.int_br,"},{"line_number":1224,"context_line":"                                                   port, port_detail)"},{"line_number":1225,"context_line":"            if cur_tag !\u003d lvm.vlan:"},{"line_number":1226,"context_line":"                self.int_br.set_db_attribute("},{"line_number":1227,"context_line":"                    \"Port\", port.port_name, \"tag\", lvm.vlan)"},{"line_number":1228,"context_line":""},{"line_number":1229,"context_line":"            # update plugin about port status"},{"line_number":1230,"context_line":"            # FIXME(salv-orlando): Failures while updating device status"}],"source_content_type":"text/x-python","patch_set":2,"id":"77da6f5e_82bd8f2d","line":1227,"range":{"start_line":1225,"start_character":0,"end_line":1227,"end_character":60},"in_reply_to":"66e85d60_ad0ec5b6","updated":"2022-03-25 08:40:18.000000000","message":"Ack","commit_id":"2875069bd069a5ea2083efeda50e16c50e559b42"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"99402a0be072d6208bce616c90392a1b92d70353","unresolved":true,"context_lines":[{"line_number":1222,"context_line":"            if self.prevent_arp_spoofing:"},{"line_number":1223,"context_line":"                self.setup_arp_spoofing_protection(self.int_br,"},{"line_number":1224,"context_line":"                                                   port, port_detail)"},{"line_number":1225,"context_line":"            if cur_tag !\u003d lvm.vlan:"},{"line_number":1226,"context_line":"                self.int_br.set_db_attribute("},{"line_number":1227,"context_line":"                    \"Port\", port.port_name, \"tag\", lvm.vlan)"},{"line_number":1228,"context_line":""},{"line_number":1229,"context_line":"            # update plugin about port status"},{"line_number":1230,"context_line":"            # FIXME(salv-orlando): Failures while updating device status"}],"source_content_type":"text/x-python","patch_set":2,"id":"66e85d60_ad0ec5b6","line":1227,"range":{"start_line":1225,"start_character":0,"end_line":1227,"end_character":60},"in_reply_to":"7b30b1d8_27da90a9","updated":"2021-12-06 14:12:36.000000000","message":"So IIUC, in case of new ports now that \"if\" condition will never be true in the rpc_loop\u0027s iteration when port is provisioned as tag will be set to the proper one always in L1158, right?","commit_id":"2875069bd069a5ea2083efeda50e16c50e559b42"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"2e18da107104e8a5469840925ca670341b74d375","unresolved":true,"context_lines":[{"line_number":1229,"context_line":"            if self.prevent_arp_spoofing:"},{"line_number":1230,"context_line":"                self.setup_arp_spoofing_protection(self.int_br,"},{"line_number":1231,"context_line":"                                                   port, port_detail)"},{"line_number":1232,"context_line":"            if cur_tag !\u003d lvm.vlan:"},{"line_number":1233,"context_line":"                ovsdb \u003d self.int_br.ovsdb"},{"line_number":1234,"context_line":"                with ovsdb.transaction() as txn:"},{"line_number":1235,"context_line":"                    txn.add(ovsdb.db_set("}],"source_content_type":"text/x-python","patch_set":3,"id":"d1259bd8_9475bed8","line":1232,"range":{"start_line":1232,"start_character":12,"end_line":1232,"end_character":35},"updated":"2022-03-22 11:41:35.000000000","message":"will this condition ever be True now?","commit_id":"74bf79a1e6daa5545b8875a90acc8b1bd7e70057"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"f6e0ee13af9eb021156c990a6084505428314fef","unresolved":false,"context_lines":[{"line_number":1229,"context_line":"            if self.prevent_arp_spoofing:"},{"line_number":1230,"context_line":"                self.setup_arp_spoofing_protection(self.int_br,"},{"line_number":1231,"context_line":"                                                   port, port_detail)"},{"line_number":1232,"context_line":"            if cur_tag !\u003d lvm.vlan:"},{"line_number":1233,"context_line":"                ovsdb \u003d self.int_br.ovsdb"},{"line_number":1234,"context_line":"                with ovsdb.transaction() as txn:"},{"line_number":1235,"context_line":"                    txn.add(ovsdb.db_set("}],"source_content_type":"text/x-python","patch_set":3,"id":"b4f26e2f_42125bef","line":1232,"range":{"start_line":1232,"start_character":12,"end_line":1232,"end_character":35},"in_reply_to":"a98b06bc_be9235b2","updated":"2022-03-25 08:40:18.000000000","message":"Ack","commit_id":"74bf79a1e6daa5545b8875a90acc8b1bd7e70057"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"31968a1323bfd98d4e03a68070ebf9de1acc7555","unresolved":true,"context_lines":[{"line_number":1229,"context_line":"            if self.prevent_arp_spoofing:"},{"line_number":1230,"context_line":"                self.setup_arp_spoofing_protection(self.int_br,"},{"line_number":1231,"context_line":"                                                   port, port_detail)"},{"line_number":1232,"context_line":"            if cur_tag !\u003d lvm.vlan:"},{"line_number":1233,"context_line":"                ovsdb \u003d self.int_br.ovsdb"},{"line_number":1234,"context_line":"                with ovsdb.transaction() as txn:"},{"line_number":1235,"context_line":"                    txn.add(ovsdb.db_set("}],"source_content_type":"text/x-python","patch_set":3,"id":"a98b06bc_be9235b2","line":1232,"range":{"start_line":1232,"start_character":12,"end_line":1232,"end_character":35},"in_reply_to":"d1259bd8_9475bed8","updated":"2022-03-22 13:06:42.000000000","message":"See line 1158, for now here can not be True anymore, but never knows if there are some extreme corner cases.","commit_id":"74bf79a1e6daa5545b8875a90acc8b1bd7e70057"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d49e7d30cd9429016634d6ca7a102a44b3716e96","unresolved":true,"context_lines":[{"line_number":1162,"context_line":"        if segmentation_id is not None:"},{"line_number":1163,"context_line":"            vlan_mapping[\u0027segmentation_id\u0027] \u003d str(segmentation_id)"},{"line_number":1164,"context_line":"        port_other_config.update(vlan_mapping)"},{"line_number":1165,"context_line":"        self.int_br.set_db_attribute(\"Port\", port.port_name, \"tag\", lvm.vlan)"},{"line_number":1166,"context_line":"        self.int_br.clear_db_attribute(\u0027Port\u0027, port.port_name, \u0027vlan_mode\u0027)"},{"line_number":1167,"context_line":"        self.int_br.clear_db_attribute(\u0027Port\u0027, port.port_name, \u0027trunks\u0027)"},{"line_number":1168,"context_line":"        self.int_br.set_db_attribute(\"Port\", port.port_name, \"other_config\","},{"line_number":1169,"context_line":"                                     port_other_config)"},{"line_number":1170,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":4,"id":"40b90497_c1f6f0c6","line":1167,"range":{"start_line":1165,"start_character":8,"end_line":1167,"end_character":72},"updated":"2022-03-23 08:41:10.000000000","message":"This should be executed in one single db txn.","commit_id":"ef6f21a0d658a79ccd05bc2171fdefb463a53838"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"bd74c5bbf569f1865191f9689b692b3b4b35afba","unresolved":true,"context_lines":[{"line_number":1162,"context_line":"        if segmentation_id is not None:"},{"line_number":1163,"context_line":"            vlan_mapping[\u0027segmentation_id\u0027] \u003d str(segmentation_id)"},{"line_number":1164,"context_line":"        port_other_config.update(vlan_mapping)"},{"line_number":1165,"context_line":"        self.int_br.set_db_attribute(\"Port\", port.port_name, \"tag\", lvm.vlan)"},{"line_number":1166,"context_line":"        self.int_br.clear_db_attribute(\u0027Port\u0027, port.port_name, \u0027vlan_mode\u0027)"},{"line_number":1167,"context_line":"        self.int_br.clear_db_attribute(\u0027Port\u0027, port.port_name, \u0027trunks\u0027)"},{"line_number":1168,"context_line":"        self.int_br.set_db_attribute(\"Port\", port.port_name, \"other_config\","},{"line_number":1169,"context_line":"                                     port_other_config)"},{"line_number":1170,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":4,"id":"918f4dd8_c9ff4ed1","line":1167,"range":{"start_line":1165,"start_character":8,"end_line":1167,"end_character":72},"in_reply_to":"40b90497_c1f6f0c6","updated":"2022-03-23 11:05:15.000000000","message":"+1","commit_id":"ef6f21a0d658a79ccd05bc2171fdefb463a53838"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"f6e0ee13af9eb021156c990a6084505428314fef","unresolved":false,"context_lines":[{"line_number":1162,"context_line":"        if segmentation_id is not None:"},{"line_number":1163,"context_line":"            vlan_mapping[\u0027segmentation_id\u0027] \u003d str(segmentation_id)"},{"line_number":1164,"context_line":"        port_other_config.update(vlan_mapping)"},{"line_number":1165,"context_line":"        self.int_br.set_db_attribute(\"Port\", port.port_name, \"tag\", lvm.vlan)"},{"line_number":1166,"context_line":"        self.int_br.clear_db_attribute(\u0027Port\u0027, port.port_name, \u0027vlan_mode\u0027)"},{"line_number":1167,"context_line":"        self.int_br.clear_db_attribute(\u0027Port\u0027, port.port_name, \u0027trunks\u0027)"},{"line_number":1168,"context_line":"        self.int_br.set_db_attribute(\"Port\", port.port_name, \"other_config\","},{"line_number":1169,"context_line":"                                     port_other_config)"},{"line_number":1170,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":4,"id":"c9a8721f_93dad7ec","line":1167,"range":{"start_line":1165,"start_character":8,"end_line":1167,"end_character":72},"in_reply_to":"8caa36e3_3cc98faa","updated":"2022-03-25 08:40:18.000000000","message":"Done","commit_id":"ef6f21a0d658a79ccd05bc2171fdefb463a53838"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"d9301cf6e244ef17ea8e6bd537487a315446311e","unresolved":true,"context_lines":[{"line_number":1162,"context_line":"        if segmentation_id is not None:"},{"line_number":1163,"context_line":"            vlan_mapping[\u0027segmentation_id\u0027] \u003d str(segmentation_id)"},{"line_number":1164,"context_line":"        port_other_config.update(vlan_mapping)"},{"line_number":1165,"context_line":"        self.int_br.set_db_attribute(\"Port\", port.port_name, \"tag\", lvm.vlan)"},{"line_number":1166,"context_line":"        self.int_br.clear_db_attribute(\u0027Port\u0027, port.port_name, \u0027vlan_mode\u0027)"},{"line_number":1167,"context_line":"        self.int_br.clear_db_attribute(\u0027Port\u0027, port.port_name, \u0027trunks\u0027)"},{"line_number":1168,"context_line":"        self.int_br.set_db_attribute(\"Port\", port.port_name, \"other_config\","},{"line_number":1169,"context_line":"                                     port_other_config)"},{"line_number":1170,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":4,"id":"8caa36e3_3cc98faa","line":1167,"range":{"start_line":1165,"start_character":8,"end_line":1167,"end_character":72},"in_reply_to":"918f4dd8_c9ff4ed1","updated":"2022-03-23 12:43:50.000000000","message":"Yes, yes, for now this is just to see if it CI still get failures.","commit_id":"ef6f21a0d658a79ccd05bc2171fdefb463a53838"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"a174a8d950a605d74457ef3e5f2cd5905de68729","unresolved":true,"context_lines":[{"line_number":1121,"context_line":"        ovsdb \u003d self.int_br.ovsdb"},{"line_number":1122,"context_line":"        with self.int_br.ovsdb.transaction() as txn:"},{"line_number":1123,"context_line":"            txn.add(ovsdb.db_set(\u0027Port\u0027, port.port_name, (\u0027tag\u0027, vlan)))"},{"line_number":1124,"context_line":"            txn.add(ovsdb.db_clear(\u0027Port\u0027, port.port_name, \u0027vlan_mode\u0027))"},{"line_number":1125,"context_line":"            txn.add(ovsdb.db_clear(\u0027Port\u0027, port.port_name, \u0027trunks\u0027))"},{"line_number":1126,"context_line":""},{"line_number":1127,"context_line":"    def port_bound(self, port, net_uuid,"},{"line_number":1128,"context_line":"                   network_type, physical_network,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7015840d_4355a943","line":1125,"range":{"start_line":1124,"start_character":12,"end_line":1125,"end_character":69},"updated":"2022-04-04 06:48:28.000000000","message":"Please add a comment similar to #1244-1246","commit_id":"869aeb542c971eb4e07dee1d9a71731621296ee5"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"26811a2372e7b68013acecbdfefb10ce78ba8efc","unresolved":false,"context_lines":[{"line_number":1121,"context_line":"        ovsdb \u003d self.int_br.ovsdb"},{"line_number":1122,"context_line":"        with self.int_br.ovsdb.transaction() as txn:"},{"line_number":1123,"context_line":"            txn.add(ovsdb.db_set(\u0027Port\u0027, port.port_name, (\u0027tag\u0027, vlan)))"},{"line_number":1124,"context_line":"            txn.add(ovsdb.db_clear(\u0027Port\u0027, port.port_name, \u0027vlan_mode\u0027))"},{"line_number":1125,"context_line":"            txn.add(ovsdb.db_clear(\u0027Port\u0027, port.port_name, \u0027trunks\u0027))"},{"line_number":1126,"context_line":""},{"line_number":1127,"context_line":"    def port_bound(self, port, net_uuid,"},{"line_number":1128,"context_line":"                   network_type, physical_network,"}],"source_content_type":"text/x-python","patch_set":5,"id":"14677297_9bfe9377","line":1125,"range":{"start_line":1124,"start_character":12,"end_line":1125,"end_character":69},"in_reply_to":"7015840d_4355a943","updated":"2022-04-06 01:54:49.000000000","message":"Done","commit_id":"869aeb542c971eb4e07dee1d9a71731621296ee5"}]}