)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"8702e352cc48c89438b56c2a7ec66dd8ef5b8d5d","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The OVS system-id must be a UUID formated string. If not, the OVN"},{"line_number":10,"context_line":"metadata agent will log the error and will not register the OVN agent"},{"line_number":11,"context_line":"in the OVN SB DB."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1952550"},{"line_number":14,"context_line":"Change-Id: Iad2b07f6e40dcbf690889d3b69bc00bb2ed0c05c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"cecb2af9_ae6b5bf2","line":11,"updated":"2021-11-29 12:41:37.000000000","message":"But, do we want the agent to keep running even tho it\u0027s not registered correctly ? Maybe we should raise an exception and exit in this case ?","commit_id":"474190153eba157dee9ffe6f93079a0b26a11297"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d5b4abad6208be5a8bb2c8fcd32c5bedc52ab98a","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The OVS system-id must be a UUID formated string. If not, the OVN"},{"line_number":10,"context_line":"metadata agent will log the error and will not register the OVN agent"},{"line_number":11,"context_line":"in the OVN SB DB."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1952550"},{"line_number":14,"context_line":"Change-Id: Iad2b07f6e40dcbf690889d3b69bc00bb2ed0c05c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"255d8714_9cb04ccd","line":11,"in_reply_to":"cecb2af9_ae6b5bf2","updated":"2021-11-29 12:43:13.000000000","message":"Right, the agent is bound to a single chassis. I doesn\u0027t make sense to continue with a wrong config.","commit_id":"474190153eba157dee9ffe6f93079a0b26a11297"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"8702e352cc48c89438b56c2a7ec66dd8ef5b8d5d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f4566946_cd6d54bf","updated":"2021-11-29 12:41:37.000000000","message":"Soft -1, I wonder if this is the desirable behavior.","commit_id":"474190153eba157dee9ffe6f93079a0b26a11297"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"5fbc69dcdc4bc2aa88f3f8fc95c62ebb64000c16","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"62ae2cb5_1d03bed7","updated":"2021-11-30 12:20:28.000000000","message":"recheck","commit_id":"68f3e21034461ffa1525d2680b20ba2ecbb53dd4"}],"neutron/agent/ovn/metadata/agent.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"8702e352cc48c89438b56c2a7ec66dd8ef5b8d5d","unresolved":true,"context_lines":[{"line_number":269,"context_line":"        except ValueError:"},{"line_number":270,"context_line":"            LOG.error(\u0027Chassis name %s is not a correctly formatted UUID \u0027"},{"line_number":271,"context_line":"                      \u0027string\u0027, chassis_name)"},{"line_number":272,"context_line":"            return"},{"line_number":273,"context_line":"        # Generate unique, but consistent metadata id for chassis name"},{"line_number":274,"context_line":"        agent_id \u003d uuid.uuid5(chassis_id, \u0027metadata_agent\u0027)"},{"line_number":275,"context_line":"        ext_ids \u003d {ovn_const.OVN_AGENT_METADATA_ID_KEY: str(agent_id)}"}],"source_content_type":"text/x-python","patch_set":1,"id":"83c68dc1_e8c4cd46","line":272,"updated":"2021-11-29 12:41:37.000000000","message":"Wouldn\u0027t be better to error out and not start the service if the name is not in the right format ?\n\nOtherwise, from the service standpoint (systemd) the status will be \"alive\" but the agent is not really functioning properly.","commit_id":"474190153eba157dee9ffe6f93079a0b26a11297"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d5b4abad6208be5a8bb2c8fcd32c5bedc52ab98a","unresolved":true,"context_lines":[{"line_number":269,"context_line":"        except ValueError:"},{"line_number":270,"context_line":"            LOG.error(\u0027Chassis name %s is not a correctly formatted UUID \u0027"},{"line_number":271,"context_line":"                      \u0027string\u0027, chassis_name)"},{"line_number":272,"context_line":"            return"},{"line_number":273,"context_line":"        # Generate unique, but consistent metadata id for chassis name"},{"line_number":274,"context_line":"        agent_id \u003d uuid.uuid5(chassis_id, \u0027metadata_agent\u0027)"},{"line_number":275,"context_line":"        ext_ids \u003d {ovn_const.OVN_AGENT_METADATA_ID_KEY: str(agent_id)}"}],"source_content_type":"text/x-python","patch_set":1,"id":"5e62e138_3f3bcc08","line":272,"in_reply_to":"83c68dc1_e8c4cd46","updated":"2021-11-29 12:43:13.000000000","message":"right","commit_id":"474190153eba157dee9ffe6f93079a0b26a11297"}]}