)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"ffcbc273213b70b5a430667a8836f464cc13d1dd","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Tamas Gergely Peter \u003ctamasgp@complexnet.hu\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-12-06 09:32:25 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Check whether vxlan group and local addresses are IPv4 or IPv6 and"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If addresses are IPv6 change vxlan_group and vxlan_local arguments to"},{"line_number":10,"context_line":"vxlan_group6 and vxlan_local6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"34921741_10c03cf0","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":66},"updated":"2021-12-06 09:58:11.000000000","message":"nit: commit msg header is a short summary of the patch, and write please a longer explanation in the main part of the commit msg.","commit_id":"c2d2dc65d059ae40222580b46531aeabafd07cf8"},{"author":{"_account_id":34329,"name":"Tamas Gergely","display_name":"Tamas Gergely Peter","email":"tamasgp@complexnet.hu","username":"tamasgp"},"change_message_id":"e8bddad0a250321e4629402ceb5a81bae87fb80d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Tamas Gergely Peter \u003ctamasgp@complexnet.hu\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-12-06 09:32:25 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Check whether vxlan group and local addresses are IPv4 or IPv6 and"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If addresses are IPv6 change vxlan_group and vxlan_local arguments to"},{"line_number":10,"context_line":"vxlan_group6 and vxlan_local6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7657e41b_59656292","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":66},"in_reply_to":"34921741_10c03cf0","updated":"2021-12-06 10:27:28.000000000","message":"Done","commit_id":"c2d2dc65d059ae40222580b46531aeabafd07cf8"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"dce3394ee8f82010707680389779c05be4a1c010","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"88c39f77_51fb7165","updated":"2021-12-03 13:59:07.000000000","message":"Please, add functional tests in \"IpLibTestCase\"","commit_id":"04c34281e03137872c7b1aef508d9a9c7b964d6d"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"ef763fcdcb984cbc8b119a0e002afcdcbf321f15","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"05c205e1_48d6fa4c","updated":"2021-12-03 14:18:57.000000000","message":"Please, the functional tests.\n\nAnd limit the title to 72 chars: https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"e150c887a6e0921d59c22dbed4d9b46977f99103"},{"author":{"_account_id":34329,"name":"Tamas Gergely","display_name":"Tamas Gergely Peter","email":"tamasgp@complexnet.hu","username":"tamasgp"},"change_message_id":"3dac60ecbbd88e488bd7e378fdd1b6a43c014821","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"98d15865_96e6a99b","in_reply_to":"05c205e1_48d6fa4c","updated":"2021-12-03 14:25:33.000000000","message":"Sorry, it\u0027s my first contribution, I\u0027ll fix the issues","commit_id":"e150c887a6e0921d59c22dbed4d9b46977f99103"},{"author":{"_account_id":34329,"name":"Tamas Gergely","display_name":"Tamas Gergely Peter","email":"tamasgp@complexnet.hu","username":"tamasgp"},"change_message_id":"93f77f058c282fdce3ebbe66f217334b859fc3bb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"55cb8314_7dff5db6","in_reply_to":"98d15865_96e6a99b","updated":"2021-12-05 11:22:08.000000000","message":"Done","commit_id":"e150c887a6e0921d59c22dbed4d9b46977f99103"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"ffcbc273213b70b5a430667a8836f464cc13d1dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c18bf3fc_26f6abf9","updated":"2021-12-06 09:58:11.000000000","message":"Thanks for working on this issue.\nMy comments are mostly for the failing unit tests in neutron.tests.unit.agent.linux.test_ip_lib.TestIpWrapper, and to fix the tests instead of adopting the code to the unit tests","commit_id":"c2d2dc65d059ae40222580b46531aeabafd07cf8"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"cad2faf82689e8b98578868857ffabb9de1ccd21","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"6b649a54_480afe11","updated":"2021-12-06 15:39:07.000000000","message":"thanks for the work, and happy contribution :-)\nLet\u0027s wait till zuul checks all the things","commit_id":"40578557fcfd179626a39c43857690c78e21d9e3"},{"author":{"_account_id":34329,"name":"Tamas Gergely","display_name":"Tamas Gergely Peter","email":"tamasgp@complexnet.hu","username":"tamasgp"},"change_message_id":"339cf42549f2c0a318db4cca2e4c1045b346f601","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"75e664e6_311689b4","in_reply_to":"6b649a54_480afe11","updated":"2021-12-06 21:49:50.000000000","message":"Thanks! Zuul found an extra blank line in the unit tests... Pls. vote again for the modified path!","commit_id":"40578557fcfd179626a39c43857690c78e21d9e3"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"e2a7b0b538ab6a30e783a2bd1b789e02b8f81b57","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"3d5d6b5a_a54bc84c","updated":"2021-12-07 07:41:16.000000000","message":"added func test failed [1]: test_ipv6_vxlan_exists - please check\n[1] https://275be5166d1dc4979358-25c02cc852b41c1f5e6364b172a698f0.ssl.cf5.rackcdn.com/820376/12/check/neutron-functional-with-uwsgi/1ad1908/testr_results.html","commit_id":"d0b51174acb52e8e5bdbfeedea8d62cb13ebfb76"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"000445dbbc7444ddd428bcd718a92d251df424cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"3e6f2210_2bb168d2","updated":"2021-12-09 18:02:17.000000000","message":"FT failing. You need to provide a device (\"dev\" input parameter). That is mandatory when creating a VXLAN interface.\n\nI don\u0027t know why this is failing in ipv4 tests, but I\u0027ll open another bug.","commit_id":"2df82a59819852497328bdd22e7e581cd2ab98e6"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"efa6650dc739eb67582ef6edae0a48c6f529bad2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"eed96887_4b0cf4d6","in_reply_to":"3e6f2210_2bb168d2","updated":"2021-12-10 10:15:31.000000000","message":"Bug: https://bugs.launchpad.net/neutron/+bug/1954316","commit_id":"2df82a59819852497328bdd22e7e581cd2ab98e6"},{"author":{"_account_id":34329,"name":"Tamas Gergely","display_name":"Tamas Gergely Peter","email":"tamasgp@complexnet.hu","username":"tamasgp"},"change_message_id":"fca8be090b4b719e5a272400dc2cad5cafd7aa3f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"576e0a44_f2b40e84","in_reply_to":"3e6f2210_2bb168d2","updated":"2021-12-10 07:36:44.000000000","message":"Didn\u0027t checked that, but I feel that this can be related to my other reported bug #1953139.\nIPv4 address objects have an IFA_LABEL attribute which contain the interface name, but IPv6 objects do not. In this case a \u0027lookup\u0027 is being started, but based on the mentioned case this lookup is not working well.","commit_id":"2df82a59819852497328bdd22e7e581cd2ab98e6"},{"author":{"_account_id":34329,"name":"Tamas Gergely","display_name":"Tamas Gergely Peter","email":"tamasgp@complexnet.hu","username":"tamasgp"},"change_message_id":"b5adfd11884f6ed9cfb372101522f299a17099b7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"c448c487_445841b0","updated":"2021-12-10 16:20:22.000000000","message":"Finally Zuul is happy 😄","commit_id":"c83022769f516585b67ca56d927aed617895fa2f"},{"author":{"_account_id":34329,"name":"Tamas Gergely","display_name":"Tamas Gergely Peter","email":"tamasgp@complexnet.hu","username":"tamasgp"},"change_message_id":"626d711fa9c9826e5260ab787e59089d24cf2557","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"5f0c4b02_2852c144","updated":"2021-12-14 08:55:51.000000000","message":"Guys, please vote 😊","commit_id":"c83022769f516585b67ca56d927aed617895fa2f"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"1196cbc498b87cf33d352e4ed5871f415aaa85f5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"13665a0b_a91032e7","updated":"2021-12-14 10:28:08.000000000","message":"Thanks","commit_id":"c83022769f516585b67ca56d927aed617895fa2f"}],"neutron/agent/linux/ip_lib.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"dce3394ee8f82010707680389779c05be4a1c010","unresolved":true,"context_lines":[{"line_number":282,"context_line":"                  local\u003dNone, srcport\u003dNone, dstport\u003dNone, proxy\u003dFalse):"},{"line_number":283,"context_line":"        kwargs \u003d {\u0027vxlan_id\u0027: vni}"},{"line_number":284,"context_line":"        if group:"},{"line_number":285,"context_line":"            if netaddr.IPAddress(group).version \u003d\u003d 6:"},{"line_number":286,"context_line":"                kwargs[\u0027vxlan_group6\u0027] \u003d group"},{"line_number":287,"context_line":"            else:"},{"line_number":288,"context_line":"                kwargs[\u0027vxlan_group\u0027] \u003d group"}],"source_content_type":"text/x-python","patch_set":1,"id":"b1b7d8d5_0fbb2c8a","line":285,"range":{"start_line":285,"start_character":15,"end_line":285,"end_character":39},"updated":"2021-12-03 13:59:07.000000000","message":"\"group\" is a network, not an IP address.\n\nInstead of this, you should use common_utils.get_ip_version(local) in both checks (here and in L296)","commit_id":"04c34281e03137872c7b1aef508d9a9c7b964d6d"},{"author":{"_account_id":34329,"name":"Tamas Gergely","display_name":"Tamas Gergely Peter","email":"tamasgp@complexnet.hu","username":"tamasgp"},"change_message_id":"93f77f058c282fdce3ebbe66f217334b859fc3bb","unresolved":false,"context_lines":[{"line_number":282,"context_line":"                  local\u003dNone, srcport\u003dNone, dstport\u003dNone, proxy\u003dFalse):"},{"line_number":283,"context_line":"        kwargs \u003d {\u0027vxlan_id\u0027: vni}"},{"line_number":284,"context_line":"        if group:"},{"line_number":285,"context_line":"            if netaddr.IPAddress(group).version \u003d\u003d 6:"},{"line_number":286,"context_line":"                kwargs[\u0027vxlan_group6\u0027] \u003d group"},{"line_number":287,"context_line":"            else:"},{"line_number":288,"context_line":"                kwargs[\u0027vxlan_group\u0027] \u003d group"}],"source_content_type":"text/x-python","patch_set":1,"id":"80b2debe_10e0e54a","line":285,"range":{"start_line":285,"start_character":15,"end_line":285,"end_character":39},"in_reply_to":"b1b7d8d5_0fbb2c8a","updated":"2021-12-05 11:22:08.000000000","message":"Done","commit_id":"04c34281e03137872c7b1aef508d9a9c7b964d6d"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"571513dd472f357aa95c4ff0906e23a1efa51ca3","unresolved":true,"context_lines":[{"line_number":282,"context_line":"                  local\u003dNone, srcport\u003dNone, dstport\u003dNone, proxy\u003dFalse):"},{"line_number":283,"context_line":"        kwargs \u003d {\u0027vxlan_id\u0027: vni}"},{"line_number":284,"context_line":"        if group:"},{"line_number":285,"context_line":"            if common_utils.get_ip_version(group) \u003d\u003d 6:"},{"line_number":286,"context_line":"                kwargs[\u0027vxlan_group6\u0027] \u003d group"},{"line_number":287,"context_line":"            else:"},{"line_number":288,"context_line":"                kwargs[\u0027vxlan_group\u0027] \u003d group"}],"source_content_type":"text/x-python","patch_set":2,"id":"cd55c1b7_c6d855cc","line":285,"updated":"2021-12-03 18:31:28.000000000","message":"Please use constants.IP_VERSION_6 instead of 6 here and below, it\u0027s used elsewhere in this file as well.","commit_id":"e150c887a6e0921d59c22dbed4d9b46977f99103"},{"author":{"_account_id":34329,"name":"Tamas Gergely","display_name":"Tamas Gergely Peter","email":"tamasgp@complexnet.hu","username":"tamasgp"},"change_message_id":"93f77f058c282fdce3ebbe66f217334b859fc3bb","unresolved":false,"context_lines":[{"line_number":282,"context_line":"                  local\u003dNone, srcport\u003dNone, dstport\u003dNone, proxy\u003dFalse):"},{"line_number":283,"context_line":"        kwargs \u003d {\u0027vxlan_id\u0027: vni}"},{"line_number":284,"context_line":"        if group:"},{"line_number":285,"context_line":"            if common_utils.get_ip_version(group) \u003d\u003d 6:"},{"line_number":286,"context_line":"                kwargs[\u0027vxlan_group6\u0027] \u003d group"},{"line_number":287,"context_line":"            else:"},{"line_number":288,"context_line":"                kwargs[\u0027vxlan_group\u0027] \u003d group"}],"source_content_type":"text/x-python","patch_set":2,"id":"7b3335ab_82c3ff9a","line":285,"in_reply_to":"cd55c1b7_c6d855cc","updated":"2021-12-05 11:22:08.000000000","message":"Done","commit_id":"e150c887a6e0921d59c22dbed4d9b46977f99103"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"ffcbc273213b70b5a430667a8836f464cc13d1dd","unresolved":true,"context_lines":[{"line_number":290,"context_line":"                    kwargs[\u0027vxlan_group\u0027] \u003d group"},{"line_number":291,"context_line":"            except netaddr.core.AddrFormatError:"},{"line_number":292,"context_line":"                LOG.error(\"Invalid group address: %(group)s\", {\u0027group\u0027: group})"},{"line_number":293,"context_line":"                # save invalid group IP into vxlan_group to fix mock tests"},{"line_number":294,"context_line":"                kwargs[\u0027vxlan_group\u0027] \u003d group"},{"line_number":295,"context_line":"        if dev:"},{"line_number":296,"context_line":"            kwargs[\u0027physical_interface\u0027] \u003d dev"},{"line_number":297,"context_line":"        if ttl:"}],"source_content_type":"text/x-python","patch_set":6,"id":"13725dae_8be4ce31","line":294,"range":{"start_line":293,"start_character":16,"end_line":294,"end_character":45},"updated":"2021-12-06 09:58:11.000000000","message":"please do not adopt code to tests","commit_id":"c2d2dc65d059ae40222580b46531aeabafd07cf8"},{"author":{"_account_id":34329,"name":"Tamas Gergely","display_name":"Tamas Gergely Peter","email":"tamasgp@complexnet.hu","username":"tamasgp"},"change_message_id":"e8bddad0a250321e4629402ceb5a81bae87fb80d","unresolved":false,"context_lines":[{"line_number":290,"context_line":"                    kwargs[\u0027vxlan_group\u0027] \u003d group"},{"line_number":291,"context_line":"            except netaddr.core.AddrFormatError:"},{"line_number":292,"context_line":"                LOG.error(\"Invalid group address: %(group)s\", {\u0027group\u0027: group})"},{"line_number":293,"context_line":"                # save invalid group IP into vxlan_group to fix mock tests"},{"line_number":294,"context_line":"                kwargs[\u0027vxlan_group\u0027] \u003d group"},{"line_number":295,"context_line":"        if dev:"},{"line_number":296,"context_line":"            kwargs[\u0027physical_interface\u0027] \u003d dev"},{"line_number":297,"context_line":"        if ttl:"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a75216e_9ee6ea3b","line":294,"range":{"start_line":293,"start_character":16,"end_line":294,"end_character":45},"in_reply_to":"13725dae_8be4ce31","updated":"2021-12-06 10:27:28.000000000","message":"Done","commit_id":"c2d2dc65d059ae40222580b46531aeabafd07cf8"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"ffcbc273213b70b5a430667a8836f464cc13d1dd","unresolved":true,"context_lines":[{"line_number":307,"context_line":"                    kwargs[\u0027vxlan_local\u0027] \u003d local"},{"line_number":308,"context_line":"            except netaddr.core.AddrFormatError:"},{"line_number":309,"context_line":"                LOG.error(\"Invalid local address: %(local)s\", {\u0027local\u0027: local})"},{"line_number":310,"context_line":"                # save invalid local IP into vxlan_local to fix mock tests"},{"line_number":311,"context_line":"                kwargs[\u0027vxlan_group\u0027] \u003d group"},{"line_number":312,"context_line":"        if proxy:"},{"line_number":313,"context_line":"            kwargs[\u0027vxlan_proxy\u0027] \u003d proxy"},{"line_number":314,"context_line":"        # tuple: min,max"}],"source_content_type":"text/x-python","patch_set":6,"id":"2d2cc115_461d434b","line":311,"range":{"start_line":310,"start_character":16,"end_line":311,"end_character":45},"updated":"2021-12-06 09:58:11.000000000","message":"ditto","commit_id":"c2d2dc65d059ae40222580b46531aeabafd07cf8"},{"author":{"_account_id":34329,"name":"Tamas Gergely","display_name":"Tamas Gergely Peter","email":"tamasgp@complexnet.hu","username":"tamasgp"},"change_message_id":"e8bddad0a250321e4629402ceb5a81bae87fb80d","unresolved":false,"context_lines":[{"line_number":307,"context_line":"                    kwargs[\u0027vxlan_local\u0027] \u003d local"},{"line_number":308,"context_line":"            except netaddr.core.AddrFormatError:"},{"line_number":309,"context_line":"                LOG.error(\"Invalid local address: %(local)s\", {\u0027local\u0027: local})"},{"line_number":310,"context_line":"                # save invalid local IP into vxlan_local to fix mock tests"},{"line_number":311,"context_line":"                kwargs[\u0027vxlan_group\u0027] \u003d group"},{"line_number":312,"context_line":"        if proxy:"},{"line_number":313,"context_line":"            kwargs[\u0027vxlan_proxy\u0027] \u003d proxy"},{"line_number":314,"context_line":"        # tuple: min,max"}],"source_content_type":"text/x-python","patch_set":6,"id":"51d5349a_0974ba0a","line":311,"range":{"start_line":310,"start_character":16,"end_line":311,"end_character":45},"in_reply_to":"2d2cc115_461d434b","updated":"2021-12-06 10:27:28.000000000","message":"Done","commit_id":"c2d2dc65d059ae40222580b46531aeabafd07cf8"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"659861b25fb9908be5505f70de2b61316ef5ceb1","unresolved":true,"context_lines":[{"line_number":290,"context_line":"                    kwargs[\u0027vxlan_group\u0027] \u003d group"},{"line_number":291,"context_line":"            except netaddr.core.AddrFormatError:"},{"line_number":292,"context_line":"                LOG.error(\"Invalid group address: %(group)s\", {\u0027group\u0027: group})"},{"line_number":293,"context_line":"                raise"},{"line_number":294,"context_line":"        if dev:"},{"line_number":295,"context_line":"            kwargs[\u0027physical_interface\u0027] \u003d dev"},{"line_number":296,"context_line":"        if ttl:"}],"source_content_type":"text/x-python","patch_set":8,"id":"36d41d04_6b708c8f","line":293,"range":{"start_line":293,"start_character":16,"end_line":293,"end_character":21},"updated":"2021-12-06 14:53:28.000000000","message":"In case of hitting this exception, we usually raise \"InvalidInput(error_message\u003derr_msg)\"","commit_id":"8cd1ee5916776dd63ed66c05edce79dc9a2acfaa"},{"author":{"_account_id":34329,"name":"Tamas Gergely","display_name":"Tamas Gergely Peter","email":"tamasgp@complexnet.hu","username":"tamasgp"},"change_message_id":"8b5c0623b09df0dff4f5e3678c0657f03b70bf08","unresolved":false,"context_lines":[{"line_number":290,"context_line":"                    kwargs[\u0027vxlan_group\u0027] \u003d group"},{"line_number":291,"context_line":"            except netaddr.core.AddrFormatError:"},{"line_number":292,"context_line":"                LOG.error(\"Invalid group address: %(group)s\", {\u0027group\u0027: group})"},{"line_number":293,"context_line":"                raise"},{"line_number":294,"context_line":"        if dev:"},{"line_number":295,"context_line":"            kwargs[\u0027physical_interface\u0027] \u003d dev"},{"line_number":296,"context_line":"        if ttl:"}],"source_content_type":"text/x-python","patch_set":8,"id":"445b40c7_d9ee3178","line":293,"range":{"start_line":293,"start_character":16,"end_line":293,"end_character":21},"in_reply_to":"36d41d04_6b708c8f","updated":"2021-12-06 15:00:55.000000000","message":"Done","commit_id":"8cd1ee5916776dd63ed66c05edce79dc9a2acfaa"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ffdfc9b220007662a0c0be05dd63ae66007ebe8a","unresolved":true,"context_lines":[{"line_number":299,"context_line":"            kwargs[\u0027vxlan_tos\u0027] \u003d tos"},{"line_number":300,"context_line":"        if local:"},{"line_number":301,"context_line":"            try:"},{"line_number":302,"context_line":"                ip_version \u003d common_utils.get_ip_version(local)"},{"line_number":303,"context_line":"                if ip_version \u003d\u003d constants.IP_VERSION_6:"},{"line_number":304,"context_line":"                    kwargs[\u0027vxlan_local6\u0027] \u003d local"},{"line_number":305,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":16,"id":"8efdf61c_18da9695","line":302,"updated":"2021-12-14 09:28:25.000000000","message":"is it possible that e.g. group will be IPv6 and local will be IPv4 address? Or should we maybe check that case too and raise some exception in such case?","commit_id":"c83022769f516585b67ca56d927aed617895fa2f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"592e37ee2c1682e87124a1f190383712700cea53","unresolved":true,"context_lines":[{"line_number":299,"context_line":"            kwargs[\u0027vxlan_tos\u0027] \u003d tos"},{"line_number":300,"context_line":"        if local:"},{"line_number":301,"context_line":"            try:"},{"line_number":302,"context_line":"                ip_version \u003d common_utils.get_ip_version(local)"},{"line_number":303,"context_line":"                if ip_version \u003d\u003d constants.IP_VERSION_6:"},{"line_number":304,"context_line":"                    kwargs[\u0027vxlan_local6\u0027] \u003d local"},{"line_number":305,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":16,"id":"47900ac9_93a9933d","line":302,"in_reply_to":"8efdf61c_18da9695","updated":"2021-12-14 10:09:14.000000000","message":"If we pass mixed IPs, the interface creation will fail and will raise an exception.","commit_id":"c83022769f516585b67ca56d927aed617895fa2f"}],"neutron/plugins/ml2/drivers/linuxbridge/agent/linuxbridge_neutron_agent.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"659861b25fb9908be5505f70de2b61316ef5ceb1","unresolved":true,"context_lines":[{"line_number":357,"context_line":"                int_vxlan \u003d self.ip.add_vxlan(interface, segmentation_id,"},{"line_number":358,"context_line":"                                              **args)"},{"line_number":359,"context_line":"            except netaddr.core.AddrFormatError:"},{"line_number":360,"context_line":"                LOG.error(\"Unable to create VXLAN interface for \""},{"line_number":361,"context_line":"                          \"VNI %s because the passed address(es) \""},{"line_number":362,"context_line":"                          \"have invalid format.\", segmentation_id)"},{"line_number":363,"context_line":"                return None"},{"line_number":364,"context_line":"            except RuntimeError:"},{"line_number":365,"context_line":"                with excutils.save_and_reraise_exception() as ctxt:"},{"line_number":366,"context_line":"                    # perform this check after an attempt rather than before"}],"source_content_type":"text/x-python","patch_set":8,"id":"d2ebbb20_5e38233e","line":363,"range":{"start_line":360,"start_character":16,"end_line":363,"end_character":27},"updated":"2021-12-06 14:53:28.000000000","message":"We should not be masking this exception. If we fail here, we should raise the exception. This exception catch is not needed.","commit_id":"8cd1ee5916776dd63ed66c05edce79dc9a2acfaa"},{"author":{"_account_id":34329,"name":"Tamas Gergely","display_name":"Tamas Gergely Peter","email":"tamasgp@complexnet.hu","username":"tamasgp"},"change_message_id":"8b5c0623b09df0dff4f5e3678c0657f03b70bf08","unresolved":false,"context_lines":[{"line_number":357,"context_line":"                int_vxlan \u003d self.ip.add_vxlan(interface, segmentation_id,"},{"line_number":358,"context_line":"                                              **args)"},{"line_number":359,"context_line":"            except netaddr.core.AddrFormatError:"},{"line_number":360,"context_line":"                LOG.error(\"Unable to create VXLAN interface for \""},{"line_number":361,"context_line":"                          \"VNI %s because the passed address(es) \""},{"line_number":362,"context_line":"                          \"have invalid format.\", segmentation_id)"},{"line_number":363,"context_line":"                return None"},{"line_number":364,"context_line":"            except RuntimeError:"},{"line_number":365,"context_line":"                with excutils.save_and_reraise_exception() as ctxt:"},{"line_number":366,"context_line":"                    # perform this check after an attempt rather than before"}],"source_content_type":"text/x-python","patch_set":8,"id":"843ca455_546b22b1","line":363,"range":{"start_line":360,"start_character":16,"end_line":363,"end_character":27},"in_reply_to":"d2ebbb20_5e38233e","updated":"2021-12-06 15:00:55.000000000","message":"Done","commit_id":"8cd1ee5916776dd63ed66c05edce79dc9a2acfaa"}],"neutron/tests/functional/agent/linux/test_ip_lib.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"23ac9f3f00154a5ae1e857bed82d591880c4aebc","unresolved":true,"context_lines":[{"line_number":256,"context_line":"        self.addCleanup(ip.netns.delete, attr.namespace)"},{"line_number":257,"context_line":"        self.assertFalse(ip_lib.vxlan_in_use(9999, namespace\u003dattr.namespace))"},{"line_number":258,"context_line":"        device \u003d ip.add_vxlan(attr.name, 9999, local\u003d\u0027fd00::1\u0027,"},{"line_number":259,"context_line":"                group\u003dTEST_IP6_VXLAN_GROUP)"},{"line_number":260,"context_line":"        self.addCleanup(self._safe_delete_device, device)"},{"line_number":261,"context_line":"        self.assertTrue(ip_lib.vxlan_in_use(9999, namespace\u003dattr.namespace))"},{"line_number":262,"context_line":"        device.link.delete()"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a345244_ad74007f","line":259,"range":{"start_line":259,"start_character":8,"end_line":259,"end_character":16},"updated":"2021-12-09 16:13:17.000000000","message":"nit: weird indentation","commit_id":"2df82a59819852497328bdd22e7e581cd2ab98e6"}],"neutron/tests/unit/agent/linux/test_ip_lib.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"ffcbc273213b70b5a430667a8836f464cc13d1dd","unresolved":true,"context_lines":[{"line_number":434,"context_line":"            \u0027vxlan_port_range\u0027: (\u00271\u0027, \u00272\u0027),"},{"line_number":435,"context_line":"            \u0027vxlan_port\u0027: 4789}"},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"        retval \u003d ip_lib.IPWrapper().add_vxlan(\u0027vxlan0\u0027, \u0027vni0\u0027,"},{"line_number":438,"context_line":"                                              group\u003d\u0027group0\u0027,"},{"line_number":439,"context_line":"                                              dev\u003d\u0027dev0\u0027, ttl\u003d\u0027ttl0\u0027,"},{"line_number":440,"context_line":"                                              tos\u003d\u0027tos0\u0027,"},{"line_number":441,"context_line":"                                              local\u003d\u0027local0\u0027, proxy\u003dTrue,"},{"line_number":442,"context_line":"                                              srcport\u003d(1, 2),"},{"line_number":443,"context_line":"                                              dstport\u003d4789)"},{"line_number":444,"context_line":""},{"line_number":445,"context_line":"        self.assertIsInstance(retval, ip_lib.IPDevice)"},{"line_number":446,"context_line":"        self.assertEqual(retval.name, \u0027vxlan0\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"a00b5f45_ffda03fa","line":443,"range":{"start_line":437,"start_character":0,"end_line":443,"end_character":59},"updated":"2021-12-06 09:58:11.000000000","message":"You have to fix these params like: group\u003d\u0027fd00::1\u0027, local\u003d\u0027fd00::1\u0027\n\nPerhaps even split these tests to cover both IPv4 and IPv6 case.","commit_id":"a25f187d7a5e3d777a60f7bff651f1b341c59828"},{"author":{"_account_id":34329,"name":"Tamas Gergely","display_name":"Tamas Gergely Peter","email":"tamasgp@complexnet.hu","username":"tamasgp"},"change_message_id":"e8bddad0a250321e4629402ceb5a81bae87fb80d","unresolved":false,"context_lines":[{"line_number":434,"context_line":"            \u0027vxlan_port_range\u0027: (\u00271\u0027, \u00272\u0027),"},{"line_number":435,"context_line":"            \u0027vxlan_port\u0027: 4789}"},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"        retval \u003d ip_lib.IPWrapper().add_vxlan(\u0027vxlan0\u0027, \u0027vni0\u0027,"},{"line_number":438,"context_line":"                                              group\u003d\u0027group0\u0027,"},{"line_number":439,"context_line":"                                              dev\u003d\u0027dev0\u0027, ttl\u003d\u0027ttl0\u0027,"},{"line_number":440,"context_line":"                                              tos\u003d\u0027tos0\u0027,"},{"line_number":441,"context_line":"                                              local\u003d\u0027local0\u0027, proxy\u003dTrue,"},{"line_number":442,"context_line":"                                              srcport\u003d(1, 2),"},{"line_number":443,"context_line":"                                              dstport\u003d4789)"},{"line_number":444,"context_line":""},{"line_number":445,"context_line":"        self.assertIsInstance(retval, ip_lib.IPDevice)"},{"line_number":446,"context_line":"        self.assertEqual(retval.name, \u0027vxlan0\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"029dc12f_6e555f7b","line":443,"range":{"start_line":437,"start_character":0,"end_line":443,"end_character":59},"in_reply_to":"a00b5f45_ffda03fa","updated":"2021-12-06 10:27:28.000000000","message":"I\u0027ve added some new tests for v4 and v6 cases and for a check of invalid address format.","commit_id":"a25f187d7a5e3d777a60f7bff651f1b341c59828"},{"author":{"_account_id":34329,"name":"Tamas Gergely","display_name":"Tamas Gergely Peter","email":"tamasgp@complexnet.hu","username":"tamasgp"},"change_message_id":"699e1daa47f7001ff2c1d048ff12fe0ed2717bc7","unresolved":false,"context_lines":[{"line_number":438,"context_line":"        self.assertDictEqual(expected_call_params, self.call_params)"},{"line_number":439,"context_line":""},{"line_number":440,"context_line":""},{"line_number":441,"context_line":"    def test_add_vxlan_invalid_srcport_length(self):"},{"line_number":442,"context_line":"        wrapper \u003d ip_lib.IPWrapper()"},{"line_number":443,"context_line":"        self.assertRaises(exceptions.NetworkVxlanPortRangeError,"},{"line_number":444,"context_line":"                          wrapper.add_vxlan, \u0027vxlan0\u0027, \u0027vni0\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"122ada6a_154ed0d4","line":441,"in_reply_to":"a77103eb_90363ea5","updated":"2021-12-06 21:28:52.000000000","message":"\u003e pep8: E303 too many blank lines (2)\n\nPlease fix.","commit_id":"40578557fcfd179626a39c43857690c78e21d9e3"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ffdfc9b220007662a0c0be05dd63ae66007ebe8a","unresolved":true,"context_lines":[{"line_number":105,"context_line":"VXLAN6_GROUP_SAMPLE \u003d \"ff00::1\""},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"VXLAN6_INVALID_IPV6_SAMPLE \u003d \"invalid:ipv6::address\""},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"VXLAN6_LOCAL_SAMPLE \u003d \"fd00::1\""},{"line_number":110,"context_line":""},{"line_number":111,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"8c1cab91_a7a3c32d","line":108,"updated":"2021-12-14 09:28:25.000000000","message":"nitty nit: if You would respin it, maybe You can remove all those empty lines here, IMO they aren\u0027t needed.","commit_id":"c83022769f516585b67ca56d927aed617895fa2f"}]}