)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"fd42bcd083e5854048a9edd042bb1e968c91f89f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"70645a8f_4f679aab","updated":"2021-12-09 08:50:57.000000000","message":"recheck","commit_id":"20ef973dbf884d64d24a614a777997e336d11080"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4f15aa85efc2816c6d66ed5e8f20cce55c12ff24","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e93c328b_e519cd2b","updated":"2021-12-10 15:39:23.000000000","message":"recheck","commit_id":"20ef973dbf884d64d24a614a777997e336d11080"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"a4fbb48eb716fd8891c41c457619b406606918ef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"57dc2a3e_ef39a433","updated":"2021-12-16 23:35:17.000000000","message":"This does mimic the current behavior but also fixes the bug.\n\nI will agree to disagree on what to do when there are two IP addresses and one is invalid (the ANY address), as it\u0027s indeterminate based on the docs. I think the option of ignoring it is best, another option being to change the API slightly to complain, but that has other consequences.","commit_id":"a416f8b0ab810f34ea274183df590a73d150a137"}],"neutron/common/ovn/utils.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c910cc43e578537c98c86361558d088eea27a208","unresolved":true,"context_lines":[{"line_number":433,"context_line":""},{"line_number":434,"context_line":"    for dns_server in dns_servers:"},{"line_number":435,"context_line":"        if netaddr.IPNetwork(dns_server).ip \u003d\u003d ip_any:"},{"line_number":436,"context_line":"            return []"},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"    return dns_servers"},{"line_number":439,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"0f79779b_c3d94567","line":436,"updated":"2021-12-07 15:49:26.000000000","message":"Just trying to understand why we don\u0027t remove the \"any address\".  For example, one of the tests uses [0.0.0.0, 5.6.7.8] and expects [] instead of [5.6.7.8]","commit_id":"20ef973dbf884d64d24a614a777997e336d11080"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b58130944fd9b3b37e24932933ba13612ddb3569","unresolved":true,"context_lines":[{"line_number":433,"context_line":""},{"line_number":434,"context_line":"    for dns_server in dns_servers:"},{"line_number":435,"context_line":"        if netaddr.IPNetwork(dns_server).ip \u003d\u003d ip_any:"},{"line_number":436,"context_line":"            return []"},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"    return dns_servers"},{"line_number":439,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3b1985c1_b7fcc392","line":436,"in_reply_to":"0f79779b_c3d94567","updated":"2021-12-09 08:06:29.000000000","message":"This is what is documented in [1]. I pasted this specific paragraph in the method description and the commit message. We can change this behaviour but not in this patch.\n\n[1]https://docs.openstack.org/neutron/latest/admin/config-dns-res.html","commit_id":"20ef973dbf884d64d24a614a777997e336d11080"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"22ca1af8aa72bd46fe8f49bf37ae24ea969f2efd","unresolved":true,"context_lines":[{"line_number":433,"context_line":""},{"line_number":434,"context_line":"    for dns_server in dns_servers:"},{"line_number":435,"context_line":"        if netaddr.IPNetwork(dns_server).ip \u003d\u003d ip_any:"},{"line_number":436,"context_line":"            return []"},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"    return dns_servers"},{"line_number":439,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"76f386f8_3084f20e","line":436,"in_reply_to":"3b1985c1_b7fcc392","updated":"2021-12-15 22:44:39.000000000","message":"The paragraph you linked is slightly different from the text above:\n\n\"You can also set the DNS resolver address to 0.0.0.0 for IPv4 subnets, or :: for IPv6 subnets, which are special values that indicate to the DHCP agent that it should not announce any DNS resolver at all on the subnet.\"\n\nThe word \u0027address\u0027 is used, it doesn\u0027t cover the case where there are \u0027addresses\u0027 present.\n\nIn my opinion we should just filter the 0.0.0.0/:: and use the resultant list, which might be an IP address(es). I think the code above actually changes the behavior, it used to return both if they were present and now it will return none.","commit_id":"20ef973dbf884d64d24a614a777997e336d11080"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8372dd22f49eaed8a89f6ce7a450195f3347645d","unresolved":true,"context_lines":[{"line_number":433,"context_line":""},{"line_number":434,"context_line":"    for dns_server in dns_servers:"},{"line_number":435,"context_line":"        if netaddr.IPNetwork(dns_server).ip \u003d\u003d ip_any:"},{"line_number":436,"context_line":"            return []"},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"    return dns_servers"},{"line_number":439,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"c8cab2bb_5e3c8cb9","line":436,"in_reply_to":"76f386f8_3084f20e","updated":"2021-12-16 08:53:32.000000000","message":"I don\u0027t agree with this interpretation and doesn\u0027t make sense. But this is what is implemented [1] in the DHCP agent right now and the goal of this patch is to mimic the current behaviour.\n\n[1]https://github.com/openstack/neutron/blob/e99d9a9d0697a21ba7ec84465f415f60041f3767/neutron/agent/linux/dhcp.py#L1156-L1165","commit_id":"20ef973dbf884d64d24a614a777997e336d11080"}]}