)]}'
{"neutron/plugins/cisco/db/nexus_models_v2.py":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"27ff7ab8a86671a91d9069d0866d21a8755d0f39","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    port_id \u003d sa.Column(sa.String(255))"},{"line_number":30,"context_line":"    vlan_id \u003d sa.Column(sa.Integer, nullable\u003dFalse)"},{"line_number":31,"context_line":"    switch_ip \u003d sa.Column(sa.String(255), nullable\u003dFalse)"},{"line_number":32,"context_line":"    instance_id \u003d sa.Column(sa.String(255), nullable\u003dFalse)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def __repr__(self):"},{"line_number":35,"context_line":"        \"\"\"Just the binding, without the id key.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2B8G4%3D","line":32,"updated":"2014-03-21 14:47:48.000000000","message":"Awesome, thanks for fixing this! But isn\u0027t a migration needed?","commit_id":"009b25ccedf8dea529c002aaa9da4cf6213ea4c0"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"ba15d207f9f9cbd638350824cbdfb9c53bf6972c","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    port_id \u003d sa.Column(sa.String(255))"},{"line_number":30,"context_line":"    vlan_id \u003d sa.Column(sa.Integer, nullable\u003dFalse)"},{"line_number":31,"context_line":"    switch_ip \u003d sa.Column(sa.String(255), nullable\u003dFalse)"},{"line_number":32,"context_line":"    instance_id \u003d sa.Column(sa.String(255), nullable\u003dFalse)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def __repr__(self):"},{"line_number":35,"context_line":"        \"\"\"Just the binding, without the id key.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2B7%2F8%3D","line":32,"in_reply_to":"AAAAWH%2F%2B8G4%3D","updated":"2014-03-21 14:56:29.000000000","message":"Sorry, I was confused. I was thinking about port_id, which needs nullable\u003dFalse. I believe that will need to be addressed separately with a migration.","commit_id":"009b25ccedf8dea529c002aaa9da4cf6213ea4c0"}],"neutron/plugins/vmware/dbexts/lsn_db.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"a908f266bea4fce6ee8e391665212caa64fc018b","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    lsn_port_id \u003d Column(String(36), primary_key\u003dTrue)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    lsn_id \u003d Column(String(36), ForeignKey(\u0027lsn.lsn_id\u0027, ondelete\u003d\"CASCADE\"),"},{"line_number":39,"context_line":"                    nullable\u003dFalse)"},{"line_number":40,"context_line":"    sub_id \u003d Column(String(36), nullable\u003dFalse, unique\u003dTrue)"},{"line_number":41,"context_line":"    mac_addr \u003d Column(String(32), nullable\u003dFalse, unique\u003dTrue)"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2B8fc%3D","line":39,"updated":"2014-03-21 13:59:08.000000000","message":"can you tell me why this is actually needed here, other than documentation reasons (the column has a foreign key constraint with an cascade on delete, so it cannot really be NULL, ever)","commit_id":"009b25ccedf8dea529c002aaa9da4cf6213ea4c0"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"91280fbad05643ab5e0fa838312d8267ff1da031","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    lsn_port_id \u003d Column(String(36), primary_key\u003dTrue)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    lsn_id \u003d Column(String(36), ForeignKey(\u0027lsn.lsn_id\u0027, ondelete\u003d\"CASCADE\"),"},{"line_number":39,"context_line":"                    nullable\u003dFalse)"},{"line_number":40,"context_line":"    sub_id \u003d Column(String(36), nullable\u003dFalse, unique\u003dTrue)"},{"line_number":41,"context_line":"    mac_addr \u003d Column(String(32), nullable\u003dFalse, unique\u003dTrue)"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2B1%2Bc%3D","line":39,"in_reply_to":"AAAAWH%2F%2B8fc%3D","updated":"2014-03-23 13:43:34.000000000","message":"Because in database it is set as NULL. Take a look at this migration that set it\nhttps://github.com/openstack/neutron/blob/master/neutron/db/migration/alembic_migrations/versions/1421183d533f_nsx_dhcp_metadata.py#L51","commit_id":"009b25ccedf8dea529c002aaa9da4cf6213ea4c0"}],"neutron/plugins/vmware/dbexts/models.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"a908f266bea4fce6ee8e391665212caa64fc018b","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    binding_type \u003d Column(Enum(\u0027flat\u0027, \u0027vlan\u0027, \u0027stt\u0027, \u0027gre\u0027, \u0027l3_ext\u0027,"},{"line_number":40,"context_line":"                               name\u003d\u0027tz_network_bindings_binding_type\u0027),"},{"line_number":41,"context_line":"                          nullable\u003dFalse, primary_key\u003dTrue)"},{"line_number":42,"context_line":"    phy_uuid \u003d Column(String(36), primary_key\u003dTrue, nullable\u003dFalse)"},{"line_number":43,"context_line":"    vlan_id \u003d Column(Integer, primary_key\u003dTrue, nullable\u003dFalse,"},{"line_number":44,"context_line":"                     autoincrement\u003dFalse)"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2B8dc%3D","line":42,"updated":"2014-03-21 13:59:08.000000000","message":"this cannot be done without a db migration","commit_id":"009b25ccedf8dea529c002aaa9da4cf6213ea4c0"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"a908f266bea4fce6ee8e391665212caa64fc018b","unresolved":false,"context_lines":[{"line_number":91,"context_line":"                        ForeignKey(\u0027ports.id\u0027, ondelete\u003d\"CASCADE\"),"},{"line_number":92,"context_line":"                        primary_key\u003dTrue)"},{"line_number":93,"context_line":"    nsx_switch_id \u003d Column(String(36))"},{"line_number":94,"context_line":"    nsx_port_id \u003d Column(String(36), nullable\u003dFalse)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def __init__(self, neutron_id, nsx_switch_id, nsx_port_id):"},{"line_number":97,"context_line":"        self.neutron_id \u003d neutron_id"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2B8dQ%3D","line":94,"updated":"2014-03-21 13:59:08.000000000","message":"and so this one. But the bigger question is why are you changing it?","commit_id":"009b25ccedf8dea529c002aaa9da4cf6213ea4c0"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1de410b5682074971f687ada1e6dceff2b76a124","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                               name\u003d\u0027tz_network_bindings_binding_type\u0027),"},{"line_number":41,"context_line":"                          nullable\u003dFalse, primary_key\u003dTrue)"},{"line_number":42,"context_line":"    phy_uuid \u003d Column(String(36), primary_key\u003dTrue, nullable\u003dFalse)"},{"line_number":43,"context_line":"    vlan_id \u003d Column(Integer, primary_key\u003dTrue, nullable\u003dFalse,"},{"line_number":44,"context_line":"                     autoincrement\u003dFalse)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def __init__(self, network_id, binding_type, phy_uuid, vlan_id):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2B1q8%3D","line":43,"updated":"2014-03-23 16:22:26.000000000","message":"I think nullable is not required if it is primary_key. nullable\u003dFalse is assumeed.","commit_id":"03f60fe73556d8ed2e76d8a31c9eb75456ef3ae6"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"c886c723094e780c7532cf539452be1f5a79f874","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                               name\u003d\u0027tz_network_bindings_binding_type\u0027),"},{"line_number":41,"context_line":"                          nullable\u003dFalse, primary_key\u003dTrue)"},{"line_number":42,"context_line":"    phy_uuid \u003d Column(String(36), primary_key\u003dTrue, nullable\u003dTrue)"},{"line_number":43,"context_line":"    vlan_id \u003d Column(Integer, primary_key\u003dTrue, nullable\u003dTrue,"},{"line_number":44,"context_line":"                     autoincrement\u003dFalse)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def __init__(self, network_id, binding_type, phy_uuid, vlan_id):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAWH%2F%2Bfco%3D","side":"PARENT","line":43,"updated":"2014-03-26 12:55:30.000000000","message":"sorry these could be nullable... it\u0027s the migration which needs to be changed then.\n\nI apologise if I misled you with previous comments.","commit_id":"4599e80bd2d6b6ea17b78ba858d618e95ca8be22"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"c994c25bc3b380d01b253e04b71802e37878e792","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                               name\u003d\u0027tz_network_bindings_binding_type\u0027),"},{"line_number":41,"context_line":"                          nullable\u003dFalse, primary_key\u003dTrue)"},{"line_number":42,"context_line":"    phy_uuid \u003d Column(String(36), primary_key\u003dTrue, nullable\u003dTrue)"},{"line_number":43,"context_line":"    vlan_id \u003d Column(Integer, primary_key\u003dTrue, nullable\u003dTrue,"},{"line_number":44,"context_line":"                     autoincrement\u003dFalse)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def __init__(self, network_id, binding_type, phy_uuid, vlan_id):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAWH%2F%2BfSg%3D","side":"PARENT","line":43,"in_reply_to":"AAAAWH%2F%2Bfco%3D","updated":"2014-03-26 13:16:18.000000000","message":"I don\u0027t know how this could be fixed using migration because you can\u0027t set this column nullable as it is a primary key, and when this columns created they created NOT NULL automatic as in migration https://github.com/openstack/neutron/blob/master/neutron/db/migration/alembic_migrations/versions/1d76643bcec4_nvp_netbinding.py#L57 it was tried to set NULL in fact.","commit_id":"4599e80bd2d6b6ea17b78ba858d618e95ca8be22"}]}
