)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"0b2358f722730342581a76e0edc24cb1f2006d9c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b3f238e3_326f467a","updated":"2021-12-14 09:01:36.000000000","message":"API tests failures seems that may be related to that patch. Please check them before rechecking it.","commit_id":"e9ae8dacad1088a36fe0d98a530950cbf5f97ba5"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"66383ab7cd7cad2de93c62cec791c2d8404c0ab0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"78c86089_60d87ebb","updated":"2021-12-22 08:58:26.000000000","message":"Code looks OK, very good catch.","commit_id":"080b9e0451767b0fc1cd2f84affbb779cb344ec0"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"a13e9eefdd1dba7e56e894e3ebe772d9aba37e2c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"250cdb78_05a10850","updated":"2021-12-17 08:15:12.000000000","message":"Very solid detective work Arnau!!! Awesome!\nA couple of comments:\n\n1) This looks to me like a bug fix so we probably want to report it, add the Closes-Bug #xxx to the commit message and backport to stable branches once this one gets merged.\n\n2) It\u0027d be nice to add some test that updates the port (multiple times?) and verifies that the port won\u0027t transition from \u0027up\u0027 to \u0027down\u0027.\n\nWhat do you think?","commit_id":"080b9e0451767b0fc1cd2f84affbb779cb344ec0"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"66383ab7cd7cad2de93c62cec791c2d8404c0ab0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"339677b8_da243b88","in_reply_to":"250cdb78_05a10850","updated":"2021-12-22 08:58:26.000000000","message":"Right, we need a LP bug. There you can add the link for the bugzilla bug (but only there)","commit_id":"080b9e0451767b0fc1cd2f84affbb779cb344ec0"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"90522a2982acd4c1a38500a3e76c312c0f980824","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"735f9a35_4aff59e0","updated":"2021-12-23 08:16:58.000000000","message":"-1 just for triggering discussion about the relation with the other patch","commit_id":"2469c3e576b3d95bbea20cbf7235bf2df5c7697a"},{"author":{"_account_id":34118,"name":"Arnau Verdaguer","email":"averdagu@redhat.com","username":"averdaguer"},"change_message_id":"2963ac24965940330df0fed2342815cdcb10d2bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c1416587_49f3bdaf","updated":"2021-12-22 18:47:37.000000000","message":"Working on functional tests","commit_id":"2469c3e576b3d95bbea20cbf7235bf2df5c7697a"},{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"0305c792b49c72bc18f5d9ec4b29492fdd180dd5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"92ca16d3_1ba477fd","updated":"2022-06-22 08:48:58.000000000","message":"Thanks a lot Arnau!! o/ I just put a small comment there.","commit_id":"8c482b83f2cf6f5495f4df2e5698595db704798d"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"05cd231111759da8c54e5371a87d780cb0ed0358","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"fc645a8c_8d8b6f5f","updated":"2022-08-12 07:18:21.000000000","message":"recheck functional","commit_id":"8c482b83f2cf6f5495f4df2e5698595db704798d"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"66383ab7cd7cad2de93c62cec791c2d8404c0ab0","unresolved":true,"context_lines":[{"line_number":553,"context_line":"                # on the northd status column from UP to DOWN, triggering a"},{"line_number":554,"context_line":"                # LogicalSwitchPortUpdateDownEvent, that will most likely"},{"line_number":555,"context_line":"                # cause a revision conflict."},{"line_number":556,"context_line":"                # https://bugzilla.redhat.com/show_bug.cgi?id\u003d1860448"},{"line_number":557,"context_line":"                columns_dict[\u0027type\u0027] \u003d ovn_const.LSP_TYPE_ROUTER"},{"line_number":558,"context_line":"                port_info.options.update("},{"line_number":559,"context_line":"                    self._nb_idl.get_router_port_options(port[\u0027id\u0027]))"}],"source_content_type":"text/x-python","patch_set":5,"id":"91d2ed44_3a87746b","line":556,"range":{"start_line":556,"start_character":19,"end_line":556,"end_character":68},"updated":"2021-12-22 08:58:26.000000000","message":"Please, remove this link. Create a launchpad bug as a copy of this bugzilla and there add this link. I usually add at the end of the description something like:\nBugzilla reference: https://bugzilla.redhat.com/show_bug.cgi?id\u003d1860448","commit_id":"080b9e0451767b0fc1cd2f84affbb779cb344ec0"},{"author":{"_account_id":34118,"name":"Arnau Verdaguer","email":"averdagu@redhat.com","username":"averdaguer"},"change_message_id":"11cd92b8293fe5b4583b0417706aaf30c0faadcb","unresolved":false,"context_lines":[{"line_number":553,"context_line":"                # on the northd status column from UP to DOWN, triggering a"},{"line_number":554,"context_line":"                # LogicalSwitchPortUpdateDownEvent, that will most likely"},{"line_number":555,"context_line":"                # cause a revision conflict."},{"line_number":556,"context_line":"                # https://bugzilla.redhat.com/show_bug.cgi?id\u003d1860448"},{"line_number":557,"context_line":"                columns_dict[\u0027type\u0027] \u003d ovn_const.LSP_TYPE_ROUTER"},{"line_number":558,"context_line":"                port_info.options.update("},{"line_number":559,"context_line":"                    self._nb_idl.get_router_port_options(port[\u0027id\u0027]))"}],"source_content_type":"text/x-python","patch_set":5,"id":"200422ff_6abcbe70","line":556,"range":{"start_line":556,"start_character":19,"end_line":556,"end_character":68},"in_reply_to":"91d2ed44_3a87746b","updated":"2022-06-20 11:32:58.000000000","message":"Done","commit_id":"080b9e0451767b0fc1cd2f84affbb779cb344ec0"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"90522a2982acd4c1a38500a3e76c312c0f980824","unresolved":true,"context_lines":[{"line_number":554,"context_line":"                # LogicalSwitchPortUpdateDownEvent, that will most likely"},{"line_number":555,"context_line":"                # cause a revision conflict."},{"line_number":556,"context_line":"                # https://bugs.launchpad.net/neutron/+bug/1955578"},{"line_number":557,"context_line":"                columns_dict[\u0027type\u0027] \u003d ovn_const.LSP_TYPE_ROUTER"},{"line_number":558,"context_line":"                port_info.options.update("},{"line_number":559,"context_line":"                    self._nb_idl.get_router_port_options(port[\u0027id\u0027]))"},{"line_number":560,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"6addad72_434ba273","line":557,"range":{"start_line":557,"start_character":16,"end_line":557,"end_character":64},"updated":"2021-12-23 08:16:58.000000000","message":"this patch https://review.opendev.org/c/openstack/neutron/+/821544 removed the LogicalSwitchPortUpdateUp/Down events in favor of monitoring the SB DB instead.\n\nI suppose adding the type here is still ok, but now it won\u0027t affect on those events as the ovsdb_monitor is not reacting to them anymore, right?","commit_id":"2469c3e576b3d95bbea20cbf7235bf2df5c7697a"},{"author":{"_account_id":34118,"name":"Arnau Verdaguer","email":"averdagu@redhat.com","username":"averdaguer"},"change_message_id":"11cd92b8293fe5b4583b0417706aaf30c0faadcb","unresolved":true,"context_lines":[{"line_number":554,"context_line":"                # LogicalSwitchPortUpdateDownEvent, that will most likely"},{"line_number":555,"context_line":"                # cause a revision conflict."},{"line_number":556,"context_line":"                # https://bugs.launchpad.net/neutron/+bug/1955578"},{"line_number":557,"context_line":"                columns_dict[\u0027type\u0027] \u003d ovn_const.LSP_TYPE_ROUTER"},{"line_number":558,"context_line":"                port_info.options.update("},{"line_number":559,"context_line":"                    self._nb_idl.get_router_port_options(port[\u0027id\u0027]))"},{"line_number":560,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"e28eebf5_0a6701e5","line":557,"range":{"start_line":557,"start_character":16,"end_line":557,"end_character":64},"in_reply_to":"6addad72_434ba273","updated":"2022-06-20 11:32:58.000000000","message":"Since the patch was #821544 was reverted, this patch is effective again","commit_id":"2469c3e576b3d95bbea20cbf7235bf2df5c7697a"},{"author":{"_account_id":34118,"name":"Arnau Verdaguer","email":"averdagu@redhat.com","username":"averdaguer"},"change_message_id":"9f51a90e444f695a4117e0b505abd51cdaec4de6","unresolved":false,"context_lines":[{"line_number":554,"context_line":"                # LogicalSwitchPortUpdateDownEvent, that will most likely"},{"line_number":555,"context_line":"                # cause a revision conflict."},{"line_number":556,"context_line":"                # https://bugs.launchpad.net/neutron/+bug/1955578"},{"line_number":557,"context_line":"                columns_dict[\u0027type\u0027] \u003d ovn_const.LSP_TYPE_ROUTER"},{"line_number":558,"context_line":"                port_info.options.update("},{"line_number":559,"context_line":"                    self._nb_idl.get_router_port_options(port[\u0027id\u0027]))"},{"line_number":560,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a01fe02_7ebf9501","line":557,"range":{"start_line":557,"start_character":16,"end_line":557,"end_character":64},"in_reply_to":"e28eebf5_0a6701e5","updated":"2022-06-20 11:33:16.000000000","message":"Done","commit_id":"2469c3e576b3d95bbea20cbf7235bf2df5c7697a"}],"neutron/tests/functional/plugins/ml2/drivers/ovn/mech_driver/test_mech_driver.py":[{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"0305c792b49c72bc18f5d9ec4b29492fdd180dd5","unresolved":true,"context_lines":[{"line_number":658,"context_line":"        og_down_event \u003d ovsdb_monitor.LogicalSwitchPortUpdateDownEvent(None)"},{"line_number":659,"context_line":"        test_down_event \u003d LogicalSwitchPortUpdateDownEventTest()"},{"line_number":660,"context_line":"        test_up_event \u003d LogicalSwitchPortUpdateUpEventTest()"},{"line_number":661,"context_line":"        self.nb_api.idl.notify_handler.unwatch_events("},{"line_number":662,"context_line":"            [og_up_event, og_down_event])"},{"line_number":663,"context_line":"        self.nb_api.idl.notify_handler.watch_events("},{"line_number":664,"context_line":"            [test_down_event, test_up_event])"},{"line_number":665,"context_line":"        # Creating a port the same way as the osp cli cmd"}],"source_content_type":"text/x-python","patch_set":9,"id":"0259d28c_4259b1f4","line":662,"range":{"start_line":661,"start_character":0,"end_line":662,"end_character":41},"updated":"2022-06-22 08:48:58.000000000","message":"Like we talked yesterday, I still think this is not necessary, you can have both events being triggered and it won\u0027t really affect this test result, as far as I can see","commit_id":"8c482b83f2cf6f5495f4df2e5698595db704798d"}]}