)]}'
{"neutron/plugins/nec/nec_plugin.py":[{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"d09dad9a1a7be392f42c6d9ce96742cc182d7c9d","unresolved":false,"context_lines":[{"line_number":243,"context_line":""},{"line_number":244,"context_line":"        try:"},{"line_number":245,"context_line":"            self.ofc.delete_ofc_port(context, port[\u0027id\u0027], port)"},{"line_number":246,"context_line":"            port_status \u003d const.PORT_STATUS_DOWN"},{"line_number":247,"context_line":"            if port_status !\u003d port[\u0027status\u0027]:"},{"line_number":248,"context_line":"                self._update_resource_status(context, \"port\", port[\u0027id\u0027],"},{"line_number":249,"context_line":"                                             port_status)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2Bmhs%3D","line":246,"updated":"2014-03-25 16:26:34.000000000","message":"nit:port_status is needed?","commit_id":"b81c2e218b21364c45baa75682869825c39c0bb4"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b1f7fa2b84e74afe0dfe68ce790b92545729335c","unresolved":false,"context_lines":[{"line_number":243,"context_line":""},{"line_number":244,"context_line":"        try:"},{"line_number":245,"context_line":"            self.ofc.delete_ofc_port(context, port[\u0027id\u0027], port)"},{"line_number":246,"context_line":"            port_status \u003d const.PORT_STATUS_DOWN"},{"line_number":247,"context_line":"            if port_status !\u003d port[\u0027status\u0027]:"},{"line_number":248,"context_line":"                self._update_resource_status(context, \"port\", port[\u0027id\u0027],"},{"line_number":249,"context_line":"                                             port_status)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2Blt4%3D","line":246,"in_reply_to":"AAAAWH%2F%2Bmhs%3D","updated":"2014-03-26 04:56:12.000000000","message":"It is just to use a shorter name, but I should define a new method because we have similar pattern. Done.","commit_id":"b81c2e218b21364c45baa75682869825c39c0bb4"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"d09dad9a1a7be392f42c6d9ce96742cc182d7c9d","unresolved":false,"context_lines":[{"line_number":344,"context_line":"                                                       filters\u003dfilters)"},{"line_number":345,"context_line":"            for port in ports:"},{"line_number":346,"context_line":"                # If some error occurs, status of errored port is set to ERROR."},{"line_number":347,"context_line":"                # This is avoid too many rollback."},{"line_number":348,"context_line":"                # TODO(amotoki): Raise an exception after all port operations"},{"line_number":349,"context_line":"                # are finished to inform the caller of API of the failure."},{"line_number":350,"context_line":"                self.deactivate_port(context, port, raise_exc\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2Bmgo%3D","line":347,"updated":"2014-03-25 16:26:34.000000000","message":"nit: This avoids","commit_id":"b81c2e218b21364c45baa75682869825c39c0bb4"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b1f7fa2b84e74afe0dfe68ce790b92545729335c","unresolved":false,"context_lines":[{"line_number":344,"context_line":"                                                       filters\u003dfilters)"},{"line_number":345,"context_line":"            for port in ports:"},{"line_number":346,"context_line":"                # If some error occurs, status of errored port is set to ERROR."},{"line_number":347,"context_line":"                # This is avoid too many rollback."},{"line_number":348,"context_line":"                # TODO(amotoki): Raise an exception after all port operations"},{"line_number":349,"context_line":"                # are finished to inform the caller of API of the failure."},{"line_number":350,"context_line":"                self.deactivate_port(context, port, raise_exc\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2Bla0%3D","line":347,"in_reply_to":"AAAAWH%2F%2Bmgo%3D","updated":"2014-03-26 04:56:12.000000000","message":"Done","commit_id":"b81c2e218b21364c45baa75682869825c39c0bb4"}],"neutron/plugins/nec/packet_filter.py":[{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"d09dad9a1a7be392f42c6d9ce96742cc182d7c9d","unresolved":false,"context_lines":[{"line_number":226,"context_line":"                LOG.error(_(\"Failed to delete packet_filter id\u003d%(id)s \""},{"line_number":227,"context_line":"                            \"from OFC: %(exc)s\"),"},{"line_number":228,"context_line":"                          {\u0027id\u0027: pf_id, \u0027exc\u0027: str(exc)})"},{"line_number":229,"context_line":"                pf_status \u003d pf_db.PF_STATUS_ERROR"},{"line_number":230,"context_line":"                if pf_status !\u003d current:"},{"line_number":231,"context_line":"                    self._update_resource_status(context, \"packet_filter\","},{"line_number":232,"context_line":"                                                 pf_id, pf_status)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2BmfQ%3D","line":229,"updated":"2014-03-25 16:26:34.000000000","message":"(nit) personally, I prefer use constant directly because variable may be rewritten.","commit_id":"b81c2e218b21364c45baa75682869825c39c0bb4"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b1f7fa2b84e74afe0dfe68ce790b92545729335c","unresolved":false,"context_lines":[{"line_number":226,"context_line":"                LOG.error(_(\"Failed to delete packet_filter id\u003d%(id)s \""},{"line_number":227,"context_line":"                            \"from OFC: %(exc)s\"),"},{"line_number":228,"context_line":"                          {\u0027id\u0027: pf_id, \u0027exc\u0027: str(exc)})"},{"line_number":229,"context_line":"                pf_status \u003d pf_db.PF_STATUS_ERROR"},{"line_number":230,"context_line":"                if pf_status !\u003d current:"},{"line_number":231,"context_line":"                    self._update_resource_status(context, \"packet_filter\","},{"line_number":232,"context_line":"                                                 pf_id, pf_status)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2BlX8%3D","line":229,"in_reply_to":"AAAAWH%2F%2BmfQ%3D","updated":"2014-03-26 04:56:12.000000000","message":"Done","commit_id":"b81c2e218b21364c45baa75682869825c39c0bb4"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"aba8968bde2dec8c71c6158c62c5bb45afd3bd87","unresolved":false,"context_lines":[{"line_number":242,"context_line":""},{"line_number":243,"context_line":"        filters \u003d {\u0027in_port\u0027: [port_id], \u0027status\u0027: [pf_db.PF_STATUS_ACTIVE]}"},{"line_number":244,"context_line":"        pfs \u003d self.get_packet_filters(context, filters\u003dfilters)"},{"line_number":245,"context_line":"        error \u003d False"},{"line_number":246,"context_line":"        for pf in pfs:"},{"line_number":247,"context_line":"            try:"},{"line_number":248,"context_line":"                self.deactivate_packet_filter(context, pf)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2BVOU%3D","line":245,"updated":"2014-03-27 15:24:16.000000000","message":"I don\u0027t think you need this local variable, as you can raise in the except block if raise_exc is True.","commit_id":"f45c1c52423dcbb2ea7690d56b3edc232d16636e"},{"author":{"_account_id":8911,"name":"Sergey Vilgelm","email":"sergey@vilgelm.info","username":"sergey.vilgelm"},"change_message_id":"98d884e8954e36d3129413fe5516188a0455f19d","unresolved":false,"context_lines":[{"line_number":242,"context_line":""},{"line_number":243,"context_line":"        filters \u003d {\u0027in_port\u0027: [port_id], \u0027status\u0027: [pf_db.PF_STATUS_ACTIVE]}"},{"line_number":244,"context_line":"        pfs \u003d self.get_packet_filters(context, filters\u003dfilters)"},{"line_number":245,"context_line":"        error \u003d False"},{"line_number":246,"context_line":"        for pf in pfs:"},{"line_number":247,"context_line":"            try:"},{"line_number":248,"context_line":"                self.deactivate_packet_filter(context, pf)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2BUs4%3D","line":245,"in_reply_to":"AAAAWH%2F%2BU2I%3D","updated":"2014-03-27 16:16:24.000000000","message":"Sorry. My mistake. You are right.","commit_id":"f45c1c52423dcbb2ea7690d56b3edc232d16636e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"301ebdabf89920fc3c97a90db3c11a44fa398fd1","unresolved":false,"context_lines":[{"line_number":242,"context_line":""},{"line_number":243,"context_line":"        filters \u003d {\u0027in_port\u0027: [port_id], \u0027status\u0027: [pf_db.PF_STATUS_ACTIVE]}"},{"line_number":244,"context_line":"        pfs \u003d self.get_packet_filters(context, filters\u003dfilters)"},{"line_number":245,"context_line":"        error \u003d False"},{"line_number":246,"context_line":"        for pf in pfs:"},{"line_number":247,"context_line":"            try:"},{"line_number":248,"context_line":"                self.deactivate_packet_filter(context, pf)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2BU2I%3D","line":245,"in_reply_to":"AAAAWH%2F%2BVOU%3D","updated":"2014-03-27 16:01:20.000000000","message":"There is a case where multiple packet filters are associated with a port. I tried to deactivate packet filters as possible as we can even after an exception occurs (to keep the previous behaviors).\n\nHowever, it looks unnecessary. It does not provide more value because a user still need a retry.\nThanks for pointing it.","commit_id":"f45c1c52423dcbb2ea7690d56b3edc232d16636e"},{"author":{"_account_id":8911,"name":"Sergey Vilgelm","email":"sergey@vilgelm.info","username":"sergey.vilgelm"},"change_message_id":"14e446b02569e43dbdba666c9609751a3f6788f3","unresolved":false,"context_lines":[{"line_number":247,"context_line":"            try:"},{"line_number":248,"context_line":"                self.deactivate_packet_filter(context, pf)"},{"line_number":249,"context_line":"            except (nexc.OFCException, nexc.OFCMappingNotFound):"},{"line_number":250,"context_line":"                error \u003d True"},{"line_number":251,"context_line":"        if raise_exc and error:"},{"line_number":252,"context_line":"            raise nexc.OFCException(_(\u0027Error occurred while disabling packet \u0027"},{"line_number":253,"context_line":"                                      \u0027filter(s) for port %s\u0027), port_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2BVEY%3D","line":250,"updated":"2014-03-27 15:39:42.000000000","message":"I agree with Salavatore. You don\u0027t need the \"error\" variable. You can raise exception in this position.\n    except (...):\n        if raise_exc:\n            raise nexc.OFCException(...)","commit_id":"f45c1c52423dcbb2ea7690d56b3edc232d16636e"}],"neutron/tests/unit/nec/test_nec_plugin.py":[{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"d09dad9a1a7be392f42c6d9ce96742cc182d7c9d","unresolved":false,"context_lines":[{"line_number":586,"context_line":""},{"line_number":587,"context_line":"    def test_delete_network_with_error_status(self):"},{"line_number":588,"context_line":"        self.ofc.set_raise_exc(\u0027create_ofc_network\u0027,"},{"line_number":589,"context_line":"                               nexc.OFCException(reason\u003d\u0027hoge\u0027))"},{"line_number":590,"context_line":""},{"line_number":591,"context_line":"        with self.network() as net:"},{"line_number":592,"context_line":"            net_id \u003d net[\u0027network\u0027][\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2BmeY%3D","line":589,"updated":"2014-03-25 16:26:34.000000000","message":"nit: hoge is may be japanese :) May be fake_error is better?","commit_id":"b81c2e218b21364c45baa75682869825c39c0bb4"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b1f7fa2b84e74afe0dfe68ce790b92545729335c","unresolved":false,"context_lines":[{"line_number":586,"context_line":""},{"line_number":587,"context_line":"    def test_delete_network_with_error_status(self):"},{"line_number":588,"context_line":"        self.ofc.set_raise_exc(\u0027create_ofc_network\u0027,"},{"line_number":589,"context_line":"                               nexc.OFCException(reason\u003d\u0027hoge\u0027))"},{"line_number":590,"context_line":""},{"line_number":591,"context_line":"        with self.network() as net:"},{"line_number":592,"context_line":"            net_id \u003d net[\u0027network\u0027][\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2BlzU%3D","line":589,"in_reply_to":"AAAAWH%2F%2BmeY%3D","updated":"2014-03-26 04:56:12.000000000","message":"I just followed the convention in this module :-)\nI see Adeus, Forza Juve too.\n\nI changed it for new tests.","commit_id":"b81c2e218b21364c45baa75682869825c39c0bb4"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"d09dad9a1a7be392f42c6d9ce96742cc182d7c9d","unresolved":false,"context_lines":[{"line_number":837,"context_line":""},{"line_number":838,"context_line":"    def test_delete_port_with_error_status(self):"},{"line_number":839,"context_line":"        self.ofc.set_raise_exc(\u0027create_ofc_port\u0027,"},{"line_number":840,"context_line":"                               nexc.OFCException(reason\u003d\u0027hoge\u0027))"},{"line_number":841,"context_line":""},{"line_number":842,"context_line":"        with self.port() as port:"},{"line_number":843,"context_line":"            port_id \u003d port[\u0027port\u0027][\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2BmeU%3D","line":840,"updated":"2014-03-25 16:26:34.000000000","message":"ditto","commit_id":"b81c2e218b21364c45baa75682869825c39c0bb4"}],"neutron/tests/unit/nec/test_packet_filter.py":[{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"d09dad9a1a7be392f42c6d9ce96742cc182d7c9d","unresolved":false,"context_lines":[{"line_number":390,"context_line":""},{"line_number":391,"context_line":"    def test_delete_pf_with_error_status(self):"},{"line_number":392,"context_line":"        self.ofc.set_raise_exc(\u0027create_ofc_packet_filter\u0027,"},{"line_number":393,"context_line":"                               nexc.OFCException(reason\u003d\u0027hoge\u0027))"},{"line_number":394,"context_line":"        with self.packet_filter_on_network() as pf:"},{"line_number":395,"context_line":"            pf_id \u003d pf[\u0027packet_filter\u0027][\u0027id\u0027]"},{"line_number":396,"context_line":"            pf_ref \u003d self._show(\u0027packet_filters\u0027, pf_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2BmeQ%3D","line":393,"updated":"2014-03-25 16:26:34.000000000","message":"ditto","commit_id":"b81c2e218b21364c45baa75682869825c39c0bb4"}]}
