)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a446dae026b6c489702a338c23658dd3b71a638f","unresolved":true,"context_lines":[{"line_number":10,"context_line":"could not be modified by another object. This change prevents the driver"},{"line_number":11,"context_line":"from associating more ACLs than needed if the network log object created"},{"line_number":12,"context_line":"is to log the dropped traffic."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ib392b46308aaf76386a747870c5600790a268d51"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"04d1729e_a25c1390","line":13,"updated":"2022-01-03 09:15:32.000000000","message":"is there any bug reported for that?","commit_id":"cbae0f18f44617f0c6edcf74e08be9a99a152914"},{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"44ff871644f6885cecef8dd4253a0c59edfaefc7","unresolved":false,"context_lines":[{"line_number":10,"context_line":"could not be modified by another object. This change prevents the driver"},{"line_number":11,"context_line":"from associating more ACLs than needed if the network log object created"},{"line_number":12,"context_line":"is to log the dropped traffic."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ib392b46308aaf76386a747870c5600790a268d51"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"57f3964c_2a0cf03e","line":13,"in_reply_to":"04d1729e_a25c1390","updated":"2022-01-07 14:06:25.000000000","message":"Thanks for the heads up! It was only on Red Hat\u0027s BZ. I just reported it on Launchpad too and updated the commit to reflect that. https://bugs.launchpad.net/neutron/+bug/1956763","commit_id":"cbae0f18f44617f0c6edcf74e08be9a99a152914"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"eaaecac9373a18f345a6b3de11dba5de52de526c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"adf16c43_47fb7569","updated":"2021-12-21 10:03:30.000000000","message":"Please check failed functional test: https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_124/822096/2/check/neutron-functional-with-uwsgi/1242a41/testr_results.html\nIt seems to be related to this change","commit_id":"935f69a783e13010fdecdd4ce96ef138c224777b"},{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"6f9e1dc563fc2ac8ecc089618b07181367a44f79","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"95170098_d3d1e368","in_reply_to":"adf16c43_47fb7569","updated":"2021-12-21 10:37:52.000000000","message":"Yes! Sorry for not updating this with a comment but I don\u0027t think this patch is a good way forward because it messes up the way --enable and --disable work in the network log api. I\u0027m currently working on an update to this patch to properly fix this. Thanks a lot for taking a look!!","commit_id":"935f69a783e13010fdecdd4ce96ef138c224777b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"83fe0061cbe6b4f95ffc43a26951ea44131da34e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a8267d4b_8b92229d","updated":"2022-01-10 14:11:53.000000000","message":"Good catch! I\u0027ve tested this manually and now DROP ACLs do not override the ACCEPT ones. The match is\n  match               : \"outport \u003d\u003d @neutron_pg_drop \u0026\u0026 ip\"\n\nThe -1 for this patch is because you should implement some FTs testing what you have modified here. Currently we don\u0027t define the \"event\" parameter in the FTs for service logapi in OVN. Adding this parameter and test it, checking the port group and ACLs created, will prevent future regressions.\n\n","commit_id":"cddccfc8dee32525c992956a5b8693310bc328e5"},{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"dda91b40cc04cd1981b2aa75cc8e36bb1048295d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b07da507_e7dddec7","in_reply_to":"a8267d4b_8b92229d","updated":"2022-01-11 18:18:47.000000000","message":"You are totally right. I\u0027m currently implementing that. Thanks to your comment I realized this patch was previously not fixing the case where no \"--resource\" was defined, and now it does. I\u0027m changing it to WIP while I make the functional tests.","commit_id":"cddccfc8dee32525c992956a5b8693310bc328e5"},{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"dda91b40cc04cd1981b2aa75cc8e36bb1048295d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a0c379b0_79672993","updated":"2022-01-11 18:18:47.000000000","message":"WIP Because I have not added the functional tests yet.","commit_id":"e43fceb85ed1bf148ba1550ba1d5efd6411f10b2"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"af7d434d136890994f4e7b60d6141d9ffdb5b1fc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"518684d8_fba0f3a6","updated":"2022-01-17 17:35:43.000000000","message":"BTW, good testing.","commit_id":"9bcdabf0a1e2aadf4ab5d15f837ff41fcceaede8"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"bf0b75d7c811a821353c2a33c01efcc6996e6026","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"ae529641_4a342078","updated":"2022-01-24 12:22:18.000000000","message":"Thanks Elvira!","commit_id":"af837fc797c116a4c9257dc25603bd76c82e61f7"},{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"85f6798ff5b0486681ca042745abb8cd33d1b6d9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"d0ac7734_bc79b999","updated":"2022-01-18 10:19:27.000000000","message":"Thanks a lot for your comments!!! I think I\u0027ve fixed them now.","commit_id":"af837fc797c116a4c9257dc25603bd76c82e61f7"},{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"43114ca8fa333e14ddb0247cca901a3996808693","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"b9311c50_7cf64cfb","updated":"2022-01-25 19:30:13.000000000","message":"Hi, I went over the reviews in this new patch version. Thanks!!","commit_id":"ac1b680e1f87269f1379813f6f2203354b42538c"}],"neutron/services/logapi/drivers/ovn/driver.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a45950569a858017ef044696395ac9e9614ef2f6","unresolved":true,"context_lines":[{"line_number":224,"context_line":"                    pg \u003d self.ovn_nb.lookup(\"Port_Group\","},{"line_number":225,"context_line":"                                            ovn_const.OVN_DROP_PORT_GROUP_NAME)"},{"line_number":226,"context_line":"                    return [{\"name\": pg.name,"},{"line_number":227,"context_line":"                        \"acls\": [r.uuid for r in pg.acls]}]"},{"line_number":228,"context_line":"                except idlutils.RowNotFound:"},{"line_number":229,"context_line":"                    pass"},{"line_number":230,"context_line":"            # No sg, no port, ACCEPT: return all except DROP pg"}],"source_content_type":"text/x-python","patch_set":7,"id":"38b4be10_6622cdd2","line":227,"updated":"2022-01-18 07:32:45.000000000","message":"nit: this indentation is strange, IMHO it would be better to have it like in L237","commit_id":"9bcdabf0a1e2aadf4ab5d15f837ff41fcceaede8"},{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"85f6798ff5b0486681ca042745abb8cd33d1b6d9","unresolved":false,"context_lines":[{"line_number":224,"context_line":"                    pg \u003d self.ovn_nb.lookup(\"Port_Group\","},{"line_number":225,"context_line":"                                            ovn_const.OVN_DROP_PORT_GROUP_NAME)"},{"line_number":226,"context_line":"                    return [{\"name\": pg.name,"},{"line_number":227,"context_line":"                        \"acls\": [r.uuid for r in pg.acls]}]"},{"line_number":228,"context_line":"                except idlutils.RowNotFound:"},{"line_number":229,"context_line":"                    pass"},{"line_number":230,"context_line":"            # No sg, no port, ACCEPT: return all except DROP pg"}],"source_content_type":"text/x-python","patch_set":7,"id":"65b8318f_f7d914fb","line":227,"in_reply_to":"38b4be10_6622cdd2","updated":"2022-01-18 10:19:27.000000000","message":"Done","commit_id":"9bcdabf0a1e2aadf4ab5d15f837ff41fcceaede8"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"bf0b75d7c811a821353c2a33c01efcc6996e6026","unresolved":true,"context_lines":[{"line_number":231,"context_line":"            else:"},{"line_number":232,"context_line":"                pgs \u003d self._pgs_all()"},{"line_number":233,"context_line":"                try:"},{"line_number":234,"context_line":"                    pg \u003d self.ovn_nb.lookup(\"Port_Group\","},{"line_number":235,"context_line":"                                            ovn_const.OVN_DROP_PORT_GROUP_NAME)"},{"line_number":236,"context_line":"                    pgs.remove({\"name\": pg.name,"},{"line_number":237,"context_line":"                                \"acls\": [r.uuid for r in pg.acls]})"},{"line_number":238,"context_line":"                except idlutils.RowNotFound:"}],"source_content_type":"text/x-python","patch_set":8,"id":"766ee142_ac86534a","line":235,"range":{"start_line":234,"start_character":0,"end_line":235,"end_character":79},"updated":"2022-01-24 12:22:18.000000000","message":"instead of pg, perhaps pg_drop and since you do the same in L224, can you have a single try/except block in the else clause? eg.\n\nif log_obj.event \u003d\u003d log_const.ALL_EVENT:\n  ...\nelse:\n    try:\n       ....\n    except ...\n    if log:obj.event \u003d\u003d ...\n    elif","commit_id":"af837fc797c116a4c9257dc25603bd76c82e61f7"},{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"43114ca8fa333e14ddb0247cca901a3996808693","unresolved":false,"context_lines":[{"line_number":231,"context_line":"            else:"},{"line_number":232,"context_line":"                pgs \u003d self._pgs_all()"},{"line_number":233,"context_line":"                try:"},{"line_number":234,"context_line":"                    pg \u003d self.ovn_nb.lookup(\"Port_Group\","},{"line_number":235,"context_line":"                                            ovn_const.OVN_DROP_PORT_GROUP_NAME)"},{"line_number":236,"context_line":"                    pgs.remove({\"name\": pg.name,"},{"line_number":237,"context_line":"                                \"acls\": [r.uuid for r in pg.acls]})"},{"line_number":238,"context_line":"                except idlutils.RowNotFound:"}],"source_content_type":"text/x-python","patch_set":8,"id":"849022c6_a0b8ef30","line":235,"range":{"start_line":234,"start_character":0,"end_line":235,"end_character":79},"in_reply_to":"63297344_bc6aa1f3","updated":"2022-01-25 19:30:13.000000000","message":"You are right, thanks!","commit_id":"af837fc797c116a4c9257dc25603bd76c82e61f7"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"647da143c706b6e5a7c8aed97bb1542f5236ca3b","unresolved":true,"context_lines":[{"line_number":231,"context_line":"            else:"},{"line_number":232,"context_line":"                pgs \u003d self._pgs_all()"},{"line_number":233,"context_line":"                try:"},{"line_number":234,"context_line":"                    pg \u003d self.ovn_nb.lookup(\"Port_Group\","},{"line_number":235,"context_line":"                                            ovn_const.OVN_DROP_PORT_GROUP_NAME)"},{"line_number":236,"context_line":"                    pgs.remove({\"name\": pg.name,"},{"line_number":237,"context_line":"                                \"acls\": [r.uuid for r in pg.acls]})"},{"line_number":238,"context_line":"                except idlutils.RowNotFound:"}],"source_content_type":"text/x-python","patch_set":8,"id":"63297344_bc6aa1f3","line":235,"range":{"start_line":234,"start_character":0,"end_line":235,"end_character":79},"in_reply_to":"766ee142_ac86534a","updated":"2022-01-24 15:21:47.000000000","message":"+1","commit_id":"af837fc797c116a4c9257dc25603bd76c82e61f7"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"2b7f8465ac10fa946f4b65879252b36c4c4075ed","unresolved":true,"context_lines":[{"line_number":218,"context_line":"            # No sg, no port, ALL: return all pgs"},{"line_number":219,"context_line":"            if log_obj.event \u003d\u003d log_const.ALL_EVENT:"},{"line_number":220,"context_line":"                return self._pgs_all()"},{"line_number":221,"context_line":"            # No sg, no port, DROP: return DROP pg"},{"line_number":222,"context_line":"            else:"},{"line_number":223,"context_line":"                try:"},{"line_number":224,"context_line":"                    pg_drop \u003d self.ovn_nb.lookup(\"Port_Group\","}],"source_content_type":"text/x-python","patch_set":9,"id":"83ac3964_893260b2","line":221,"range":{"start_line":221,"start_character":12,"end_line":221,"end_character":50},"updated":"2022-01-28 12:21:07.000000000","message":"This is not valid any more here. Maybe in L226","commit_id":"ac1b680e1f87269f1379813f6f2203354b42538c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"2b7f8465ac10fa946f4b65879252b36c4c4075ed","unresolved":true,"context_lines":[{"line_number":219,"context_line":"            if log_obj.event \u003d\u003d log_const.ALL_EVENT:"},{"line_number":220,"context_line":"                return self._pgs_all()"},{"line_number":221,"context_line":"            # No sg, no port, DROP: return DROP pg"},{"line_number":222,"context_line":"            else:"},{"line_number":223,"context_line":"                try:"},{"line_number":224,"context_line":"                    pg_drop \u003d self.ovn_nb.lookup(\"Port_Group\","},{"line_number":225,"context_line":"                            ovn_const.OVN_DROP_PORT_GROUP_NAME)"}],"source_content_type":"text/x-python","patch_set":9,"id":"bbf86a75_25ace8b3","line":222,"range":{"start_line":222,"start_character":0,"end_line":222,"end_character":4},"updated":"2022-01-28 12:21:07.000000000","message":"pep8 should raise a warning here. This \"else\" clause is not needed","commit_id":"ac1b680e1f87269f1379813f6f2203354b42538c"}],"neutron/tests/functional/services/logapi/drivers/ovn/test_driver.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a746695b2f4e75586da714b1c998c559f1e8e2a7","unresolved":true,"context_lines":[{"line_number":309,"context_line":"        log_data1[\u0027log\u0027][\u0027event\u0027] \u003d event1"},{"line_number":310,"context_line":"        log_obj1 \u003d self.log_plugin.create_log(self.ctxt, log_data1)"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"        if event1 in drop_true_events:"},{"line_number":313,"context_line":"            self._check_acl_log_drop()"},{"line_number":314,"context_line":"        else:"},{"line_number":315,"context_line":"            self._check_acl_log_drop(is_enabled\u003dFalse)"},{"line_number":316,"context_line":"        if event1 in accept_true_events:"},{"line_number":317,"context_line":"            self._check_sgrs(sgrs\u003dsgrs)"},{"line_number":318,"context_line":"        else:"},{"line_number":319,"context_line":"            self._check_sgrs(sgrs\u003dsgrs, is_enabled\u003dFalse)"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"        # Add second log object"},{"line_number":322,"context_line":"        log_data2 \u003d self._log_data(sg_id\u003dsg)"}],"source_content_type":"text/x-python","patch_set":7,"id":"e11036a3_7263bbb6","line":319,"range":{"start_line":312,"start_character":0,"end_line":319,"end_character":57},"updated":"2022-01-17 17:34:52.000000000","message":"In sake of simplicity:\n\nself._check_acl_log_drop(is_enabled\u003devent1 in drop_true_events)\nself._check_sgrs(sgrs\u003dsgrs, is_enabled\u003devent1 in accept_true_events)","commit_id":"9bcdabf0a1e2aadf4ab5d15f837ff41fcceaede8"},{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"85f6798ff5b0486681ca042745abb8cd33d1b6d9","unresolved":false,"context_lines":[{"line_number":309,"context_line":"        log_data1[\u0027log\u0027][\u0027event\u0027] \u003d event1"},{"line_number":310,"context_line":"        log_obj1 \u003d self.log_plugin.create_log(self.ctxt, log_data1)"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"        if event1 in drop_true_events:"},{"line_number":313,"context_line":"            self._check_acl_log_drop()"},{"line_number":314,"context_line":"        else:"},{"line_number":315,"context_line":"            self._check_acl_log_drop(is_enabled\u003dFalse)"},{"line_number":316,"context_line":"        if event1 in accept_true_events:"},{"line_number":317,"context_line":"            self._check_sgrs(sgrs\u003dsgrs)"},{"line_number":318,"context_line":"        else:"},{"line_number":319,"context_line":"            self._check_sgrs(sgrs\u003dsgrs, is_enabled\u003dFalse)"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"        # Add second log object"},{"line_number":322,"context_line":"        log_data2 \u003d self._log_data(sg_id\u003dsg)"}],"source_content_type":"text/x-python","patch_set":7,"id":"b4c230eb_f3303d4a","line":319,"range":{"start_line":312,"start_character":0,"end_line":319,"end_character":57},"in_reply_to":"67d0f0c1_6a513aa0","updated":"2022-01-18 10:19:27.000000000","message":"Thanks, that is indeed much better!","commit_id":"9bcdabf0a1e2aadf4ab5d15f837ff41fcceaede8"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a45950569a858017ef044696395ac9e9614ef2f6","unresolved":true,"context_lines":[{"line_number":309,"context_line":"        log_data1[\u0027log\u0027][\u0027event\u0027] \u003d event1"},{"line_number":310,"context_line":"        log_obj1 \u003d self.log_plugin.create_log(self.ctxt, log_data1)"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"        if event1 in drop_true_events:"},{"line_number":313,"context_line":"            self._check_acl_log_drop()"},{"line_number":314,"context_line":"        else:"},{"line_number":315,"context_line":"            self._check_acl_log_drop(is_enabled\u003dFalse)"},{"line_number":316,"context_line":"        if event1 in accept_true_events:"},{"line_number":317,"context_line":"            self._check_sgrs(sgrs\u003dsgrs)"},{"line_number":318,"context_line":"        else:"},{"line_number":319,"context_line":"            self._check_sgrs(sgrs\u003dsgrs, is_enabled\u003dFalse)"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"        # Add second log object"},{"line_number":322,"context_line":"        log_data2 \u003d self._log_data(sg_id\u003dsg)"}],"source_content_type":"text/x-python","patch_set":7,"id":"67d0f0c1_6a513aa0","line":319,"range":{"start_line":312,"start_character":0,"end_line":319,"end_character":57},"in_reply_to":"e11036a3_7263bbb6","updated":"2022-01-18 07:32:45.000000000","message":"+1","commit_id":"9bcdabf0a1e2aadf4ab5d15f837ff41fcceaede8"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a746695b2f4e75586da714b1c998c559f1e8e2a7","unresolved":true,"context_lines":[{"line_number":333,"context_line":""},{"line_number":334,"context_line":"        # Delete second log object"},{"line_number":335,"context_line":"        self.log_plugin.delete_log(self.ctxt, log_obj2[\u0027id\u0027])"},{"line_number":336,"context_line":"        if event1 in drop_true_events:"},{"line_number":337,"context_line":"            self._check_acl_log_drop()"},{"line_number":338,"context_line":"        else:"},{"line_number":339,"context_line":"            self._check_acl_log_drop(is_enabled\u003dFalse)"},{"line_number":340,"context_line":"        if event1 in accept_true_events:"},{"line_number":341,"context_line":"            self._check_sgrs(sgrs\u003dsgrs)"},{"line_number":342,"context_line":"        else:"},{"line_number":343,"context_line":"            self._check_sgrs(sgrs\u003dsgrs, is_enabled\u003dFalse)"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"        # Delete first log object"},{"line_number":346,"context_line":"        self.log_plugin.delete_log(self.ctxt, log_obj1[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"ce0cede0_4dda5edb","line":343,"range":{"start_line":336,"start_character":0,"end_line":343,"end_character":57},"updated":"2022-01-17 17:34:52.000000000","message":"same as in L312","commit_id":"9bcdabf0a1e2aadf4ab5d15f837ff41fcceaede8"},{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"85f6798ff5b0486681ca042745abb8cd33d1b6d9","unresolved":false,"context_lines":[{"line_number":333,"context_line":""},{"line_number":334,"context_line":"        # Delete second log object"},{"line_number":335,"context_line":"        self.log_plugin.delete_log(self.ctxt, log_obj2[\u0027id\u0027])"},{"line_number":336,"context_line":"        if event1 in drop_true_events:"},{"line_number":337,"context_line":"            self._check_acl_log_drop()"},{"line_number":338,"context_line":"        else:"},{"line_number":339,"context_line":"            self._check_acl_log_drop(is_enabled\u003dFalse)"},{"line_number":340,"context_line":"        if event1 in accept_true_events:"},{"line_number":341,"context_line":"            self._check_sgrs(sgrs\u003dsgrs)"},{"line_number":342,"context_line":"        else:"},{"line_number":343,"context_line":"            self._check_sgrs(sgrs\u003dsgrs, is_enabled\u003dFalse)"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"        # Delete first log object"},{"line_number":346,"context_line":"        self.log_plugin.delete_log(self.ctxt, log_obj1[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"d9cf4851_932dd2c8","line":343,"range":{"start_line":336,"start_character":0,"end_line":343,"end_character":57},"in_reply_to":"716f1969_843eeb3f","updated":"2022-01-18 10:19:27.000000000","message":"Done","commit_id":"9bcdabf0a1e2aadf4ab5d15f837ff41fcceaede8"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a45950569a858017ef044696395ac9e9614ef2f6","unresolved":true,"context_lines":[{"line_number":333,"context_line":""},{"line_number":334,"context_line":"        # Delete second log object"},{"line_number":335,"context_line":"        self.log_plugin.delete_log(self.ctxt, log_obj2[\u0027id\u0027])"},{"line_number":336,"context_line":"        if event1 in drop_true_events:"},{"line_number":337,"context_line":"            self._check_acl_log_drop()"},{"line_number":338,"context_line":"        else:"},{"line_number":339,"context_line":"            self._check_acl_log_drop(is_enabled\u003dFalse)"},{"line_number":340,"context_line":"        if event1 in accept_true_events:"},{"line_number":341,"context_line":"            self._check_sgrs(sgrs\u003dsgrs)"},{"line_number":342,"context_line":"        else:"},{"line_number":343,"context_line":"            self._check_sgrs(sgrs\u003dsgrs, is_enabled\u003dFalse)"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"        # Delete first log object"},{"line_number":346,"context_line":"        self.log_plugin.delete_log(self.ctxt, log_obj1[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"716f1969_843eeb3f","line":343,"range":{"start_line":336,"start_character":0,"end_line":343,"end_character":57},"in_reply_to":"ce0cede0_4dda5edb","updated":"2022-01-18 07:32:45.000000000","message":"+1","commit_id":"9bcdabf0a1e2aadf4ab5d15f837ff41fcceaede8"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a746695b2f4e75586da714b1c998c559f1e8e2a7","unresolved":true,"context_lines":[{"line_number":349,"context_line":""},{"line_number":350,"context_line":"    def test_events_all_sg(self):"},{"line_number":351,"context_line":"        self._add_logs_then_remove(log_const.DROP_EVENT,"},{"line_number":352,"context_line":"                log_const.ALL_EVENT)"},{"line_number":353,"context_line":"        self._add_logs_then_remove(log_const.ACCEPT_EVENT,"},{"line_number":354,"context_line":"                log_const.DROP_EVENT)"},{"line_number":355,"context_line":"        self._add_logs_then_remove(log_const.DROP_EVENT,"}],"source_content_type":"text/x-python","patch_set":7,"id":"652ca8e4_6a2c631c","line":352,"updated":"2022-01-17 17:34:52.000000000","message":"nit: this indentation is weird.","commit_id":"9bcdabf0a1e2aadf4ab5d15f837ff41fcceaede8"},{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"85f6798ff5b0486681ca042745abb8cd33d1b6d9","unresolved":true,"context_lines":[{"line_number":349,"context_line":""},{"line_number":350,"context_line":"    def test_events_all_sg(self):"},{"line_number":351,"context_line":"        self._add_logs_then_remove(log_const.DROP_EVENT,"},{"line_number":352,"context_line":"                log_const.ALL_EVENT)"},{"line_number":353,"context_line":"        self._add_logs_then_remove(log_const.ACCEPT_EVENT,"},{"line_number":354,"context_line":"                log_const.DROP_EVENT)"},{"line_number":355,"context_line":"        self._add_logs_then_remove(log_const.DROP_EVENT,"}],"source_content_type":"text/x-python","patch_set":7,"id":"fab49a13_f1d1df7a","line":352,"in_reply_to":"23e0a90e_68af6538","updated":"2022-01-18 10:19:27.000000000","message":"Nice catch, thanks!!\nAre the indentations better now? If not, how do you recommend them?\n(I could not put the ones below as one-liner because it would be 80 chars per line instead of 79)","commit_id":"9bcdabf0a1e2aadf4ab5d15f837ff41fcceaede8"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a45950569a858017ef044696395ac9e9614ef2f6","unresolved":true,"context_lines":[{"line_number":349,"context_line":""},{"line_number":350,"context_line":"    def test_events_all_sg(self):"},{"line_number":351,"context_line":"        self._add_logs_then_remove(log_const.DROP_EVENT,"},{"line_number":352,"context_line":"                log_const.ALL_EVENT)"},{"line_number":353,"context_line":"        self._add_logs_then_remove(log_const.ACCEPT_EVENT,"},{"line_number":354,"context_line":"                log_const.DROP_EVENT)"},{"line_number":355,"context_line":"        self._add_logs_then_remove(log_const.DROP_EVENT,"}],"source_content_type":"text/x-python","patch_set":7,"id":"23e0a90e_68af6538","line":352,"in_reply_to":"652ca8e4_6a2c631c","updated":"2022-01-18 07:32:45.000000000","message":"I agree. And so all the indentations below","commit_id":"9bcdabf0a1e2aadf4ab5d15f837ff41fcceaede8"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"bf0b75d7c811a821353c2a33c01efcc6996e6026","unresolved":true,"context_lines":[{"line_number":148,"context_line":"                return row"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    def _find_drop_acls(self):"},{"line_number":151,"context_line":"        # The drop security group is special and doesn\u0027t depend on the security"},{"line_number":152,"context_line":"        # group."},{"line_number":153,"context_line":"        rows \u003d []"},{"line_number":154,"context_line":"        for row in self.nb_api._tables[\u0027ACL\u0027].rows.values():"},{"line_number":155,"context_line":"            if \"@neutron_pg_drop\" in row.match:"},{"line_number":156,"context_line":"                rows.append(row)"},{"line_number":157,"context_line":"        return rows"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    def _check_acl_log(self, sgr, is_enabled\u003dTrue):"},{"line_number":160,"context_line":"        acl \u003d self._find_security_group_rule_row_by_id(sgr)"}],"source_content_type":"text/x-python","patch_set":8,"id":"128d5e55_1c1026a6","line":157,"range":{"start_line":151,"start_character":0,"end_line":157,"end_character":19},"updated":"2022-01-24 12:22:18.000000000","message":"Can\u0027t we just fetch the ACLs in the PG drop? \nhttps://github.com/ovn-org/ovn/blob/main/ovn-nb.ovsschema#L172","commit_id":"af837fc797c116a4c9257dc25603bd76c82e61f7"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"647da143c706b6e5a7c8aed97bb1542f5236ca3b","unresolved":true,"context_lines":[{"line_number":148,"context_line":"                return row"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    def _find_drop_acls(self):"},{"line_number":151,"context_line":"        # The drop security group is special and doesn\u0027t depend on the security"},{"line_number":152,"context_line":"        # group."},{"line_number":153,"context_line":"        rows \u003d []"},{"line_number":154,"context_line":"        for row in self.nb_api._tables[\u0027ACL\u0027].rows.values():"},{"line_number":155,"context_line":"            if \"@neutron_pg_drop\" in row.match:"},{"line_number":156,"context_line":"                rows.append(row)"},{"line_number":157,"context_line":"        return rows"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    def _check_acl_log(self, sgr, is_enabled\u003dTrue):"},{"line_number":160,"context_line":"        acl \u003d self._find_security_group_rule_row_by_id(sgr)"}],"source_content_type":"text/x-python","patch_set":8,"id":"c986b0b1_05664d1e","line":157,"range":{"start_line":151,"start_character":0,"end_line":157,"end_character":19},"in_reply_to":"128d5e55_1c1026a6","updated":"2022-01-24 15:21:47.000000000","message":"+1","commit_id":"af837fc797c116a4c9257dc25603bd76c82e61f7"},{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"43114ca8fa333e14ddb0247cca901a3996808693","unresolved":false,"context_lines":[{"line_number":148,"context_line":"                return row"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    def _find_drop_acls(self):"},{"line_number":151,"context_line":"        # The drop security group is special and doesn\u0027t depend on the security"},{"line_number":152,"context_line":"        # group."},{"line_number":153,"context_line":"        rows \u003d []"},{"line_number":154,"context_line":"        for row in self.nb_api._tables[\u0027ACL\u0027].rows.values():"},{"line_number":155,"context_line":"            if \"@neutron_pg_drop\" in row.match:"},{"line_number":156,"context_line":"                rows.append(row)"},{"line_number":157,"context_line":"        return rows"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    def _check_acl_log(self, sgr, is_enabled\u003dTrue):"},{"line_number":160,"context_line":"        acl \u003d self._find_security_group_rule_row_by_id(sgr)"}],"source_content_type":"text/x-python","patch_set":8,"id":"001f81a6_7342c7d9","line":157,"range":{"start_line":151,"start_character":0,"end_line":157,"end_character":19},"in_reply_to":"c986b0b1_05664d1e","updated":"2022-01-25 19:30:13.000000000","message":"Done","commit_id":"af837fc797c116a4c9257dc25603bd76c82e61f7"}]}