)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22865,"name":"Jaganathan Palanisamy","email":"jpalanis@redhat.com","username":"jaganathancse"},"change_message_id":"abbc09a5929a71bbfc7348bb596b01b400ee671c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f1dc38d3_67e4338e","updated":"2021-12-21 17:21:54.000000000","message":"@Jakub Libosvar, Thanks for your comments. will update it.","commit_id":"1e42d658475746b123657782c0d1db7756a7ff9f"}],"tools/ovn_migration/tripleo_environment/ovn_migration.sh":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"84e68c2708d265c1eb0dde6792ac71f868ec74b3","unresolved":true,"context_lines":[{"line_number":170,"context_line":"    echo \"[ovn-controllers]\" \u003e\u003e hosts_for_migration"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    # We want to run ovn-controller where OVS agent was running before the migration"},{"line_number":173,"context_line":"    OVN_CONTROLLERS\u003d$(get_group_hosts \"$inventory_file\" neutron_ovs_agent \u0026\u0026 get_group_hosts \"$inventory_file\" neutron_ovs_dpdk_agent)"},{"line_number":174,"context_line":"    for node_name in $OVN_CONTROLLERS; do"},{"line_number":175,"context_line":"        node_ip\u003d$(get_host_ip \"$inventory_file\" $node_name)"},{"line_number":176,"context_line":"        echo $node_name ansible_host\u003d$node_ip ansible_ssh_user\u003d$UNDERCLOUD_NODE_USER ansible_become\u003dtrue ovn_controller\u003dtrue \u003e\u003e hosts_for_migration"}],"source_content_type":"text/x-sh","patch_set":1,"id":"49df7b84_ad2bd07b","line":173,"range":{"start_line":173,"start_character":22,"end_line":173,"end_character":38},"updated":"2021-12-21 13:14:14.000000000","message":"If this first command fails because it doesn\u0027t find neutron_ovs_agent then the next command won\u0027t be executed, will it?","commit_id":"1e42d658475746b123657782c0d1db7756a7ff9f"},{"author":{"_account_id":22865,"name":"Jaganathan Palanisamy","email":"jpalanis@redhat.com","username":"jaganathancse"},"change_message_id":"10f5ae058342dc0520f267cb0618865424e51506","unresolved":true,"context_lines":[{"line_number":170,"context_line":"    echo \"[ovn-controllers]\" \u003e\u003e hosts_for_migration"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    # We want to run ovn-controller where OVS agent was running before the migration"},{"line_number":173,"context_line":"    OVN_CONTROLLERS\u003d$(get_group_hosts \"$inventory_file\" neutron_ovs_agent \u0026\u0026 get_group_hosts \"$inventory_file\" neutron_ovs_dpdk_agent)"},{"line_number":174,"context_line":"    for node_name in $OVN_CONTROLLERS; do"},{"line_number":175,"context_line":"        node_ip\u003d$(get_host_ip \"$inventory_file\" $node_name)"},{"line_number":176,"context_line":"        echo $node_name ansible_host\u003d$node_ip ansible_ssh_user\u003d$UNDERCLOUD_NODE_USER ansible_become\u003dtrue ovn_controller\u003dtrue \u003e\u003e hosts_for_migration"}],"source_content_type":"text/x-sh","patch_set":1,"id":"8fef8c07_53d7d3b1","line":173,"range":{"start_line":173,"start_character":22,"end_line":173,"end_character":38},"in_reply_to":"17299bcd_31caf922","updated":"2021-12-21 17:29:12.000000000","message":"Also \u0027;\u0027 works, i think using \u0027;\u0027 is safe. please share your comments.","commit_id":"1e42d658475746b123657782c0d1db7756a7ff9f"},{"author":{"_account_id":22865,"name":"Jaganathan Palanisamy","email":"jpalanis@redhat.com","username":"jaganathancse"},"change_message_id":"abbc09a5929a71bbfc7348bb596b01b400ee671c","unresolved":true,"context_lines":[{"line_number":170,"context_line":"    echo \"[ovn-controllers]\" \u003e\u003e hosts_for_migration"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    # We want to run ovn-controller where OVS agent was running before the migration"},{"line_number":173,"context_line":"    OVN_CONTROLLERS\u003d$(get_group_hosts \"$inventory_file\" neutron_ovs_agent \u0026\u0026 get_group_hosts \"$inventory_file\" neutron_ovs_dpdk_agent)"},{"line_number":174,"context_line":"    for node_name in $OVN_CONTROLLERS; do"},{"line_number":175,"context_line":"        node_ip\u003d$(get_host_ip \"$inventory_file\" $node_name)"},{"line_number":176,"context_line":"        echo $node_name ansible_host\u003d$node_ip ansible_ssh_user\u003d$UNDERCLOUD_NODE_USER ansible_become\u003dtrue ovn_controller\u003dtrue \u003e\u003e hosts_for_migration"}],"source_content_type":"text/x-sh","patch_set":1,"id":"17299bcd_31caf922","line":173,"range":{"start_line":173,"start_character":22,"end_line":173,"end_character":38},"in_reply_to":"49df7b84_ad2bd07b","updated":"2021-12-21 17:21:54.000000000","message":"Ack, will not execute next command if fails first command.\nplanning to use \u0027\u0026\u0027 which works based on both the command results.","commit_id":"1e42d658475746b123657782c0d1db7756a7ff9f"}]}
