)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"28ff1939168d39b5d8e9ed5669646d49364d8d1d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"483c350a_b73cee4a","updated":"2022-01-13 17:41:29.000000000","message":"LGTM!","commit_id":"1c9edc272d2d48ac382f0c5d02d92fea725e8d33"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/maintenance.py":[{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"d3e77912152d377c57c1e6e40170877e744be6c8","unresolved":true,"context_lines":[{"line_number":751,"context_line":"            r\u0027(inport|outport) \u003d\u003d \\\"(?P\u003cport_id\u003e[a-z0-9\\-]{36})\\\"\u0027)"},{"line_number":752,"context_line":"        cmds \u003d []"},{"line_number":753,"context_line":"        for ls in self._nb_idl.ls_list().execute(check_error\u003dTrue):"},{"line_number":754,"context_line":"            for qos in self._nb_idl.qos_list(ls.name).execute("},{"line_number":755,"context_line":"                    check_error\u003dTrue):"},{"line_number":756,"context_line":"                if qos.external_ids:"},{"line_number":757,"context_line":"                    continue"}],"source_content_type":"text/x-python","patch_set":5,"id":"79256529_992d558d","line":754,"updated":"2022-02-04 21:09:23.000000000","message":"This makes me realize that I added ovsdbapp\u0027s RowView as an idea for a backend-agnostic read-only version of a Row, but that I didn\u0027t add it to ovsdbapp/api.py and left the single implementation in backend/ovs_idl. It\u0027s not nice to have to do a transaction for every logical switch (and look up the ls again by name in memory) when we already have the data.\n\nWe can leave this as-is for now, but I\u0027ll try to get something up making it official that code outside of command objects should be able to use RowViews (which is a little different than just accessing idl.tables directly.\n\nLooking at the RowView code, it probably does need some more isolation before being used this way (either something like making it a namedtuple like is used in indexing, or at least making a copy of the row that is stored in it).","commit_id":"ce7f2795384e05b7e086bdab41226a69708dfdc5"}]}