)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"18878b712f8da81901c1dc2b8d39382da789711d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7f2e7deb_06628dca","updated":"2022-01-03 17:36:43.000000000","message":"LGTM, but I\u0027d like to make sure Rodolfo is ok with it as he did the last update.","commit_id":"1e055b4ce6aaeb3e8d3774b0731dc5a344b9a261"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"688ff77c5e04af404572d1c9fc000e46b021e16a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"01673c0d_1a5093f6","updated":"2022-01-05 13:51:11.000000000","message":"Apart from the comment, the patch looks ok","commit_id":"b5726bb60f6febd6d5a8756dccc18c79f0c61ad8"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"3c83e5705efd030b0c617de62c95e508b2a246d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"2a961ba0_82fe84cb","updated":"2022-01-06 06:46:59.000000000","message":"recheck test_gateway_chassis_rebalance","commit_id":"4a06685098cc2e9b69c1b961eecef957314faf85"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"127cea3bd396627e34739f57f64a67ce35b5bee1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"77a00262_3cabdcce","updated":"2022-01-11 04:26:44.000000000","message":"recheck test_trunk_creation_with_no_subports timeout exception","commit_id":"4a06685098cc2e9b69c1b961eecef957314faf85"}],"neutron/common/ovn/utils.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"0240bf7551d32827f852e0b70dc4466c102c86a1","unresolved":true,"context_lines":[{"line_number":428,"context_line":"                   get_system_dns_resolvers())"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"    # Filter dns nameservers based on ip_version"},{"line_number":431,"context_line":"    dns_servers \u003d [ns for ns in dns_servers"},{"line_number":432,"context_line":"        if netaddr.IPAddress(ns).version \u003d\u003d ip_version]"},{"line_number":433,"context_line":""},{"line_number":434,"context_line":"    if common_utils.is_dns_servers_any_address(dns_servers, ip_version):"},{"line_number":435,"context_line":"        return []"}],"source_content_type":"text/x-python","patch_set":2,"id":"5441b589_834cb8b0","line":432,"range":{"start_line":431,"start_character":4,"end_line":432,"end_character":55},"updated":"2022-01-04 15:33:50.000000000","message":"We should make this filtering before PS base L426-431. Here you are changing the DNS servers assignation, depending on the version. In IPv4, if no DNS servers are provided, we can use the OVN configured servers or the system DNS resolvers (default option). This is not available in IPv6.","commit_id":"1e055b4ce6aaeb3e8d3774b0731dc5a344b9a261"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"cda81835646a9167d9592f5b7aa965e0a785af7d","unresolved":true,"context_lines":[{"line_number":428,"context_line":"                   get_system_dns_resolvers())"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"    # Filter dns nameservers based on ip_version"},{"line_number":431,"context_line":"    dns_servers \u003d [ns for ns in dns_servers"},{"line_number":432,"context_line":"        if netaddr.IPAddress(ns).version \u003d\u003d ip_version]"},{"line_number":433,"context_line":""},{"line_number":434,"context_line":"    if common_utils.is_dns_servers_any_address(dns_servers, ip_version):"},{"line_number":435,"context_line":"        return []"}],"source_content_type":"text/x-python","patch_set":2,"id":"f0a2d2ed_5b2e7d27","line":432,"range":{"start_line":431,"start_character":4,"end_line":432,"end_character":55},"in_reply_to":"5441b589_834cb8b0","updated":"2022-01-04 15:58:35.000000000","message":"Ok Thanks will get it udpated, along with release note as changing handling of ipv6 subnet nameservers.","commit_id":"1e055b4ce6aaeb3e8d3774b0731dc5a344b9a261"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"50b613850990c2a58512af7af1b8fb627803c7ad","unresolved":false,"context_lines":[{"line_number":428,"context_line":"                   get_system_dns_resolvers())"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"    # Filter dns nameservers based on ip_version"},{"line_number":431,"context_line":"    dns_servers \u003d [ns for ns in dns_servers"},{"line_number":432,"context_line":"        if netaddr.IPAddress(ns).version \u003d\u003d ip_version]"},{"line_number":433,"context_line":""},{"line_number":434,"context_line":"    if common_utils.is_dns_servers_any_address(dns_servers, ip_version):"},{"line_number":435,"context_line":"        return []"}],"source_content_type":"text/x-python","patch_set":2,"id":"49891f63_5cae29ee","line":432,"range":{"start_line":431,"start_character":4,"end_line":432,"end_character":55},"in_reply_to":"f0a2d2ed_5b2e7d27","updated":"2022-01-05 08:44:44.000000000","message":"Done","commit_id":"1e055b4ce6aaeb3e8d3774b0731dc5a344b9a261"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"688ff77c5e04af404572d1c9fc000e46b021e16a","unresolved":true,"context_lines":[{"line_number":419,"context_line":""},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"def filter_ips(ips, ip_version\u003dconst.IP_VERSION_4):"},{"line_number":422,"context_line":"    ips \u003d [ip for ip in ips"},{"line_number":423,"context_line":"        if netaddr.IPAddress(ip).version \u003d\u003d ip_version]"},{"line_number":424,"context_line":"    return ips"},{"line_number":425,"context_line":""},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"def get_dhcp_dns_servers(subnet, ip_version\u003dconst.IP_VERSION_4):"}],"source_content_type":"text/x-python","patch_set":5,"id":"a609145f_000426e8","line":424,"range":{"start_line":422,"start_character":4,"end_line":424,"end_character":14},"updated":"2022-01-05 13:51:11.000000000","message":"1) Variable \"ips\" is not needed. You should directly return the list.\n2) The indentation is weird. Please align it\n\n    return [ip for ip in ips\n            if netaddr.IPAddress(ip).version \u003d\u003d ip_version]\n\n3) This should be a inner method of \"get_dhcp_dns_servers\"","commit_id":"b5726bb60f6febd6d5a8756dccc18c79f0c61ad8"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"762973860561211ecf1f0c70201d8af78816b26a","unresolved":false,"context_lines":[{"line_number":419,"context_line":""},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"def filter_ips(ips, ip_version\u003dconst.IP_VERSION_4):"},{"line_number":422,"context_line":"    ips \u003d [ip for ip in ips"},{"line_number":423,"context_line":"        if netaddr.IPAddress(ip).version \u003d\u003d ip_version]"},{"line_number":424,"context_line":"    return ips"},{"line_number":425,"context_line":""},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"def get_dhcp_dns_servers(subnet, ip_version\u003dconst.IP_VERSION_4):"}],"source_content_type":"text/x-python","patch_set":5,"id":"0b921673_beb22ed9","line":424,"range":{"start_line":422,"start_character":4,"end_line":424,"end_character":14},"in_reply_to":"a609145f_000426e8","updated":"2022-01-05 14:33:59.000000000","message":"Done","commit_id":"b5726bb60f6febd6d5a8756dccc18c79f0c61ad8"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a31c939666f0563e8045db846285d526f69c331c","unresolved":true,"context_lines":[{"line_number":429,"context_line":"        return [ip for ip in ips"},{"line_number":430,"context_line":"                if netaddr.IPAddress(ip).version \u003d\u003d ip_version]"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"    dns_servers \u003d (subnet.get(\u0027dns_nameservers\u0027) or"},{"line_number":433,"context_line":"                   filter_ips(ovn_conf.get_dns_servers(), ip_version) or"},{"line_number":434,"context_line":"                   filter_ips(get_system_dns_resolvers(), ip_version))"},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"    if common_utils.is_dns_servers_any_address(dns_servers, ip_version):"},{"line_number":437,"context_line":"        return []"}],"source_content_type":"text/x-python","patch_set":7,"id":"053cf1e8_91a81737","line":434,"range":{"start_line":432,"start_character":4,"end_line":434,"end_character":70},"updated":"2022-01-07 14:07:22.000000000","message":"Very nice!","commit_id":"4a06685098cc2e9b69c1b961eecef957314faf85"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"4536a1e4a491c8fdf55b1662dfdfd04eb5090d38","unresolved":true,"context_lines":[{"line_number":1925,"context_line":"            options[\u0027server_mac\u0027] \u003d n_net.get_random_mac("},{"line_number":1926,"context_line":"                cfg.CONF.base_mac.split(\u0027:\u0027))"},{"line_number":1927,"context_line":""},{"line_number":1928,"context_line":"        dns_servers \u003d utils.get_dhcp_dns_servers(subnet)"},{"line_number":1929,"context_line":"        ip4_dns_servers \u003d [i for i in dns_servers"},{"line_number":1930,"context_line":"            if netaddr.IPAddress(i).version \u003d\u003d const.IP_VERSION_4]"},{"line_number":1931,"context_line":"        if ip4_dns_servers:"}],"source_content_type":"text/x-python","patch_set":1,"id":"0bb3ea40_54e66376","line":1928,"range":{"start_line":1928,"start_character":28,"end_line":1928,"end_character":48},"updated":"2021-12-23 17:07:05.000000000","message":"I think get_dhcp_dns_servers() should be fixed to just do this filtering, let\u0027s get Rodolfo\u0027s opinion as he added this code.","commit_id":"749b8e9f0d9c1562cf64c7d7be6a57314e4905a9"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"16bca4d8e4267b627b955d4449260572ef64c1b4","unresolved":true,"context_lines":[{"line_number":1925,"context_line":"            options[\u0027server_mac\u0027] \u003d n_net.get_random_mac("},{"line_number":1926,"context_line":"                cfg.CONF.base_mac.split(\u0027:\u0027))"},{"line_number":1927,"context_line":""},{"line_number":1928,"context_line":"        dns_servers \u003d utils.get_dhcp_dns_servers(subnet)"},{"line_number":1929,"context_line":"        ip4_dns_servers \u003d [i for i in dns_servers"},{"line_number":1930,"context_line":"            if netaddr.IPAddress(i).version \u003d\u003d const.IP_VERSION_4]"},{"line_number":1931,"context_line":"        if ip4_dns_servers:"}],"source_content_type":"text/x-python","patch_set":1,"id":"8a0828a2_564c108a","line":1928,"range":{"start_line":1928,"start_character":28,"end_line":1928,"end_character":48},"in_reply_to":"0bb3ea40_54e66376","updated":"2021-12-24 06:23:14.000000000","message":"Yes right that would be even better, will wait for rodolfo\u0027s opinion too.\n\nAlso while checking the code i didn\u0027t get why ovn/dns_servers and system\u0027s nameserver not used in ipv6 case when dns_nameservers not specified for ip6 subnet, couldn\u0027t trace that even in original patch https://review.opendev.org/c/openstack/networking-ovn/+/571006. If there is no strong reason for that can fix that with this patch or as follow up patch. wdyt?","commit_id":"749b8e9f0d9c1562cf64c7d7be6a57314e4905a9"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"dc19b4ff0b15b3dd2856a8e22adc2a7ae832a162","unresolved":true,"context_lines":[{"line_number":1925,"context_line":"            options[\u0027server_mac\u0027] \u003d n_net.get_random_mac("},{"line_number":1926,"context_line":"                cfg.CONF.base_mac.split(\u0027:\u0027))"},{"line_number":1927,"context_line":""},{"line_number":1928,"context_line":"        dns_servers \u003d utils.get_dhcp_dns_servers(subnet)"},{"line_number":1929,"context_line":"        ip4_dns_servers \u003d [i for i in dns_servers"},{"line_number":1930,"context_line":"            if netaddr.IPAddress(i).version \u003d\u003d const.IP_VERSION_4]"},{"line_number":1931,"context_line":"        if ip4_dns_servers:"}],"source_content_type":"text/x-python","patch_set":1,"id":"e7533858_46e15720","line":1928,"range":{"start_line":1928,"start_character":28,"end_line":1928,"end_character":48},"in_reply_to":"8a0828a2_564c108a","updated":"2021-12-30 10:23:32.000000000","message":"Moving the filtering part to get_dhcp_dns_servers, will also make ipv6 case to read from conf when dns_nameservers not passed in subnet in the same patch.","commit_id":"749b8e9f0d9c1562cf64c7d7be6a57314e4905a9"}],"neutron/tests/unit/common/ovn/test_utils.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ae2915277670e61b8d0466bdf9a27e37f6f8a50d","unresolved":true,"context_lines":[{"line_number":38,"context_line":"\"\"\""},{"line_number":39,"context_line":"RESOLV_DNS_SERVERS \u003d [\u002710.0.0.1\u0027, \u002710.0.0.3\u0027, \u0027aef0::4\u0027]"},{"line_number":40,"context_line":"RESOLV_DNS_SERVERS_V4 \u003d [\u002710.0.0.1\u0027, \u002710.0.0.3\u0027]"},{"line_number":41,"context_line":"RESOLV_DNS_SERVERS_V6 \u003d [\u0027aef0::4\u0027]"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"class TestUtils(base.BaseTestCase):"}],"source_content_type":"text/x-python","patch_set":6,"id":"8da86f3d_24dc836a","line":41,"range":{"start_line":41,"start_character":26,"end_line":41,"end_character":33},"updated":"2022-01-05 19:29:39.000000000","message":"Should use doc prefix, but maybe we can fix the whole file at once later, or tree...","commit_id":"0e2748443ad568d25a577c9770b79fb8cf1c4a42"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"d5ff276842273826221b725d5d8d95c59c8fb2dd","unresolved":true,"context_lines":[{"line_number":38,"context_line":"\"\"\""},{"line_number":39,"context_line":"RESOLV_DNS_SERVERS \u003d [\u002710.0.0.1\u0027, \u002710.0.0.3\u0027, \u0027aef0::4\u0027]"},{"line_number":40,"context_line":"RESOLV_DNS_SERVERS_V4 \u003d [\u002710.0.0.1\u0027, \u002710.0.0.3\u0027]"},{"line_number":41,"context_line":"RESOLV_DNS_SERVERS_V6 \u003d [\u0027aef0::4\u0027]"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"class TestUtils(base.BaseTestCase):"}],"source_content_type":"text/x-python","patch_set":6,"id":"02c473a9_54a31858","line":41,"range":{"start_line":41,"start_character":26,"end_line":41,"end_character":33},"in_reply_to":"8da86f3d_24dc836a","updated":"2022-01-06 05:04:22.000000000","message":"ack can be done as follow up in all the places together.","commit_id":"0e2748443ad568d25a577c9770b79fb8cf1c4a42"}],"neutron/tests/unit/plugins/ml2/drivers/ovn/mech_driver/test_mech_driver.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"4536a1e4a491c8fdf55b1662dfdfd04eb5090d38","unresolved":true,"context_lines":[{"line_number":2800,"context_line":"                                       group\u003d\u0027ovn\u0027)"},{"line_number":2801,"context_line":""},{"line_number":2802,"context_line":"        subnet \u003d {\u0027id\u0027: \u0027foo-subnet\u0027, \u0027network_id\u0027: \u0027network-id\u0027,"},{"line_number":2803,"context_line":"                  \u0027cidr\u0027: \u0027ae70::/24\u0027,"},{"line_number":2804,"context_line":"                  \u0027ip_version\u0027: 6,"},{"line_number":2805,"context_line":"                  \u0027enable_dhcp\u0027: True,"},{"line_number":2806,"context_line":"                  \u0027dns_nameservers\u0027: [\u002710::3\u0027, \u002711::3\u0027]}"}],"source_content_type":"text/x-python","patch_set":1,"id":"c9994844_ccf45136","line":2803,"range":{"start_line":2803,"start_character":27,"end_line":2803,"end_character":36},"updated":"2021-12-23 17:07:05.000000000","message":"I guess this should be fixed as well?  2001:db8:1:2::/64 ?","commit_id":"749b8e9f0d9c1562cf64c7d7be6a57314e4905a9"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"16bca4d8e4267b627b955d4449260572ef64c1b4","unresolved":true,"context_lines":[{"line_number":2800,"context_line":"                                       group\u003d\u0027ovn\u0027)"},{"line_number":2801,"context_line":""},{"line_number":2802,"context_line":"        subnet \u003d {\u0027id\u0027: \u0027foo-subnet\u0027, \u0027network_id\u0027: \u0027network-id\u0027,"},{"line_number":2803,"context_line":"                  \u0027cidr\u0027: \u0027ae70::/24\u0027,"},{"line_number":2804,"context_line":"                  \u0027ip_version\u0027: 6,"},{"line_number":2805,"context_line":"                  \u0027enable_dhcp\u0027: True,"},{"line_number":2806,"context_line":"                  \u0027dns_nameservers\u0027: [\u002710::3\u0027, \u002711::3\u0027]}"}],"source_content_type":"text/x-python","patch_set":1,"id":"2dc57577_1160cab9","line":2803,"range":{"start_line":2803,"start_character":27,"end_line":2803,"end_character":36},"in_reply_to":"c9994844_ccf45136","updated":"2021-12-24 06:23:14.000000000","message":"same","commit_id":"749b8e9f0d9c1562cf64c7d7be6a57314e4905a9"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"4536a1e4a491c8fdf55b1662dfdfd04eb5090d38","unresolved":true,"context_lines":[{"line_number":2803,"context_line":"                  \u0027cidr\u0027: \u0027ae70::/24\u0027,"},{"line_number":2804,"context_line":"                  \u0027ip_version\u0027: 6,"},{"line_number":2805,"context_line":"                  \u0027enable_dhcp\u0027: True,"},{"line_number":2806,"context_line":"                  \u0027dns_nameservers\u0027: [\u002710::3\u0027, \u002711::3\u0027]}"},{"line_number":2807,"context_line":"        network \u003d {\u0027id\u0027: \u0027network-id\u0027, \u0027mtu\u0027: 1400}"},{"line_number":2808,"context_line":""},{"line_number":2809,"context_line":"        ext_ids \u003d {\u0027subnet_id\u0027: \u0027foo-subnet\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"15eb8e10_3a486a28","line":2806,"range":{"start_line":2806,"start_character":39,"end_line":2806,"end_character":44},"updated":"2021-12-23 17:07:05.000000000","message":"These are not truly IPv6 addresses according to IANA, should use the doc prefix or ???","commit_id":"749b8e9f0d9c1562cf64c7d7be6a57314e4905a9"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"16bca4d8e4267b627b955d4449260572ef64c1b4","unresolved":true,"context_lines":[{"line_number":2803,"context_line":"                  \u0027cidr\u0027: \u0027ae70::/24\u0027,"},{"line_number":2804,"context_line":"                  \u0027ip_version\u0027: 6,"},{"line_number":2805,"context_line":"                  \u0027enable_dhcp\u0027: True,"},{"line_number":2806,"context_line":"                  \u0027dns_nameservers\u0027: [\u002710::3\u0027, \u002711::3\u0027]}"},{"line_number":2807,"context_line":"        network \u003d {\u0027id\u0027: \u0027network-id\u0027, \u0027mtu\u0027: 1400}"},{"line_number":2808,"context_line":""},{"line_number":2809,"context_line":"        ext_ids \u003d {\u0027subnet_id\u0027: \u0027foo-subnet\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"a403ad66_60df899d","line":2806,"range":{"start_line":2806,"start_character":39,"end_line":2806,"end_character":44},"in_reply_to":"15eb8e10_3a486a28","updated":"2021-12-24 06:23:14.000000000","message":"Actually i took these examples from other unit tests,not sure if it\u0027s good to fix other tests here itself, if needed may be can done in seperate patch?\nAlso didn\u0027t got \"doc prefix or ???\", can u share some reference or detail.","commit_id":"749b8e9f0d9c1562cf64c7d7be6a57314e4905a9"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"dc19b4ff0b15b3dd2856a8e22adc2a7ae832a162","unresolved":true,"context_lines":[{"line_number":2803,"context_line":"                  \u0027cidr\u0027: \u0027ae70::/24\u0027,"},{"line_number":2804,"context_line":"                  \u0027ip_version\u0027: 6,"},{"line_number":2805,"context_line":"                  \u0027enable_dhcp\u0027: True,"},{"line_number":2806,"context_line":"                  \u0027dns_nameservers\u0027: [\u002710::3\u0027, \u002711::3\u0027]}"},{"line_number":2807,"context_line":"        network \u003d {\u0027id\u0027: \u0027network-id\u0027, \u0027mtu\u0027: 1400}"},{"line_number":2808,"context_line":""},{"line_number":2809,"context_line":"        ext_ids \u003d {\u0027subnet_id\u0027: \u0027foo-subnet\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"57b78ea5_1f0a04c4","line":2806,"range":{"start_line":2806,"start_character":39,"end_line":2806,"end_character":44},"in_reply_to":"35ae8d67_42379016","updated":"2021-12-30 10:23:32.000000000","message":"Done using 2001:db8::4444, 2001:db8::8888 instead.","commit_id":"749b8e9f0d9c1562cf64c7d7be6a57314e4905a9"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"cbfab5e1930196a6b0b2b33c0748f207793e7b46","unresolved":true,"context_lines":[{"line_number":2803,"context_line":"                  \u0027cidr\u0027: \u0027ae70::/24\u0027,"},{"line_number":2804,"context_line":"                  \u0027ip_version\u0027: 6,"},{"line_number":2805,"context_line":"                  \u0027enable_dhcp\u0027: True,"},{"line_number":2806,"context_line":"                  \u0027dns_nameservers\u0027: [\u002710::3\u0027, \u002711::3\u0027]}"},{"line_number":2807,"context_line":"        network \u003d {\u0027id\u0027: \u0027network-id\u0027, \u0027mtu\u0027: 1400}"},{"line_number":2808,"context_line":""},{"line_number":2809,"context_line":"        ext_ids \u003d {\u0027subnet_id\u0027: \u0027foo-subnet\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"35ae8d67_42379016","line":2806,"range":{"start_line":2806,"start_character":39,"end_line":2806,"end_character":44},"in_reply_to":"938610cf_b16d27d4","updated":"2021-12-29 11:02:23.000000000","message":"Ok sure will do while updating the patch, currently CI is down due to paramiko issue and would need https://review.opendev.org/c/openstack/requirements/+/823128 merged","commit_id":"749b8e9f0d9c1562cf64c7d7be6a57314e4905a9"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"926871e32f6a2970c2999f9f593b8b3164d19fd6","unresolved":true,"context_lines":[{"line_number":2803,"context_line":"                  \u0027cidr\u0027: \u0027ae70::/24\u0027,"},{"line_number":2804,"context_line":"                  \u0027ip_version\u0027: 6,"},{"line_number":2805,"context_line":"                  \u0027enable_dhcp\u0027: True,"},{"line_number":2806,"context_line":"                  \u0027dns_nameservers\u0027: [\u002710::3\u0027, \u002711::3\u0027]}"},{"line_number":2807,"context_line":"        network \u003d {\u0027id\u0027: \u0027network-id\u0027, \u0027mtu\u0027: 1400}"},{"line_number":2808,"context_line":""},{"line_number":2809,"context_line":"        ext_ids \u003d {\u0027subnet_id\u0027: \u0027foo-subnet\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"938610cf_b16d27d4","line":2806,"range":{"start_line":2806,"start_character":39,"end_line":2806,"end_character":44},"in_reply_to":"a403ad66_60df899d","updated":"2021-12-28 19:53:35.000000000","message":"We can fix other prefixes in a follow-on, but I think we can use the correct prefix here since you\u0027re changing things. The doc prefix is 2001:db8::/64 (anything in that cidr) and should be used throughout tests, even if it isn\u0027t currently.","commit_id":"749b8e9f0d9c1562cf64c7d7be6a57314e4905a9"}],"releasenotes/notes/ovn-default-dns-servers-ipv6-subnets-f2d525abc70b01b3.yaml":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ae2915277670e61b8d0466bdf9a27e37f6f8a50d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    For ipv4 subnets when dns_nameservers is not set in subnet,"},{"line_number":5,"context_line":"    servers defined in \u0027ovn/dns_servers\u0027 config option or system\u0027s"},{"line_number":6,"context_line":"    resolv.conf were used, but for ipv6 subnets these were"},{"line_number":7,"context_line":"    not used. The same will now be used for ipv6 subnets too."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"2cf1047f_8a5ebdd4","line":4,"range":{"start_line":4,"start_character":8,"end_line":4,"end_character":12},"updated":"2022-01-05 19:29:39.000000000","message":"nit: IPv4, same for others","commit_id":"0e2748443ad568d25a577c9770b79fb8cf1c4a42"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ae2915277670e61b8d0466bdf9a27e37f6f8a50d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    For ipv4 subnets when dns_nameservers is not set in subnet,"},{"line_number":5,"context_line":"    servers defined in \u0027ovn/dns_servers\u0027 config option or system\u0027s"},{"line_number":6,"context_line":"    resolv.conf were used, but for ipv6 subnets these were"},{"line_number":7,"context_line":"    not used. The same will now be used for ipv6 subnets too."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1b8ebbdf_42f0dc96","line":4,"range":{"start_line":4,"start_character":56,"end_line":4,"end_character":62},"updated":"2022-01-05 19:29:39.000000000","message":"nit: the subnet","commit_id":"0e2748443ad568d25a577c9770b79fb8cf1c4a42"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"d5ff276842273826221b725d5d8d95c59c8fb2dd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    For ipv4 subnets when dns_nameservers is not set in subnet,"},{"line_number":5,"context_line":"    servers defined in \u0027ovn/dns_servers\u0027 config option or system\u0027s"},{"line_number":6,"context_line":"    resolv.conf were used, but for ipv6 subnets these were"},{"line_number":7,"context_line":"    not used. The same will now be used for ipv6 subnets too."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"c2d619de_aea44e8c","line":4,"range":{"start_line":4,"start_character":56,"end_line":4,"end_character":62},"in_reply_to":"1b8ebbdf_42f0dc96","updated":"2022-01-06 05:04:22.000000000","message":"Done","commit_id":"0e2748443ad568d25a577c9770b79fb8cf1c4a42"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"d5ff276842273826221b725d5d8d95c59c8fb2dd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    For ipv4 subnets when dns_nameservers is not set in subnet,"},{"line_number":5,"context_line":"    servers defined in \u0027ovn/dns_servers\u0027 config option or system\u0027s"},{"line_number":6,"context_line":"    resolv.conf were used, but for ipv6 subnets these were"},{"line_number":7,"context_line":"    not used. The same will now be used for ipv6 subnets too."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"c380822f_c735de28","line":4,"range":{"start_line":4,"start_character":8,"end_line":4,"end_character":12},"in_reply_to":"2cf1047f_8a5ebdd4","updated":"2022-01-06 05:04:22.000000000","message":"Done","commit_id":"0e2748443ad568d25a577c9770b79fb8cf1c4a42"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ae2915277670e61b8d0466bdf9a27e37f6f8a50d","unresolved":true,"context_lines":[{"line_number":7,"context_line":"    not used. The same will now be used for ipv6 subnets too."},{"line_number":8,"context_line":"    Additionally dns servers added in \u0027ovn/dns_servers\u0027 config"},{"line_number":9,"context_line":"    option or system\u0027s resolv.conf will be filtered as per"},{"line_number":10,"context_line":"    subnet\u0027s ip_version."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"4d11a637_8e6a8801","line":10,"range":{"start_line":10,"start_character":13,"end_line":10,"end_character":23},"updated":"2022-01-05 19:29:39.000000000","message":"nit: if you fix the other you can make this \u0027IP version\u0027 but not important.\n\nAlso, if you update this you can add the bug link, see other release notes on how they do it.","commit_id":"0e2748443ad568d25a577c9770b79fb8cf1c4a42"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"d5ff276842273826221b725d5d8d95c59c8fb2dd","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    not used. The same will now be used for ipv6 subnets too."},{"line_number":8,"context_line":"    Additionally dns servers added in \u0027ovn/dns_servers\u0027 config"},{"line_number":9,"context_line":"    option or system\u0027s resolv.conf will be filtered as per"},{"line_number":10,"context_line":"    subnet\u0027s ip_version."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3d253046_2777b7a5","line":10,"range":{"start_line":10,"start_character":13,"end_line":10,"end_character":23},"in_reply_to":"4d11a637_8e6a8801","updated":"2022-01-06 05:04:22.000000000","message":"Done","commit_id":"0e2748443ad568d25a577c9770b79fb8cf1c4a42"}]}