)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"a8caf533be2da7465f506865ed591d51372b7ae5","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix a error when l3-agent gets filter id for ip"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Before using filter_id in _get_filterid_for_ip(), we should assignment it first."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Closes-Bug: #1955775"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"b4eabfcb_1309198f","line":9,"range":{"start_line":9,"start_character":60,"end_line":9,"end_character":70},"updated":"2022-01-10 11:24:44.000000000","message":"nit: assign or do assignment","commit_id":"e60a736cbea682b6953b1da4bdfcc71653bc84bf"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"dc00eda9683a494bd89738d70be8f72e1d03406f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5e165a23_a52aec8c","updated":"2022-01-04 13:01:04.000000000","message":"In the bug you state that the TC rules were added \"accidentally\" to the interface (I\u0027m reluctant to consider this casuistic). In any case, please add a unit test using the \"tc filter show\" output you have in you environment.","commit_id":"75916a121e7ddf18f7f42c1ce1d5bbee3187b746"},{"author":{"_account_id":28781,"name":"Zhai Mengdong","email":"429322003@qq.com","username":"mengdong"},"change_message_id":"d60a6a7bea7fe6969dbd0e0be54dd3bf3a5ccd7f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9950482a_27174266","in_reply_to":"5e165a23_a52aec8c","updated":"2022-01-07 03:08:48.000000000","message":"You are right, I rechecked the error in my environment, the reason for the error is that the FILTER_ID_REGEX in the local environment is old. When using the latest FILTER_ID_REGEX, the problem I described in the https://launchpad.net/bugs/1955775 will not appear.","commit_id":"75916a121e7ddf18f7f42c1ce1d5bbee3187b746"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"23228e5fc812c15e41714ad945143139269da5df","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d3b126b5_81bd2fb1","updated":"2022-01-07 14:06:05.000000000","message":"Please, add unit tests.","commit_id":"ed221f80119ed8dbab231810bb380560d166e669"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"95e7f2bdf9b04a4b024614ce236ec3295b1e8745","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c7ff142f_7f237662","updated":"2022-01-11 11:06:00.000000000","message":"Thanks","commit_id":"0255eb31e5c3ce31ed08069c4e5c0fcb1fc29074"}],"neutron/agent/linux/l3_tc_lib.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"dc00eda9683a494bd89738d70be8f72e1d03406f","unresolved":true,"context_lines":[{"line_number":73,"context_line":"            if not line.startswith(\u0027match\u0027):"},{"line_number":74,"context_line":"                continue"},{"line_number":75,"context_line":"            parts \u003d line.split(\" \")"},{"line_number":76,"context_line":"            if ip + \u0027/32\u0027 in parts and \u0027filter_id\u0027 in dir():"},{"line_number":77,"context_line":"                filterids_for_ip.append(filter_id)"},{"line_number":78,"context_line":"        if len(filterids_for_ip) \u003e 1:"},{"line_number":79,"context_line":"            raise exceptions.MultipleFilterIDForIPFound(ip\u003dip)"}],"source_content_type":"text/x-python","patch_set":1,"id":"d8119040_27e952f1","line":76,"range":{"start_line":76,"start_character":38,"end_line":76,"end_character":60},"updated":"2022-01-04 13:01:04.000000000","message":"This is valid, but better if you declare filter_id\u003dNone in L65 (before the for loop).","commit_id":"75916a121e7ddf18f7f42c1ce1d5bbee3187b746"},{"author":{"_account_id":28781,"name":"Zhai Mengdong","email":"429322003@qq.com","username":"mengdong"},"change_message_id":"d60a6a7bea7fe6969dbd0e0be54dd3bf3a5ccd7f","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            if not line.startswith(\u0027match\u0027):"},{"line_number":74,"context_line":"                continue"},{"line_number":75,"context_line":"            parts \u003d line.split(\" \")"},{"line_number":76,"context_line":"            if ip + \u0027/32\u0027 in parts and \u0027filter_id\u0027 in dir():"},{"line_number":77,"context_line":"                filterids_for_ip.append(filter_id)"},{"line_number":78,"context_line":"        if len(filterids_for_ip) \u003e 1:"},{"line_number":79,"context_line":"            raise exceptions.MultipleFilterIDForIPFound(ip\u003dip)"}],"source_content_type":"text/x-python","patch_set":1,"id":"2cde883e_37cfe634","line":76,"range":{"start_line":76,"start_character":38,"end_line":76,"end_character":60},"in_reply_to":"d8119040_27e952f1","updated":"2022-01-07 03:08:48.000000000","message":"Done","commit_id":"75916a121e7ddf18f7f42c1ce1d5bbee3187b746"}]}