)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"469f75c864fadc5a30efa86868b47b688ee1f044","unresolved":true,"context_lines":[{"line_number":16,"context_line":"transitioned to DOWN."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Closes-Bug: #1956233"},{"line_number":19,"context_line":"Depends-On: https://review.opendev.org/c/openstack/neutron/+/823818"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I5b06eb517cb4d9e9ce018147788ed7bf9b34aa24"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fd7a54be_e99d40e7","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":1},"updated":"2022-01-11 14:59:48.000000000","message":"We don\u0027t use depends-on in the same repo but rebase this patch on top of the referred one. That will create the needed dependency.","commit_id":"b7ca5d4c22822c2886edd4b5a2349575d1d022b2"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"c93212f5163ab96c70954ff8b779fc1c7b259c26","unresolved":true,"context_lines":[{"line_number":16,"context_line":"transitioned to DOWN."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Closes-Bug: #1956233"},{"line_number":19,"context_line":"Depends-On: https://review.opendev.org/c/openstack/neutron/+/823818"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I5b06eb517cb4d9e9ce018147788ed7bf9b34aa24"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"acd973d9_cdf59164","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":1},"in_reply_to":"fd7a54be_e99d40e7","updated":"2022-01-11 16:18:58.000000000","message":"right, that was just for testing if the problem with the chassis HA test was being fixed by this. I\u0027ll remove it","commit_id":"b7ca5d4c22822c2886edd4b5a2349575d1d022b2"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"0752453c104ca932c885f876e5952f7e449d8541","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4ba8508e_8d453da4","updated":"2022-01-05 14:53:07.000000000","message":"It\u0027s tested in the RDO job https://review.rdoproject.org/r/c/testproject/+/37697 and it passed: https://logserver.rdoproject.org/97/37697/3/check/periodic-tripleo-ci-centos-8-standalone-full-tempest-scenario-master/8ca5c97/logs/undercloud/var/log/tempest/stestr_results.html.gz","commit_id":"1ac76b9abca0ee6e27e2f29ea7b272f56cb2d5c0"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b3fbb9f2126b6ad721daa1cf6e1afb09215a54b4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9d52a966_caf2a1a4","updated":"2022-01-05 15:48:12.000000000","message":"Please, once the OVN bug is filled, add it to the launchpad bug just to have the reference. Thanks!","commit_id":"1ac76b9abca0ee6e27e2f29ea7b272f56cb2d5c0"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"e6b77dfb341a1e4779a4dc53e1eced2d0ca01c3f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e5353e8b_9acf20bb","updated":"2022-01-10 07:42:19.000000000","message":"There is definitely something in this patch making that test to fail. I think it can be related to handling chassisredirect ports. This should be avoided by https://review.opendev.org/c/openstack/neutron/+/823818, going to add a depends on on that one","commit_id":"1ac76b9abca0ee6e27e2f29ea7b272f56cb2d5c0"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a1c0fda71a25eb96681d16b58a77a2ac5526bb7b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7af76c71_a3f29e04","updated":"2022-01-05 17:11:08.000000000","message":"recheck","commit_id":"1ac76b9abca0ee6e27e2f29ea7b272f56cb2d5c0"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"387509c9fad4f10f401f1f6ef3b49ffb6f38a161","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a919c93f_742d8f23","updated":"2022-01-07 07:54:41.000000000","message":"recheck","commit_id":"1ac76b9abca0ee6e27e2f29ea7b272f56cb2d5c0"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"9a176259943fffc72a55c402a0a31dfd5649ffef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"feb35fc1_60238726","updated":"2022-01-07 10:41:19.000000000","message":"recheck","commit_id":"1ac76b9abca0ee6e27e2f29ea7b272f56cb2d5c0"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"0667c1e620af8879e0f3be633bd472672eaaa223","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6d2b0900_6b9e745a","updated":"2022-01-07 10:41:13.000000000","message":"umm, same test seems to be sometimes failing... not sure if it would be related to the change, going to recheck again and see","commit_id":"1ac76b9abca0ee6e27e2f29ea7b272f56cb2d5c0"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"bfea80cff679c9ac00fee62816e5ebfe02555094","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"12ed2671_39615797","updated":"2022-01-10 11:39:21.000000000","message":"recheck","commit_id":"b7ca5d4c22822c2886edd4b5a2349575d1d022b2"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"20cbc348fba50fc6436705fdbc50228c31c3c5a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7ad34545_7f004a00","updated":"2022-01-10 09:59:39.000000000","message":"recheck","commit_id":"b7ca5d4c22822c2886edd4b5a2349575d1d022b2"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"be480d72a92f491602f5c1bed9602e8c64c25413","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7d89064f_faeed1a5","updated":"2022-01-10 09:59:35.000000000","message":"rechecking to see if the depends-on fixes the issue with neutron-functional-with-uwsgi test failing for the chassis HA test","commit_id":"b7ca5d4c22822c2886edd4b5a2349575d1d022b2"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"ccc48b4f709df5b681b15e5bfc28053196aa568f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c0ac6f0a_1faf1c60","updated":"2022-01-10 11:39:16.000000000","message":"seems to work, rechecking once more","commit_id":"b7ca5d4c22822c2886edd4b5a2349575d1d022b2"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"24c6289665c3850f794ac6e435e5cc480805b529","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"82b08055_1baef28d","updated":"2022-01-17 13:36:43.000000000","message":"I would like Jakub to check this patch one last time.","commit_id":"5e036a6b281e4331f396473e299b26b2537d5322"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"86ed3f164fc29ddd9ebd8857d8f92209388db6ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"aebb082d_35dec2be","updated":"2022-01-12 11:48:05.000000000","message":"recheck","commit_id":"5e036a6b281e4331f396473e299b26b2537d5322"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovsdb_monitor.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"ff0357a37af08751f5137a9a6607d62bcf9685c2","unresolved":true,"context_lines":[{"line_number":414,"context_line":"            # to DOWN in some cases (for example subports detachment from"},{"line_number":415,"context_line":"            # trunks), we need to also check the chassis is set to claim the"},{"line_number":416,"context_line":"            # port as ACTIVE"},{"line_number":417,"context_line":"            return row.chassis and bool(row.up[0])"},{"line_number":418,"context_line":"        elif row.chassis:"},{"line_number":419,"context_line":"            return True"},{"line_number":420,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":4,"id":"4e9c3452_1e7055b7","line":417,"updated":"2022-01-11 14:43:32.000000000","message":"This event is triggered when the up row is changed. So what if we have a PB with up set to True but without chassis - then we leave the port in DOWN state. Then if chassis is added it should change the port to UP status - but we have no such a thing to detect when chassis was added, do we?","commit_id":"b7ca5d4c22822c2886edd4b5a2349575d1d022b2"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"0622838a34cd2ffb55c5a7b698bb2c17b7a9c7b4","unresolved":true,"context_lines":[{"line_number":414,"context_line":"            # to DOWN in some cases (for example subports detachment from"},{"line_number":415,"context_line":"            # trunks), we need to also check the chassis is set to claim the"},{"line_number":416,"context_line":"            # port as ACTIVE"},{"line_number":417,"context_line":"            return row.chassis and bool(row.up[0])"},{"line_number":418,"context_line":"        elif row.chassis:"},{"line_number":419,"context_line":"            return True"},{"line_number":420,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":4,"id":"d042252c_1d0a715a","line":417,"in_reply_to":"03f5cdb9_c00cd181","updated":"2022-01-12 10:31:26.000000000","message":"actually, the problem I found is independent of this change: https://bugs.launchpad.net/neutron/+bug/1957161","commit_id":"b7ca5d4c22822c2886edd4b5a2349575d1d022b2"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"f9b2f45a47e5f03ef3bb4e007e3664a982e451fd","unresolved":true,"context_lines":[{"line_number":414,"context_line":"            # to DOWN in some cases (for example subports detachment from"},{"line_number":415,"context_line":"            # trunks), we need to also check the chassis is set to claim the"},{"line_number":416,"context_line":"            # port as ACTIVE"},{"line_number":417,"context_line":"            return row.chassis and bool(row.up[0])"},{"line_number":418,"context_line":"        elif row.chassis:"},{"line_number":419,"context_line":"            return True"},{"line_number":420,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":4,"id":"03f5cdb9_c00cd181","line":417,"in_reply_to":"3ba550f2_7b0f7bf5","updated":"2022-01-11 17:29:03.000000000","message":"in fact, I\u0027m testing it at the moment, and the condition seems to work (the one on PortBindingUpdateUpEvent). If the PB has no chassis and up\u003dTrue, and then a chassis gets added, the port is transitioned to ACTIVE","commit_id":"b7ca5d4c22822c2886edd4b5a2349575d1d022b2"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"469f75c864fadc5a30efa86868b47b688ee1f044","unresolved":true,"context_lines":[{"line_number":414,"context_line":"            # to DOWN in some cases (for example subports detachment from"},{"line_number":415,"context_line":"            # trunks), we need to also check the chassis is set to claim the"},{"line_number":416,"context_line":"            # port as ACTIVE"},{"line_number":417,"context_line":"            return row.chassis and bool(row.up[0])"},{"line_number":418,"context_line":"        elif row.chassis:"},{"line_number":419,"context_line":"            return True"},{"line_number":420,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":4,"id":"f4705119_2feb44fb","line":417,"in_reply_to":"4e9c3452_1e7055b7","updated":"2022-01-11 14:59:48.000000000","message":"Is that possible to have a PB without chassis?","commit_id":"b7ca5d4c22822c2886edd4b5a2349575d1d022b2"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"5e2db0d6521a50e3deb38a42b5534e40e04ef8bc","unresolved":true,"context_lines":[{"line_number":414,"context_line":"            # to DOWN in some cases (for example subports detachment from"},{"line_number":415,"context_line":"            # trunks), we need to also check the chassis is set to claim the"},{"line_number":416,"context_line":"            # port as ACTIVE"},{"line_number":417,"context_line":"            return row.chassis and bool(row.up[0])"},{"line_number":418,"context_line":"        elif row.chassis:"},{"line_number":419,"context_line":"            return True"},{"line_number":420,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":4,"id":"3ba550f2_7b0f7bf5","line":417,"in_reply_to":"f4705119_2feb44fb","updated":"2022-01-11 15:11:07.000000000","message":"This applies to the portbindingupdateEvent instead, right? and you are right, I need to add the check of chassis getting added with up status already to True","commit_id":"b7ca5d4c22822c2886edd4b5a2349575d1d022b2"}]}