)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"2ac4e1ce9724d5bb0f7a01af6a442c8b1ace0f10","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"628c8f70_21cd140d","updated":"2022-01-07 08:00:51.000000000","message":"Code looks good to me. Just a question though (due to me not knowing enough about the flow). I think it is a great idea not to set the port again to ACTIVE or again to DOWN, but, is there a chance that the other actions are needed? For example the nova notifications?\n\nAdding -1 to ensure this is not missed in case it can break something","commit_id":"59488238ff0d53f7db34a29b00b574e3151ef96b"},{"author":{"_account_id":34118,"name":"Arnau Verdaguer","email":"averdagu@redhat.com","username":"averdaguer"},"change_message_id":"8e236279a91ab7e79396121bf32f7d77a68f6b1c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fb07e926_ec40105f","in_reply_to":"628c8f70_21cd140d","updated":"2022-01-07 10:31:27.000000000","message":"On the DOWN to DOWN transition i don\u0027t think that other actions are needed, since\nit will not send anything to nova due to it\u0027s of no interest to nova (https://github.com/openstack/neutron/blob/1ad9ca56b07ffdc9f7e0bc6a62af61961b9128eb/neutron/notifiers/nova.py#L222)\nAlthough I\u0027m not sure about the notify_port_active_direct","commit_id":"59488238ff0d53f7db34a29b00b574e3151ef96b"},{"author":{"_account_id":34118,"name":"Arnau Verdaguer","email":"averdagu@redhat.com","username":"averdaguer"},"change_message_id":"ed71c72ae080915149433c8c78c82c55f581def1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e8b52817_1de364ef","in_reply_to":"e464c2d7_234803ff","updated":"2022-01-07 13:14:42.000000000","message":"Thanks Rodolfo,\n\nI\u0027ve seen the behavior of receiving multiple PortBindingUpEvents[1] on devstack while adding a port to a router. \n\nLog: https://paste.opendev.org/show/811962/\n\n[1]https://review.opendev.org/c/openstack/neutron/+/821544","commit_id":"59488238ff0d53f7db34a29b00b574e3151ef96b"},{"author":{"_account_id":34118,"name":"Arnau Verdaguer","email":"averdagu@redhat.com","username":"averdaguer"},"change_message_id":"b76a6c57eda71573c1129807fba5d593ff5419e3","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"240a5e18_78196d6d","in_reply_to":"e8b52817_1de364ef","updated":"2022-01-07 15:45:59.000000000","message":"With this patch [1] should no longer receive multiple PortBindingUpEvents for the same port without a Down event. Maybe if it\u0027s merged into master this patch will no longer be needed?\n\n[1] https://review.opendev.org/c/openstack/neutron/+/823818","commit_id":"59488238ff0d53f7db34a29b00b574e3151ef96b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"cde46a8fb650db61d05794b630a0caefb76932d7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e464c2d7_234803ff","in_reply_to":"fb07e926_ec40105f","updated":"2022-01-07 10:44:47.000000000","message":"In OVN we fake the port status transition [1]. If the port status is DOWN and the migration attributes are detected, we force the status updated to UP. But this is not related with the OVN port status.\n\nIn fact, to be honest, I don\u0027t know when this should happen. In OVN mech driver, apart from this related code [1], we only set the port status when we receive the OVN event. And if that happens, we should not send twice the same event to Nova.\n\nArnau, Let me ask you, as you state that in the commit message: when is it possible to receive two triggers for the same event? Do you have a bug describing it?\n\n[1]https://github.com/openstack/neutron/blob/7aba1bddabc9fb92b1603ad0ff86c4fe75f36b1f/neutron/plugins/ml2/drivers/ovn/mech_driver/mech_driver.py#L829-L844","commit_id":"59488238ff0d53f7db34a29b00b574e3151ef96b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d50656c13e8625e90c520abbba10377c33ce39c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8437dfec_d6a13607","updated":"2022-05-10 15:06:08.000000000","message":"Do we still need this patch? Is there a LP bug?","commit_id":"3877cd927b656b5aadf3a1e4be329e52725b8b85"},{"author":{"_account_id":34118,"name":"Arnau Verdaguer","email":"averdagu@redhat.com","username":"averdaguer"},"change_message_id":"a7240a94f07578b4579fc1ec690721b7fac57b6c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"adec1a02_cc4ee9d1","updated":"2022-01-07 14:42:01.000000000","message":"recheck","commit_id":"3877cd927b656b5aadf3a1e4be329e52725b8b85"},{"author":{"_account_id":34118,"name":"Arnau Verdaguer","email":"averdagu@redhat.com","username":"averdaguer"},"change_message_id":"057b59166a94fc35a0674f51327474249582f4f9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"79fd65f2_ee7fb203","updated":"2022-01-07 13:17:55.000000000","message":"rechek","commit_id":"3877cd927b656b5aadf3a1e4be329e52725b8b85"},{"author":{"_account_id":34118,"name":"Arnau Verdaguer","email":"averdagu@redhat.com","username":"averdaguer"},"change_message_id":"dbf810b8f76acd34311529e59c320fc9e1bb134d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"47b247a5_b756c30b","in_reply_to":"8437dfec_d6a13607","updated":"2022-05-11 09:52:07.000000000","message":"I don\u0027t think that we need this patch, and there is not a LP bug. \n\nI\u0027ll abandon the patch","commit_id":"3877cd927b656b5aadf3a1e4be329e52725b8b85"}]}