)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"72625f9e61e298d0bd7baaaa9403ed130c41d1af","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f92e86aa_322074e8","updated":"2022-08-10 05:26:29.000000000","message":"@Jakub, @Lucas can you please share your thoughts on this i can revise it accordingly.","commit_id":"7cfd1c0e15d30995f01a172d494cafe9df4cb6d5"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"667af160750f9862237c12e57fe1cd74e28d3ebf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"48096265_7d76b5c0","updated":"2022-01-20 09:50:17.000000000","message":"This is a nice optimization.\n\nIn a follow up patch we need to document all possible config knobs related. For example disabling the RPC workers and disabling \"dhcp_agent_notification\".","commit_id":"7cfd1c0e15d30995f01a172d494cafe9df4cb6d5"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"2ba29834aa9cdda91d87c10508092b9be2cbdc93","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"31f77a88_393240fd","updated":"2022-01-18 13:50:54.000000000","message":"This looks good for me. Lets see what OVN guys will tell about it","commit_id":"7cfd1c0e15d30995f01a172d494cafe9df4cb6d5"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"29ac80cc4980070f0b63c4893e2b2ba86ac815e2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3a60e1c8_ada4835d","updated":"2022-08-31 13:37:08.000000000","message":"+1 (apart from the comment), this is a good idea","commit_id":"dc8842a7a9644444264c89bbd5b050af5a95205c"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"3cfc658d0a5ed68fce75270eac9694809d9cdeaf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"641a4436_a01b144c","updated":"2023-01-05 19:33:54.000000000","message":"I\u0027m going to rebase this to help push it forward and address one of the comments.","commit_id":"bca4874bb3a2c43061736a1c8a20cb85d05b77d2"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"dace9c8c79090daad01e80b819654037f02635a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7f7f0263_e31aa820","in_reply_to":"641a4436_a01b144c","updated":"2023-01-06 13:21:20.000000000","message":"Thanks Brian i had missed this patch, i will update the patch to also include some more cases as described in other bug https://bugs.launchpad.net/neutron/+bug/1992352, if needed can be split too.","commit_id":"bca4874bb3a2c43061736a1c8a20cb85d05b77d2"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2fb4922d593dce61e2704d20b32c16e489321023","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"6ae87ebf_fb19c407","updated":"2023-02-02 15:57:32.000000000","message":"Since I helped a little with this will only +1.","commit_id":"3e1e2d63b3383d28c9a36b00000ab89caffa3829"}],"neutron/conf/common.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"96a56c431798f98fd70a3fe84b46b8e8ecbd3082","unresolved":true,"context_lines":[{"line_number":159,"context_line":"                help\u003d_(\u0027If False, neutron-server will not enable the rpc \u0027"},{"line_number":160,"context_line":"                       \u0027notifications on ml2 object changes. This can be \u0027"},{"line_number":161,"context_line":"                       \u0027done for cases when there are no agents expected to \u0027"},{"line_number":162,"context_line":"                       \u0027run to consume these messages\u0027)),"},{"line_number":163,"context_line":"]"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"core_cli_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"9afb31bf_9668229d","line":162,"updated":"2022-08-10 08:22:50.000000000","message":"Do we need a new option for this ? In my head, if we could set the \"rpc_workers\" to 0 that would already be a way to disable it.\n\nIf I am not mistaken, rpc_workers minimum is 1. So it would be odd to have enable_resources_rpc_notifications set to False and also a RpcWorker running.","commit_id":"7cfd1c0e15d30995f01a172d494cafe9df4cb6d5"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"9839c8ceb1a0bfb8183392fe3d2fa8330f5f5b31","unresolved":true,"context_lines":[{"line_number":159,"context_line":"                help\u003d_(\u0027If False, neutron-server will not enable the rpc \u0027"},{"line_number":160,"context_line":"                       \u0027notifications on ml2 object changes. This can be \u0027"},{"line_number":161,"context_line":"                       \u0027done for cases when there are no agents expected to \u0027"},{"line_number":162,"context_line":"                       \u0027run to consume these messages\u0027)),"},{"line_number":163,"context_line":"]"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"core_cli_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"ab5c7142_1d4b0c42","line":162,"in_reply_to":"90c29134_d5085579","updated":"2022-08-10 14:13:19.000000000","message":"I think it\u0027s a good option allowing to avoid new config. Probably \"-1\" would be better to reflect that rpc is disabled","commit_id":"7cfd1c0e15d30995f01a172d494cafe9df4cb6d5"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"54a4bc9e06c8df132e740a5ab59be23ace29ca94","unresolved":true,"context_lines":[{"line_number":159,"context_line":"                help\u003d_(\u0027If False, neutron-server will not enable the rpc \u0027"},{"line_number":160,"context_line":"                       \u0027notifications on ml2 object changes. This can be \u0027"},{"line_number":161,"context_line":"                       \u0027done for cases when there are no agents expected to \u0027"},{"line_number":162,"context_line":"                       \u0027run to consume these messages\u0027)),"},{"line_number":163,"context_line":"]"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"core_cli_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"e4b0a775_4aba724c","line":162,"in_reply_to":"9afb31bf_9668229d","updated":"2022-08-10 13:37:36.000000000","message":"Okk i need to check it again then, it was long back when i discussed with slawek and using config option for disabling these notifications like it\u0027s done for dhcp_notification, but yes seems rpc_workers config option can be used here to disable notification too.\n\nwrt rpc_workers minimum, yes for \u003c 1 it considers 1 worker to be running\nand yes it\u0027s odd rpc worker always running due to worker setting and notification disabled. This patch was mainly to disable notification part as described in the attached bug.","commit_id":"7cfd1c0e15d30995f01a172d494cafe9df4cb6d5"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"480e4e86273d7b897b26df1fc8cfeb075c8fd4fb","unresolved":true,"context_lines":[{"line_number":159,"context_line":"                help\u003d_(\u0027If False, neutron-server will not enable the rpc \u0027"},{"line_number":160,"context_line":"                       \u0027notifications on ml2 object changes. This can be \u0027"},{"line_number":161,"context_line":"                       \u0027done for cases when there are no agents expected to \u0027"},{"line_number":162,"context_line":"                       \u0027run to consume these messages\u0027)),"},{"line_number":163,"context_line":"]"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"core_cli_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"90c29134_d5085579","line":162,"in_reply_to":"e4b0a775_4aba724c","updated":"2022-08-10 14:00:10.000000000","message":"Thanks for the info.\n\nYeah, I think it may worth taking a look at the \"rpc_workers\" config and see if we can change it to accept 0 as a value to disable RPC in Neutron. I think that makes sense and probably make it easier to backport and also saves time as we wouldn\u0027t need a puppet/tripleo change for an already supported config option.\n\nI don\u0027t know what other reviewers think of it tho, if you are a reviewer reading this, let me know ur thoughts.","commit_id":"7cfd1c0e15d30995f01a172d494cafe9df4cb6d5"}],"neutron/plugins/ml2/plugin.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"29ac80cc4980070f0b63c4893e2b2ba86ac815e2","unresolved":true,"context_lines":[{"line_number":378,"context_line":"    @log_helpers.log_method_call"},{"line_number":379,"context_line":"    def _start_rpc_notifiers(self):"},{"line_number":380,"context_line":"        \"\"\"Initialize RPC notifiers for agents.\"\"\""},{"line_number":381,"context_line":"        if cfg.CONF.rpc_workers is None or cfg.CONF.rpc_workers \u003e\u003d 1:"},{"line_number":382,"context_line":"            self.ovo_notifier \u003d ovo_rpc.OVOServerRpcInterface()"},{"line_number":383,"context_line":"        self.notifier \u003d rpc.AgentNotifierApi(topics.AGENT)"},{"line_number":384,"context_line":"        if cfg.CONF.enable_traditional_dhcp:"}],"source_content_type":"text/x-python","patch_set":2,"id":"cd8b28c6_a03d5359","line":381,"range":{"start_line":381,"start_character":8,"end_line":381,"end_character":69},"updated":"2022-08-31 13:37:08.000000000","message":"You should also include \"rpc_state_report_workers\"","commit_id":"dc8842a7a9644444264c89bbd5b050af5a95205c"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"56dd07f5879b73c7645992301f31e5e498be0bb5","unresolved":true,"context_lines":[{"line_number":378,"context_line":"    @log_helpers.log_method_call"},{"line_number":379,"context_line":"    def _start_rpc_notifiers(self):"},{"line_number":380,"context_line":"        \"\"\"Initialize RPC notifiers for agents.\"\"\""},{"line_number":381,"context_line":"        if cfg.CONF.rpc_workers is None or cfg.CONF.rpc_workers \u003e\u003d 1:"},{"line_number":382,"context_line":"            self.ovo_notifier \u003d ovo_rpc.OVOServerRpcInterface()"},{"line_number":383,"context_line":"        self.notifier \u003d rpc.AgentNotifierApi(topics.AGENT)"},{"line_number":384,"context_line":"        if cfg.CONF.enable_traditional_dhcp:"}],"source_content_type":"text/x-python","patch_set":2,"id":"df75ecb6_fa09a757","line":381,"range":{"start_line":381,"start_character":8,"end_line":381,"end_character":69},"in_reply_to":"cd8b28c6_a03d5359","updated":"2022-10-10 12:37:06.000000000","message":"But AFAIU agent state not involved here as here it notifies for following resources https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/ovo_rpc.py#L166-L171 and rpc_state_report_workers is dedicated to report_state.","commit_id":"dc8842a7a9644444264c89bbd5b050af5a95205c"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"3cfc658d0a5ed68fce75270eac9694809d9cdeaf","unresolved":true,"context_lines":[{"line_number":378,"context_line":"    @log_helpers.log_method_call"},{"line_number":379,"context_line":"    def _start_rpc_notifiers(self):"},{"line_number":380,"context_line":"        \"\"\"Initialize RPC notifiers for agents.\"\"\""},{"line_number":381,"context_line":"        if cfg.CONF.rpc_workers is None or cfg.CONF.rpc_workers \u003e\u003d 1:"},{"line_number":382,"context_line":"            self.ovo_notifier \u003d ovo_rpc.OVOServerRpcInterface()"},{"line_number":383,"context_line":"        self.notifier \u003d rpc.AgentNotifierApi(topics.AGENT)"},{"line_number":384,"context_line":"        if cfg.CONF.enable_traditional_dhcp:"}],"source_content_type":"text/x-python","patch_set":2,"id":"909678d2_5576c148","line":381,"range":{"start_line":381,"start_character":8,"end_line":381,"end_character":69},"in_reply_to":"df75ecb6_fa09a757","updated":"2023-01-05 19:33:54.000000000","message":"I\u0027ll leave this as-is based on Yatin\u0027s comment.","commit_id":"dc8842a7a9644444264c89bbd5b050af5a95205c"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"9ceffa20e31ab1d2b8b142cde2a241c404857533","unresolved":true,"context_lines":[{"line_number":400,"context_line":"    def _start_rpc_notifiers(self):"},{"line_number":401,"context_line":"        \"\"\"Initialize RPC notifiers for agents.\"\"\""},{"line_number":402,"context_line":"        if cfg.CONF.rpc_workers is None or cfg.CONF.rpc_workers \u003e\u003d 1:"},{"line_number":403,"context_line":"            self.ovo_notifier \u003d ovo_rpc.OVOServerRpcInterface()"},{"line_number":404,"context_line":"        self.notifier \u003d rpc.AgentNotifierApi(topics.AGENT)"},{"line_number":405,"context_line":"        if cfg.CONF.enable_traditional_dhcp:"},{"line_number":406,"context_line":"            self.agent_notifiers[const.AGENT_TYPE_DHCP] \u003d ("}],"source_content_type":"text/x-python","patch_set":3,"id":"802f1902_4118c5f5","line":403,"range":{"start_line":403,"start_character":12,"end_line":403,"end_character":29},"updated":"2022-10-10 13:04:28.000000000","message":"ok this class member is never used in code except for tests, but still I think better initialise it as None","commit_id":"bca4874bb3a2c43061736a1c8a20cb85d05b77d2"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"3cfc658d0a5ed68fce75270eac9694809d9cdeaf","unresolved":false,"context_lines":[{"line_number":400,"context_line":"    def _start_rpc_notifiers(self):"},{"line_number":401,"context_line":"        \"\"\"Initialize RPC notifiers for agents.\"\"\""},{"line_number":402,"context_line":"        if cfg.CONF.rpc_workers is None or cfg.CONF.rpc_workers \u003e\u003d 1:"},{"line_number":403,"context_line":"            self.ovo_notifier \u003d ovo_rpc.OVOServerRpcInterface()"},{"line_number":404,"context_line":"        self.notifier \u003d rpc.AgentNotifierApi(topics.AGENT)"},{"line_number":405,"context_line":"        if cfg.CONF.enable_traditional_dhcp:"},{"line_number":406,"context_line":"            self.agent_notifiers[const.AGENT_TYPE_DHCP] \u003d ("}],"source_content_type":"text/x-python","patch_set":3,"id":"66c801b9_2f1f5c6a","line":403,"range":{"start_line":403,"start_character":12,"end_line":403,"end_character":29},"in_reply_to":"802f1902_4118c5f5","updated":"2023-01-05 19:33:54.000000000","message":"Done","commit_id":"bca4874bb3a2c43061736a1c8a20cb85d05b77d2"}],"neutron/tests/unit/common/test_utils.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"ad9f8df3c630b45cbc683a1e6cee99779882b141","unresolved":true,"context_lines":[{"line_number":634,"context_line":"    def sample_method(self):"},{"line_number":635,"context_line":"        raise AttributeError()"},{"line_number":636,"context_line":""},{"line_number":637,"context_line":"    def test_notification_not_disabled(self):"},{"line_number":638,"context_line":"        self.assertRaises(AttributeError, self.sample_method)"},{"line_number":639,"context_line":""},{"line_number":640,"context_line":"    def test_notification_disabled(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"91886ecb_1aa9a94c","line":637,"updated":"2023-01-06 15:21:49.000000000","message":"This test relies on the default. It\u0027s better to explicitly set the rpc_workers to 1 as unittest should be independent on default settings.","commit_id":"10fbbca78da108a0729a53e79bde6425bf1e3324"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"4ad75750211d31fe5acd416d317df706e9242cb6","unresolved":false,"context_lines":[{"line_number":634,"context_line":"    def sample_method(self):"},{"line_number":635,"context_line":"        raise AttributeError()"},{"line_number":636,"context_line":""},{"line_number":637,"context_line":"    def test_notification_not_disabled(self):"},{"line_number":638,"context_line":"        self.assertRaises(AttributeError, self.sample_method)"},{"line_number":639,"context_line":""},{"line_number":640,"context_line":"    def test_notification_disabled(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"8f1ffc68_8bbc1cdf","line":637,"in_reply_to":"91886ecb_1aa9a94c","updated":"2023-01-09 08:03:48.000000000","message":"Done","commit_id":"10fbbca78da108a0729a53e79bde6425bf1e3324"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"ad9f8df3c630b45cbc683a1e6cee99779882b141","unresolved":true,"context_lines":[{"line_number":640,"context_line":"    def test_notification_disabled(self):"},{"line_number":641,"context_line":"        cfg.CONF.set_override(\u0027rpc_workers\u0027, 0)"},{"line_number":642,"context_line":"        self.assertIsNone(self.sample_method())"},{"line_number":643,"context_line":""},{"line_number":644,"context_line":""},{"line_number":645,"context_line":"class SignatureTestCase(base.BaseTestCase):"},{"line_number":646,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ee64f30b_320dfa18","line":643,"updated":"2023-01-06 15:21:49.000000000","message":"Missing test for rpc_workers set to None","commit_id":"10fbbca78da108a0729a53e79bde6425bf1e3324"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"4ad75750211d31fe5acd416d317df706e9242cb6","unresolved":false,"context_lines":[{"line_number":640,"context_line":"    def test_notification_disabled(self):"},{"line_number":641,"context_line":"        cfg.CONF.set_override(\u0027rpc_workers\u0027, 0)"},{"line_number":642,"context_line":"        self.assertIsNone(self.sample_method())"},{"line_number":643,"context_line":""},{"line_number":644,"context_line":""},{"line_number":645,"context_line":"class SignatureTestCase(base.BaseTestCase):"},{"line_number":646,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7e97f24d_87d20b3f","line":643,"in_reply_to":"ee64f30b_320dfa18","updated":"2023-01-09 08:03:48.000000000","message":"Done","commit_id":"10fbbca78da108a0729a53e79bde6425bf1e3324"}],"releasenotes/notes/config_disable_resources_rpc_notifications-2f47ede25904b92c.yaml":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"2ba29834aa9cdda91d87c10508092b9be2cbdc93","unresolved":true,"context_lines":[{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added a new config option ``enable_resources_rpc_notifications`` for"},{"line_number":5,"context_line":"    neutron server, if it is set to False, neutron server will not enable"},{"line_number":6,"context_line":"    rpc notifications on ml2 object changes. This can be done for cases"},{"line_number":7,"context_line":"    when there are no agents expected to run to consume these messages,"},{"line_number":8,"context_line":"    for example it can be used when \u0027ovn\u0027 mechanism_driver is enabled"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"2a0e3161_010d04e7","line":5,"range":{"start_line":5,"start_character":36,"end_line":5,"end_character":41},"updated":"2022-01-18 13:50:54.000000000","message":"nitty nit: You can put it in `` `` to highlight in the rendered html page.","commit_id":"7cfd1c0e15d30995f01a172d494cafe9df4cb6d5"}]}