)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b59d25c0f3e5259575e847a92b82f3ba2c7e3ef2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c316220a_d0c66f5e","updated":"2022-01-17 17:20:18.000000000","message":"Waiting for the CI","commit_id":"e787835a96a8a1eaaa6d80b6047edd53c6ad0a24"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6dba074ca26fb781c8126032145317990247f740","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"174fc2e6_946337cb","updated":"2022-01-19 08:36:43.000000000","message":"recheck - bug https://bugs.launchpad.net/neutron/+bug/1958363","commit_id":"1562f9141ba9c90c69c1c851dd9a50c8108ab15f"}],"neutron/agent/dhcp/agent.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b59d25c0f3e5259575e847a92b82f3ba2c7e3ef2","unresolved":true,"context_lines":[{"line_number":400,"context_line":"        if not network.admin_state_up:"},{"line_number":401,"context_line":"            return"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"        if (any(s for s in network.subnets if s.enable_dhcp) and"},{"line_number":404,"context_line":"                self.call_driver(\u0027enable\u0027, network)):"},{"line_number":405,"context_line":"            self.update_isolated_metadata_proxy(network)"},{"line_number":406,"context_line":"            self.cache.put(network)"}],"source_content_type":"text/x-python","patch_set":1,"id":"b909f82b_f04d5d84","line":403,"updated":"2022-01-17 17:20:18.000000000","message":"Right, this \"network\" was collected in \"self.plugin_rpc.get_active_networks_info(                enable_dhcp_filter\u003dFalse)\". That means we retrieve all networks and any subnet, including those ones with the DHCP disabled.","commit_id":"e787835a96a8a1eaaa6d80b6047edd53c6ad0a24"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"2a89d02225173b8fe31c57784e26e5333fdf752f","unresolved":true,"context_lines":[{"line_number":400,"context_line":"        if not network.admin_state_up:"},{"line_number":401,"context_line":"            return"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"        if (any(s for s in network.subnets if s.enable_dhcp) and"},{"line_number":404,"context_line":"                self.call_driver(\u0027enable\u0027, network)):"},{"line_number":405,"context_line":"            self.update_isolated_metadata_proxy(network)"},{"line_number":406,"context_line":"            self.cache.put(network)"}],"source_content_type":"text/x-python","patch_set":1,"id":"852aae38_6a50fc77","line":403,"in_reply_to":"3f093c12_95c77995","updated":"2022-01-18 06:18:06.000000000","message":"Is there a reason for passing \"enable_dhcp_filter\u003dFalse\" in self.plugin_rpc.get_active_networks_info? - I don\u0027t see any. Lately we moved towards only passing dhcp enabled subnets to the agent [1], [2], shouldn\u0027t we keep this direction?\n\n[1] https://review.opendev.org/c/openstack/neutron/+/289165\n[2] https://review.opendev.org/c/openstack/neutron/+/815853","commit_id":"e787835a96a8a1eaaa6d80b6047edd53c6ad0a24"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"711e087db8c4fc9f184420147bc093d8dd1f1dce","unresolved":true,"context_lines":[{"line_number":400,"context_line":"        if not network.admin_state_up:"},{"line_number":401,"context_line":"            return"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"        if (any(s for s in network.subnets if s.enable_dhcp) and"},{"line_number":404,"context_line":"                self.call_driver(\u0027enable\u0027, network)):"},{"line_number":405,"context_line":"            self.update_isolated_metadata_proxy(network)"},{"line_number":406,"context_line":"            self.cache.put(network)"}],"source_content_type":"text/x-python","patch_set":1,"id":"eedb8de8_d90c84c2","line":403,"in_reply_to":"852aae38_6a50fc77","updated":"2022-01-18 10:59:09.000000000","message":"@Oleg: It was done like that to fix other bug, see https://review.opendev.org/c/openstack/neutron/+/566405 for details.\n\n@Brian: done","commit_id":"e787835a96a8a1eaaa6d80b6047edd53c6ad0a24"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e7fb32d4a942b6b225b29a7b1fc132f6ff03722e","unresolved":true,"context_lines":[{"line_number":400,"context_line":"        if not network.admin_state_up:"},{"line_number":401,"context_line":"            return"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"        if (any(s for s in network.subnets if s.enable_dhcp) and"},{"line_number":404,"context_line":"                self.call_driver(\u0027enable\u0027, network)):"},{"line_number":405,"context_line":"            self.update_isolated_metadata_proxy(network)"},{"line_number":406,"context_line":"            self.cache.put(network)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f093c12_95c77995","line":403,"in_reply_to":"b909f82b_f04d5d84","updated":"2022-01-17 18:13:44.000000000","message":"Looks correct, should probably add a unit test to cover this case as well.","commit_id":"e787835a96a8a1eaaa6d80b6047edd53c6ad0a24"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"780bc1b9bf11f294111e3e3ddfaff44834cbd6fc","unresolved":true,"context_lines":[{"line_number":400,"context_line":"        if not network.admin_state_up:"},{"line_number":401,"context_line":"            return"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"        if (any(s for s in network.subnets if s.enable_dhcp) and"},{"line_number":404,"context_line":"                self.call_driver(\u0027enable\u0027, network)):"},{"line_number":405,"context_line":"            self.update_isolated_metadata_proxy(network)"},{"line_number":406,"context_line":"            self.cache.put(network)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f3b7ed7_71cc6b27","line":403,"in_reply_to":"eedb8de8_d90c84c2","updated":"2022-01-19 11:19:28.000000000","message":"Indeed, thanks!","commit_id":"e787835a96a8a1eaaa6d80b6047edd53c6ad0a24"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"39667a95b7e65191145f30f34a06f708a8fdd5f0","unresolved":true,"context_lines":[{"line_number":400,"context_line":"        if not network.admin_state_up:"},{"line_number":401,"context_line":"            return"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"        if (any(s for s in network.subnets if s.enable_dhcp) and"},{"line_number":404,"context_line":"                self.call_driver(\u0027enable\u0027, network)):"},{"line_number":405,"context_line":"            self.update_isolated_metadata_proxy(network)"},{"line_number":406,"context_line":"            self.cache.put(network)"}],"source_content_type":"text/x-python","patch_set":2,"id":"0272c4de_8da72bba","line":403,"updated":"2022-01-18 23:53:06.000000000","message":"It seems to me this is what is going to directly address https://bugs.launchpad.net/neutron/+bug/1953478. Am I right?","commit_id":"1562f9141ba9c90c69c1c851dd9a50c8108ab15f"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"9ebd9054f3e8d044df94783a1a2dd3c29feea689","unresolved":true,"context_lines":[{"line_number":400,"context_line":"        if not network.admin_state_up:"},{"line_number":401,"context_line":"            return"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"        if (any(s for s in network.subnets if s.enable_dhcp) and"},{"line_number":404,"context_line":"                self.call_driver(\u0027enable\u0027, network)):"},{"line_number":405,"context_line":"            self.update_isolated_metadata_proxy(network)"},{"line_number":406,"context_line":"            self.cache.put(network)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ec08f67_3e86316d","line":403,"in_reply_to":"0272c4de_8da72bba","updated":"2022-01-19 08:15:58.000000000","message":"This is addressing the cause of this specific, \"unexpected\" provisioning complete message, so I would say it fixes what triggered that error with shelve/unshelve.\nBut the root cause of the problem is addressed in https://review.opendev.org/c/openstack/neutron/+/824981","commit_id":"1562f9141ba9c90c69c1c851dd9a50c8108ab15f"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"661bbff4f2a6313c5a10a96f84395baac918e70d","unresolved":false,"context_lines":[{"line_number":400,"context_line":"        if not network.admin_state_up:"},{"line_number":401,"context_line":"            return"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"        if (any(s for s in network.subnets if s.enable_dhcp) and"},{"line_number":404,"context_line":"                self.call_driver(\u0027enable\u0027, network)):"},{"line_number":405,"context_line":"            self.update_isolated_metadata_proxy(network)"},{"line_number":406,"context_line":"            self.cache.put(network)"}],"source_content_type":"text/x-python","patch_set":2,"id":"252e313a_f495abdb","line":403,"in_reply_to":"9ec08f67_3e86316d","updated":"2022-01-19 16:52:31.000000000","message":"Ack","commit_id":"1562f9141ba9c90c69c1c851dd9a50c8108ab15f"}]}