)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"3e756021025e8493af2a0bc6023823d2869723aa","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     labedz \u003ckrzysztof.tomaszewski@ovhcloud.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-03-01 15:20:08 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Don\u0027t set HA ports down while L2 agent restart."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Because of the fix for bug[1] and issue with linux_utils"},{"line_number":10,"context_line":"get_process_count_by_name() L3 agent puts all it\u0027s HA ports down"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"965ecfe8_1db7602e","line":7,"range":{"start_line":7,"start_character":30,"end_line":7,"end_character":32},"updated":"2022-03-01 14:24:59.000000000","message":"L3?","commit_id":"1c37880135fe15c98a19aa02e8237fa2e6315d9c"},{"author":{"_account_id":30463,"name":"Krzysztof Tomaszewski","display_name":"Krzysztof Tomaszewski","email":"ktomaszewski@cloudferro.com","username":"labedz"},"change_message_id":"f62c1f0b21a4325d1441549b58d2b6dee4b2b130","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     labedz \u003ckrzysztof.tomaszewski@ovhcloud.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-03-01 15:20:08 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Don\u0027t set HA ports down while L2 agent restart."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Because of the fix for bug[1] and issue with linux_utils"},{"line_number":10,"context_line":"get_process_count_by_name() L3 agent puts all it\u0027s HA ports down"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"a48cc7c0_ad4abbb2","line":7,"range":{"start_line":7,"start_character":30,"end_line":7,"end_character":32},"in_reply_to":"965ecfe8_1db7602e","updated":"2022-03-01 14:28:30.000000000","message":"...\nthanks","commit_id":"1c37880135fe15c98a19aa02e8237fa2e6315d9c"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"5d137c11e6b1969bc5ee0ec842f38a62004af329","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"8e9c8b2b_35229873","updated":"2022-03-02 00:56:55.000000000","message":"Let\u0027s get it merged, for our local environment we do not want to set HA port down for a long time.","commit_id":"f430cd00725f8303f5313cb7784c9aed4b982e62"},{"author":{"_account_id":30463,"name":"Krzysztof Tomaszewski","display_name":"Krzysztof Tomaszewski","email":"ktomaszewski@cloudferro.com","username":"labedz"},"change_message_id":"ed21db4426e9c482f36eb5378516628dfb5d2ab8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"fe23925b_51dc31be","updated":"2022-03-01 16:16:17.000000000","message":"recheck","commit_id":"f430cd00725f8303f5313cb7784c9aed4b982e62"}],"neutron/agent/l3/agent.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"98bea99033c7feb53c7e031f5c3a7cbe0b09fdb8","unresolved":true,"context_lines":[{"line_number":389,"context_line":"            # Only set HA ports down when host was rebooted so no net"},{"line_number":390,"context_line":"            # namespaces were still created."},{"line_number":391,"context_line":"            if any(ns.startswith(dvr_snat_ns.SNAT_NS_PREFIX) for ns in"},{"line_number":392,"context_line":"                   self.namespaces_manager.list_all()):"},{"line_number":393,"context_line":"                LOG.debug(\"Network configuration already done. Skipping\""},{"line_number":394,"context_line":"                          \" set HA port to DOWN state.\")"},{"line_number":395,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":5,"id":"02746185_a91ca648","line":392,"updated":"2022-01-31 15:40:15.000000000","message":"but if You don\u0027t have dvr enabled, there will be no snat- namespaces at all. So how this will work in such case?","commit_id":"5121be53adff490a35a2c91d938e6708b67b61fe"},{"author":{"_account_id":30463,"name":"Krzysztof Tomaszewski","display_name":"Krzysztof Tomaszewski","email":"ktomaszewski@cloudferro.com","username":"labedz"},"change_message_id":"a3816bd8cffe9d2e39a73bc278a5f2b202936adc","unresolved":true,"context_lines":[{"line_number":389,"context_line":"            # Only set HA ports down when host was rebooted so no net"},{"line_number":390,"context_line":"            # namespaces were still created."},{"line_number":391,"context_line":"            if any(ns.startswith(dvr_snat_ns.SNAT_NS_PREFIX) for ns in"},{"line_number":392,"context_line":"                   self.namespaces_manager.list_all()):"},{"line_number":393,"context_line":"                LOG.debug(\"Network configuration already done. Skipping\""},{"line_number":394,"context_line":"                          \" set HA port to DOWN state.\")"},{"line_number":395,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":5,"id":"464d855a_40455c94","line":392,"in_reply_to":"02746185_a91ca648","updated":"2022-01-31 15:56:22.000000000","message":"If we don\u0027t have snat-* ns then we don\u0027t have to put ha- ports down either as those interfaces are in the snat- namespace","commit_id":"5121be53adff490a35a2c91d938e6708b67b61fe"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"85e7daaf3396f639e7ccf4434fdeffd570f9b4e2","unresolved":true,"context_lines":[{"line_number":389,"context_line":"            # Only set HA ports down when host was rebooted so no net"},{"line_number":390,"context_line":"            # namespaces were still created."},{"line_number":391,"context_line":"            if any(ns.startswith(dvr_snat_ns.SNAT_NS_PREFIX) for ns in"},{"line_number":392,"context_line":"                   self.namespaces_manager.list_all()):"},{"line_number":393,"context_line":"                LOG.debug(\"Network configuration already done. Skipping\""},{"line_number":394,"context_line":"                          \" set HA port to DOWN state.\")"},{"line_number":395,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":5,"id":"404a1a81_ccdcf2ac","line":392,"in_reply_to":"1a5bdfac_d1b1886e","updated":"2022-02-17 10:12:03.000000000","message":"ha- interfaces may be also in qrouter- namespace if it\u0027s L3HA without DVR. Did You considered that case or it\u0027s irrelevant here?","commit_id":"5121be53adff490a35a2c91d938e6708b67b61fe"},{"author":{"_account_id":30463,"name":"Krzysztof Tomaszewski","display_name":"Krzysztof Tomaszewski","email":"ktomaszewski@cloudferro.com","username":"labedz"},"change_message_id":"2c024ae8fd159010681a7acd3f09bc6993f450a1","unresolved":true,"context_lines":[{"line_number":389,"context_line":"            # Only set HA ports down when host was rebooted so no net"},{"line_number":390,"context_line":"            # namespaces were still created."},{"line_number":391,"context_line":"            if any(ns.startswith(dvr_snat_ns.SNAT_NS_PREFIX) for ns in"},{"line_number":392,"context_line":"                   self.namespaces_manager.list_all()):"},{"line_number":393,"context_line":"                LOG.debug(\"Network configuration already done. Skipping\""},{"line_number":394,"context_line":"                          \" set HA port to DOWN state.\")"},{"line_number":395,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":5,"id":"e17164bb_e04a835c","line":392,"in_reply_to":"404a1a81_ccdcf2ac","updated":"2022-03-01 00:00:48.000000000","message":"True. In that case checking if qrouter-* net namespace exists should do the job in both situations.","commit_id":"5121be53adff490a35a2c91d938e6708b67b61fe"},{"author":{"_account_id":30463,"name":"Krzysztof Tomaszewski","display_name":"Krzysztof Tomaszewski","email":"ktomaszewski@cloudferro.com","username":"labedz"},"change_message_id":"7ba15a4825f7a23d58f8d027b7a1054f488acd60","unresolved":true,"context_lines":[{"line_number":389,"context_line":"            # Only set HA ports down when host was rebooted so no net"},{"line_number":390,"context_line":"            # namespaces were still created."},{"line_number":391,"context_line":"            if any(ns.startswith(dvr_snat_ns.SNAT_NS_PREFIX) for ns in"},{"line_number":392,"context_line":"                   self.namespaces_manager.list_all()):"},{"line_number":393,"context_line":"                LOG.debug(\"Network configuration already done. Skipping\""},{"line_number":394,"context_line":"                          \" set HA port to DOWN state.\")"},{"line_number":395,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a5bdfac_d1b1886e","line":392,"in_reply_to":"464d855a_40455c94","updated":"2022-02-01 08:53:36.000000000","message":"In other words: this patch effect only when there is snat-* namespace: putting ha-* ports down will be ommited. In other situations the codeflow will be the same.","commit_id":"5121be53adff490a35a2c91d938e6708b67b61fe"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"b4fff385b01f2de25230f79eaa83ba124c6fda3c","unresolved":true,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import eventlet"},{"line_number":19,"context_line":"import netaddr"},{"line_number":20,"context_line":"from neutron.agent.l3 import namespaces as l3_namespaces"},{"line_number":21,"context_line":"from neutron_lib.agent import constants as agent_consts"},{"line_number":22,"context_line":"from neutron_lib.agent import topics"},{"line_number":23,"context_line":"from neutron_lib.callbacks import events"}],"source_content_type":"text/x-python","patch_set":8,"id":"5b124398_042b902f","line":20,"updated":"2022-03-01 14:05:57.000000000","message":"sorry that I didn\u0027t saw it before but this is import from neutron so it should be in the next section, between lines 43 and 60","commit_id":"bedf60fc5448a013cf4fdabc9936830aa3bea448"},{"author":{"_account_id":30463,"name":"Krzysztof Tomaszewski","display_name":"Krzysztof Tomaszewski","email":"ktomaszewski@cloudferro.com","username":"labedz"},"change_message_id":"4d5ff55f46396d2e916db76a4bf122ad6c0e3b98","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import eventlet"},{"line_number":19,"context_line":"import netaddr"},{"line_number":20,"context_line":"from neutron.agent.l3 import namespaces as l3_namespaces"},{"line_number":21,"context_line":"from neutron_lib.agent import constants as agent_consts"},{"line_number":22,"context_line":"from neutron_lib.agent import topics"},{"line_number":23,"context_line":"from neutron_lib.callbacks import events"}],"source_content_type":"text/x-python","patch_set":8,"id":"a3540d29_f4ab021d","line":20,"in_reply_to":"5b124398_042b902f","updated":"2022-03-01 14:21:17.000000000","message":"You didn\u0027t as it is from the last patchset 😊\nPlease check last comment on bug report.","commit_id":"bedf60fc5448a013cf4fdabc9936830aa3bea448"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"b24c65f2e75c6e4d96cf78793834a2bb871c57d3","unresolved":true,"context_lines":[{"line_number":372,"context_line":""},{"line_number":373,"context_line":"        # Only set HA ports down when host was rebooted so no net"},{"line_number":374,"context_line":"        # namespaces were still created."},{"line_number":375,"context_line":"        if any(ns.startswith(l3_namespaces.NS_PREFIX) for ns in"},{"line_number":376,"context_line":"               self.namespaces_manager.list_all()):"},{"line_number":377,"context_line":"            LOG.debug(\"Network configuration already done. Skipping\""},{"line_number":378,"context_line":"                      \" set HA port to DOWN state.\")"},{"line_number":379,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":10,"id":"0ced68a5_41c59dc6","line":376,"range":{"start_line":375,"start_character":8,"end_line":376,"end_character":51},"updated":"2022-03-01 14:44:39.000000000","message":"This may not cover the case that restart l3-agent in a short period, yes not once, but multiple times, some qrouter-ns are created, some HA port are not set properly, which will be a regression on bug https://bugs.launchpad.net/neutron/+bug/1597461","commit_id":"f430cd00725f8303f5313cb7784c9aed4b982e62"},{"author":{"_account_id":30463,"name":"Krzysztof Tomaszewski","display_name":"Krzysztof Tomaszewski","email":"ktomaszewski@cloudferro.com","username":"labedz"},"change_message_id":"3aa071409a6e981dcfd68a25ea9dd8f932ffcfea","unresolved":true,"context_lines":[{"line_number":372,"context_line":""},{"line_number":373,"context_line":"        # Only set HA ports down when host was rebooted so no net"},{"line_number":374,"context_line":"        # namespaces were still created."},{"line_number":375,"context_line":"        if any(ns.startswith(l3_namespaces.NS_PREFIX) for ns in"},{"line_number":376,"context_line":"               self.namespaces_manager.list_all()):"},{"line_number":377,"context_line":"            LOG.debug(\"Network configuration already done. Skipping\""},{"line_number":378,"context_line":"                      \" set HA port to DOWN state.\")"},{"line_number":379,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":10,"id":"652eda0f_753eab96","line":376,"range":{"start_line":375,"start_character":8,"end_line":376,"end_character":51},"in_reply_to":"0ced68a5_41c59dc6","updated":"2022-03-01 15:33:14.000000000","message":"Agree, it\u0027s not perfect. The best would be some kind of synchronisation between L3 and L2 agents. But such sollution is far away.\nThis change is an improvement to the current state (keepalived and neutron-keepalived-state-change also need some time to set up after L3 agent restart).","commit_id":"f430cd00725f8303f5313cb7784c9aed4b982e62"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"5d137c11e6b1969bc5ee0ec842f38a62004af329","unresolved":true,"context_lines":[{"line_number":372,"context_line":""},{"line_number":373,"context_line":"        # Only set HA ports down when host was rebooted so no net"},{"line_number":374,"context_line":"        # namespaces were still created."},{"line_number":375,"context_line":"        if any(ns.startswith(l3_namespaces.NS_PREFIX) for ns in"},{"line_number":376,"context_line":"               self.namespaces_manager.list_all()):"},{"line_number":377,"context_line":"            LOG.debug(\"Network configuration already done. Skipping\""},{"line_number":378,"context_line":"                      \" set HA port to DOWN state.\")"},{"line_number":379,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":10,"id":"dd97de4f_fd986a1c","line":376,"range":{"start_line":375,"start_character":8,"end_line":376,"end_character":51},"in_reply_to":"652eda0f_753eab96","updated":"2022-03-02 00:56:55.000000000","message":"Yes, process counting is not perfect as well.","commit_id":"f430cd00725f8303f5313cb7784c9aed4b982e62"}]}