)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"509113e69c47a1db34e71599ee739489c04a5312","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ffa34631_61ebe579","updated":"2022-01-31 16:39:06.000000000","message":"recheck - trunk port status error, not related to that patch","commit_id":"bf9c90829f2c91f8964e34636969966d6ce366c8"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"26f58039197ba253933664a32d51cd95dd4ad43a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0d6de16b_746a2782","updated":"2022-02-03 00:30:07.000000000","message":"recheck","commit_id":"8fd88fd2239bd19794f2a1cf9480e5aa7d4f5a9b"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"d43c72d4e100c12524598b7cffcf1a46271725fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"103b2911_68dede22","updated":"2022-02-01 20:48:56.000000000","message":"recheck","commit_id":"8fd88fd2239bd19794f2a1cf9480e5aa7d4f5a9b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"697aec54c43345cdf241c8451e1c09c1b7e51556","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9c7cffa5_207c0617","updated":"2022-02-02 10:35:00.000000000","message":"recheck","commit_id":"8fd88fd2239bd19794f2a1cf9480e5aa7d4f5a9b"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"a78c864e0a3a306d2635b725e97a462557ae376f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b46e84fa_da2bcb3f","updated":"2022-02-02 02:58:34.000000000","message":"recheck","commit_id":"8fd88fd2239bd19794f2a1cf9480e5aa7d4f5a9b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"effbd4afec4891a30e11f4fd0c3f74c63247b705","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f863ea08_ba18af08","updated":"2022-02-01 10:18:21.000000000","message":"recheck","commit_id":"8fd88fd2239bd19794f2a1cf9480e5aa7d4f5a9b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"3bfb7f2a7b8656ba6ca9dae7aaad2a5fb7e4f4c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2491d2b9_1efe6d7e","updated":"2022-02-02 15:26:43.000000000","message":"recheck - problem with Ubuntu repositories","commit_id":"8fd88fd2239bd19794f2a1cf9480e5aa7d4f5a9b"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"e9f082c6b13a32fd3e717e87181e2f9b9f55c6a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"12edd7c7_749e0d75","updated":"2022-02-02 07:36:32.000000000","message":"should it be rebased?","commit_id":"8fd88fd2239bd19794f2a1cf9480e5aa7d4f5a9b"}],"neutron/api/rpc/handlers/dhcp_rpc.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f8731d6f3e73af066a3ca2c6a1943b26d20e5211","unresolved":true,"context_lines":[{"line_number":209,"context_line":"        nonlocal_subnets \u003d []"},{"line_number":210,"context_line":"        # If there are no subnets with segments, then this is not a routed"},{"line_number":211,"context_line":"        # network and no filtering should take place."},{"line_number":212,"context_line":"        # If there is no host given, we shouldn\u0027t filter subnets based on the"},{"line_number":213,"context_line":"        # segments"},{"line_number":214,"context_line":"        if seg_plug and seg_subnets and host:"},{"line_number":215,"context_line":"            # Network subnets can be associated only to network segments."},{"line_number":216,"context_line":"            # From those segments, we retrieve only those ones mapped to"}],"source_content_type":"text/x-python","patch_set":1,"id":"588b3cce_17697487","line":213,"range":{"start_line":212,"start_character":8,"end_line":213,"end_character":18},"updated":"2022-01-31 17:07:39.000000000","message":"First of all, I\u0027ll refer to the original method implementation [1]. If \"host\" is nothing or an invalid value, \"get_segments_by_hosts\" will return []. That means we always need to filter by \"host\" but we need to pass the value then.\n\nNo method is calling \"get_network_info\" passing the \"host\" kwarg. This is an error of my patch [2]. In [3], we should be passing \"host\" as a kwarg. My bad, sorry!\n\n[1]https://review.opendev.org/c/openstack/neutron/+/339365/9/neutron/api/rpc/handlers/dhcp_rpc.py#146\n[2]https://review.opendev.org/c/openstack/neutron/+/820190\n[3]https://github.com/openstack/neutron/blob/30951fcdfab753153a30c4e77309da0b9afd919e/neutron/api/rpc/handlers/dhcp_rpc.py#L169-L171","commit_id":"bf9c90829f2c91f8964e34636969966d6ce366c8"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e70ae930a0bbd63c452399b50f3a29318b25d5c2","unresolved":false,"context_lines":[{"line_number":209,"context_line":"        nonlocal_subnets \u003d []"},{"line_number":210,"context_line":"        # If there are no subnets with segments, then this is not a routed"},{"line_number":211,"context_line":"        # network and no filtering should take place."},{"line_number":212,"context_line":"        # If there is no host given, we shouldn\u0027t filter subnets based on the"},{"line_number":213,"context_line":"        # segments"},{"line_number":214,"context_line":"        if seg_plug and seg_subnets and host:"},{"line_number":215,"context_line":"            # Network subnets can be associated only to network segments."},{"line_number":216,"context_line":"            # From those segments, we retrieve only those ones mapped to"}],"source_content_type":"text/x-python","patch_set":1,"id":"7247695e_b2e32fef","line":213,"range":{"start_line":212,"start_character":8,"end_line":213,"end_character":18},"in_reply_to":"588b3cce_17697487","updated":"2022-02-01 07:24:26.000000000","message":"You\u0027re absolutely right. We should pass host parameter there. Now I changed that.","commit_id":"bf9c90829f2c91f8964e34636969966d6ce366c8"}]}
