)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"4dfab36463c0981806ee1852a5b62170a07c4838","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"13e51241_0c7a3b46","updated":"2022-02-08 18:12:08.000000000","message":"Should there be a unit test for this? There is one for the egress equivalent.","commit_id":"0d233041206434b91e5f2d1f00593e592019a99d"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"622871418efa7ef7d8604d7cdd8eecb1cd3f734c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2bf8d3b7_12b51499","updated":"2022-02-14 10:35:08.000000000","message":"Thanks","commit_id":"0d233041206434b91e5f2d1f00593e592019a99d"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"233c903b6ff2fa236b9f0b865a2625ef7478149b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6b762c57_b1ac2c5f","updated":"2022-02-02 08:04:36.000000000","message":"recheck","commit_id":"0d233041206434b91e5f2d1f00593e592019a99d"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"88b3de408394928e0e3e6fe8b5411997a64132c8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d77f5cd9_d02d3db4","updated":"2022-02-03 10:43:22.000000000","message":"recheck","commit_id":"0d233041206434b91e5f2d1f00593e592019a99d"}],"neutron/agent/linux/openvswitch_firewall/firewall.py":[{"author":{"_account_id":28722,"name":"Anton Kurbatov","email":"anton.kurbatov@acronis.com","username":"akurbatov"},"change_message_id":"210fdff158f523b2c8adbf3ae063e7c4f5fdfc8f","unresolved":true,"context_lines":[{"line_number":1350,"context_line":"        # firewall. This rule was added in \"_add_ingress_ra_rule\". However,"},{"line_number":1351,"context_line":"        # the OVS firewall does not use port[\"security_group_rules\"]."},{"line_number":1352,"context_line":"        for icmp_type in (firewall.ICMPV6_ALLOWED_INGRESS_TYPES,"},{"line_number":1353,"context_line":"                          lib_const.ICMPV6_TYPE_RA):"},{"line_number":1354,"context_line":"            self._add_flow("},{"line_number":1355,"context_line":"                table\u003dovs_consts.BASE_INGRESS_TABLE,"},{"line_number":1356,"context_line":"                priority\u003d100,"}],"source_content_type":"text/x-python","patch_set":1,"id":"04644383_686b717d","line":1353,"updated":"2022-02-01 09:32:52.000000000","message":"Hm, are you sure this will work as expected?\nICMPV6_ALLOWED_INGRESS_TYPES is a tuple.\nSo, here we are getting:\n\nself._add_flow(..., icmp_type\u003d(130, 135, 136), ...)\nself._add_flow(..., icmp_type\u003d134, ...)\n\nRight?","commit_id":"00bcfc06dc193a1394b9852908a97ab43b81303e"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"77524692849a0338dc7474fa5fb7d909e8727c25","unresolved":true,"context_lines":[{"line_number":1350,"context_line":"        # firewall. This rule was added in \"_add_ingress_ra_rule\". However,"},{"line_number":1351,"context_line":"        # the OVS firewall does not use port[\"security_group_rules\"]."},{"line_number":1352,"context_line":"        for icmp_type in (firewall.ICMPV6_ALLOWED_INGRESS_TYPES,"},{"line_number":1353,"context_line":"                          lib_const.ICMPV6_TYPE_RA):"},{"line_number":1354,"context_line":"            self._add_flow("},{"line_number":1355,"context_line":"                table\u003dovs_consts.BASE_INGRESS_TABLE,"},{"line_number":1356,"context_line":"                priority\u003d100,"}],"source_content_type":"text/x-python","patch_set":1,"id":"c0f133ea_4571434a","line":1353,"in_reply_to":"04644383_686b717d","updated":"2022-02-01 11:34:32.000000000","message":"No, that was terribly implemented","commit_id":"00bcfc06dc193a1394b9852908a97ab43b81303e"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"90c14563810b3932807f950a3cfe69375faa251a","unresolved":false,"context_lines":[{"line_number":1350,"context_line":"        # firewall. This rule was added in \"_add_ingress_ra_rule\". However,"},{"line_number":1351,"context_line":"        # the OVS firewall does not use port[\"security_group_rules\"]."},{"line_number":1352,"context_line":"        for icmp_type in (firewall.ICMPV6_ALLOWED_INGRESS_TYPES,"},{"line_number":1353,"context_line":"                          lib_const.ICMPV6_TYPE_RA):"},{"line_number":1354,"context_line":"            self._add_flow("},{"line_number":1355,"context_line":"                table\u003dovs_consts.BASE_INGRESS_TABLE,"},{"line_number":1356,"context_line":"                priority\u003d100,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3d0e7000_c683ed3a","line":1353,"in_reply_to":"c0f133ea_4571434a","updated":"2022-02-07 14:11:25.000000000","message":"Done","commit_id":"00bcfc06dc193a1394b9852908a97ab43b81303e"}]}