)]}'
{"neutron/agent/securitygroups_rpc.py":[{"author":{"_account_id":8911,"name":"Sergey Vilgelm","email":"sergey@vilgelm.info","username":"sergey.vilgelm"},"change_message_id":"22b62fdea7493db4319410e4bc8dfbe23d0ff826","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            (not cfg.CONF.SECURITYGROUP.enable_security_group and"},{"line_number":51,"context_line":"             (cfg.CONF.SECURITYGROUP.firewall_driver \u003d\u003d"},{"line_number":52,"context_line":"             \u0027neutron.agent.firewall.NoopFirewallDriver\u0027 or"},{"line_number":53,"context_line":"              cfg.CONF.SECURITYGROUP.firewall_driver \u003d\u003d None)"},{"line_number":54,"context_line":"             ))"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2BqVE%3D","line":53,"updated":"2014-03-25 08:26:46.000000000","message":"cfg.CONF.SECURITYGROUP.firewall_driver is not SQLAlchemy object. Could you replace \"\u003d\u003d None\" to \"is None\"?","commit_id":"6184647f2032b16902a3338e1cdd98d51cb78cc7"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"17f445fdaaf9ee8887848fd648fbc04956413d05","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            (not cfg.CONF.SECURITYGROUP.enable_security_group and"},{"line_number":51,"context_line":"             (cfg.CONF.SECURITYGROUP.firewall_driver \u003d\u003d"},{"line_number":52,"context_line":"             \u0027neutron.agent.firewall.NoopFirewallDriver\u0027 or"},{"line_number":53,"context_line":"              cfg.CONF.SECURITYGROUP.firewall_driver \u003d\u003d None)"},{"line_number":54,"context_line":"             ))"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2Bp0k%3D","line":53,"in_reply_to":"AAAAWH%2F%2BqVE%3D","updated":"2014-03-25 09:27:14.000000000","message":"This not changed as part of this patch. But yes, I can change it.","commit_id":"6184647f2032b16902a3338e1cdd98d51cb78cc7"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"bd7715e2dccb4180df53fa4473737262fcc1d6ab","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        firewall_driver \u003d cfg.CONF.SECURITYGROUP.firewall_driver"},{"line_number":140,"context_line":"        LOG.debug(_(\"Init firewall settings (driver\u003d%s)\"), firewall_driver)"},{"line_number":141,"context_line":"        if not _is_valid_driver_combination():"},{"line_number":142,"context_line":"            LOG.warn(\"Driver configuration don\u0027t match \""},{"line_number":143,"context_line":"                     \"with enable_security_group\")"},{"line_number":144,"context_line":"        if not firewall_driver:"},{"line_number":145,"context_line":"            firewall_driver \u003d \u0027neutron.agent.firewall.NoopFirewallDriver\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2Bg6E%3D","line":142,"updated":"2014-03-26 09:12:51.000000000","message":"(suggestion for log text) \u0027doesn\u0027t match\u0027 or \u0027incompatible with\u0027","commit_id":"d2dbd3a70398754a553b0b852614ad1f04ef68de"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"5e3dd72305495793a9c9252af52126f2087c964c","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        firewall_driver \u003d cfg.CONF.SECURITYGROUP.firewall_driver"},{"line_number":140,"context_line":"        LOG.debug(_(\"Init firewall settings (driver\u003d%s)\"), firewall_driver)"},{"line_number":141,"context_line":"        if not _is_valid_driver_combination():"},{"line_number":142,"context_line":"            LOG.warn(\"Driver configuration don\u0027t match \""},{"line_number":143,"context_line":"                     \"with enable_security_group\")"},{"line_number":144,"context_line":"        if not firewall_driver:"},{"line_number":145,"context_line":"            firewall_driver \u003d \u0027neutron.agent.firewall.NoopFirewallDriver\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2BpQc%3D","line":142,"updated":"2014-03-25 10:41:37.000000000","message":"Wondering...if the combination is invalid, is the desire to only warn and continue?","commit_id":"d2dbd3a70398754a553b0b852614ad1f04ef68de"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"1e7424609b61a338ce718b959e3c26fee8fafaee","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        firewall_driver \u003d cfg.CONF.SECURITYGROUP.firewall_driver"},{"line_number":140,"context_line":"        LOG.debug(_(\"Init firewall settings (driver\u003d%s)\"), firewall_driver)"},{"line_number":141,"context_line":"        if not _is_valid_driver_combination():"},{"line_number":142,"context_line":"            LOG.warn(\"Driver configuration don\u0027t match \""},{"line_number":143,"context_line":"                     \"with enable_security_group\")"},{"line_number":144,"context_line":"        if not firewall_driver:"},{"line_number":145,"context_line":"            firewall_driver \u003d \u0027neutron.agent.firewall.NoopFirewallDriver\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2Bg08%3D","line":142,"in_reply_to":"AAAAWH%2F%2Bg6E%3D","updated":"2014-03-26 09:27:01.000000000","message":"Done","commit_id":"d2dbd3a70398754a553b0b852614ad1f04ef68de"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"13bcd9fc0a62aad000b80ce447f6e943dc548d1a","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        firewall_driver \u003d cfg.CONF.SECURITYGROUP.firewall_driver"},{"line_number":140,"context_line":"        LOG.debug(_(\"Init firewall settings (driver\u003d%s)\"), firewall_driver)"},{"line_number":141,"context_line":"        if not _is_valid_driver_combination():"},{"line_number":142,"context_line":"            LOG.warn(\"Driver configuration don\u0027t match \""},{"line_number":143,"context_line":"                     \"with enable_security_group\")"},{"line_number":144,"context_line":"        if not firewall_driver:"},{"line_number":145,"context_line":"            firewall_driver \u003d \u0027neutron.agent.firewall.NoopFirewallDriver\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2Boy4%3D","line":142,"in_reply_to":"AAAAWH%2F%2BpQc%3D","updated":"2014-03-25 11:39:52.000000000","message":"I am following the same handling as for Server side with is_firewall_enabled(). \nThe current patch is meant to to fix error trying to import None firewall_driver. Wondering about the same issue, is it OK to continue or should raise exception...","commit_id":"d2dbd3a70398754a553b0b852614ad1f04ef68de"}],"neutron/tests/unit/test_security_groups_rpc.py":[{"author":{"_account_id":8911,"name":"Sergey Vilgelm","email":"sergey@vilgelm.info","username":"sergey.vilgelm"},"change_message_id":"22b62fdea7493db4319410e4bc8dfbe23d0ff826","unresolved":false,"context_lines":[{"line_number":509,"context_line":"    def test_init_firewall_with_none_driver(self):"},{"line_number":510,"context_line":"        cfg.CONF.set_override("},{"line_number":511,"context_line":"            \u0027enable_security_group\u0027, False,"},{"line_number":512,"context_line":"            group\u003d\u0027SECURITYGROUP\u0027)"},{"line_number":513,"context_line":"        agent \u003d sg_rpc.SecurityGroupAgentRpcMixin()"},{"line_number":514,"context_line":"        agent.init_firewall()"},{"line_number":515,"context_line":"        self.assertEqual(agent.firewall.__class__.__name__,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2BqSE%3D","line":512,"updated":"2014-03-25 08:26:46.000000000","message":"Why without overriding \u0027firewall_driver\u0027 option to None?","commit_id":"6184647f2032b16902a3338e1cdd98d51cb78cc7"},{"author":{"_account_id":8911,"name":"Sergey Vilgelm","email":"sergey@vilgelm.info","username":"sergey.vilgelm"},"change_message_id":"b5166e3c2ddb2e6732b9bf7d30db693137f3032b","unresolved":false,"context_lines":[{"line_number":509,"context_line":"    def test_init_firewall_with_none_driver(self):"},{"line_number":510,"context_line":"        cfg.CONF.set_override("},{"line_number":511,"context_line":"            \u0027enable_security_group\u0027, False,"},{"line_number":512,"context_line":"            group\u003d\u0027SECURITYGROUP\u0027)"},{"line_number":513,"context_line":"        agent \u003d sg_rpc.SecurityGroupAgentRpcMixin()"},{"line_number":514,"context_line":"        agent.init_firewall()"},{"line_number":515,"context_line":"        self.assertEqual(agent.firewall.__class__.__name__,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2BpMU%3D","line":512,"in_reply_to":"AAAAWH%2F%2Bp7Y%3D","updated":"2014-03-26 07:57:21.000000000","message":"Ok, thanks.","commit_id":"6184647f2032b16902a3338e1cdd98d51cb78cc7"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"17f445fdaaf9ee8887848fd648fbc04956413d05","unresolved":false,"context_lines":[{"line_number":509,"context_line":"    def test_init_firewall_with_none_driver(self):"},{"line_number":510,"context_line":"        cfg.CONF.set_override("},{"line_number":511,"context_line":"            \u0027enable_security_group\u0027, False,"},{"line_number":512,"context_line":"            group\u003d\u0027SECURITYGROUP\u0027)"},{"line_number":513,"context_line":"        agent \u003d sg_rpc.SecurityGroupAgentRpcMixin()"},{"line_number":514,"context_line":"        agent.init_firewall()"},{"line_number":515,"context_line":"        self.assertEqual(agent.firewall.__class__.__name__,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2Bp7Y%3D","line":512,"in_reply_to":"AAAAWH%2F%2BqSE%3D","updated":"2014-03-25 09:27:14.000000000","message":"This is the default value in securitygroups_rpc.py","commit_id":"6184647f2032b16902a3338e1cdd98d51cb78cc7"}]}
