)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"343852b5c6d15e69ce85bf27f4ffbf4a0593f007","unresolved":true,"context_lines":[{"line_number":10,"context_line":"details without showing its connection to the associated request_id."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"That complicates debugging of corner cases for external events as we"},{"line_number":13,"context_line":"cannot be sure to which exactly request a logged event is related."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Make the request_id logged alongside external event details."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"06887292_65ad2c47","line":13,"range":{"start_line":13,"start_character":24,"end_line":13,"end_character":31},"updated":"2022-02-17 14:43:24.000000000","message":"nit: exact","commit_id":"545807190a0cbe6d0f7272ab131b19e71955ee67"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"f98655a93c39532cb2efbde010380ef3c2ebde36","unresolved":false,"context_lines":[{"line_number":10,"context_line":"details without showing its connection to the associated request_id."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"That complicates debugging of corner cases for external events as we"},{"line_number":13,"context_line":"cannot be sure to which exactly request a logged event is related."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Make the request_id logged alongside external event details."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"01ba8608_ccbdeaf3","line":13,"range":{"start_line":13,"start_character":24,"end_line":13,"end_character":31},"in_reply_to":"06887292_65ad2c47","updated":"2022-02-24 12:15:36.000000000","message":"Done","commit_id":"545807190a0cbe6d0f7272ab131b19e71955ee67"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"343852b5c6d15e69ce85bf27f4ffbf4a0593f007","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"aa343d14_aa2ed81b","updated":"2022-02-17 14:43:24.000000000","message":"I am fine with it, thanks\nDo you have perhaps bug also for the case which you need to debug?","commit_id":"545807190a0cbe6d0f7272ab131b19e71955ee67"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a49c4e1e2c9ec25dd4e3c449e794311a4167fbfa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a038f045_75fc8a1d","updated":"2022-02-22 07:26:32.000000000","message":"recheck - bug https://bugs.launchpad.net/neutron/+bug/1961740","commit_id":"545807190a0cbe6d0f7272ab131b19e71955ee67"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"cb1b96ed66bf05f48229866311209f27355d36c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5ad53f08_9dacb114","updated":"2022-02-22 08:50:39.000000000","message":"seeing errors like below:-\n\nFeb 21 12:17:21.410353 nested-virt-ubuntu-focal-ovh-bhs1-0028541600 neutron-server[71939]: DEBUG novaclient.v2.client [-] POST call to compute for https://158.69.69.206/compute/v2.1/os-server-external-events used request id req-3d8b38e1-3b5a-479b-9d10-279308652331 {{(pid\u003d71939) request /usr/local/lib/python3.8/dist-packages/keystoneauth1/session.py:954}}\nFeb 21 12:17:21.411871 nested-virt-ubuntu-focal-ovh-bhs1-0028541600 neutron-server[71939]: Traceback (most recent call last):\nFeb 21 12:17:21.411871 nested-virt-ubuntu-focal-ovh-bhs1-0028541600 neutron-server[71939]:   File \"/usr/local/lib/python3.8/dist-packages/eventlet/hubs/poll.py\", line 111, in wait\nFeb 21 12:17:21.411871 nested-virt-ubuntu-focal-ovh-bhs1-0028541600 neutron-server[71939]:     listener.cb(fileno)\nFeb 21 12:17:21.411871 nested-virt-ubuntu-focal-ovh-bhs1-0028541600 neutron-server[71939]:   File \"/opt/stack/neutron/neutron/common/utils.py\", line 921, in wrapper\nFeb 21 12:17:21.411871 nested-virt-ubuntu-focal-ovh-bhs1-0028541600 neutron-server[71939]:     return func(*args, **kwargs)\nFeb 21 12:17:21.411871 nested-virt-ubuntu-focal-ovh-bhs1-0028541600 neutron-server[71939]:   File \"/opt/stack/neutron/neutron/notifiers/batch_notifier.py\", line 58, in synced_send\nFeb 21 12:17:21.411871 nested-virt-ubuntu-focal-ovh-bhs1-0028541600 neutron-server[71939]:     self._notify()\nFeb 21 12:17:21.411871 nested-virt-ubuntu-focal-ovh-bhs1-0028541600 neutron-server[71939]:   File \"/opt/stack/neutron/neutron/notifiers/batch_notifier.py\", line 69, in _notify\nFeb 21 12:17:21.411871 nested-virt-ubuntu-focal-ovh-bhs1-0028541600 neutron-server[71939]:     self.callback(batched_events)\nFeb 21 12:17:21.411871 nested-virt-ubuntu-focal-ovh-bhs1-0028541600 neutron-server[71939]:   File \"/opt/stack/neutron/neutron/notifiers/nova.py\", line 299, in send_events\nFeb 21 12:17:21.411871 nested-virt-ubuntu-focal-ovh-bhs1-0028541600 neutron-server[71939]:     response.request_id, event)\nFeb 21 12:17:21.411871 nested-virt-ubuntu-focal-ovh-bhs1-0028541600 neutron-server[71939]: AttributeError: \u0027ListWithMeta\u0027 object has no attribute \u0027request_id\u0027\n\nexample log https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_f66/828687/1/gate/neutron-tempest-plugin-scenario-openvswitch/f66514c/controller/logs/screen-q-svc.txt","commit_id":"545807190a0cbe6d0f7272ab131b19e71955ee67"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"46cc0449de4cc4c6c7b6a74e9cbe018d2e126ebe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ec4055de_a403027c","in_reply_to":"57470107_00508fdd","updated":"2022-02-24 11:59:15.000000000","message":"I thought oslo middleware generates it if missing, will update to log it if defined","commit_id":"545807190a0cbe6d0f7272ab131b19e71955ee67"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"7d652219bd87eb7da9f719f3bda0aa8600e57ea0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"57470107_00508fdd","in_reply_to":"5ad53f08_9dacb114","updated":"2022-02-22 10:04:06.000000000","message":"Yatin is right, not all clients have \"response_id\" [1]\n\n[1]https://opendev.org/openstack/python-cinderclient/src/branch/master/cinderclient/apiclient/base.py","commit_id":"545807190a0cbe6d0f7272ab131b19e71955ee67"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"269eb9c5ddf40fee823d69d14777404da3a8d636","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"ecf4a330_f954ec8c","updated":"2022-03-17 10:43:21.000000000","message":"@bogdan i forgot about it, restore please, i will push the patch to fix it.","commit_id":"759b82f1d06aa3857b2a7902ad492eb7b42cfa51"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"ad63949ae9d68010295e9fa5923c0db48a492883","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"35b00066_083f02a3","updated":"2022-03-17 10:54:27.000000000","message":"@yatin, please go ahead, thanks!","commit_id":"759b82f1d06aa3857b2a7902ad492eb7b42cfa51"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"eb3e168a22a296161e94bc218cb247ae01f79967","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"831124a4_aa6e740d","updated":"2022-03-04 16:04:55.000000000","message":"I\u0027m sorry but continuation of this effort requires way more deeper knowledge of Neutron than I have.\nClosing.","commit_id":"759b82f1d06aa3857b2a7902ad492eb7b42cfa51"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"8698eff4f164405ec223cb53e6a4fac9123e1ff6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"dda63c67_1915af95","in_reply_to":"35b00066_083f02a3","updated":"2022-03-17 11:11:26.000000000","message":"Thanks. latest patch should properly log the request_ids, i have dropped request_id and just kept request_ids as i only found that being set. Let\u0027s see how it goes now.","commit_id":"759b82f1d06aa3857b2a7902ad492eb7b42cfa51"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"2e957333f4d6a804917cb86ba7d1d1fe0539ed90","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"38f7287f_816798a6","in_reply_to":"5035a7ed_359f25ce","updated":"2022-03-07 10:18:06.000000000","message":"thank you for catching this up, let me know and I\u0027ll reopen it.\nThe background is provided in the commit message. There is no a defect to fix, just a logging improvement to simplify tracking of causality of external events aiming help to debug things.","commit_id":"759b82f1d06aa3857b2a7902ad492eb7b42cfa51"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"6baf52409c93b1cb9b8aae7fdc6427198c81c106","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"5035a7ed_359f25ce","in_reply_to":"831124a4_aa6e740d","updated":"2022-03-04 16:28:48.000000000","message":"Actually i think it\u0027s straight forward, you patch set 1 should have worked fine if used request_ids(you had used request_id). And for safety we have to check if request_ids is in the response object or not, for that can use hasattr or getattr.\nIf this patch really required i can help out next week.\nMay be can u share background or bug link which created motivation for this patch, that should help in understanding what case we need to cover or what case we can missout?","commit_id":"759b82f1d06aa3857b2a7902ad492eb7b42cfa51"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"7471dde4b091a5b5c93d8d8666bbc2d239fa2b48","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"967889c4_c059ad14","updated":"2022-03-17 13:00:22.000000000","message":"It\u0027s being logged fine now like[1][2]:-\nMar 17 11:54:44.836691 nested-virt-ubuntu-focal-vexxhost-ca-ymq-1-0028868161 neutron-server[71814]: INFO neutron.notifiers.nova [-] Nova event matching [\u0027req-53a1c9c1-2097-4843-bde5-8e3ac5366e44\u0027] response: {\u0027server_uuid\u0027: \u002760819d2d-2d10-4304-bd30-575f483002c0\u0027, \u0027name\u0027: \u0027network-vif-plugged\u0027, \u0027status\u0027: \u0027completed\u0027, \u0027tag\u0027: \u00276c6c9434-0fd3-44c9-8c01-3fb498041e6d\u0027, \u0027code\u0027: 200}\n\n[1] https://82aeb71d4c2ef828072a-87e6ec00760ed1d0ee3af698b2b27828.ssl.cf5.rackcdn.com/828687/8/check/neutron-tempest-plugin-scenario-ovn/e2c7115/controller/logs/screen-q-svc.txt\n[2] https://6a807d47cb361b68fc49-d5a2c2135ef34e5fcff72992ca5eb476.ssl.cf5.rackcdn.com/828687/8/check/neutron-tempest-plugin-scenario-openvswitch/9b978ec/controller/logs/screen-q-svc.txt\n\n\n","commit_id":"7cedbdeabae6c520dcdd56007d288cd351fb3269"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"3b2db38e6d980488af2785d041f7da28f0ea36a3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"b05922ce_4c738a0c","updated":"2022-03-17 14:56:01.000000000","message":"\\o/ it works like a charm, see q-svc logs [0]\n\n...Nova event matching [\u0027req-de8f4084-b598-4be0-a81a-23cb9e02c6ff\u0027] response: ...\n\n[0] https://a340eb04c9bdc60233e3-f794ac2492944f87fa91e71db0988d60.ssl.cf1.rackcdn.com/828687/8/check/neutron-ovs-tempest-multinode-full/4f9ae38/controller/logs/index.html","commit_id":"7cedbdeabae6c520dcdd56007d288cd351fb3269"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"78035fca37e02a0a7bac99de91f46f6c827198a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"77b6984c_5f1b42b4","updated":"2022-03-18 10:36:06.000000000","message":"could you please merge?","commit_id":"7cedbdeabae6c520dcdd56007d288cd351fb3269"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"bb1898823479b62b67244ed5782f05b3bc062717","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"e8d9b1ae_fce372ac","updated":"2022-03-22 05:28:08.000000000","message":"recheck functional test test_good_address_allocation timeout","commit_id":"7cedbdeabae6c520dcdd56007d288cd351fb3269"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"467e6af97544678e85d83f762dc1c3c4dafbe57d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"f543caeb_7d595968","updated":"2022-03-22 09:35:56.000000000","message":"thank you Yatin, Miguel and Oleg for moving this forward. A better logging serves the greater goodness.","commit_id":"7cedbdeabae6c520dcdd56007d288cd351fb3269"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"12e672983ad1df20911167f60c60fc99fb5a44bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"1a5374fd_cc11d898","updated":"2022-03-17 14:53:04.000000000","message":"thanks yatin!","commit_id":"7cedbdeabae6c520dcdd56007d288cd351fb3269"}],"neutron/notifiers/nova.py":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"bc9c38a528a3338b7bd1597c1f0371b03edf82a7","unresolved":true,"context_lines":[{"line_number":291,"context_line":"                except KeyError:"},{"line_number":292,"context_line":"                    response_error \u003d True"},{"line_number":293,"context_line":"                    continue"},{"line_number":294,"context_line":"                if \u0027request_id\u0027 in respone:"},{"line_number":295,"context_line":"                    msg \u003d \"Nova event for {}\".format(response.request_id)"},{"line_number":296,"context_line":"                else:"},{"line_number":297,"context_line":"                    msg \u003d \"Nova event for\""}],"source_content_type":"text/x-python","patch_set":4,"id":"299eef3a_578c7b8e","line":294,"range":{"start_line":294,"start_character":20,"end_line":294,"end_character":30},"updated":"2022-02-25 12:17:42.000000000","message":"I think you want to use \"request_ids\"[1][2] instead of \"request_id\". request_ids is a list of request_id. If right PS1 should have worked too.\n\n[1] https://opendev.org/openstack/python-novaclient/src/branch/master/novaclient/base.py#L85-L86\n[2] https://opendev.org/openstack/python-cinderclient/src/branch/master/cinderclient/apiclient/base.py#L412-L413","commit_id":"4dfe29a95e2dcabece2d9b967a86536d5314a974"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"be984ea4bf2cb0441cadf15c5deaf63a7b867240","unresolved":false,"context_lines":[{"line_number":291,"context_line":"                except KeyError:"},{"line_number":292,"context_line":"                    response_error \u003d True"},{"line_number":293,"context_line":"                    continue"},{"line_number":294,"context_line":"                if \u0027request_id\u0027 in respone:"},{"line_number":295,"context_line":"                    msg \u003d \"Nova event for {}\".format(response.request_id)"},{"line_number":296,"context_line":"                else:"},{"line_number":297,"context_line":"                    msg \u003d \"Nova event for\""}],"source_content_type":"text/x-python","patch_set":4,"id":"89095b05_f68efd12","line":294,"range":{"start_line":294,"start_character":20,"end_line":294,"end_character":30},"in_reply_to":"210d7289_8654f5e6","updated":"2022-02-25 14:27:38.000000000","message":"Done","commit_id":"4dfe29a95e2dcabece2d9b967a86536d5314a974"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"317fb827db447c78c16af3ecc8d0facc7693f34c","unresolved":true,"context_lines":[{"line_number":291,"context_line":"                except KeyError:"},{"line_number":292,"context_line":"                    response_error \u003d True"},{"line_number":293,"context_line":"                    continue"},{"line_number":294,"context_line":"                if \u0027request_id\u0027 in respone:"},{"line_number":295,"context_line":"                    msg \u003d \"Nova event for {}\".format(response.request_id)"},{"line_number":296,"context_line":"                else:"},{"line_number":297,"context_line":"                    msg \u003d \"Nova event for\""}],"source_content_type":"text/x-python","patch_set":4,"id":"210d7289_8654f5e6","line":294,"range":{"start_line":294,"start_character":20,"end_line":294,"end_character":30},"in_reply_to":"299eef3a_578c7b8e","updated":"2022-02-25 14:23:17.000000000","message":"I think we need request_id for the best match? But if it is not there, we could log the request_ids contents as well (it\u0027s better than nothing!). But I better off to keep the safe-check for request_ids in the dict as well.","commit_id":"4dfe29a95e2dcabece2d9b967a86536d5314a974"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"54b9687eeef9e5a21c8b6709f6bc38a0816ecec9","unresolved":false,"context_lines":[{"line_number":291,"context_line":"                except KeyError:"},{"line_number":292,"context_line":"                    response_error \u003d True"},{"line_number":293,"context_line":"                    continue"},{"line_number":294,"context_line":"                if \u0027request_id\u0027 in respone:"},{"line_number":295,"context_line":"                    msg \u003d \"Nova event for {}\".format(response.request_id)"},{"line_number":296,"context_line":"                else:"},{"line_number":297,"context_line":"                    msg \u003d \"Nova event for\""}],"source_content_type":"text/x-python","patch_set":4,"id":"beaa9ecf_87e1d595","line":294,"range":{"start_line":294,"start_character":20,"end_line":294,"end_character":30},"in_reply_to":"89095b05_f68efd12","updated":"2022-02-25 14:30:55.000000000","message":"where is request_id, can you share pointers? from the last link i shared i only see request_ids.\nIf request_id is available for some case then ok to check for it else it\u0027s just extra.","commit_id":"4dfe29a95e2dcabece2d9b967a86536d5314a974"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"4349aad073665a6cae67c90edffb84d92675c2fd","unresolved":false,"context_lines":[{"line_number":291,"context_line":"                except KeyError:"},{"line_number":292,"context_line":"                    response_error \u003d True"},{"line_number":293,"context_line":"                    continue"},{"line_number":294,"context_line":"                if \u0027request_id\u0027 in respone:"},{"line_number":295,"context_line":"                    msg \u003d \"Nova event for {}\".format(response.request_id)"},{"line_number":296,"context_line":"                else:"},{"line_number":297,"context_line":"                    msg \u003d \"Nova event for\""}],"source_content_type":"text/x-python","patch_set":4,"id":"ec059293_e3eb45ef","line":294,"range":{"start_line":294,"start_character":20,"end_line":294,"end_character":30},"in_reply_to":"beaa9ecf_87e1d595","updated":"2022-02-28 12:03:33.000000000","message":"I would gladly do that, if anyone kindly points me a CI job with this code in use","commit_id":"4dfe29a95e2dcabece2d9b967a86536d5314a974"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"7fce962756a4971a7bea9933cbd8a3de18e34d89","unresolved":false,"context_lines":[{"line_number":291,"context_line":"                except KeyError:"},{"line_number":292,"context_line":"                    response_error \u003d True"},{"line_number":293,"context_line":"                    continue"},{"line_number":294,"context_line":"                if \u0027request_id\u0027 in respone:"},{"line_number":295,"context_line":"                    msg \u003d \"Nova event for {}\".format(response.request_id)"},{"line_number":296,"context_line":"                else:"},{"line_number":297,"context_line":"                    msg \u003d \"Nova event for\""}],"source_content_type":"text/x-python","patch_set":4,"id":"e5202d2b_06abf5cc","line":294,"range":{"start_line":294,"start_character":20,"end_line":294,"end_character":30},"in_reply_to":"ec059293_e3eb45ef","updated":"2022-02-28 12:14:34.000000000","message":"I\u0027ll check in the CI logs now...","commit_id":"4dfe29a95e2dcabece2d9b967a86536d5314a974"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"3e085b0756a3c0dbc43a61354b2e1d398b2e160c","unresolved":true,"context_lines":[{"line_number":294,"context_line":"                if \u0027request_id\u0027 in respone:"},{"line_number":295,"context_line":"                    msg \u003d \"Nova event for {}\".format(response.request_id)"},{"line_number":296,"context_line":"                else:"},{"line_number":297,"context_line":"                    msg \u003d \"Nova event for\""},{"line_number":298,"context_line":"                if code !\u003d 200:"},{"line_number":299,"context_line":"                    LOG.warning(\"%s: %s returned with failed \""},{"line_number":300,"context_line":"                                \"status\", msg, event)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dab4bd92_b3b022a3","line":297,"range":{"start_line":297,"start_character":38,"end_line":297,"end_character":41},"updated":"2022-02-25 10:34:51.000000000","message":"nit: why this for?","commit_id":"4dfe29a95e2dcabece2d9b967a86536d5314a974"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"be984ea4bf2cb0441cadf15c5deaf63a7b867240","unresolved":false,"context_lines":[{"line_number":294,"context_line":"                if \u0027request_id\u0027 in respone:"},{"line_number":295,"context_line":"                    msg \u003d \"Nova event for {}\".format(response.request_id)"},{"line_number":296,"context_line":"                else:"},{"line_number":297,"context_line":"                    msg \u003d \"Nova event for\""},{"line_number":298,"context_line":"                if code !\u003d 200:"},{"line_number":299,"context_line":"                    LOG.warning(\"%s: %s returned with failed \""},{"line_number":300,"context_line":"                                \"status\", msg, event)"}],"source_content_type":"text/x-python","patch_set":4,"id":"2af54fdc_ae77f017","line":297,"range":{"start_line":297,"start_character":38,"end_line":297,"end_character":41},"in_reply_to":"489c0e54_6f2de7be","updated":"2022-02-25 14:27:38.000000000","message":"Done","commit_id":"4dfe29a95e2dcabece2d9b967a86536d5314a974"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"19cae536d2999ac4f53f9e827803f4b579c7d419","unresolved":true,"context_lines":[{"line_number":294,"context_line":"                if \u0027request_id\u0027 in respone:"},{"line_number":295,"context_line":"                    msg \u003d \"Nova event for {}\".format(response.request_id)"},{"line_number":296,"context_line":"                else:"},{"line_number":297,"context_line":"                    msg \u003d \"Nova event for\""},{"line_number":298,"context_line":"                if code !\u003d 200:"},{"line_number":299,"context_line":"                    LOG.warning(\"%s: %s returned with failed \""},{"line_number":300,"context_line":"                                \"status\", msg, event)"}],"source_content_type":"text/x-python","patch_set":4,"id":"73bf4f78_4ddbefc8","line":297,"range":{"start_line":297,"start_character":38,"end_line":297,"end_character":41},"in_reply_to":"dab4bd92_b3b022a3","updated":"2022-02-25 10:40:55.000000000","message":"assuming event is matching \"for\" req-Id... I can remove that, if the wording looked confusing","commit_id":"4dfe29a95e2dcabece2d9b967a86536d5314a974"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a88cae3a82f70e22863b9b26f5128dee645b17c3","unresolved":true,"context_lines":[{"line_number":294,"context_line":"                if \u0027request_id\u0027 in respone:"},{"line_number":295,"context_line":"                    msg \u003d \"Nova event for {}\".format(response.request_id)"},{"line_number":296,"context_line":"                else:"},{"line_number":297,"context_line":"                    msg \u003d \"Nova event for\""},{"line_number":298,"context_line":"                if code !\u003d 200:"},{"line_number":299,"context_line":"                    LOG.warning(\"%s: %s returned with failed \""},{"line_number":300,"context_line":"                                \"status\", msg, event)"}],"source_content_type":"text/x-python","patch_set":4,"id":"489c0e54_6f2de7be","line":297,"range":{"start_line":297,"start_character":38,"end_line":297,"end_character":41},"in_reply_to":"dab4bd92_b3b022a3","updated":"2022-02-25 10:44:37.000000000","message":"this will render as \n\"Nova event for: \u003cevent name\u003e returned with failed status\"\nin the fail case and \n\"Nova event for responce: \u003cevent name\u003e\"\nin the succes case if the request id is not present.\n\n\nso the use of for seam ok to me.\n\nif you were to remove for i would remote it in the if branc too not jsut the else","commit_id":"4dfe29a95e2dcabece2d9b967a86536d5314a974"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"54b9687eeef9e5a21c8b6709f6bc38a0816ecec9","unresolved":true,"context_lines":[{"line_number":291,"context_line":"                except KeyError:"},{"line_number":292,"context_line":"                    response_error \u003d True"},{"line_number":293,"context_line":"                    continue"},{"line_number":294,"context_line":"                if \u0027request_id\u0027 in respone:"},{"line_number":295,"context_line":"                    msg \u003d \"Nova event matching {}\".format(response.request_id)"},{"line_number":296,"context_line":"                elif \u0027request_ids\u0027 in respone:"},{"line_number":297,"context_line":"                    msg \u003d \"Nova event matching {}\".format(response.request_ids)"}],"source_content_type":"text/x-python","patch_set":5,"id":"aa3f642d_56085bb9","line":294,"range":{"start_line":294,"start_character":35,"end_line":294,"end_character":42},"updated":"2022-02-25 14:30:55.000000000","message":"response","commit_id":"c177d82c2a4bef1086c8f8b67efab3825170c852"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"d07012a962603ff6b93ec9b5cbdbbf59630f82ef","unresolved":false,"context_lines":[{"line_number":291,"context_line":"                except KeyError:"},{"line_number":292,"context_line":"                    response_error \u003d True"},{"line_number":293,"context_line":"                    continue"},{"line_number":294,"context_line":"                if \u0027request_id\u0027 in respone:"},{"line_number":295,"context_line":"                    msg \u003d \"Nova event matching {}\".format(response.request_id)"},{"line_number":296,"context_line":"                elif \u0027request_ids\u0027 in respone:"},{"line_number":297,"context_line":"                    msg \u003d \"Nova event matching {}\".format(response.request_ids)"}],"source_content_type":"text/x-python","patch_set":5,"id":"b43156a4_5f68c496","line":294,"range":{"start_line":294,"start_character":35,"end_line":294,"end_character":42},"in_reply_to":"aa3f642d_56085bb9","updated":"2022-02-28 12:14:48.000000000","message":"Done","commit_id":"c177d82c2a4bef1086c8f8b67efab3825170c852"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"54b9687eeef9e5a21c8b6709f6bc38a0816ecec9","unresolved":true,"context_lines":[{"line_number":293,"context_line":"                    continue"},{"line_number":294,"context_line":"                if \u0027request_id\u0027 in respone:"},{"line_number":295,"context_line":"                    msg \u003d \"Nova event matching {}\".format(response.request_id)"},{"line_number":296,"context_line":"                elif \u0027request_ids\u0027 in respone:"},{"line_number":297,"context_line":"                    msg \u003d \"Nova event matching {}\".format(response.request_ids)"},{"line_number":298,"context_line":"                else"},{"line_number":299,"context_line":"                    msg \u003d \"Nova event\""}],"source_content_type":"text/x-python","patch_set":5,"id":"10d28065_7dd86486","line":296,"range":{"start_line":296,"start_character":38,"end_line":296,"end_character":45},"updated":"2022-02-25 14:30:55.000000000","message":"ditto","commit_id":"c177d82c2a4bef1086c8f8b67efab3825170c852"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"d07012a962603ff6b93ec9b5cbdbbf59630f82ef","unresolved":false,"context_lines":[{"line_number":293,"context_line":"                    continue"},{"line_number":294,"context_line":"                if \u0027request_id\u0027 in respone:"},{"line_number":295,"context_line":"                    msg \u003d \"Nova event matching {}\".format(response.request_id)"},{"line_number":296,"context_line":"                elif \u0027request_ids\u0027 in respone:"},{"line_number":297,"context_line":"                    msg \u003d \"Nova event matching {}\".format(response.request_ids)"},{"line_number":298,"context_line":"                else"},{"line_number":299,"context_line":"                    msg \u003d \"Nova event\""}],"source_content_type":"text/x-python","patch_set":5,"id":"b6259243_6c097e9f","line":296,"range":{"start_line":296,"start_character":38,"end_line":296,"end_character":45},"in_reply_to":"10d28065_7dd86486","updated":"2022-02-28 12:14:48.000000000","message":"Done","commit_id":"c177d82c2a4bef1086c8f8b67efab3825170c852"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"2ed335e4ad2fc85a309c4e4471c3b85014bb4ac8","unresolved":true,"context_lines":[{"line_number":291,"context_line":"                except KeyError:"},{"line_number":292,"context_line":"                    response_error \u003d True"},{"line_number":293,"context_line":"                    continue"},{"line_number":294,"context_line":"                if \u0027request_id\u0027 in response:"},{"line_number":295,"context_line":"                    msg \u003d \"Nova event matching {}\".format(response.request_id)"},{"line_number":296,"context_line":"                elif \u0027request_ids\u0027 in response:"},{"line_number":297,"context_line":"                    msg \u003d \"Nova event matching {}\".format(response.request_ids)"}],"source_content_type":"text/x-python","patch_set":7,"id":"98879d45_bda0fde6","line":294,"range":{"start_line":294,"start_character":35,"end_line":294,"end_character":43},"updated":"2022-03-04 10:12:48.000000000","message":"this should be event, as response is a list of events","commit_id":"759b82f1d06aa3857b2a7902ad492eb7b42cfa51"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"2ed335e4ad2fc85a309c4e4471c3b85014bb4ac8","unresolved":true,"context_lines":[{"line_number":293,"context_line":"                    continue"},{"line_number":294,"context_line":"                if \u0027request_id\u0027 in response:"},{"line_number":295,"context_line":"                    msg \u003d \"Nova event matching {}\".format(response.request_id)"},{"line_number":296,"context_line":"                elif \u0027request_ids\u0027 in response:"},{"line_number":297,"context_line":"                    msg \u003d \"Nova event matching {}\".format(response.request_ids)"},{"line_number":298,"context_line":"                else:"},{"line_number":299,"context_line":"                    msg \u003d \"Nova event\""}],"source_content_type":"text/x-python","patch_set":7,"id":"46516434_37d9e25f","line":296,"range":{"start_line":296,"start_character":38,"end_line":296,"end_character":46},"updated":"2022-03-04 10:12:48.000000000","message":"ditto","commit_id":"759b82f1d06aa3857b2a7902ad492eb7b42cfa51"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"2a2e8c118868c6b170dab772ba4500da56c295d3","unresolved":true,"context_lines":[{"line_number":291,"context_line":"                except KeyError:"},{"line_number":292,"context_line":"                    response_error \u003d True"},{"line_number":293,"context_line":"                    continue"},{"line_number":294,"context_line":"                if \u0027request_id\u0027 in response:"},{"line_number":295,"context_line":"                    msg \u003d \"Nova event matching {}\".format(response.request_id)"},{"line_number":296,"context_line":"                elif \u0027request_ids\u0027 in response:"},{"line_number":297,"context_line":"                    msg \u003d \"Nova event matching {}\".format(response.request_ids)"},{"line_number":298,"context_line":"                else:"},{"line_number":299,"context_line":"                    msg \u003d \"Nova event\""},{"line_number":300,"context_line":"                if code !\u003d 200:"},{"line_number":301,"context_line":"                    LOG.warning(\"%s: %s returned with failed \""},{"line_number":302,"context_line":"                                \"status\", msg, event)"},{"line_number":303,"context_line":"                else:"},{"line_number":304,"context_line":"                    LOG.info(\"%s response: %s\", msg, event)"},{"line_number":305,"context_line":"            if response_error:"}],"source_content_type":"text/x-python","patch_set":7,"id":"18395d21_0ef8b3fd","line":302,"range":{"start_line":294,"start_character":14,"end_line":302,"end_character":53},"updated":"2022-03-04 08:34:12.000000000","message":"still not working, sorry i should have checked before workflow.\n\nhttps://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_090/828687/7/check/neutron-tempest-plugin-scenario-openvswitch/0900938/controller/logs/screen-q-svc.txt\n\n@bogdan you checked from where request_id is comming from? we found request_ids as shared in previous links, also i think u need to search as class attributes instead of using \"in response\".","commit_id":"759b82f1d06aa3857b2a7902ad492eb7b42cfa51"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"2ed335e4ad2fc85a309c4e4471c3b85014bb4ac8","unresolved":true,"context_lines":[{"line_number":291,"context_line":"                except KeyError:"},{"line_number":292,"context_line":"                    response_error \u003d True"},{"line_number":293,"context_line":"                    continue"},{"line_number":294,"context_line":"                if \u0027request_id\u0027 in response:"},{"line_number":295,"context_line":"                    msg \u003d \"Nova event matching {}\".format(response.request_id)"},{"line_number":296,"context_line":"                elif \u0027request_ids\u0027 in response:"},{"line_number":297,"context_line":"                    msg \u003d \"Nova event matching {}\".format(response.request_ids)"},{"line_number":298,"context_line":"                else:"},{"line_number":299,"context_line":"                    msg \u003d \"Nova event\""},{"line_number":300,"context_line":"                if code !\u003d 200:"},{"line_number":301,"context_line":"                    LOG.warning(\"%s: %s returned with failed \""},{"line_number":302,"context_line":"                                \"status\", msg, event)"},{"line_number":303,"context_line":"                else:"},{"line_number":304,"context_line":"                    LOG.info(\"%s response: %s\", msg, event)"},{"line_number":305,"context_line":"            if response_error:"}],"source_content_type":"text/x-python","patch_set":7,"id":"cde2991a_a68f4571","line":302,"range":{"start_line":294,"start_character":14,"end_line":302,"end_character":53},"in_reply_to":"18395d21_0ef8b3fd","updated":"2022-03-04 10:12:48.000000000","message":"In my env event is a dict with keys: {name: \"\", server_uuid: \"\", tag: \"\", status: \"\", code: \"\"}\nso request_ids should be somewhere else as yatin wrote","commit_id":"759b82f1d06aa3857b2a7902ad492eb7b42cfa51"}]}