)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"0e6c525d8d7108da525c71281d9b8208a3cae097","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1aceb8ed_6c5050ad","updated":"2022-02-17 09:57:58.000000000","message":"That wasn\u0027t my idea of fixing this issue. Instead of this, we should make \"DriverBase\" and \"LoggingApiNotification\" inherit from the same API class (a new one implementing the methods described in [1]\n\n[1]https://github.com/openstack/neutron-lib/blob/master/neutron_lib/services/logapi/constants.py#L38-L44","commit_id":"155420d80b336ca0e5019c7ca2fa32a77ff7fac4"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"37dde756a77d6286eb531e4547e468377c14203b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d2c3f825_7d0c57e2","updated":"2022-02-17 08:44:31.000000000","message":"makes sense","commit_id":"155420d80b336ca0e5019c7ca2fa32a77ff7fac4"},{"author":{"_account_id":32667,"name":"Mamatisa Nurmatov","email":"nurmatov.mamatisa@huawei.com","username":"isabek"},"change_message_id":"bb4666c0612da40cfe8b40ea5847d62903a731f7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"98b4db06_e60152f4","in_reply_to":"1aceb8ed_6c5050ad","updated":"2022-02-17 11:17:09.000000000","message":"But this will require changes in all handlers of LOGGING_RESOURCE events including possible handlers in advanced services outside main neutron.\nCurrent handlers only need \u0027created\u0027 \u0027updated\u0027 \u0027deleted\u0027 events, so \u0027precommit\u0027 is not needed for them.\nDo you think it is worth change event type?","commit_id":"155420d80b336ca0e5019c7ca2fa32a77ff7fac4"},{"author":{"_account_id":32667,"name":"Mamatisa Nurmatov","email":"nurmatov.mamatisa@huawei.com","username":"isabek"},"change_message_id":"232b138df12280ace880b7ed7b51cb1bc4a04261","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"15ab6958_860db0fc","in_reply_to":"98b4db06_e60152f4","updated":"2022-02-17 11:32:50.000000000","message":"Sorry, Now I see what you mean","commit_id":"155420d80b336ca0e5019c7ca2fa32a77ff7fac4"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"0579c684b6bdace85471208ba7175287c86bc83f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ae8dfe48_e3fd54fb","updated":"2022-02-17 15:22:59.000000000","message":"Make LoggingApiBase abstract\n\nGood patch!","commit_id":"8b63bca5b63bbe16e2ab9f45f5c1e6741e10c118"},{"author":{"_account_id":32667,"name":"Mamatisa Nurmatov","email":"nurmatov.mamatisa@huawei.com","username":"isabek"},"change_message_id":"710156ad592d9d9d8cdcbf3cd4944dd755b4bf48","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"22ca8a2f_9f1d1cc3","updated":"2022-02-19 11:22:50.000000000","message":"recheck","commit_id":"1aeef5a74e82e97cbed7d65a1f824dbb3070af08"},{"author":{"_account_id":32667,"name":"Mamatisa Nurmatov","email":"nurmatov.mamatisa@huawei.com","username":"isabek"},"change_message_id":"d13e5be39d0d902a36254da87206140f543b33ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"610193ad_cad7fea8","updated":"2022-02-21 07:00:34.000000000","message":"recheck","commit_id":"1aeef5a74e82e97cbed7d65a1f824dbb3070af08"},{"author":{"_account_id":32667,"name":"Mamatisa Nurmatov","email":"nurmatov.mamatisa@huawei.com","username":"isabek"},"change_message_id":"adee09cb8ccd65bf3d7ce2433d3c32b497ab74cc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"86de6d47_deebeb81","updated":"2022-02-19 06:17:37.000000000","message":"recheck ","commit_id":"1aeef5a74e82e97cbed7d65a1f824dbb3070af08"}],"neutron/services/logapi/api_base.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"0579c684b6bdace85471208ba7175287c86bc83f","unresolved":true,"context_lines":[{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"class LoggingApiBase:"},{"line_number":15,"context_line":"    \"\"\"Logging API methods\"\"\""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    def create_log(self, context, log_obj):"}],"source_content_type":"text/x-python","patch_set":3,"id":"47c91f09_5fd975d3","line":14,"range":{"start_line":14,"start_character":6,"end_line":14,"end_character":20},"updated":"2022-02-17 15:22:59.000000000","message":"+1 this is exactly what I was looking for\n\nNOTE: make this class abstract","commit_id":"8b63bca5b63bbe16e2ab9f45f5c1e6741e10c118"},{"author":{"_account_id":32667,"name":"Mamatisa Nurmatov","email":"nurmatov.mamatisa@huawei.com","username":"isabek"},"change_message_id":"8807ea282840995c03604938c7eaf4f913e12476","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"class LoggingApiBase:"},{"line_number":15,"context_line":"    \"\"\"Logging API methods\"\"\""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    def create_log(self, context, log_obj):"}],"source_content_type":"text/x-python","patch_set":3,"id":"0af2e278_abc5bb57","line":14,"range":{"start_line":14,"start_character":6,"end_line":14,"end_character":20},"in_reply_to":"47c91f09_5fd975d3","updated":"2022-02-17 16:06:21.000000000","message":"Done","commit_id":"8b63bca5b63bbe16e2ab9f45f5c1e6741e10c118"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a9583ea318e4a91548746714d2562956e828ea98","unresolved":true,"context_lines":[{"line_number":16,"context_line":"class LoggingApiBase(object, metaclass\u003dabc.ABCMeta):"},{"line_number":17,"context_line":"    \"\"\"Logging API methods\"\"\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    @abc.abstractmethod"},{"line_number":20,"context_line":"    def create_log(self, context, log_obj):"},{"line_number":21,"context_line":"        \"\"\"Create a log_obj invocation."},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9a210e57_c07e11c9","line":19,"range":{"start_line":19,"start_character":4,"end_line":19,"end_character":23},"updated":"2022-02-18 16:01:35.000000000","message":"I don\u0027t like this inconsistency defining abstract methods. Why \"create_log\" is and \"create_log_precommit\" not? (I know the easy answer: because then we don\u0027t need to reimplement them in LoggingApiNotification, but this is not a reason).","commit_id":"08a0e7ffe46449925774751ef5fab0250190a63d"},{"author":{"_account_id":32667,"name":"Mamatisa Nurmatov","email":"nurmatov.mamatisa@huawei.com","username":"isabek"},"change_message_id":"9ffa20baa378b0ac0bb6b543b223f6b248b6b4d7","unresolved":false,"context_lines":[{"line_number":16,"context_line":"class LoggingApiBase(object, metaclass\u003dabc.ABCMeta):"},{"line_number":17,"context_line":"    \"\"\"Logging API methods\"\"\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    @abc.abstractmethod"},{"line_number":20,"context_line":"    def create_log(self, context, log_obj):"},{"line_number":21,"context_line":"        \"\"\"Create a log_obj invocation."},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5301729e_877f77b7","line":19,"range":{"start_line":19,"start_character":4,"end_line":19,"end_character":23},"in_reply_to":"9a210e57_c07e11c9","updated":"2022-02-18 17:33:21.000000000","message":"Done","commit_id":"08a0e7ffe46449925774751ef5fab0250190a63d"}]}