)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"2c8c10ae72c94208a8b65513ceb260e89dd14a70","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e642b0b0_e8b48e3a","updated":"2022-02-25 09:06:19.000000000","message":"recheck neutron-tempest-plugin-designate-scenario test fail","commit_id":"22f1c99453e933ec0bcb2be2a8e258d91768ae4c"}],"zuul.d/project.yaml":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"0d2b16303862c18de40e55235132936dc9d2239e","unresolved":true,"context_lines":[{"line_number":15,"context_line":"      - release-notes-jobs-python3"},{"line_number":16,"context_line":"      - neutron-experimental-jobs"},{"line_number":17,"context_line":"      - neutron-periodic-jobs"},{"line_number":18,"context_line":"      - neutron-tox-override-jobs"},{"line_number":19,"context_line":"    check:"},{"line_number":20,"context_line":"      jobs:"},{"line_number":21,"context_line":"        - neutron-functional-with-uwsgi"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"448b5302_d42eae6f","line":18,"range":{"start_line":18,"start_character":8,"end_line":18,"end_character":33},"updated":"2022-02-25 10:48:45.000000000","message":"I wouldn\u0027t move this, I don\u0027t understand the rationale.\n\nI prefer having the check and the gate job definitions in one place.","commit_id":"22f1c99453e933ec0bcb2be2a8e258d91768ae4c"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"e0987563317f2e31f3a1808bed78521b5e1f6238","unresolved":true,"context_lines":[{"line_number":15,"context_line":"      - release-notes-jobs-python3"},{"line_number":16,"context_line":"      - neutron-experimental-jobs"},{"line_number":17,"context_line":"      - neutron-periodic-jobs"},{"line_number":18,"context_line":"      - neutron-tox-override-jobs"},{"line_number":19,"context_line":"    check:"},{"line_number":20,"context_line":"      jobs:"},{"line_number":21,"context_line":"        - neutron-functional-with-uwsgi"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ef54e748_b1cc225b","line":18,"range":{"start_line":18,"start_character":8,"end_line":18,"end_character":33},"in_reply_to":"448b5302_d42eae6f","updated":"2022-02-25 11:13:54.000000000","message":"@rodolfo mainly wanted to keep the layout file clean(avoid injecting long list of irrelevant files here) + also want to get these jobs running when we change the overrides in future but skip other jobs.\nWe already using many project-templates, also we don\u0027t manage definition of the tox jobs just do override them for our needs and to get future changes to these jobs and pipelines efficient, some examples of future patches:-\nhttps://review.opendev.org/c/openstack/neutron/+/830812\nhttps://review.opendev.org/c/openstack/neutron/+/827302\nhttps://review.opendev.org/c/openstack/neutron/+/830623\n\npast patch https://review.opendev.org/c/openstack/neutron/+/819201 which took much time to get in, there can be many such examples.","commit_id":"22f1c99453e933ec0bcb2be2a8e258d91768ae4c"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"40d5edaf6aa27e6026856b2a7c2e9c9d7035aeaa","unresolved":true,"context_lines":[{"line_number":15,"context_line":"      - release-notes-jobs-python3"},{"line_number":16,"context_line":"      - neutron-experimental-jobs"},{"line_number":17,"context_line":"      - neutron-periodic-jobs"},{"line_number":18,"context_line":"      - neutron-tox-override-jobs"},{"line_number":19,"context_line":"    check:"},{"line_number":20,"context_line":"      jobs:"},{"line_number":21,"context_line":"        - neutron-functional-with-uwsgi"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"fc345501_7d992511","line":18,"range":{"start_line":18,"start_character":8,"end_line":18,"end_character":33},"in_reply_to":"76a5a4f7_c9941032","updated":"2022-03-01 08:46:02.000000000","message":"I understand Rodolfo\u0027s point here, but we discussed it offline too and I\u0027m going to approve this patch. It still seems to be small improvement in terms of the overall infra resources\u0027 usage :)","commit_id":"22f1c99453e933ec0bcb2be2a8e258d91768ae4c"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"1d470df10e7054932541795c609758de5a2e4089","unresolved":true,"context_lines":[{"line_number":15,"context_line":"      - release-notes-jobs-python3"},{"line_number":16,"context_line":"      - neutron-experimental-jobs"},{"line_number":17,"context_line":"      - neutron-periodic-jobs"},{"line_number":18,"context_line":"      - neutron-tox-override-jobs"},{"line_number":19,"context_line":"    check:"},{"line_number":20,"context_line":"      jobs:"},{"line_number":21,"context_line":"        - neutron-functional-with-uwsgi"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"76a5a4f7_c9941032","line":18,"range":{"start_line":18,"start_character":8,"end_line":18,"end_character":33},"in_reply_to":"ade0ee19_534f2dec","updated":"2022-02-28 09:40:02.000000000","message":"\u003c\u003c We use templates from other projects but not from Neutron. I don\u0027t see the benefit of, a part from the external templates, why should we define the list of jobs in two different places. The size of this file is short enough to be manageable.\n\nIt\u0027s not about size at all, it\u0027s all about optimization as shared in previous comments. I have seen many patches in past adjusting these, for tox jobs adjusting timeouts is example and from periodic,experimental addition/removing of jobs. And all these changes are recurring so i think it\u0027s good to improve it and thus this patch.\n\n\u003c\u003c I prefer to have all CI queue definitions in one single place.\nWe can never have that unless we stop using templates altogether, We currently don\u0027t have queue definition at single place(we using templates from other projects, this one proposing to move not all but some special(periodic/expeimental as have different triggers then check/cage, tox for the overrides of jobs from other project) jobs to a template and different file)\nYes if it\u0027s possible to get same benefits by keeping in single place i will too prefer that, but i don\u0027t see how it can be done without losing coverage for check/gate jobs, if you or others have some idea for that? i can consider working on that.\n\n\u003c\u003c None of the referred patches are affected by this patch, it is not optimizing the code.\nYes right it\u0027s not code optimization but reducing CI time(less jobs) + people(committers to these jobs and reviewers to these jobs) time(less unnecessary jobs would lead to avoid failures in that, check logs and re-check to rerun), and yes this is not solving all the problems but 1 of them. All the patches linked are related in terms of optimization mentioned, and these are just example there are lot of such which can be found out.","commit_id":"22f1c99453e933ec0bcb2be2a8e258d91768ae4c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"aa969b4e2b249820e835905d2d82d7d9064ca8af","unresolved":true,"context_lines":[{"line_number":15,"context_line":"      - release-notes-jobs-python3"},{"line_number":16,"context_line":"      - neutron-experimental-jobs"},{"line_number":17,"context_line":"      - neutron-periodic-jobs"},{"line_number":18,"context_line":"      - neutron-tox-override-jobs"},{"line_number":19,"context_line":"    check:"},{"line_number":20,"context_line":"      jobs:"},{"line_number":21,"context_line":"        - neutron-functional-with-uwsgi"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ade0ee19_534f2dec","line":18,"range":{"start_line":18,"start_character":8,"end_line":18,"end_character":33},"in_reply_to":"ef54e748_b1cc225b","updated":"2022-02-28 08:22:12.000000000","message":"We use templates from other projects but not from Neutron. I don\u0027t see the benefit of, a part from the external templates, why should we define the list of jobs in two different places. The size of this file is short enough to be manageable.\n\nI prefer to have all CI queue definitions in one single place.\n\nNone of the referred patches are affected by this patch, it is not optimizing the code.","commit_id":"22f1c99453e933ec0bcb2be2a8e258d91768ae4c"}]}