)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"0eacdfd16239d25789165e995767fc460751dce3","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Luis Tomas Bolivar \u003cltomasbo@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-03-14 15:27:09 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Ensure no GARPs are sent for Load Balanver VIPs on tenant networks"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When a loadbalancer is created in tenant network (VIP and members),"},{"line_number":10,"context_line":"and that tenant networks is connected to a router, which in connected"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5d5541bf_58b45ddf","line":7,"range":{"start_line":7,"start_character":34,"end_line":7,"end_character":42},"updated":"2022-03-14 14:52:18.000000000","message":"typo","commit_id":"cc592acc922ea6176ebcea9bbf7246d8a0201f6b"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"0399510640f368b0a692de1e5008f5f70fa87e13","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Luis Tomas Bolivar \u003cltomasbo@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-03-14 15:27:09 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Ensure no GARPs are sent for Load Balanver VIPs on tenant networks"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When a loadbalancer is created in tenant network (VIP and members),"},{"line_number":10,"context_line":"and that tenant networks is connected to a router, which in connected"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"efb79da0_aa008ec3","line":7,"range":{"start_line":7,"start_character":34,"end_line":7,"end_character":42},"in_reply_to":"5d5541bf_58b45ddf","updated":"2022-03-14 14:56:18.000000000","message":"Done","commit_id":"cc592acc922ea6176ebcea9bbf7246d8a0201f6b"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"0eacdfd16239d25789165e995767fc460751dce3","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Ensure no GARPs are sent for Load Balanver VIPs on tenant networks"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When a loadbalancer is created in tenant network (VIP and members),"},{"line_number":10,"context_line":"and that tenant networks is connected to a router, which in connected"},{"line_number":11,"context_line":"to the provider network, the ovn loadbalancer gets"},{"line_number":12,"context_line":"associated to the ovn logical router. If the \"router\" option is used for"},{"line_number":13,"context_line":"\"nat-addresses\" (as currently done), ovn-controller will send GARPs for"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"c77fc2c9_0fc72eac","line":10,"range":{"start_line":10,"start_character":57,"end_line":10,"end_character":59},"updated":"2022-03-14 14:52:18.000000000","message":"is","commit_id":"cc592acc922ea6176ebcea9bbf7246d8a0201f6b"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"0eacdfd16239d25789165e995767fc460751dce3","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Ensure no GARPs are sent for Load Balanver VIPs on tenant networks"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When a loadbalancer is created in tenant network (VIP and members),"},{"line_number":10,"context_line":"and that tenant networks is connected to a router, which in connected"},{"line_number":11,"context_line":"to the provider network, the ovn loadbalancer gets"},{"line_number":12,"context_line":"associated to the ovn logical router. If the \"router\" option is used for"},{"line_number":13,"context_line":"\"nat-addresses\" (as currently done), ovn-controller will send GARPs for"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"21a742bb_c7127d24","line":10,"range":{"start_line":10,"start_character":16,"end_line":10,"end_character":24},"updated":"2022-03-14 14:52:18.000000000","message":"network","commit_id":"cc592acc922ea6176ebcea9bbf7246d8a0201f6b"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"0399510640f368b0a692de1e5008f5f70fa87e13","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Ensure no GARPs are sent for Load Balanver VIPs on tenant networks"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When a loadbalancer is created in tenant network (VIP and members),"},{"line_number":10,"context_line":"and that tenant networks is connected to a router, which in connected"},{"line_number":11,"context_line":"to the provider network, the ovn loadbalancer gets"},{"line_number":12,"context_line":"associated to the ovn logical router. If the \"router\" option is used for"},{"line_number":13,"context_line":"\"nat-addresses\" (as currently done), ovn-controller will send GARPs for"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"6354edb6_a8633599","line":10,"range":{"start_line":10,"start_character":16,"end_line":10,"end_character":24},"in_reply_to":"21a742bb_c7127d24","updated":"2022-03-14 14:56:18.000000000","message":"Done","commit_id":"cc592acc922ea6176ebcea9bbf7246d8a0201f6b"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"0399510640f368b0a692de1e5008f5f70fa87e13","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Ensure no GARPs are sent for Load Balanver VIPs on tenant networks"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When a loadbalancer is created in tenant network (VIP and members),"},{"line_number":10,"context_line":"and that tenant networks is connected to a router, which in connected"},{"line_number":11,"context_line":"to the provider network, the ovn loadbalancer gets"},{"line_number":12,"context_line":"associated to the ovn logical router. If the \"router\" option is used for"},{"line_number":13,"context_line":"\"nat-addresses\" (as currently done), ovn-controller will send GARPs for"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fc3372c3_d9ac2623","line":10,"range":{"start_line":10,"start_character":57,"end_line":10,"end_character":59},"in_reply_to":"c77fc2c9_0fc72eac","updated":"2022-03-14 14:56:18.000000000","message":"Done","commit_id":"cc592acc922ea6176ebcea9bbf7246d8a0201f6b"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":34118,"name":"Arnau Verdaguer","email":"averdagu@redhat.com","username":"averdaguer"},"change_message_id":"2e679874d729820590dd79c5954d336462d75495","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5a092b8c_5c220e73","updated":"2022-03-14 14:58:41.000000000","message":"LGTM!","commit_id":"9d4e6edd5b4c92c88fbe8d06f6a176fae1b35f25"}],"neutron/common/ovn/constants.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"5bbf4b9269f8eb7abc036779c391578cebc965e6","unresolved":true,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"MIGRATING_ATTR \u003d \u0027migrating_to\u0027"},{"line_number":53,"context_line":"OVN_ROUTER_PORT_OPTION_KEYS \u003d [\u0027router-port\u0027, \u0027nat-addresses\u0027,"},{"line_number":54,"context_line":"                               \u0027exclude-lb-vips-from-garp\u0027]"},{"line_number":55,"context_line":"OVN_GATEWAY_CHASSIS_KEY \u003d \u0027redirect-chassis\u0027"},{"line_number":56,"context_line":"OVN_CHASSIS_REDIRECT \u003d \u0027chassisredirect\u0027"},{"line_number":57,"context_line":"OVN_GATEWAY_NAT_ADDRESSES_KEY \u003d \u0027nat-addresses\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"24f0466d_87867934","line":54,"updated":"2022-03-14 16:16:49.000000000","message":"Perhaps not in this patch, but maybe we should move this list down in this file and use the constants in it to avoid duplicating the strings\n \nOVN_ROUTER_PORT_OPTION_KEYS \u003d [..., OVN_GATEWAY_NAT_ADDRESSES_KEY,                                                                                    OVN_ROUTER_PORT_EXCLUDE_LB_VIPS_GARP]","commit_id":"9d4e6edd5b4c92c88fbe8d06f6a176fae1b35f25"}],"neutron/tests/unit/plugins/ml2/drivers/ovn/mech_driver/ovsdb/test_commands.py":[{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"2a5126db0d7bd20f26dccefac025a8b6ef67aeed","unresolved":true,"context_lines":[{"line_number":676,"context_line":"            cmd \u003d commands.SetLRouterPortInLSwitchPortCommand("},{"line_number":677,"context_line":"                self.ovn_api, fake_lsp.name, lrp_name, True, True, \u0027router\u0027)"},{"line_number":678,"context_line":"            cmd.run_idl(self.transaction)"},{"line_number":679,"context_line":"            self.assertEqual({\u0027router-port\u0027: lrp_name,"},{"line_number":680,"context_line":"                              \u0027nat-addresses\u0027: \u0027router\u0027,"},{"line_number":681,"context_line":"                              \u0027exclude-lb-vips-from-garp\u0027: \u0027true\u0027},"},{"line_number":682,"context_line":"                             fake_lsp.options)"},{"line_number":683,"context_line":"            self.assertEqual(\u0027router\u0027, fake_lsp.type)"},{"line_number":684,"context_line":"            self.assertEqual(\u0027router\u0027, fake_lsp.addresses)"}],"source_content_type":"text/x-python","patch_set":4,"id":"a782ef76_26d32255","line":681,"range":{"start_line":679,"start_character":30,"end_line":681,"end_character":65},"updated":"2022-03-14 16:46:04.000000000","message":"(nit) Same topic as Lucas: It might be good to use the constants in the tests too to avoid having to change them if the parameter name ever changes.","commit_id":"9d4e6edd5b4c92c88fbe8d06f6a176fae1b35f25"}]}