)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34118,"name":"Arnau Verdaguer","email":"averdagu@redhat.com","username":"averdaguer"},"change_message_id":"160695b762f7535ca3f9c57c4a9e822e00887270","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"76d05b64_29eef6a6","updated":"2022-03-14 13:50:25.000000000","message":"Testing slawek and yatin comment","commit_id":"3827523145906154b117216df36b659c0d2ab0a2"},{"author":{"_account_id":34118,"name":"Arnau Verdaguer","email":"averdagu@redhat.com","username":"averdaguer"},"change_message_id":"9b926db8c4d4e09aeb911af70203fef407cd7918","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ee788f48_d88c49cc","updated":"2022-03-14 11:11:47.000000000","message":"recheck\n","commit_id":"3827523145906154b117216df36b659c0d2ab0a2"}],"tools/ovn_migration/tripleo_environment/playbooks/roles/migration/tasks/cleanup-dataplane.yml":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"1c17f090f36649a4cd370a759a9876ee76311838","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Cleanup neutron router and dhcp interfaces"},{"line_number":3,"context_line":"  shell: |"},{"line_number":4,"context_line":"    ovs-vsctl list interface | awk \u0027/name[ ]*: qr-|ha-|qg-|rfp-/ { print $3 }\u0027 | xargs -n1 ovs-vsctl del-port"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    # dhcp tap ports cannot be easily distinguished from ovsfw ports, so we"},{"line_number":7,"context_line":"    # list them from within the qdhcp namespaces"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"e4f5fd5e_f7392eb4","line":4,"range":{"start_line":4,"start_character":47,"end_line":4,"end_character":63},"updated":"2022-03-09 13:25:30.000000000","message":"don\u0027t need to clean here?","commit_id":"3827523145906154b117216df36b659c0d2ab0a2"},{"author":{"_account_id":34118,"name":"Arnau Verdaguer","email":"averdagu@redhat.com","username":"averdaguer"},"change_message_id":"7c840b9239b991a6d175bc4ae12048498a3962fc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Cleanup neutron router and dhcp interfaces"},{"line_number":3,"context_line":"  shell: |"},{"line_number":4,"context_line":"    ovs-vsctl list interface | awk \u0027/name[ ]*: qr-|ha-|qg-|rfp-/ { print $3 }\u0027 | xargs -n1 ovs-vsctl del-port"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    # dhcp tap ports cannot be easily distinguished from ovsfw ports, so we"},{"line_number":7,"context_line":"    # list them from within the qdhcp namespaces"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"39a51ae6_4dc1d12c","line":4,"range":{"start_line":4,"start_character":47,"end_line":4,"end_character":63},"in_reply_to":"16ca501b_11f06fd9","updated":"2022-03-16 14:36:14.000000000","message":"It was necessary, applied in this patchset2, thanks for pointing it out!","commit_id":"3827523145906154b117216df36b659c0d2ab0a2"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6c281abef5205128fe7d3eca5c8865800eb2ce8c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Cleanup neutron router and dhcp interfaces"},{"line_number":3,"context_line":"  shell: |"},{"line_number":4,"context_line":"    ovs-vsctl list interface | awk \u0027/name[ ]*: qr-|ha-|qg-|rfp-/ { print $3 }\u0027 | xargs -n1 ovs-vsctl del-port"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    # dhcp tap ports cannot be easily distinguished from ovsfw ports, so we"},{"line_number":7,"context_line":"    # list them from within the qdhcp namespaces"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"234d08fe_1baac32f","line":4,"range":{"start_line":4,"start_character":47,"end_line":4,"end_character":63},"in_reply_to":"1c1ac38f_89da05c3","updated":"2022-03-14 13:27:33.000000000","message":"I think Yatin may be right as delete of the namespace will remove devices but not ports from ovs br-int and You will still have those ports in the br-int with ofport \u003d -1.","commit_id":"3827523145906154b117216df36b659c0d2ab0a2"},{"author":{"_account_id":34118,"name":"Arnau Verdaguer","email":"averdagu@redhat.com","username":"averdaguer"},"change_message_id":"160695b762f7535ca3f9c57c4a9e822e00887270","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Cleanup neutron router and dhcp interfaces"},{"line_number":3,"context_line":"  shell: |"},{"line_number":4,"context_line":"    ovs-vsctl list interface | awk \u0027/name[ ]*: qr-|ha-|qg-|rfp-/ { print $3 }\u0027 | xargs -n1 ovs-vsctl del-port"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    # dhcp tap ports cannot be easily distinguished from ovsfw ports, so we"},{"line_number":7,"context_line":"    # list them from within the qdhcp namespaces"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"16ca501b_11f06fd9","line":4,"range":{"start_line":4,"start_character":47,"end_line":4,"end_character":63},"in_reply_to":"234d08fe_1baac32f","updated":"2022-03-14 13:50:25.000000000","message":"True, I didn\u0027t thought of it, I\u0027ll test on an environment and upload a new patch if needed, thanks Slawek and Yatin!","commit_id":"3827523145906154b117216df36b659c0d2ab0a2"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"2db156ee3bef9c6a10a633d97f2983dea8f6b015","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Cleanup neutron router and dhcp interfaces"},{"line_number":3,"context_line":"  shell: |"},{"line_number":4,"context_line":"    ovs-vsctl list interface | awk \u0027/name[ ]*: qr-|ha-|qg-|rfp-/ { print $3 }\u0027 | xargs -n1 ovs-vsctl del-port"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    # dhcp tap ports cannot be easily distinguished from ovsfw ports, so we"},{"line_number":7,"context_line":"    # list them from within the qdhcp namespaces"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"6e43b227_9466ef08","line":4,"range":{"start_line":4,"start_character":47,"end_line":4,"end_character":63},"in_reply_to":"39a51ae6_4dc1d12c","updated":"2022-03-16 14:58:14.000000000","message":"Thanks for verifying it.","commit_id":"3827523145906154b117216df36b659c0d2ab0a2"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"5777d4e06ccb0a16d2822b3745042c950f382cfa","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Cleanup neutron router and dhcp interfaces"},{"line_number":3,"context_line":"  shell: |"},{"line_number":4,"context_line":"    ovs-vsctl list interface | awk \u0027/name[ ]*: qr-|ha-|qg-|rfp-/ { print $3 }\u0027 | xargs -n1 ovs-vsctl del-port"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    # dhcp tap ports cannot be easily distinguished from ovsfw ports, so we"},{"line_number":7,"context_line":"    # list them from within the qdhcp namespaces"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1c1ac38f_89da05c3","line":4,"range":{"start_line":4,"start_character":47,"end_line":4,"end_character":63},"in_reply_to":"9f5630af_5f60950e","updated":"2022-03-10 06:39:23.000000000","message":"yeap i got the other parts, only not clear was explicitly cleanup using ovs-vsctl del-port. While reading it i understood like first delete ports is attempted and then later the namespaces. If sg- and fg- are some special ports which don\u0027t need to follow the similar approach as others ok from my end. Thanks for checking it out, will let others to give feedback too.","commit_id":"3827523145906154b117216df36b659c0d2ab0a2"},{"author":{"_account_id":34118,"name":"Arnau Verdaguer","email":"averdagu@redhat.com","username":"averdaguer"},"change_message_id":"ff4767da0b1e76c695849113a67fcb1f7798a604","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Cleanup neutron router and dhcp interfaces"},{"line_number":3,"context_line":"  shell: |"},{"line_number":4,"context_line":"    ovs-vsctl list interface | awk \u0027/name[ ]*: qr-|ha-|qg-|rfp-/ { print $3 }\u0027 | xargs -n1 ovs-vsctl del-port"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    # dhcp tap ports cannot be easily distinguished from ovsfw ports, so we"},{"line_number":7,"context_line":"    # list them from within the qdhcp namespaces"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f5630af_5f60950e","line":4,"range":{"start_line":4,"start_character":47,"end_line":4,"end_character":63},"in_reply_to":"e4f5fd5e_f7392eb4","updated":"2022-03-09 13:44:37.000000000","message":"I don\u0027t think so, the sg and fg interfaces are located inside the router- and fip- netns, During the \"Cleanup neutron datapath resource\" will be deleted.\ncleanup-dataplane.yml L66:\n```\n    # cleanup Neutron ml2/ovs namespaces\n    for netns in $(ip netns | awk \u0027/^(snat|fip|qdhcp|qrouter)-/{ print $1 }\u0027); do\n        echo \"Cleaning up namespace $netns\"\n        ip netns delete $netns\n    done\n\n```\nWith this patch we are avoiding to duplicate the sg-/fg- interfaces during the clone-br-int.sh. And at this point since the system is already configured with OVN those interfaces are not used anymore (since the snat/fip is done by the openflow)","commit_id":"3827523145906154b117216df36b659c0d2ab0a2"}]}