)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"a7ca5b3daadbe5ba641fab02e00cc08c25c67c2d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6d742098_08f2bfd6","updated":"2022-03-17 05:58:20.000000000","message":"Overall looks fine, just some nits/concerns inline.","commit_id":"ae4da70719b6ee4fa202dc2115d3c134b2b4ca37"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"421869f0e90cc3d2255cfcd9a4cabfadba6239ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5a387772_af69343b","updated":"2022-03-23 17:01:11.000000000","message":"Maybe \"TestLogging\" and \"BaseLoggingTestCase\" could other candidates to remove the DHCP agent. In any case, good patch.","commit_id":"282ccbb8f0b471d9bc96261ab1866ffca4ec2b97"}],"neutron/tests/fullstack/test_connectivity.py":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"a7ca5b3daadbe5ba641fab02e00cc08c25c67c2d","unresolved":true,"context_lines":[{"line_number":166,"context_line":"        self._test_connectivity()"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"class TestConnectivitySameNetworkNoDhcp(BaseConnectivitySameNetworkTest):"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    scenarios \u003d ["},{"line_number":172,"context_line":"        (constants.AGENT_TYPE_OVS,"},{"line_number":173,"context_line":"         {\u0027l2_agent_type\u0027: constants.AGENT_TYPE_OVS}),"},{"line_number":174,"context_line":"        (constants.AGENT_TYPE_LINUXBRIDGE,"},{"line_number":175,"context_line":"         {\u0027l2_agent_type\u0027: constants.AGENT_TYPE_LINUXBRIDGE})"},{"line_number":176,"context_line":"    ]"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    use_dhcp \u003d False"},{"line_number":179,"context_line":"    network_type \u003d \u0027vxlan\u0027"},{"line_number":180,"context_line":"    l2_pop \u003d False"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    def test_connectivity(self):"},{"line_number":183,"context_line":"        self._test_connectivity()"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"class _TestUninterruptedConnectivityOnL2AgentRestart("}],"source_content_type":"text/x-python","patch_set":1,"id":"9dcfabbd_518bcc90","line":183,"range":{"start_line":169,"start_character":0,"end_line":183,"end_character":33},"updated":"2022-03-17 05:58:20.000000000","message":"This shouldn\u0027t be needed now, right? i see TestOvsConnectivitySameNetwork and TestLinuxBridgeConnectivitySameNetwork already covering the scenarios from here.","commit_id":"ae4da70719b6ee4fa202dc2115d3c134b2b4ca37"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"bf2ff22ff2a08ac90bb1524911333046a4a93f44","unresolved":true,"context_lines":[{"line_number":166,"context_line":"        self._test_connectivity()"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"class TestConnectivitySameNetworkNoDhcp(BaseConnectivitySameNetworkTest):"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    scenarios \u003d ["},{"line_number":172,"context_line":"        (constants.AGENT_TYPE_OVS,"},{"line_number":173,"context_line":"         {\u0027l2_agent_type\u0027: constants.AGENT_TYPE_OVS}),"},{"line_number":174,"context_line":"        (constants.AGENT_TYPE_LINUXBRIDGE,"},{"line_number":175,"context_line":"         {\u0027l2_agent_type\u0027: constants.AGENT_TYPE_LINUXBRIDGE})"},{"line_number":176,"context_line":"    ]"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    use_dhcp \u003d False"},{"line_number":179,"context_line":"    network_type \u003d \u0027vxlan\u0027"},{"line_number":180,"context_line":"    l2_pop \u003d False"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    def test_connectivity(self):"},{"line_number":183,"context_line":"        self._test_connectivity()"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"class _TestUninterruptedConnectivityOnL2AgentRestart("}],"source_content_type":"text/x-python","patch_set":1,"id":"3bc2f61e_44cca785","line":183,"range":{"start_line":169,"start_character":0,"end_line":183,"end_character":33},"in_reply_to":"7610e866_9652d1df","updated":"2022-03-23 15:58:04.000000000","message":"Thx, good catch indeed :)","commit_id":"ae4da70719b6ee4fa202dc2115d3c134b2b4ca37"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"171657717c2cd473fac152f4eb7de2662068af63","unresolved":true,"context_lines":[{"line_number":166,"context_line":"        self._test_connectivity()"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"class TestConnectivitySameNetworkNoDhcp(BaseConnectivitySameNetworkTest):"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    scenarios \u003d ["},{"line_number":172,"context_line":"        (constants.AGENT_TYPE_OVS,"},{"line_number":173,"context_line":"         {\u0027l2_agent_type\u0027: constants.AGENT_TYPE_OVS}),"},{"line_number":174,"context_line":"        (constants.AGENT_TYPE_LINUXBRIDGE,"},{"line_number":175,"context_line":"         {\u0027l2_agent_type\u0027: constants.AGENT_TYPE_LINUXBRIDGE})"},{"line_number":176,"context_line":"    ]"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    use_dhcp \u003d False"},{"line_number":179,"context_line":"    network_type \u003d \u0027vxlan\u0027"},{"line_number":180,"context_line":"    l2_pop \u003d False"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    def test_connectivity(self):"},{"line_number":183,"context_line":"        self._test_connectivity()"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"class _TestUninterruptedConnectivityOnL2AgentRestart("}],"source_content_type":"text/x-python","patch_set":1,"id":"7610e866_9652d1df","line":183,"range":{"start_line":169,"start_character":0,"end_line":183,"end_character":33},"in_reply_to":"9dcfabbd_518bcc90","updated":"2022-03-18 10:34:32.000000000","message":"+1 good catch","commit_id":"ae4da70719b6ee4fa202dc2115d3c134b2b4ca37"}],"neutron/tests/fullstack/test_dhcp_agent.py":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"a7ca5b3daadbe5ba641fab02e00cc08c25c67c2d","unresolved":true,"context_lines":[{"line_number":85,"context_line":"            name\u003d\u0027subnet-test\u0027,"},{"line_number":86,"context_line":"            enable_dhcp\u003dTrue)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        self.vm \u003d self._spawn_vm()"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"class TestDhcpAgentNoHA(BaseDhcpAgentTest):"}],"source_content_type":"text/x-python","patch_set":1,"id":"17c35038_0272da8f","line":88,"updated":"2022-03-17 05:58:20.000000000","message":"i think need to call block_until_dhcp_config_done here or if want to add to _spawn_vm itself then can remove explicit calls to block_until_dhcp_config_done as it will be duplicated where _spawn_vm is used.","commit_id":"ae4da70719b6ee4fa202dc2115d3c134b2b4ca37"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"bf2ff22ff2a08ac90bb1524911333046a4a93f44","unresolved":true,"context_lines":[{"line_number":85,"context_line":"            name\u003d\u0027subnet-test\u0027,"},{"line_number":86,"context_line":"            enable_dhcp\u003dTrue)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        self.vm \u003d self._spawn_vm()"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"class TestDhcpAgentNoHA(BaseDhcpAgentTest):"}],"source_content_type":"text/x-python","patch_set":1,"id":"c1afc209_8179c8f4","line":88,"in_reply_to":"17c35038_0272da8f","updated":"2022-03-23 15:58:04.000000000","message":"I will keep it in _spawn_vm() and remove from other places. That way we will not need to remember about adding it in new places in future.","commit_id":"ae4da70719b6ee4fa202dc2115d3c134b2b4ca37"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"6524288cce2debb1ad51336e9bfcb94de565aa6b","unresolved":true,"context_lines":[{"line_number":85,"context_line":"            name\u003d\u0027subnet-test\u0027,"},{"line_number":86,"context_line":"            enable_dhcp\u003dTrue)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        self.vm \u003d self._spawn_vm()"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"class TestDhcpAgentNoHA(BaseDhcpAgentTest):"}],"source_content_type":"text/x-python","patch_set":1,"id":"58f6650a_c6067a81","line":88,"in_reply_to":"c1afc209_8179c8f4","updated":"2022-03-24 07:05:44.000000000","message":"+1","commit_id":"ae4da70719b6ee4fa202dc2115d3c134b2b4ca37"}],"neutron/tests/fullstack/test_securitygroup.py":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"a7ca5b3daadbe5ba641fab02e00cc08c25c67c2d","unresolved":true,"context_lines":[{"line_number":569,"context_line":"                    use_dhcp\u003dFalse))"},{"line_number":570,"context_line":"            for port, host in enumerate(index_to_host)]"},{"line_number":571,"context_line":"        map(lambda vm: vm.block_until_boot(), vms)"},{"line_number":572,"context_line":"        map(lambda vm: vm.block_until_dhcp_config_done(), vms)"},{"line_number":573,"context_line":""},{"line_number":574,"context_line":"        return vms, ports, sgs, network, index_to_host"},{"line_number":575,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"168f679e_d7799517","line":572,"range":{"start_line":572,"start_character":26,"end_line":572,"end_character":54},"updated":"2022-03-17 05:58:20.000000000","message":"do we still need to call this here and other places above when disabling dhcp?","commit_id":"ae4da70719b6ee4fa202dc2115d3c134b2b4ca37"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"bf2ff22ff2a08ac90bb1524911333046a4a93f44","unresolved":true,"context_lines":[{"line_number":569,"context_line":"                    use_dhcp\u003dFalse))"},{"line_number":570,"context_line":"            for port, host in enumerate(index_to_host)]"},{"line_number":571,"context_line":"        map(lambda vm: vm.block_until_boot(), vms)"},{"line_number":572,"context_line":"        map(lambda vm: vm.block_until_dhcp_config_done(), vms)"},{"line_number":573,"context_line":""},{"line_number":574,"context_line":"        return vms, ports, sgs, network, index_to_host"},{"line_number":575,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"71ad2888_c8a81dd7","line":572,"range":{"start_line":572,"start_character":26,"end_line":572,"end_character":54},"in_reply_to":"168f679e_d7799517","updated":"2022-03-23 15:58:04.000000000","message":"nope","commit_id":"ae4da70719b6ee4fa202dc2115d3c134b2b4ca37"}]}