)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"9a1ca702ea1168dcee3aacdee0faaafed354c196","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3e5cdcd1_ad834b18","updated":"2022-03-23 12:40:31.000000000","message":"Let\u0027s wait for zuul","commit_id":"e76634abfd11decf3ea3ef97ffc1b59e2c4e7602"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"09e466e6ed20742acabaa22412705568a9210b3d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f0d174fb_a634ac1b","updated":"2022-03-28 07:27:50.000000000","message":"Another way would be to send nova notification regardless of previous port status, then nova will decide whether to skip it or not (should be not much of a burden). Are there any known downsides of such approach?","commit_id":"e7edcec2608fe1cb30d7458a882eb81e058eb76e"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"7e259289533e4c6f295686d2833b6ad2b83aadc9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1214d687_05030508","updated":"2022-03-25 09:43:18.000000000","message":"This situation, to be honest, is very exceptional. But of course we have seen it several times in the CI (ok, maybe not so exceptional).\n\nI think that, in the case of failing to report the DOWN status, as commented (and Slawek addressed this comment), we should not treat this port again.\n\n+2 for this code as is.","commit_id":"e7edcec2608fe1cb30d7458a882eb81e058eb76e"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"f958cb8ab0eed4eb6edd49cffdac6a90357d2a6d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9074c232_3037af0a","in_reply_to":"f0d174fb_a634ac1b","updated":"2022-03-28 07:52:21.000000000","message":"I don\u0027t know about any. But I would like someone from Nova team to take a look and tell us how it\u0027s from their PoV","commit_id":"e7edcec2608fe1cb30d7458a882eb81e058eb76e"}],"neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"9a1ca702ea1168dcee3aacdee0faaafed354c196","unresolved":true,"context_lines":[{"line_number":2126,"context_line":"            # process_network_ports, we can be sure that update state to UP"},{"line_number":2127,"context_line":"            # will trigger send notification about port status to Nova"},{"line_number":2128,"context_line":"            re_added_devices \u003d self.plugin_rpc.update_device_list("},{"line_number":2129,"context_line":"                self.context, [], re_added, self.agent_id, self.conf.host)"},{"line_number":2130,"context_line":"            failed_re_added_down \u003d re_added_devices.get(\u0027failed_devices_down\u0027)"},{"line_number":2131,"context_line":"            if failed_re_added_down:"},{"line_number":2132,"context_line":"                LOG.debug(\"Status updated failed for re_added devices: %s\","}],"source_content_type":"text/x-python","patch_set":1,"id":"ac63b9ab_11f8221e","line":2129,"range":{"start_line":2129,"start_character":16,"end_line":2129,"end_character":73},"updated":"2022-03-23 12:40:31.000000000","message":"nit: just for readability\"\nupdate_device_list(context\u003d..., devices_up\u003d[], devices_down\u003d....)","commit_id":"e76634abfd11decf3ea3ef97ffc1b59e2c4e7602"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"376abcd3b4ac757ff144808455d70eee95af2cf5","unresolved":false,"context_lines":[{"line_number":2126,"context_line":"            # process_network_ports, we can be sure that update state to UP"},{"line_number":2127,"context_line":"            # will trigger send notification about port status to Nova"},{"line_number":2128,"context_line":"            re_added_devices \u003d self.plugin_rpc.update_device_list("},{"line_number":2129,"context_line":"                self.context, [], re_added, self.agent_id, self.conf.host)"},{"line_number":2130,"context_line":"            failed_re_added_down \u003d re_added_devices.get(\u0027failed_devices_down\u0027)"},{"line_number":2131,"context_line":"            if failed_re_added_down:"},{"line_number":2132,"context_line":"                LOG.debug(\"Status updated failed for re_added devices: %s\","}],"source_content_type":"text/x-python","patch_set":1,"id":"9c169996_7a3d8586","line":2129,"range":{"start_line":2129,"start_character":16,"end_line":2129,"end_character":73},"in_reply_to":"ac63b9ab_11f8221e","updated":"2022-03-23 14:17:15.000000000","message":"Done","commit_id":"e76634abfd11decf3ea3ef97ffc1b59e2c4e7602"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"7289004cf470766846d018015454de83bc242096","unresolved":true,"context_lines":[{"line_number":2131,"context_line":"            if failed_re_added_down:"},{"line_number":2132,"context_line":"                LOG.debug(\"Status updated failed for re_added devices: %s\","},{"line_number":2133,"context_line":"                          failed_re_added_down)"},{"line_number":2134,"context_line":"                failed_devices[\u0027removed\u0027] |\u003d set(failed_re_added_down)"},{"line_number":2135,"context_line":"            LOG.info(\"process_network_ports - iteration:%(iter_num)d - \""},{"line_number":2136,"context_line":"                     \"reporting re_added devices DOWN completed. \""},{"line_number":2137,"context_line":"                     \"Number of readded devices: %(re_added)s. \""}],"source_content_type":"text/x-python","patch_set":1,"id":"fe593c8d_ab500220","line":2134,"range":{"start_line":2134,"start_character":16,"end_line":2134,"end_character":70},"updated":"2022-03-23 16:46:36.000000000","message":"We won\u0027t need to retry those ports again, or at least we can\u0027t set then as \"removed\" because those ports have been deleted and added in this polling cycle. Thus I\u0027m not sure about adding them to \"failed_devices\".\n\nIf OVS agent has problems retrieving the information for a specific \"readded\" port, it will be marked too as failed_devices[\u0027added\u0027].","commit_id":"e76634abfd11decf3ea3ef97ffc1b59e2c4e7602"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"2275421b3a26dc2fba83a5a79df49957c54c0ee8","unresolved":false,"context_lines":[{"line_number":2131,"context_line":"            if failed_re_added_down:"},{"line_number":2132,"context_line":"                LOG.debug(\"Status updated failed for re_added devices: %s\","},{"line_number":2133,"context_line":"                          failed_re_added_down)"},{"line_number":2134,"context_line":"                failed_devices[\u0027removed\u0027] |\u003d set(failed_re_added_down)"},{"line_number":2135,"context_line":"            LOG.info(\"process_network_ports - iteration:%(iter_num)d - \""},{"line_number":2136,"context_line":"                     \"reporting re_added devices DOWN completed. \""},{"line_number":2137,"context_line":"                     \"Number of readded devices: %(re_added)s. \""}],"source_content_type":"text/x-python","patch_set":1,"id":"53a65998_6c615b39","line":2134,"range":{"start_line":2134,"start_character":16,"end_line":2134,"end_character":70},"in_reply_to":"fe593c8d_ab500220","updated":"2022-03-24 15:55:15.000000000","message":"True. Done","commit_id":"e76634abfd11decf3ea3ef97ffc1b59e2c4e7602"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"9a1ca702ea1168dcee3aacdee0faaafed354c196","unresolved":true,"context_lines":[{"line_number":2132,"context_line":"                LOG.debug(\"Status updated failed for re_added devices: %s\","},{"line_number":2133,"context_line":"                          failed_re_added_down)"},{"line_number":2134,"context_line":"                failed_devices[\u0027removed\u0027] |\u003d set(failed_re_added_down)"},{"line_number":2135,"context_line":"            LOG.info(\"process_network_ports - iteration:%(iter_num)d - \""},{"line_number":2136,"context_line":"                     \"reporting re_added devices DOWN completed. \""},{"line_number":2137,"context_line":"                     \"Number of readded devices: %(re_added)s. \""},{"line_number":2138,"context_line":"                     \"Time elapsed: %(elapsed).3f\","},{"line_number":2139,"context_line":"                     {\u0027iter_num\u0027: self.iter_num,"},{"line_number":2140,"context_line":"                      \u0027re_added\u0027: len(re_added),"},{"line_number":2141,"context_line":"                      \u0027elapsed\u0027: time.time() - start})"},{"line_number":2142,"context_line":"        if devices_added_updated:"},{"line_number":2143,"context_line":"            (skipped_devices, binding_no_activated_devices,"},{"line_number":2144,"context_line":"             need_binding_devices, failed_devices[\u0027added\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"dbf9d2d5_d6c2ba4c","line":2141,"range":{"start_line":2135,"start_character":0,"end_line":2141,"end_character":54},"updated":"2022-03-23 12:40:31.000000000","message":"It will be reported in the painpoints etherpad for sure 😜\n\n(https://etherpad.opendev.org/p/pain-point-elimination#L274 )","commit_id":"e76634abfd11decf3ea3ef97ffc1b59e2c4e7602"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"376abcd3b4ac757ff144808455d70eee95af2cf5","unresolved":true,"context_lines":[{"line_number":2132,"context_line":"                LOG.debug(\"Status updated failed for re_added devices: %s\","},{"line_number":2133,"context_line":"                          failed_re_added_down)"},{"line_number":2134,"context_line":"                failed_devices[\u0027removed\u0027] |\u003d set(failed_re_added_down)"},{"line_number":2135,"context_line":"            LOG.info(\"process_network_ports - iteration:%(iter_num)d - \""},{"line_number":2136,"context_line":"                     \"reporting re_added devices DOWN completed. \""},{"line_number":2137,"context_line":"                     \"Number of readded devices: %(re_added)s. \""},{"line_number":2138,"context_line":"                     \"Time elapsed: %(elapsed).3f\","},{"line_number":2139,"context_line":"                     {\u0027iter_num\u0027: self.iter_num,"},{"line_number":2140,"context_line":"                      \u0027re_added\u0027: len(re_added),"},{"line_number":2141,"context_line":"                      \u0027elapsed\u0027: time.time() - start})"},{"line_number":2142,"context_line":"        if devices_added_updated:"},{"line_number":2143,"context_line":"            (skipped_devices, binding_no_activated_devices,"},{"line_number":2144,"context_line":"             need_binding_devices, failed_devices[\u0027added\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c181_093befec","line":2141,"range":{"start_line":2135,"start_character":0,"end_line":2141,"end_character":54},"in_reply_to":"dbf9d2d5_d6c2ba4c","updated":"2022-03-23 14:17:15.000000000","message":"This line will be only logged when there are some re_added ports. So it shouldn\u0027t be many lines added really.","commit_id":"e76634abfd11decf3ea3ef97ffc1b59e2c4e7602"}]}