)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"69d3cca2a64c87b3d2de971e8c707571e78c556d","unresolved":true,"context_lines":[{"line_number":16,"context_line":"Closes-Bug: #1966099"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I3bdf878617fbe962d56ebb66d59ae7edeb9b7c38"},{"line_number":19,"context_line":"Signed-off-by: Jakub Libosvar \u003clibosvar@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"45ad1601_3bc447f1","line":19,"range":{"start_line":19,"start_character":31,"end_line":19,"end_character":39},"updated":"2022-03-23 16:39:09.000000000","message":"missing \"j\" if I\u0027m not wrong hehehe","commit_id":"5b2fd1f830827105bcaca0d4ba5da05b8b71c515"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"7ac1e4791ed10c592893983bb2232ecc00bfa9de","unresolved":true,"context_lines":[{"line_number":16,"context_line":"Closes-Bug: #1966099"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I3bdf878617fbe962d56ebb66d59ae7edeb9b7c38"},{"line_number":19,"context_line":"Signed-off-by: Jakub Libosvar \u003clibosvar@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"a1abd6b9_3e7495ab","line":19,"range":{"start_line":19,"start_character":31,"end_line":19,"end_character":39},"in_reply_to":"45ad1601_3bc447f1","updated":"2022-03-23 19:43:34.000000000","message":"Sharp eyes :) It\u0027s actually correct, I have both jlibosva@redhat.com (no \"r\" at the end) and libosvar@redhat.com (without the \"j\" at the beginning)","commit_id":"5b2fd1f830827105bcaca0d4ba5da05b8b71c515"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"f0acac5eb2411eeef5f71ed4f38636d699d7af73","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Closes-Bug: #1966099"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I3bdf878617fbe962d56ebb66d59ae7edeb9b7c38"},{"line_number":19,"context_line":"Signed-off-by: Jakub Libosvar \u003clibosvar@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"6815c556_e208db5c","line":19,"range":{"start_line":19,"start_character":31,"end_line":19,"end_character":39},"in_reply_to":"a1abd6b9_3e7495ab","updated":"2022-07-05 16:15:04.000000000","message":"Done","commit_id":"5b2fd1f830827105bcaca0d4ba5da05b8b71c515"}],"tools/ovn_migration/tripleo_environment/ovn_migration.sh":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"89699b2bba77ce3ee200d61ca1eec51bc5ab8bb3","unresolved":true,"context_lines":[{"line_number":227,"context_line":"# Check if the stack exists"},{"line_number":228,"context_line":"function check_stack {"},{"line_number":229,"context_line":"    if [ ! -d $OOO_WORKDIR/$STACK_NAME/config-download/$STACK_NAME ]; then"},{"line_number":230,"context_line":"        echo \"ERROR: STACK_NAME\u003d${STACK_NAME} does not exist. Please provide the stack name or its ID \""},{"line_number":231,"context_line":"        echo \"       via STACK_NAME environment variable.\""},{"line_number":232,"context_line":"        exit 1"},{"line_number":233,"context_line":"    fi"},{"line_number":234,"context_line":"}"},{"line_number":235,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"f59658ec_a1aba650","line":232,"range":{"start_line":230,"start_character":0,"end_line":232,"end_character":14},"updated":"2022-03-24 08:41:09.000000000","message":"i think error message needs to be improved here as it no longer checking for stack but instead config-download dir, or may be better to check for inventory file here. May be better to check for inventory file itself instead of base directory and report inventory file is not present pass a valid one.\n\nAlso the script is no longer generating inventories, but instead utilizing already available one or just fails so seems need bit of restructuring the script.\n\n\nhttps://review.opendev.org/c/openstack/tripleo-validations/+/813535 is deprecating tripleo-ansible-inventory. Seems currently direct possible way is to regenerate full config-download to get the inventory.","commit_id":"5b2fd1f830827105bcaca0d4ba5da05b8b71c515"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"f0acac5eb2411eeef5f71ed4f38636d699d7af73","unresolved":false,"context_lines":[{"line_number":227,"context_line":"# Check if the stack exists"},{"line_number":228,"context_line":"function check_stack {"},{"line_number":229,"context_line":"    if [ ! -d $OOO_WORKDIR/$STACK_NAME/config-download/$STACK_NAME ]; then"},{"line_number":230,"context_line":"        echo \"ERROR: STACK_NAME\u003d${STACK_NAME} does not exist. Please provide the stack name or its ID \""},{"line_number":231,"context_line":"        echo \"       via STACK_NAME environment variable.\""},{"line_number":232,"context_line":"        exit 1"},{"line_number":233,"context_line":"    fi"},{"line_number":234,"context_line":"}"},{"line_number":235,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"1cc1099c_dde82928","line":232,"range":{"start_line":230,"start_character":0,"end_line":232,"end_character":14},"in_reply_to":"062b95e4_d40918fa","updated":"2022-07-05 16:15:04.000000000","message":"Done","commit_id":"5b2fd1f830827105bcaca0d4ba5da05b8b71c515"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"87d5e03ced8f1b04d558dcd5a56f687fde52782d","unresolved":true,"context_lines":[{"line_number":227,"context_line":"# Check if the stack exists"},{"line_number":228,"context_line":"function check_stack {"},{"line_number":229,"context_line":"    if [ ! -d $OOO_WORKDIR/$STACK_NAME/config-download/$STACK_NAME ]; then"},{"line_number":230,"context_line":"        echo \"ERROR: STACK_NAME\u003d${STACK_NAME} does not exist. Please provide the stack name or its ID \""},{"line_number":231,"context_line":"        echo \"       via STACK_NAME environment variable.\""},{"line_number":232,"context_line":"        exit 1"},{"line_number":233,"context_line":"    fi"},{"line_number":234,"context_line":"}"},{"line_number":235,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"062b95e4_d40918fa","line":232,"range":{"start_line":230,"start_character":0,"end_line":232,"end_character":14},"in_reply_to":"4424b4c0_2d9e27d0","updated":"2022-03-30 08:30:24.000000000","message":"Ok proposed https://review.opendev.org/c/openstack/neutron/+/835786 to fix the Error, let\u0027s coordinate improvements if any in the patch itself.","commit_id":"5b2fd1f830827105bcaca0d4ba5da05b8b71c515"},{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"1258b88a883d389de2f63965dfe4a4c6d9cff222","unresolved":true,"context_lines":[{"line_number":227,"context_line":"# Check if the stack exists"},{"line_number":228,"context_line":"function check_stack {"},{"line_number":229,"context_line":"    if [ ! -d $OOO_WORKDIR/$STACK_NAME/config-download/$STACK_NAME ]; then"},{"line_number":230,"context_line":"        echo \"ERROR: STACK_NAME\u003d${STACK_NAME} does not exist. Please provide the stack name or its ID \""},{"line_number":231,"context_line":"        echo \"       via STACK_NAME environment variable.\""},{"line_number":232,"context_line":"        exit 1"},{"line_number":233,"context_line":"    fi"},{"line_number":234,"context_line":"}"},{"line_number":235,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"4424b4c0_2d9e27d0","line":232,"range":{"start_line":230,"start_character":0,"end_line":232,"end_character":14},"in_reply_to":"9d48029b_568aa701","updated":"2022-03-29 14:13:25.000000000","message":"+2 on the error message improvement. I was just using this script(without knowing about this change) and I kept getting error about STACK_NAME not being defined although it was. Once I inspected the script, I realized that in my case $OOO_WORKDIR did not exists on my system. \nMaybe something like \"ERROR directory $OOO_WORKDIR/$STACK_NAME/config-download/$STACK_NAME not found. Hint, please ensure STACK_NAME is defined.\"\n\nor something like that","commit_id":"5b2fd1f830827105bcaca0d4ba5da05b8b71c515"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"7be78b8005e75359b28b7f4154cada38ea59b6d8","unresolved":true,"context_lines":[{"line_number":227,"context_line":"# Check if the stack exists"},{"line_number":228,"context_line":"function check_stack {"},{"line_number":229,"context_line":"    if [ ! -d $OOO_WORKDIR/$STACK_NAME/config-download/$STACK_NAME ]; then"},{"line_number":230,"context_line":"        echo \"ERROR: STACK_NAME\u003d${STACK_NAME} does not exist. Please provide the stack name or its ID \""},{"line_number":231,"context_line":"        echo \"       via STACK_NAME environment variable.\""},{"line_number":232,"context_line":"        exit 1"},{"line_number":233,"context_line":"    fi"},{"line_number":234,"context_line":"}"},{"line_number":235,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"aee18a7e_a82591e5","line":232,"range":{"start_line":230,"start_character":0,"end_line":232,"end_character":14},"in_reply_to":"ad9a0d7d_11e404c5","updated":"2022-03-25 19:01:46.000000000","message":"I think it\u0027s still the stack name that it looks for so I would consider this error message correct. I thought about using find utility but that will not guarantee what we found are correct data.\n\nThe script still generates the ansible inventory and stores it to hosts_for_migration file - that hasn\u0027t changed by this patch. You still can find the generated inventory file after running \"generate-inventory\" command.","commit_id":"5b2fd1f830827105bcaca0d4ba5da05b8b71c515"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"39092ef7ab0baf4abf23c6b1bce8a5e152b2f676","unresolved":true,"context_lines":[{"line_number":227,"context_line":"# Check if the stack exists"},{"line_number":228,"context_line":"function check_stack {"},{"line_number":229,"context_line":"    if [ ! -d $OOO_WORKDIR/$STACK_NAME/config-download/$STACK_NAME ]; then"},{"line_number":230,"context_line":"        echo \"ERROR: STACK_NAME\u003d${STACK_NAME} does not exist. Please provide the stack name or its ID \""},{"line_number":231,"context_line":"        echo \"       via STACK_NAME environment variable.\""},{"line_number":232,"context_line":"        exit 1"},{"line_number":233,"context_line":"    fi"},{"line_number":234,"context_line":"}"},{"line_number":235,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"9d48029b_568aa701","line":232,"range":{"start_line":230,"start_character":0,"end_line":232,"end_character":14},"in_reply_to":"aee18a7e_a82591e5","updated":"2022-03-28 05:26:23.000000000","message":"Actually -d here is checking for directory for particular stack on the host, not the stack on ephemeral heat instance, it always possible stack exist in ephemeral heat but not the config-download directory, also the directory will be created with stack name and not it\u0027s ID. Error message can be always updated later when needed. I believe in future there will be something available to regenerate just the inventory and not full config-download.\nwrt not using find utility /me agrees with you.\n\nWrt generate inventory, ok i read again and see hosts_for_migration is getting generated, just the source changed now. So it should be ok.","commit_id":"5b2fd1f830827105bcaca0d4ba5da05b8b71c515"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"372bf9d299d5aba8bd9d1eba933bae623ae93ca6","unresolved":true,"context_lines":[{"line_number":227,"context_line":"# Check if the stack exists"},{"line_number":228,"context_line":"function check_stack {"},{"line_number":229,"context_line":"    if [ ! -d $OOO_WORKDIR/$STACK_NAME/config-download/$STACK_NAME ]; then"},{"line_number":230,"context_line":"        echo \"ERROR: STACK_NAME\u003d${STACK_NAME} does not exist. Please provide the stack name or its ID \""},{"line_number":231,"context_line":"        echo \"       via STACK_NAME environment variable.\""},{"line_number":232,"context_line":"        exit 1"},{"line_number":233,"context_line":"    fi"},{"line_number":234,"context_line":"}"},{"line_number":235,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"ad9a0d7d_11e404c5","line":232,"range":{"start_line":230,"start_character":0,"end_line":232,"end_character":14},"in_reply_to":"f59658ec_a1aba650","updated":"2022-03-25 15:48:39.000000000","message":"+1 but can be done in follow-up patch later too probably.","commit_id":"5b2fd1f830827105bcaca0d4ba5da05b8b71c515"}]}