)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d8fa8c3083652f44c4f2de731fa18ad5aa40511c","unresolved":true,"context_lines":[{"line_number":11,"context_line":"and leaves the environment on a unusable state."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The revert plan has two stages:"},{"line_number":14,"context_line":"1- Rackup stage: included on the current ovn-migration.yml."},{"line_number":15,"context_line":"   Can be configured using the env variable CREATE_BACKUP"},{"line_number":16,"context_line":"   (True by default). This stage will run the new ansible"},{"line_number":17,"context_line":"   role, recovery-backup."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"1baee7f1_01b57f75","line":14,"range":{"start_line":14,"start_character":3,"end_line":14,"end_character":9},"updated":"2022-06-23 10:34:42.000000000","message":"nitty nit: Backup","commit_id":"855a55eeef6fdc886820179d18b711cc06d1d27d"},{"author":{"_account_id":34118,"name":"Arnau Verdaguer","email":"averdagu@redhat.com","username":"averdaguer"},"change_message_id":"cb3242037eb959e044e78832110f69d189e6038e","unresolved":false,"context_lines":[{"line_number":11,"context_line":"and leaves the environment on a unusable state."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The revert plan has two stages:"},{"line_number":14,"context_line":"1- Rackup stage: included on the current ovn-migration.yml."},{"line_number":15,"context_line":"   Can be configured using the env variable CREATE_BACKUP"},{"line_number":16,"context_line":"   (True by default). This stage will run the new ansible"},{"line_number":17,"context_line":"   role, recovery-backup."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"73b0cf28_cb64d7e1","line":14,"range":{"start_line":14,"start_character":3,"end_line":14,"end_character":9},"in_reply_to":"1baee7f1_01b57f75","updated":"2022-06-23 14:46:44.000000000","message":"Done","commit_id":"855a55eeef6fdc886820179d18b711cc06d1d27d"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":34118,"name":"Arnau Verdaguer","email":"averdagu@redhat.com","username":"averdaguer"},"change_message_id":"25abcf1af16b468fa40bae77fe71062e9bfe926f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"605b86a5_d799ca7c","updated":"2022-05-11 10:17:44.000000000","message":"Thanks for your comments Roman :)","commit_id":"38193214b5dfdf2c71f4e1cc5823a10953cf82f0"},{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"2644e3a0af21b2b3e7ddcb14456d9c182f4f9901","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"3a7bda15_abc0bd3f","updated":"2022-06-24 09:46:42.000000000","message":"Awesome! Some nits below","commit_id":"f185073e13d0d2a58893c3f10592131814e59b02"},{"author":{"_account_id":34118,"name":"Arnau Verdaguer","email":"averdagu@redhat.com","username":"averdaguer"},"change_message_id":"cb3242037eb959e044e78832110f69d189e6038e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"f628dc0c_c4388493","updated":"2022-06-23 14:46:44.000000000","message":"Thanks a lot for your comments Slawek 😊","commit_id":"f185073e13d0d2a58893c3f10592131814e59b02"},{"author":{"_account_id":34118,"name":"Arnau Verdaguer","email":"averdagu@redhat.com","username":"averdaguer"},"change_message_id":"09d2c8cd460910bf63db031d93db717e67f085c8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"d9dc7da3_99555edf","updated":"2022-06-24 10:53:13.000000000","message":"Thanks for your comments Elvira 😊","commit_id":"55f76e54b83b5f410023e05b6a1732981d879b00"},{"author":{"_account_id":34118,"name":"Arnau Verdaguer","email":"averdagu@redhat.com","username":"averdaguer"},"change_message_id":"70b219a79160d4eb11a4c342a1457a5ad479f27e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"d5e366cb_81699fb6","updated":"2022-06-24 12:44:19.000000000","message":"recheck","commit_id":"55f76e54b83b5f410023e05b6a1732981d879b00"}],"tools/ovn_migration/tripleo_environment/ovn_migration.sh":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"e40cf5f26f57b3b670d1695b2289b8571ff3045d","unresolved":true,"context_lines":[{"line_number":102,"context_line":"        exit 1"},{"line_number":103,"context_line":"    fi"},{"line_number":104,"context_line":"    # Check if backup is enabled"},{"line_number":105,"context_line":"    if [[ $CREATE_BACKUP \u003d false ]] || [[ $CREATE_BACKUP \u003d False ]] || [[ $CREATE_BACKUP \u003d FALSE ]]; then"},{"line_number":106,"context_line":"        # Check if backup server is reachable"},{"line_number":107,"context_line":"        ping -c4 $BACKUP_MIGRATION_IP"},{"line_number":108,"context_line":"        if [[ $? -eq 1 ]]; then"}],"source_content_type":"text/x-sh","patch_set":18,"id":"fec2d7d5_5ecd1869","line":105,"range":{"start_line":105,"start_character":4,"end_line":105,"end_character":105},"updated":"2022-07-20 21:56:17.000000000","message":"I\u0027m sorry for the stupid question. I may be missing something or maybe I need to be educated on bash, but don\u0027t we want to test for:\n\nif [[ $CREATE_BACKUP \u003d True ]]; then","commit_id":"ffcea178227013db1c182ef2e77758dfcdc72309"}],"tools/ovn_migration/tripleo_environment/playbooks/ovn-migration.yml":[{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"2644e3a0af21b2b3e7ddcb14456d9c182f4f9901","unresolved":true,"context_lines":[{"line_number":26,"context_line":"  tags:"},{"line_number":27,"context_line":"    - setup"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"- name: Stop ml2/ovs resources"},{"line_number":31,"context_line":"  hosts: ovn-controllers"},{"line_number":32,"context_line":"  roles:"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"d3383419_7f1c79b1","side":"PARENT","line":29,"updated":"2022-06-24 09:46:42.000000000","message":"nitty nit: unnecessary line erasing?","commit_id":"af0dd9bcb5c6df6bc6ba8dbdbcba65a821178e2c"},{"author":{"_account_id":34118,"name":"Arnau Verdaguer","email":"averdagu@redhat.com","username":"averdaguer"},"change_message_id":"09d2c8cd460910bf63db031d93db717e67f085c8","unresolved":false,"context_lines":[{"line_number":26,"context_line":"  tags:"},{"line_number":27,"context_line":"    - setup"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"- name: Stop ml2/ovs resources"},{"line_number":31,"context_line":"  hosts: ovn-controllers"},{"line_number":32,"context_line":"  roles:"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"2feec675_ac9ae265","side":"PARENT","line":29,"in_reply_to":"d3383419_7f1c79b1","updated":"2022-06-24 10:53:13.000000000","message":"Done","commit_id":"af0dd9bcb5c6df6bc6ba8dbdbcba65a821178e2c"},{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"2644e3a0af21b2b3e7ddcb14456d9c182f4f9901","unresolved":true,"context_lines":[{"line_number":34,"context_line":"  tags:"},{"line_number":35,"context_line":"    - migration"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"#"},{"line_number":39,"context_line":"# TripleO / Director is executed to deploy ovn using \"br-migration\" for the"},{"line_number":40,"context_line":"# dataplane, while br-int is left intact to avoid dataplane disruption."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"3627eec1_0d435570","side":"PARENT","line":37,"updated":"2022-06-24 09:46:42.000000000","message":"nitty nit: unnecessary line erasing?","commit_id":"af0dd9bcb5c6df6bc6ba8dbdbcba65a821178e2c"},{"author":{"_account_id":34118,"name":"Arnau Verdaguer","email":"averdagu@redhat.com","username":"averdaguer"},"change_message_id":"09d2c8cd460910bf63db031d93db717e67f085c8","unresolved":false,"context_lines":[{"line_number":34,"context_line":"  tags:"},{"line_number":35,"context_line":"    - migration"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"#"},{"line_number":39,"context_line":"# TripleO / Director is executed to deploy ovn using \"br-migration\" for the"},{"line_number":40,"context_line":"# dataplane, while br-int is left intact to avoid dataplane disruption."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"2e4728f6_baba468b","side":"PARENT","line":37,"in_reply_to":"3627eec1_0d435570","updated":"2022-06-24 10:53:13.000000000","message":"Done","commit_id":"af0dd9bcb5c6df6bc6ba8dbdbcba65a821178e2c"}],"tools/ovn_migration/tripleo_environment/playbooks/roles/backup/tasks/main.yml":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d8fa8c3083652f44c4f2de731fa18ad5aa40511c","unresolved":true,"context_lines":[{"line_number":15,"context_line":"  register: command_result"},{"line_number":16,"context_line":"  changed_when: \"\u0027Backed up\u0027 in command_result.stdout\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# At this point is possible that some files used in overcloud_deploy"},{"line_number":19,"context_line":"# have been modified with OVN values (eg. tunneltypes) need to rethink it"},{"line_number":20,"context_line":"# possibly"},{"line_number":21,"context_line":"#- name: Copy overcloud_deploy in case is needed in revert plan"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"1d138ab0_5d7572e0","line":18,"range":{"start_line":18,"start_character":16,"end_line":18,"end_character":18},"updated":"2022-06-23 10:34:42.000000000","message":"nitty nit: \"it is\"","commit_id":"855a55eeef6fdc886820179d18b711cc06d1d27d"},{"author":{"_account_id":34118,"name":"Arnau Verdaguer","email":"averdagu@redhat.com","username":"averdaguer"},"change_message_id":"cb3242037eb959e044e78832110f69d189e6038e","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  register: command_result"},{"line_number":16,"context_line":"  changed_when: \"\u0027Backed up\u0027 in command_result.stdout\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# At this point is possible that some files used in overcloud_deploy"},{"line_number":19,"context_line":"# have been modified with OVN values (eg. tunneltypes) need to rethink it"},{"line_number":20,"context_line":"# possibly"},{"line_number":21,"context_line":"#- name: Copy overcloud_deploy in case is needed in revert plan"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"e161cb6d_44d65eeb","line":18,"range":{"start_line":18,"start_character":16,"end_line":18,"end_character":18},"in_reply_to":"1d138ab0_5d7572e0","updated":"2022-06-23 14:46:44.000000000","message":"Done","commit_id":"855a55eeef6fdc886820179d18b711cc06d1d27d"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d8fa8c3083652f44c4f2de731fa18ad5aa40511c","unresolved":true,"context_lines":[{"line_number":26,"context_line":"#  shell:"},{"line_number":27,"context_line":"#    grep \u0027^/-e\u0027 {{ ovn_migration_backups }}/overcloud_deploy.sh | cut -d\u0027 \u0027 -f2 | \\"},{"line_number":28,"context_line":"#      xargs -I % cp % {{ ovn_migration_backups }}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# TODO(majopela): Include steps for backing up the mysql database on the"},{"line_number":31,"context_line":"#                 controllers and the undercloud before continuing"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"768c7acc_e0aa82f9","line":29,"updated":"2022-06-23 10:34:42.000000000","message":"is this commented code needed here really?","commit_id":"855a55eeef6fdc886820179d18b711cc06d1d27d"},{"author":{"_account_id":34118,"name":"Arnau Verdaguer","email":"averdagu@redhat.com","username":"averdaguer"},"change_message_id":"cb3242037eb959e044e78832110f69d189e6038e","unresolved":false,"context_lines":[{"line_number":26,"context_line":"#  shell:"},{"line_number":27,"context_line":"#    grep \u0027^/-e\u0027 {{ ovn_migration_backups }}/overcloud_deploy.sh | cut -d\u0027 \u0027 -f2 | \\"},{"line_number":28,"context_line":"#      xargs -I % cp % {{ ovn_migration_backups }}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# TODO(majopela): Include steps for backing up the mysql database on the"},{"line_number":31,"context_line":"#                 controllers and the undercloud before continuing"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3552710f_39ed22e4","line":29,"in_reply_to":"768c7acc_e0aa82f9","updated":"2022-06-23 14:46:44.000000000","message":"No, this was some initial approach that I forgot to remove and it made it until here, removing the modification on this file, thanks","commit_id":"855a55eeef6fdc886820179d18b711cc06d1d27d"}],"tools/ovn_migration/tripleo_environment/playbooks/roles/configure-and-backup-controllers/defaults/main.yml":[{"author":{"_account_id":34118,"name":"Arnau Verdaguer","email":"averdagu@redhat.com","username":"averdaguer"},"change_message_id":"a4a4935a9032aff62fd51edd7b14ea3dd6daa6e7","unresolved":true,"context_lines":[{"line_number":4,"context_line":"revert_preparation_backup_ip: 192.168.24.1"},{"line_number":5,"context_line":"# Name of the group hosts where the NFS instalation will take place"},{"line_number":6,"context_line":"# If the NFS server is the undercloud (and there are only one) will"},{"line_number":7,"context_line":"# not be a problem, but if exists multiples servers on the server_name group"},{"line_number":8,"context_line":"# it is possible that the nfs will be installed on every server, eventho the"},{"line_number":9,"context_line":"# storage of the backup will only be done in the backup_ip."},{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"# This can be solved if a new tripleo-inventory is manually created specifying"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"0618b274_88817fbf","line":8,"range":{"start_line":7,"start_character":20,"end_line":8,"end_character":63},"updated":"2022-05-06 15:27:06.000000000","message":"This is correct, if the revert_preparation_server_name is set to CephStorage (and the environment have 2 ceph nodes) the NFS server will be configured on both machines","commit_id":"1f54da4c3a730097720e3e4af6243e0c67b09b16"},{"author":{"_account_id":34118,"name":"Arnau Verdaguer","email":"averdagu@redhat.com","username":"averdaguer"},"change_message_id":"cb3242037eb959e044e78832110f69d189e6038e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"revert_preparation_backup_ip: 192.168.24.1"},{"line_number":5,"context_line":"# Name of the group hosts where the NFS instalation will take place"},{"line_number":6,"context_line":"# If the NFS server is the undercloud (and there are only one) will"},{"line_number":7,"context_line":"# not be a problem, but if exists multiples servers on the server_name group"},{"line_number":8,"context_line":"# it is possible that the nfs will be installed on every server, eventho the"},{"line_number":9,"context_line":"# storage of the backup will only be done in the backup_ip."},{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"# This can be solved if a new tripleo-inventory is manually created specifying"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"d8ed8bc0_d65bb637","line":8,"range":{"start_line":7,"start_character":20,"end_line":8,"end_character":63},"in_reply_to":"0618b274_88817fbf","updated":"2022-06-23 14:46:44.000000000","message":"Done","commit_id":"1f54da4c3a730097720e3e4af6243e0c67b09b16"},{"author":{"_account_id":29350,"name":"Roman Safronov","email":"rsafrono@redhat.com","username":"rsafrono"},"change_message_id":"1153fa3c8acd4340b8effc1de344d5732ac2c97e","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# By default this IP should belong to the Undercloud"},{"line_number":4,"context_line":"revert_preparation_backup_ip: 192.168.24.1"},{"line_number":5,"context_line":"# Name of the group hosts where the NFS instalation will take place"},{"line_number":6,"context_line":"# If the NFS server is the undercloud (and there are only one) will"},{"line_number":7,"context_line":"# not be a problem, but if exists multiples servers on the server_name group"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"2cb22cbf_03db17b9","line":4,"range":{"start_line":4,"start_character":30,"end_line":4,"end_character":42},"updated":"2022-05-11 09:03:54.000000000","message":"I think this should be configurable, probably as an environment variable in the ovn_migration.sh script","commit_id":"a890caf4e0cc1a61dfa2c8c4df2723536f209ef6"},{"author":{"_account_id":34118,"name":"Arnau Verdaguer","email":"averdagu@redhat.com","username":"averdaguer"},"change_message_id":"25abcf1af16b468fa40bae77fe71062e9bfe926f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# By default this IP should belong to the Undercloud"},{"line_number":4,"context_line":"revert_preparation_backup_ip: 192.168.24.1"},{"line_number":5,"context_line":"# Name of the group hosts where the NFS instalation will take place"},{"line_number":6,"context_line":"# If the NFS server is the undercloud (and there are only one) will"},{"line_number":7,"context_line":"# not be a problem, but if exists multiples servers on the server_name group"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"06ea477d_c7f39922","line":4,"range":{"start_line":4,"start_character":30,"end_line":4,"end_character":42},"in_reply_to":"2cb22cbf_03db17b9","updated":"2022-05-11 10:17:44.000000000","message":"Done","commit_id":"a890caf4e0cc1a61dfa2c8c4df2723536f209ef6"}],"tools/ovn_migration/tripleo_environment/playbooks/roles/configure-and-backup-controllers/tasks/main.yml":[{"author":{"_account_id":29350,"name":"Roman Safronov","email":"rsafrono@redhat.com","username":"rsafrono"},"change_message_id":"4292adb476d077b6558a0fe44f1cdb29734db89b","unresolved":true,"context_lines":[{"line_number":39,"context_line":"# Ensure that after the controller backups the api responds"},{"line_number":40,"context_line":" - name: Ensure that the OSP api is working"},{"line_number":41,"context_line":"   shell: \u003e"},{"line_number":42,"context_line":"     source /home/stack/overcloudrc \u0026\u0026 openstack port list"},{"line_number":43,"context_line":"   retries: 20"},{"line_number":44,"context_line":"   register: api_rc"},{"line_number":45,"context_line":"   delay: 5"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"a7eb25eb_6fd69016","line":42,"range":{"start_line":42,"start_character":12,"end_line":42,"end_character":35},"updated":"2022-05-09 22:49:25.000000000","message":"we should support other stack names as well, i.e. it would be better to have here {{ overcloudrc }}","commit_id":"1f54da4c3a730097720e3e4af6243e0c67b09b16"},{"author":{"_account_id":34118,"name":"Arnau Verdaguer","email":"averdagu@redhat.com","username":"averdaguer"},"change_message_id":"3de5d8003825ad1b6382a885efc8ea262136c05f","unresolved":false,"context_lines":[{"line_number":39,"context_line":"# Ensure that after the controller backups the api responds"},{"line_number":40,"context_line":" - name: Ensure that the OSP api is working"},{"line_number":41,"context_line":"   shell: \u003e"},{"line_number":42,"context_line":"     source /home/stack/overcloudrc \u0026\u0026 openstack port list"},{"line_number":43,"context_line":"   retries: 20"},{"line_number":44,"context_line":"   register: api_rc"},{"line_number":45,"context_line":"   delay: 5"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"14f7e434_db4c232c","line":42,"range":{"start_line":42,"start_character":12,"end_line":42,"end_character":35},"in_reply_to":"a7eb25eb_6fd69016","updated":"2022-05-11 08:53:27.000000000","message":"Good idea, thanks!","commit_id":"1f54da4c3a730097720e3e4af6243e0c67b09b16"},{"author":{"_account_id":29350,"name":"Roman Safronov","email":"rsafrono@redhat.com","username":"rsafrono"},"change_message_id":"4292adb476d077b6558a0fe44f1cdb29734db89b","unresolved":true,"context_lines":[{"line_number":37,"context_line":"    --inventory {{ backup_and_recover_temp_folder }}/tripleo-inventory.yaml"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"# Ensure that after the controller backups the api responds"},{"line_number":40,"context_line":" - name: Ensure that the OSP api is working"},{"line_number":41,"context_line":"   shell: \u003e"},{"line_number":42,"context_line":"     source /home/stack/overcloudrc \u0026\u0026 openstack port list"},{"line_number":43,"context_line":"   retries: 20"},{"line_number":44,"context_line":"   register: api_rc"},{"line_number":45,"context_line":"   delay: 5"},{"line_number":46,"context_line":"   ignore_errors: yes"},{"line_number":47,"context_line":"   until: api_rc.rc \u003d\u003d \"0\""},{"line_number":48,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"dd1548de_e0aa9433","line":48,"range":{"start_line":40,"start_character":0,"end_line":48,"end_character":0},"updated":"2022-05-09 22:49:25.000000000","message":"each line here has a redundant space at the beginning of line","commit_id":"1f54da4c3a730097720e3e4af6243e0c67b09b16"},{"author":{"_account_id":34118,"name":"Arnau Verdaguer","email":"averdagu@redhat.com","username":"averdaguer"},"change_message_id":"3de5d8003825ad1b6382a885efc8ea262136c05f","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    --inventory {{ backup_and_recover_temp_folder }}/tripleo-inventory.yaml"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"# Ensure that after the controller backups the api responds"},{"line_number":40,"context_line":" - name: Ensure that the OSP api is working"},{"line_number":41,"context_line":"   shell: \u003e"},{"line_number":42,"context_line":"     source /home/stack/overcloudrc \u0026\u0026 openstack port list"},{"line_number":43,"context_line":"   retries: 20"},{"line_number":44,"context_line":"   register: api_rc"},{"line_number":45,"context_line":"   delay: 5"},{"line_number":46,"context_line":"   ignore_errors: yes"},{"line_number":47,"context_line":"   until: api_rc.rc \u003d\u003d \"0\""},{"line_number":48,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"05f8d213_3c9e6dfd","line":48,"range":{"start_line":40,"start_character":0,"end_line":48,"end_character":0},"in_reply_to":"dd1548de_e0aa9433","updated":"2022-05-11 08:53:27.000000000","message":"Good eye, done!","commit_id":"1f54da4c3a730097720e3e4af6243e0c67b09b16"},{"author":{"_account_id":29350,"name":"Roman Safronov","email":"rsafrono@redhat.com","username":"rsafrono"},"change_message_id":"1153fa3c8acd4340b8effc1de344d5732ac2c97e","unresolved":true,"context_lines":[{"line_number":9,"context_line":"  shell: |"},{"line_number":10,"context_line":"    . ~/stackrc \u0026\u0026"},{"line_number":11,"context_line":"    tripleo-ansible-inventory \\"},{"line_number":12,"context_line":"    --ansible_ssh_user heat-admin \\"},{"line_number":13,"context_line":"    --static-yaml-inventory {{ backup_and_recover_temp_folder }}/tripleo-inventory.yaml"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"- name: Setup NFS on the backup node using IP {{ revert_preparation_backup_ip }}"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"8b93852f_37b06f84","line":12,"range":{"start_line":12,"start_character":23,"end_line":12,"end_character":33},"updated":"2022-05-11 09:03:54.000000000","message":"as we saw in the past, some customers can have a custom name here. We have UNDERCLOUD_NODE_USER defined in the ovn_migration.sh script. Here we should use this value somehow.","commit_id":"a890caf4e0cc1a61dfa2c8c4df2723536f209ef6"},{"author":{"_account_id":34118,"name":"Arnau Verdaguer","email":"averdagu@redhat.com","username":"averdaguer"},"change_message_id":"25abcf1af16b468fa40bae77fe71062e9bfe926f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"  shell: |"},{"line_number":10,"context_line":"    . ~/stackrc \u0026\u0026"},{"line_number":11,"context_line":"    tripleo-ansible-inventory \\"},{"line_number":12,"context_line":"    --ansible_ssh_user heat-admin \\"},{"line_number":13,"context_line":"    --static-yaml-inventory {{ backup_and_recover_temp_folder }}/tripleo-inventory.yaml"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"- name: Setup NFS on the backup node using IP {{ revert_preparation_backup_ip }}"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"133476a4_1f8cc299","line":12,"range":{"start_line":12,"start_character":23,"end_line":12,"end_character":33},"in_reply_to":"8b93852f_37b06f84","updated":"2022-05-11 10:17:44.000000000","message":"Done","commit_id":"a890caf4e0cc1a61dfa2c8c4df2723536f209ef6"}],"tools/ovn_migration/tripleo_environment/playbooks/roles/recovery-backup/defaults/main.yml":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d8fa8c3083652f44c4f2de731fa18ad5aa40511c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Name of the group hosts where the NFS instalation will take place"},{"line_number":4,"context_line":"# If the NFS server is the undercloud (and there are only one) will"},{"line_number":5,"context_line":"# not be a problem, but if exists multiples servers on the server_name group"},{"line_number":6,"context_line":"# it is possible that the nfs will be installed on every server, eventho the"},{"line_number":7,"context_line":"# storage of the backup will only be done in the backup_ip."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"6e70061e_6dd0e002","line":4,"range":{"start_line":4,"start_character":49,"end_line":4,"end_character":52},"updated":"2022-06-23 10:34:42.000000000","message":"nitty nit: \"is\"","commit_id":"855a55eeef6fdc886820179d18b711cc06d1d27d"},{"author":{"_account_id":34118,"name":"Arnau Verdaguer","email":"averdagu@redhat.com","username":"averdaguer"},"change_message_id":"cb3242037eb959e044e78832110f69d189e6038e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Name of the group hosts where the NFS instalation will take place"},{"line_number":4,"context_line":"# If the NFS server is the undercloud (and there are only one) will"},{"line_number":5,"context_line":"# not be a problem, but if exists multiples servers on the server_name group"},{"line_number":6,"context_line":"# it is possible that the nfs will be installed on every server, eventho the"},{"line_number":7,"context_line":"# storage of the backup will only be done in the backup_ip."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"680a4f79_76c70fbe","line":4,"range":{"start_line":4,"start_character":49,"end_line":4,"end_character":52},"in_reply_to":"6e70061e_6dd0e002","updated":"2022-06-23 14:46:44.000000000","message":"Done","commit_id":"855a55eeef6fdc886820179d18b711cc06d1d27d"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d8fa8c3083652f44c4f2de731fa18ad5aa40511c","unresolved":true,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Name of the group hosts where the NFS instalation will take place"},{"line_number":4,"context_line":"# If the NFS server is the undercloud (and there are only one) will"},{"line_number":5,"context_line":"# not be a problem, but if exists multiples servers on the server_name group"},{"line_number":6,"context_line":"# it is possible that the nfs will be installed on every server, eventho the"},{"line_number":7,"context_line":"# storage of the backup will only be done in the backup_ip."},{"line_number":8,"context_line":"#"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"ea6af922_87e52e2f","line":5,"range":{"start_line":5,"start_character":24,"end_line":5,"end_character":51},"updated":"2022-06-23 10:34:42.000000000","message":"if multiple servers exist","commit_id":"855a55eeef6fdc886820179d18b711cc06d1d27d"},{"author":{"_account_id":34118,"name":"Arnau Verdaguer","email":"averdagu@redhat.com","username":"averdaguer"},"change_message_id":"cb3242037eb959e044e78832110f69d189e6038e","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Name of the group hosts where the NFS instalation will take place"},{"line_number":4,"context_line":"# If the NFS server is the undercloud (and there are only one) will"},{"line_number":5,"context_line":"# not be a problem, but if exists multiples servers on the server_name group"},{"line_number":6,"context_line":"# it is possible that the nfs will be installed on every server, eventho the"},{"line_number":7,"context_line":"# storage of the backup will only be done in the backup_ip."},{"line_number":8,"context_line":"#"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"973cdc9a_49404ace","line":5,"range":{"start_line":5,"start_character":24,"end_line":5,"end_character":51},"in_reply_to":"ea6af922_87e52e2f","updated":"2022-06-23 14:46:44.000000000","message":"Done","commit_id":"855a55eeef6fdc886820179d18b711cc06d1d27d"}],"tools/ovn_migration/tripleo_environment/playbooks/roles/recovery-backup/tasks/main.yml":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d8fa8c3083652f44c4f2de731fa18ad5aa40511c","unresolved":true,"context_lines":[{"line_number":4,"context_line":"  file:"},{"line_number":5,"context_line":"    state: directory"},{"line_number":6,"context_line":"    path: \"{{ backup_and_recover_temp_folder }}\""},{"line_number":7,"context_line":"  when: create_backup|bool"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- name: Generate tripleo inventory"},{"line_number":10,"context_line":"  shell: |"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"c290a7c6_74207d54","line":7,"range":{"start_line":7,"start_character":2,"end_line":7,"end_character":26},"updated":"2022-06-23 10:34:42.000000000","message":"I\u0027m not ansible expert but I think You can move all those actions into one block and then use only one \"when\" clause for whole block","commit_id":"855a55eeef6fdc886820179d18b711cc06d1d27d"},{"author":{"_account_id":34118,"name":"Arnau Verdaguer","email":"averdagu@redhat.com","username":"averdaguer"},"change_message_id":"cb3242037eb959e044e78832110f69d189e6038e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  file:"},{"line_number":5,"context_line":"    state: directory"},{"line_number":6,"context_line":"    path: \"{{ backup_and_recover_temp_folder }}\""},{"line_number":7,"context_line":"  when: create_backup|bool"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- name: Generate tripleo inventory"},{"line_number":10,"context_line":"  shell: |"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"b8b805c5_698558cd","line":7,"range":{"start_line":7,"start_character":2,"end_line":7,"end_character":26},"in_reply_to":"c290a7c6_74207d54","updated":"2022-06-23 14:46:44.000000000","message":"Done","commit_id":"855a55eeef6fdc886820179d18b711cc06d1d27d"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d8fa8c3083652f44c4f2de731fa18ad5aa40511c","unresolved":true,"context_lines":[{"line_number":47,"context_line":"# Ensure that after the controller backups the api responds"},{"line_number":48,"context_line":"- name: Ensure that the OSP api is working"},{"line_number":49,"context_line":"  shell: \u003e"},{"line_number":50,"context_line":"    source {{ overcloudrc }} \u0026\u0026 openstack port list"},{"line_number":51,"context_line":"  retries: 20"},{"line_number":52,"context_line":"  register: api_rc"},{"line_number":53,"context_line":"  delay: 5"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"dc699d93_5111faa8","line":50,"range":{"start_line":50,"start_character":32,"end_line":50,"end_character":51},"updated":"2022-06-23 10:34:42.000000000","message":"in case if there is a lot of ports it may be slow query sometimes, maybe better would be to e.g. list extensions or something like that which will not depend on the resources created in the cloud that much?","commit_id":"855a55eeef6fdc886820179d18b711cc06d1d27d"},{"author":{"_account_id":34118,"name":"Arnau Verdaguer","email":"averdagu@redhat.com","username":"averdaguer"},"change_message_id":"cb3242037eb959e044e78832110f69d189e6038e","unresolved":false,"context_lines":[{"line_number":47,"context_line":"# Ensure that after the controller backups the api responds"},{"line_number":48,"context_line":"- name: Ensure that the OSP api is working"},{"line_number":49,"context_line":"  shell: \u003e"},{"line_number":50,"context_line":"    source {{ overcloudrc }} \u0026\u0026 openstack port list"},{"line_number":51,"context_line":"  retries: 20"},{"line_number":52,"context_line":"  register: api_rc"},{"line_number":53,"context_line":"  delay: 5"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"60f0f41c_81ed1a0e","line":50,"range":{"start_line":50,"start_character":32,"end_line":50,"end_character":51},"in_reply_to":"dc699d93_5111faa8","updated":"2022-06-23 14:46:44.000000000","message":"I didn\u0027t think on a large environment when I did this part, modifying it to\n`openstack flavor list`. If you think of a better API call feel free to leave a comment 😊","commit_id":"855a55eeef6fdc886820179d18b711cc06d1d27d"},{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"2644e3a0af21b2b3e7ddcb14456d9c182f4f9901","unresolved":true,"context_lines":[{"line_number":6,"context_line":"      file:"},{"line_number":7,"context_line":"        state: directory"},{"line_number":8,"context_line":"        path: \"{{ backup_and_recover_temp_folder }}\""},{"line_number":9,"context_line":"    "},{"line_number":10,"context_line":"    - name: Generate tripleo inventory"},{"line_number":11,"context_line":"      shell: |"},{"line_number":12,"context_line":"        source {{ stackrc }} \u0026\u0026"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"3079cf4a_a41c971f","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":4},"updated":"2022-06-24 09:46:42.000000000","message":"There are extra spaces through all this block","commit_id":"f185073e13d0d2a58893c3f10592131814e59b02"},{"author":{"_account_id":34118,"name":"Arnau Verdaguer","email":"averdagu@redhat.com","username":"averdaguer"},"change_message_id":"09d2c8cd460910bf63db031d93db717e67f085c8","unresolved":false,"context_lines":[{"line_number":6,"context_line":"      file:"},{"line_number":7,"context_line":"        state: directory"},{"line_number":8,"context_line":"        path: \"{{ backup_and_recover_temp_folder }}\""},{"line_number":9,"context_line":"    "},{"line_number":10,"context_line":"    - name: Generate tripleo inventory"},{"line_number":11,"context_line":"      shell: |"},{"line_number":12,"context_line":"        source {{ stackrc }} \u0026\u0026"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9d60f6b4_094c7c55","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":4},"in_reply_to":"3079cf4a_a41c971f","updated":"2022-06-24 10:53:13.000000000","message":"Done","commit_id":"f185073e13d0d2a58893c3f10592131814e59b02"},{"author":{"_account_id":29350,"name":"Roman Safronov","email":"rsafrono@redhat.com","username":"rsafrono"},"change_message_id":"475e80d86f87be8cb3184efd78c3356daf47d9d7","unresolved":true,"context_lines":[{"line_number":10,"context_line":"    - name: Generate tripleo inventory"},{"line_number":11,"context_line":"      shell: |"},{"line_number":12,"context_line":"        source {{ stackrc }} \u0026\u0026"},{"line_number":13,"context_line":"        tripleo-ansible-inventory \\"},{"line_number":14,"context_line":"        --ansible_ssh_user {{ undercloud_node_user }} \\"},{"line_number":15,"context_line":"        --static-yaml-inventory {{ backup_and_recover_temp_folder }}/tripleo-inventory.yaml"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":15,"id":"4115e4ce_1c965641","line":13,"range":{"start_line":13,"start_character":8,"end_line":13,"end_character":33},"updated":"2022-06-26 20:57:40.000000000","message":"Note, this won\u0027t not work starting from Wallaby (or RH OSP17), see https://review.opendev.org/c/openstack/neutron/+/834925/\n\nHowever we still can use this in Train (RH OSP16.X) if the feature is relevant there.","commit_id":"1ad55160ee39f00f6df4b397558e0d3dcabe632f"},{"author":{"_account_id":34118,"name":"Arnau Verdaguer","email":"averdagu@redhat.com","username":"averdaguer"},"change_message_id":"fd8f94c5d61131736fe497de7243aee06e3bb433","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    - name: Generate tripleo inventory"},{"line_number":11,"context_line":"      shell: |"},{"line_number":12,"context_line":"        source {{ stackrc }} \u0026\u0026"},{"line_number":13,"context_line":"        tripleo-ansible-inventory \\"},{"line_number":14,"context_line":"        --ansible_ssh_user {{ undercloud_node_user }} \\"},{"line_number":15,"context_line":"        --static-yaml-inventory {{ backup_and_recover_temp_folder }}/tripleo-inventory.yaml"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":15,"id":"4658d65c_9506b0c7","line":13,"range":{"start_line":13,"start_character":8,"end_line":13,"end_character":33},"in_reply_to":"4115e4ce_1c965641","updated":"2022-06-28 15:40:13.000000000","message":"Thanks for pointing this out Roman, I modified the code to work on both, OSP17 and OSP16.","commit_id":"1ad55160ee39f00f6df4b397558e0d3dcabe632f"}]}