)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"a33297adba34acea0b1210f2f2d292e06b769905","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"909ff190_92723ece","updated":"2022-04-05 17:57:36.000000000","message":"\u0027Ship it\u0027 for me. You can drop my nitpick comment if its not worth it.","commit_id":"df03b313078d3d6b3ba9bb7e4b6290600e2254ca"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"c9117dcb75bd96333def5f5b82b86b8088c3838d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2ca1ebd3_b5c67240","updated":"2022-04-11 06:57:39.000000000","message":"@Jakub can u please check the updates if looks ok to you?","commit_id":"df03b313078d3d6b3ba9bb7e4b6290600e2254ca"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"9349e9be2f8bed01ffb227ec517dca25d30fa28e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f3f60ab9_58408107","updated":"2022-04-11 17:00:18.000000000","message":"I don\u0027t like that now if the stack name or workdir is wrong and validations are turned on, we\u0027ll need to wait to check Neutron API for external network and then we get an error. Without this patch we get the error immediately. ","commit_id":"df03b313078d3d6b3ba9bb7e4b6290600e2254ca"},{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"509bb379f7156ce4cd0cb57c4e81a83699eb4ac8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4a62296f_a9eb3196","updated":"2022-03-30 16:00:42.000000000","message":"Just questioning some of the naming. Feel free to disagree","commit_id":"df03b313078d3d6b3ba9bb7e4b6290600e2254ca"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"5a4fd0f469273be25270165418fdb9a1c4059c42","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ce63254e_85f1fa6e","updated":"2022-03-30 10:09:04.000000000","message":"recheck test_ipv6_router_advts_and_fwd_after_router_state_change_primary","commit_id":"df03b313078d3d6b3ba9bb7e4b6290600e2254ca"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"b7d09538bbf1b5834ced067242c86211ac358ebd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3237db6d_e0483f39","in_reply_to":"a4957fa4_e42d44d8","updated":"2022-04-12 11:47:57.000000000","message":"Done.","commit_id":"df03b313078d3d6b3ba9bb7e4b6290600e2254ca"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"096a943ed70b4e55fab53b880abfc8621f6a2007","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a4957fa4_e42d44d8","in_reply_to":"f3f60ab9_58408107","updated":"2022-04-12 11:28:03.000000000","message":"Yes right got your point, oc_check_public_network is called before generate_ansible_inventory_file, earlier check_stack used to run first of all and fail if inventory dir absent, /me will rework.","commit_id":"df03b313078d3d6b3ba9bb7e4b6290600e2254ca"}],"tools/ovn_migration/tripleo_environment/ovn_migration.sh":[{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"509bb379f7156ce4cd0cb57c4e81a83699eb4ac8","unresolved":true,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"# Generate the inventory file for ansible migration playbook."},{"line_number":149,"context_line":"# It uses tripleo-ansible-inventory.yaml which was used during deployment as source inventory"},{"line_number":150,"context_line":"generate_ansible_inventory_file() {"},{"line_number":151,"context_line":"    local dhcp_nodes"},{"line_number":152,"context_line":"    local inventory_file\u003d\"$OOO_WORKDIR/$STACK_NAME/config-download/$STACK_NAME/tripleo-ansible-inventory.yaml\""},{"line_number":153,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"ab577515_e96a56e6","line":150,"range":{"start_line":150,"start_character":0,"end_line":150,"end_character":31},"updated":"2022-03-30 16:00:42.000000000","message":"Another nitpick. The name of this function(and comments and echo\u0027s) around it did not age well. Function is not really generating anything anymore but rather reading from an existing inventory file and redirecting it into the hosts_for_migration. I think function name should reflect that","commit_id":"df03b313078d3d6b3ba9bb7e4b6290600e2254ca"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"04fbfeac489f1409d0249e5b153521ddd288a8f9","unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"# Generate the inventory file for ansible migration playbook."},{"line_number":149,"context_line":"# It uses tripleo-ansible-inventory.yaml which was used during deployment as source inventory"},{"line_number":150,"context_line":"generate_ansible_inventory_file() {"},{"line_number":151,"context_line":"    local dhcp_nodes"},{"line_number":152,"context_line":"    local inventory_file\u003d\"$OOO_WORKDIR/$STACK_NAME/config-download/$STACK_NAME/tripleo-ansible-inventory.yaml\""},{"line_number":153,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"ab57a4a6_817c3202","line":150,"range":{"start_line":150,"start_character":0,"end_line":150,"end_character":31},"in_reply_to":"982f9614_154bbd36","updated":"2022-03-31 09:13:57.000000000","message":"Yes right it takes tripleo-ansible-inventory as source and generate an inventory required for migration playbooks.","commit_id":"df03b313078d3d6b3ba9bb7e4b6290600e2254ca"},{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"a008aeaec45c08346dc9dc29843bcf07228192f8","unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"# Generate the inventory file for ansible migration playbook."},{"line_number":149,"context_line":"# It uses tripleo-ansible-inventory.yaml which was used during deployment as source inventory"},{"line_number":150,"context_line":"generate_ansible_inventory_file() {"},{"line_number":151,"context_line":"    local dhcp_nodes"},{"line_number":152,"context_line":"    local inventory_file\u003d\"$OOO_WORKDIR/$STACK_NAME/config-download/$STACK_NAME/tripleo-ansible-inventory.yaml\""},{"line_number":153,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"982f9614_154bbd36","line":150,"range":{"start_line":150,"start_character":0,"end_line":150,"end_character":31},"in_reply_to":"ab577515_e96a56e6","updated":"2022-03-30 18:14:06.000000000","message":"Hmm on second thought, I think its still ok to call it \"generating\". This change is very low ROI. I am closing this comment.","commit_id":"df03b313078d3d6b3ba9bb7e4b6290600e2254ca"},{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"509bb379f7156ce4cd0cb57c4e81a83699eb4ac8","unresolved":true,"context_lines":[{"line_number":152,"context_line":"    local inventory_file\u003d\"$OOO_WORKDIR/$STACK_NAME/config-download/$STACK_NAME/tripleo-ansible-inventory.yaml\""},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    if [ ! -f $inventory_file ]; then"},{"line_number":155,"context_line":"        echo \"ERROR: Source Inventory File ${inventory_file} does not exist. Please provide the Stack Name and TripleO Workdir\""},{"line_number":156,"context_line":"        echo \"       via STACK_NAME and OOO_WORKDIR environment variables.\""},{"line_number":157,"context_line":"        exit 1"},{"line_number":158,"context_line":"    fi"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    echo \"Generating the inventory file for ansible-playbook\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"eee5b278_8f76400f","line":157,"range":{"start_line":155,"start_character":8,"end_line":157,"end_character":14},"updated":"2022-03-30 16:00:42.000000000","message":"just my small nitpick. I think you can shorten this to \n\"ERROR: Inventory file ${inventory_file} does not exist. (Ensure | Hint,) STACK_NAME and OOO_WORKDIR environment variables are defined.\"","commit_id":"df03b313078d3d6b3ba9bb7e4b6290600e2254ca"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"b80178cab30e1eee72a87c7a11082fecfbd76572","unresolved":true,"context_lines":[{"line_number":152,"context_line":"    local inventory_file\u003d\"$OOO_WORKDIR/$STACK_NAME/config-download/$STACK_NAME/tripleo-ansible-inventory.yaml\""},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    if [ ! -f $inventory_file ]; then"},{"line_number":155,"context_line":"        echo \"ERROR: Source Inventory File ${inventory_file} does not exist. Please provide the Stack Name and TripleO Workdir\""},{"line_number":156,"context_line":"        echo \"       via STACK_NAME and OOO_WORKDIR environment variables.\""},{"line_number":157,"context_line":"        exit 1"},{"line_number":158,"context_line":"    fi"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    echo \"Generating the inventory file for ansible-playbook\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"e1ff64ba_ccfc015c","line":157,"range":{"start_line":155,"start_character":8,"end_line":157,"end_character":14},"in_reply_to":"df323009_318ba1db","updated":"2022-04-05 08:58:12.000000000","message":"For me it is ok","commit_id":"df03b313078d3d6b3ba9bb7e4b6290600e2254ca"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"04fbfeac489f1409d0249e5b153521ddd288a8f9","unresolved":true,"context_lines":[{"line_number":152,"context_line":"    local inventory_file\u003d\"$OOO_WORKDIR/$STACK_NAME/config-download/$STACK_NAME/tripleo-ansible-inventory.yaml\""},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    if [ ! -f $inventory_file ]; then"},{"line_number":155,"context_line":"        echo \"ERROR: Source Inventory File ${inventory_file} does not exist. Please provide the Stack Name and TripleO Workdir\""},{"line_number":156,"context_line":"        echo \"       via STACK_NAME and OOO_WORKDIR environment variables.\""},{"line_number":157,"context_line":"        exit 1"},{"line_number":158,"context_line":"    fi"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    echo \"Generating the inventory file for ansible-playbook\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"df323009_318ba1db","line":157,"range":{"start_line":155,"start_character":8,"end_line":157,"end_character":14},"in_reply_to":"eee5b278_8f76400f","updated":"2022-03-31 09:13:57.000000000","message":"I tried to use the same Error convention as before in check_status, but if needed can be improved further. Let\u0027s see what others think.","commit_id":"df03b313078d3d6b3ba9bb7e4b6290600e2254ca"}]}