)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"d7eebd837336e5eecb65b8845a2979fb2536a1df","unresolved":true,"context_lines":[{"line_number":13,"context_line":"router ID and the \"enable_ndp_proxy\" value, that needs to be retrieved"},{"line_number":14,"context_line":"before the method call."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #1967839"},{"line_number":17,"context_line":"Change-Id: Iab163e69f7e3641e2e1a451374231b6ccfa74c3e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"04c53198_17ae44b8","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":20},"updated":"2022-04-07 03:32:21.000000000","message":"IMO, ndp is still in developing, so maybe still use the original topic \"bug/1877301\" or tag \"Related-Bug: #1877301\"  to it.","commit_id":"6618a01c4d54296ab6aa715ba378084e132bd2f7"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8aac0b58f3445e101a79e749dc8a769a32273275","unresolved":false,"context_lines":[{"line_number":13,"context_line":"router ID and the \"enable_ndp_proxy\" value, that needs to be retrieved"},{"line_number":14,"context_line":"before the method call."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #1967839"},{"line_number":17,"context_line":"Change-Id: Iab163e69f7e3641e2e1a451374231b6ccfa74c3e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"d741a2a1_0de22ab9","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":20},"in_reply_to":"04c53198_17ae44b8","updated":"2022-04-07 08:26:25.000000000","message":"Done","commit_id":"6618a01c4d54296ab6aa715ba378084e132bd2f7"},{"author":{"_account_id":28329,"name":"yangjianfeng","display_name":"JeffYang","email":"yjf1970231893@gmail.com","username":"yangjianfeng"},"change_message_id":"6db8053e1d2b15b19fb8056417468d121626c1ec","unresolved":true,"context_lines":[{"line_number":10,"context_line":"a router but a dictionary with \"router_id\" info."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The method \"NDPProxyAgentExtension._process_router\" requires the"},{"line_number":13,"context_line":"router ID and the \"enable_ndp_proxy\" value, that needs to be retrieved"},{"line_number":14,"context_line":"before the method call."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #1967839"},{"line_number":17,"context_line":"Related-Bug: #1877301"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"a326df4c_cc59f723","line":14,"range":{"start_line":13,"start_character":44,"end_line":14,"end_character":23},"updated":"2022-04-07 11:16:38.000000000","message":"The description isn\u0027t exact now, the new patch don\u0027t make `retrieve` action.","commit_id":"747be6520f9c2d9c72826fd29580945fd1c0cdd9"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"5236ad36d7e849adfc189777ba6fb945a5618705","unresolved":false,"context_lines":[{"line_number":10,"context_line":"a router but a dictionary with \"router_id\" info."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The method \"NDPProxyAgentExtension._process_router\" requires the"},{"line_number":13,"context_line":"router ID and the \"enable_ndp_proxy\" value, that needs to be retrieved"},{"line_number":14,"context_line":"before the method call."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #1967839"},{"line_number":17,"context_line":"Related-Bug: #1877301"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"4d946d8f_8e78832f","line":14,"range":{"start_line":13,"start_character":44,"end_line":14,"end_character":23},"in_reply_to":"59c82f05_0d636d65","updated":"2022-04-07 14:35:19.000000000","message":"Done","commit_id":"747be6520f9c2d9c72826fd29580945fd1c0cdd9"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a083cece2d98dd40cbf07704a0ea2d7456831721","unresolved":true,"context_lines":[{"line_number":10,"context_line":"a router but a dictionary with \"router_id\" info."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The method \"NDPProxyAgentExtension._process_router\" requires the"},{"line_number":13,"context_line":"router ID and the \"enable_ndp_proxy\" value, that needs to be retrieved"},{"line_number":14,"context_line":"before the method call."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #1967839"},{"line_number":17,"context_line":"Related-Bug: #1877301"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"59c82f05_0d636d65","line":14,"range":{"start_line":13,"start_character":44,"end_line":14,"end_character":23},"in_reply_to":"a326df4c_cc59f723","updated":"2022-04-07 14:35:12.000000000","message":"Right","commit_id":"747be6520f9c2d9c72826fd29580945fd1c0cdd9"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":28329,"name":"yangjianfeng","display_name":"JeffYang","email":"yjf1970231893@gmail.com","username":"yangjianfeng"},"change_message_id":"89ceb4ba7a740b90f7f02b416892c3ca27517b27","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d8ee2a27_3b614bf7","updated":"2022-04-07 05:12:01.000000000","message":"Thanks very much.","commit_id":"6618a01c4d54296ab6aa715ba378084e132bd2f7"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"3fc5b18ac34d78002b78bc45ebfc1dfbe2963f42","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4e80efdc_72efc3a0","updated":"2022-04-08 06:19:33.000000000","message":"recheck","commit_id":"cd011d29b9ab7ae7011fe7f2d4f293f92be627e1"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"624a45090e0c732fc68798e638a2af134cd3a54d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"db3db434_3c21603c","updated":"2022-04-08 18:10:30.000000000","message":"sorry I promised to test this change during this week but I got sick :/ I\u0027ll test it on Monday/Tuesday.","commit_id":"d73ec5000bcb3a6add158eb50057af0a619c7f7f"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"fe390544b4520f6efce1f1223c292fb8b29888be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"db695123_a9b7663a","in_reply_to":"db3db434_3c21603c","updated":"2022-04-08 18:25:46.000000000","message":"sorry i replied in the wrong change...","commit_id":"d73ec5000bcb3a6add158eb50057af0a619c7f7f"}],"neutron/agent/l3/extensions/ndp_proxy.py":[{"author":{"_account_id":28329,"name":"yangjianfeng","display_name":"JeffYang","email":"yjf1970231893@gmail.com","username":"yangjianfeng"},"change_message_id":"89ceb4ba7a740b90f7f02b416892c3ca27517b27","unresolved":true,"context_lines":[{"line_number":449,"context_line":"            return"},{"line_number":450,"context_line":""},{"line_number":451,"context_line":"        router_id \u003d data[\u0027router_id\u0027]"},{"line_number":452,"context_line":"        router_proxy_state \u003d ndp_proxy_obj.RouterNDPProxyState.get_object("},{"line_number":453,"context_line":"            context, router_id\u003drouter_id)"},{"line_number":454,"context_line":"        enable \u003d (router_proxy_state.enable_ndp_proxy if router_proxy_state"},{"line_number":455,"context_line":"                  else False)"},{"line_number":456,"context_line":"        self._process_router(context, router_id, enable)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7b9c340a_b9bfc4fb","line":453,"range":{"start_line":452,"start_character":0,"end_line":453,"end_character":41},"updated":"2022-04-07 05:12:01.000000000","message":"This requires that l3-agent must has access privilege of database. My confusion is that should\u0027t we put the database operations on neutron-server? Do we have any other case that read database in agent side directly?\n\nIMHO, padding more data to the dict [1] is a better solution.\n\n[1]https://github.com/openstack/neutron/blob/3615cd85a4cc6aeecf7f066c4eb21c3cdca71d4c/neutron/agent/l3/ha.py#L185","commit_id":"6618a01c4d54296ab6aa715ba378084e132bd2f7"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8aac0b58f3445e101a79e749dc8a769a32273275","unresolved":false,"context_lines":[{"line_number":449,"context_line":"            return"},{"line_number":450,"context_line":""},{"line_number":451,"context_line":"        router_id \u003d data[\u0027router_id\u0027]"},{"line_number":452,"context_line":"        router_proxy_state \u003d ndp_proxy_obj.RouterNDPProxyState.get_object("},{"line_number":453,"context_line":"            context, router_id\u003drouter_id)"},{"line_number":454,"context_line":"        enable \u003d (router_proxy_state.enable_ndp_proxy if router_proxy_state"},{"line_number":455,"context_line":"                  else False)"},{"line_number":456,"context_line":"        self._process_router(context, router_id, enable)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ebbc0f72_c1f9b221","line":453,"range":{"start_line":452,"start_character":0,"end_line":453,"end_character":41},"in_reply_to":"7352af1c_7f50ebff","updated":"2022-04-07 08:26:25.000000000","message":"Done","commit_id":"6618a01c4d54296ab6aa715ba378084e132bd2f7"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"887885d346c451c888ddd6019b1fe6b83605af98","unresolved":true,"context_lines":[{"line_number":449,"context_line":"            return"},{"line_number":450,"context_line":""},{"line_number":451,"context_line":"        router_id \u003d data[\u0027router_id\u0027]"},{"line_number":452,"context_line":"        router_proxy_state \u003d ndp_proxy_obj.RouterNDPProxyState.get_object("},{"line_number":453,"context_line":"            context, router_id\u003drouter_id)"},{"line_number":454,"context_line":"        enable \u003d (router_proxy_state.enable_ndp_proxy if router_proxy_state"},{"line_number":455,"context_line":"                  else False)"},{"line_number":456,"context_line":"        self._process_router(context, router_id, enable)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7352af1c_7f50ebff","line":453,"range":{"start_line":452,"start_character":0,"end_line":453,"end_character":41},"in_reply_to":"7b9c340a_b9bfc4fb","updated":"2022-04-07 08:26:11.000000000","message":"Uffff hold on, hold on. You are right! This operation is not possible at all, sorry for this childish mistake.\n\nYou are right: in [1], ri.router dictionary has the needed key (if the plugin is enabled). I\u0027ll add this info.","commit_id":"6618a01c4d54296ab6aa715ba378084e132bd2f7"}],"neutron/agent/l3/ha.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b5b6accee7b54b80ceffce344757df3fd5005e8c","unresolved":true,"context_lines":[{"line_number":186,"context_line":"            \"router_id\": router_id, \"state\": state, \"host\": ri.agent.host,"},{"line_number":187,"context_line":"            \"enable_ndp_proxy\": ri.router.get(\"enable_ndp_proxy\", False)}"},{"line_number":188,"context_line":"        LOG.info(\u0027Router %(router_id)s transitioned to %(state)s on \u0027"},{"line_number":189,"context_line":"                 \u0027agent %(host)s\u0027,"},{"line_number":190,"context_line":"                 state_change_data)"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"        # Set external gateway port link up or down according to state"}],"source_content_type":"text/x-python","patch_set":4,"id":"da8ded05_26899574","line":189,"updated":"2022-04-08 14:20:17.000000000","message":"nit: should you print %(enable_ndp_proxy)s here as well?","commit_id":"cd011d29b9ab7ae7011fe7f2d4f293f92be627e1"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c1e445f3b7ee79bbd21d403e0fecf8f2e721ad04","unresolved":false,"context_lines":[{"line_number":186,"context_line":"            \"router_id\": router_id, \"state\": state, \"host\": ri.agent.host,"},{"line_number":187,"context_line":"            \"enable_ndp_proxy\": ri.router.get(\"enable_ndp_proxy\", False)}"},{"line_number":188,"context_line":"        LOG.info(\u0027Router %(router_id)s transitioned to %(state)s on \u0027"},{"line_number":189,"context_line":"                 \u0027agent %(host)s\u0027,"},{"line_number":190,"context_line":"                 state_change_data)"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"        # Set external gateway port link up or down according to state"}],"source_content_type":"text/x-python","patch_set":4,"id":"4ac5ac59_2aed5480","line":189,"in_reply_to":"da8ded05_26899574","updated":"2022-04-08 16:32:17.000000000","message":"Done","commit_id":"cd011d29b9ab7ae7011fe7f2d4f293f92be627e1"}]}