)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"8a4170c4d0e10bc80a519f86d40c281db4b7739d","unresolved":true,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This solution is also not perfect as it guards the common options to be"},{"line_number":16,"context_line":"registered only once even if the function is called multiple times. This"},{"line_number":17,"context_line":"is to solve problems in unittests, ideally we should always call the"},{"line_number":18,"context_line":"function just once even in our testing suites."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Resolves-Bug: #1968606"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"89d56e2b_e05ae473","line":17,"range":{"start_line":17,"start_character":3,"end_line":17,"end_character":33},"updated":"2022-04-15 06:20:15.000000000","message":"Just wondering how\u0027s the failure looks like?","commit_id":"c9c8bb7a6f896bf45f41157ef273ab949a1b42bd"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"2cfc2ac65f97dca728614bc029820c9c2e90febc","unresolved":true,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This solution is also not perfect as it guards the common options to be"},{"line_number":16,"context_line":"registered only once even if the function is called multiple times. This"},{"line_number":17,"context_line":"is to solve problems in unittests, ideally we should always call the"},{"line_number":18,"context_line":"function just once even in our testing suites."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Resolves-Bug: #1968606"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"15e55734_64dd247e","line":17,"range":{"start_line":17,"start_character":3,"end_line":17,"end_character":33},"in_reply_to":"89d56e2b_e05ae473","updated":"2022-04-18 15:15:50.000000000","message":"IIRC the error was about re-registering the same config opts. The base class requires state_path config opt very early so we need to register the opts at the very beginning. Then some tests use agent code that calls the register function again from the setup_config() functions in agent modules.","commit_id":"c9c8bb7a6f896bf45f41157ef273ab949a1b42bd"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e24fa74be1e6df34d3aa7499b558be4b6d360183","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"f4e76f6a_c3c5ac37","updated":"2022-04-13 21:56:10.000000000","message":"recheck","commit_id":"8769cb8d8e937188678d038e1ed5998819fbbce9"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"ac235bdecddc59afe25c69459828f6aeef543399","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"bb6c9865_1d935ebf","updated":"2022-04-14 20:50:30.000000000","message":"Thanks for doing this. That we were registering options on import is...unfortunate. lgtm other than the whitespace issue.","commit_id":"f8a5671c2c729917517534d90da72298bed353a3"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"fd64afcca0bf15f03587f6aff93c586a5ff03d07","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"d80fa2ba_e3d34ba2","updated":"2022-04-18 15:36:15.000000000","message":"Code looks OK, IMO. All possible initial methods loading the configuration options have been addressed.","commit_id":"4d3a274765a364f6f7b6bff163d6f7110bdbdbbe"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"2f40e47749963722d661d2fd81117fcf71b88515","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"020033c7_f087d984","updated":"2022-04-19 07:04:35.000000000","message":"Oh great to see this one going in!","commit_id":"4d3a274765a364f6f7b6bff163d6f7110bdbdbbe"}],"neutron/cmd/linuxbridge_cleanup.py":[{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"ac235bdecddc59afe25c69459828f6aeef543399","unresolved":true,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    This tool should not be called during an instance create, migrate, etc. as"},{"line_number":69,"context_line":"    it can delete a linux bridge about to be used by nova."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    \"\"\""},{"line_number":72,"context_line":"    common_config.register_common_config_options()"},{"line_number":73,"context_line":"    cfg.CONF(sys.argv[1:])"}],"source_content_type":"text/x-python","patch_set":10,"id":"da85601d_1682e527","line":70,"updated":"2022-04-14 20:50:30.000000000","message":"nit: extra line","commit_id":"f8a5671c2c729917517534d90da72298bed353a3"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"2cfc2ac65f97dca728614bc029820c9c2e90febc","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    This tool should not be called during an instance create, migrate, etc. as"},{"line_number":69,"context_line":"    it can delete a linux bridge about to be used by nova."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    \"\"\""},{"line_number":72,"context_line":"    common_config.register_common_config_options()"},{"line_number":73,"context_line":"    cfg.CONF(sys.argv[1:])"}],"source_content_type":"text/x-python","patch_set":10,"id":"5b571b0f_ace73a8b","line":70,"in_reply_to":"da85601d_1682e527","updated":"2022-04-18 15:15:50.000000000","message":"Done","commit_id":"f8a5671c2c729917517534d90da72298bed353a3"}],"neutron/common/config.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"8a4170c4d0e10bc80a519f86d40c281db4b7739d","unresolved":true,"context_lines":[{"line_number":54,"context_line":"    if _COMMON_OPTIONS_ALREADY_REGISTERED:"},{"line_number":55,"context_line":"        return"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    NOVA_CONF_SECTION \u003d \u0027nova\u0027"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    # Register the configuration options"},{"line_number":60,"context_line":"    common_config.register_core_common_config_opts()"}],"source_content_type":"text/x-python","patch_set":11,"id":"04672024_5db59ba3","line":57,"range":{"start_line":57,"start_character":4,"end_line":57,"end_character":21},"updated":"2022-04-15 06:20:15.000000000","message":"common_config.NOVA_CONF_SECTION","commit_id":"c9c8bb7a6f896bf45f41157ef273ab949a1b42bd"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"2cfc2ac65f97dca728614bc029820c9c2e90febc","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    if _COMMON_OPTIONS_ALREADY_REGISTERED:"},{"line_number":55,"context_line":"        return"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    NOVA_CONF_SECTION \u003d \u0027nova\u0027"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    # Register the configuration options"},{"line_number":60,"context_line":"    common_config.register_core_common_config_opts()"}],"source_content_type":"text/x-python","patch_set":11,"id":"63ba9dd0_c518d316","line":57,"range":{"start_line":57,"start_character":4,"end_line":57,"end_character":21},"in_reply_to":"04672024_5db59ba3","updated":"2022-04-18 15:15:50.000000000","message":"Done","commit_id":"c9c8bb7a6f896bf45f41157ef273ab949a1b42bd"}]}