)]}'
{"neutron/agent/linux/ip_conntrack.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1cda34679d9fee41510fb3b4ce13f72232df8390","unresolved":true,"context_lines":[{"line_number":75,"context_line":"        self._populate_initial_zone_map()"},{"line_number":76,"context_line":"        self._queue \u003d eventlet.queue.LightQueue()"},{"line_number":77,"context_line":"        self._start_process_queue()"},{"line_number":78,"context_line":"        self.queue_lock \u003d eventlet.Semaphore()"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def _start_process_queue(self):"},{"line_number":81,"context_line":"        LOG.debug(\"Starting ip_conntrack _process_queue_worker() threads\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f583176_38da36d3","line":78,"range":{"start_line":78,"start_character":13,"end_line":78,"end_character":23},"updated":"2022-04-13 13:44:10.000000000","message":"The mere idea of needing synchronization between greenthreads, scares me a lot. I\u0027m not saying how it should be implemented but I\u0027ll check other options. Something like, for example, making the conntrack deletion being executed in the main thread.\n\nThis comment is just verbalizing my fears about this.","commit_id":"2e845a225f42c034b7cee71060bb9bfc308127f8"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"faa9eb4c8bdf909465a11c7ef6d6e04d0a67e131","unresolved":true,"context_lines":[{"line_number":95,"context_line":"        update \u003d None"},{"line_number":96,"context_line":"        try:"},{"line_number":97,"context_line":"            # this will block until an entry gets added to the queue"},{"line_number":98,"context_line":"            update \u003d self._queue.get()"},{"line_number":99,"context_line":"            with self.queue_lock:"},{"line_number":100,"context_line":"                if update.remote_ips:"},{"line_number":101,"context_line":"                    for remote_ip in update.remote_ips:"}],"source_content_type":"text/x-python","patch_set":1,"id":"db422da7_68232060","line":98,"range":{"start_line":98,"start_character":26,"end_line":98,"end_character":32},"updated":"2022-04-13 13:19:20.000000000","message":"This queue is only populated when using \"IptablesFirewallDriver\", not \"OVSFirewallDriver\". We never call this method","commit_id":"2e845a225f42c034b7cee71060bb9bfc308127f8"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"12dbe946dda27e8677ff0d8559b857ea75918f47","unresolved":true,"context_lines":[{"line_number":95,"context_line":"        update \u003d None"},{"line_number":96,"context_line":"        try:"},{"line_number":97,"context_line":"            # this will block until an entry gets added to the queue"},{"line_number":98,"context_line":"            update \u003d self._queue.get()"},{"line_number":99,"context_line":"            with self.queue_lock:"},{"line_number":100,"context_line":"                if update.remote_ips:"},{"line_number":101,"context_line":"                    for remote_ip in update.remote_ips:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5db523bc_8b32ce18","line":98,"range":{"start_line":98,"start_character":26,"end_line":98,"end_character":32},"in_reply_to":"db422da7_68232060","updated":"2022-04-13 13:30:59.000000000","message":"No, this statement is wrong.","commit_id":"2e845a225f42c034b7cee71060bb9bfc308127f8"}],"neutron/agent/linux/openvswitch_firewall/firewall.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1cda34679d9fee41510fb3b4ce13f72232df8390","unresolved":true,"context_lines":[{"line_number":853,"context_line":"            self._initialize_egress_no_port_security(port_id,"},{"line_number":854,"context_line":"                                                     ovs_ports\u003dovs_ports)"},{"line_number":855,"context_line":"            # yield to let other greenthreads proceed"},{"line_number":856,"context_line":"            eventlet.sleep(0)"},{"line_number":857,"context_line":""},{"line_number":858,"context_line":"    def remove_trusted_ports(self, port_ids):"},{"line_number":859,"context_line":"        for port_id in port_ids:"}],"source_content_type":"text/x-python","patch_set":1,"id":"844b97b7_f75802bf","side":"PARENT","line":856,"range":{"start_line":856,"start_character":12,"end_line":856,"end_character":29},"updated":"2022-04-13 13:44:10.000000000","message":"I understand why are you doing this but we should not remove it.","commit_id":"bb4c26eb7245465bf7cea7e0f07342601eb78ede"}]}