)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"c0a65e8c503e9b264476f663538aa8ec9733a6a1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"6033095d_97032fde","updated":"2022-05-06 23:26:35.000000000","message":"recheck neutron.tests.functional.agent.test_dhcp_agent.DHCPAgentOVSTestCase.test_good_address_allocation is failing intermittently https://bugs.launchpad.net/neutron/+bug/1966035","commit_id":"8eee41e0bff6fbcb328a3954451429972e1d3cd7"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"aa0e3dc2737942621f5de1f449a7582db34d350b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"def11606_8ecba5cf","updated":"2022-07-19 15:34:21.000000000","message":"Just a heads-up, waiting for the config knob commented during the driver\u0027s meeting.","commit_id":"f693121ba014b15ac5b6459be8af6261971dbb70"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"e045c55f1eb6472589034e4e3562debec92be2fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"d5b89149_b60134b3","updated":"2022-05-23 23:59:55.000000000","message":"recheck after fix to https://bugs.launchpad.net/neutron/+bug/1973162 has been released","commit_id":"f693121ba014b15ac5b6459be8af6261971dbb70"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"8e3cba764076d3502664bf5fd18043e88e70ef55","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"c98710e5_d99050d4","updated":"2022-08-02 08:18:49.000000000","message":"Failure in multinode tempest job seems like it can be related to that patch so please check it https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_42d/837780/11/check/neutron-ovs-tempest-multinode-full/42d468c/testr_results.html","commit_id":"86284ac401e589b4fdca4d92d46d61238010bde4"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"79d8516f56b2aeb5eb5d5cb5845f27b86932a71f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"90e9787f_df974afc","updated":"2022-11-18 16:19:48.000000000","message":"The problem seems to be in [1]. The parent port status is updated in the destination OVS agent, e.g.: [2]. But the test stops checking the port status before [3].\n\nLogs from [4].\n\nIMO, we should increase the [1] timeout in order to pass the test.\n\n[1]https://github.com/openstack/tempest/blob/2c6da1db396c018ec6d52961edfadd9fe20cb5ad/tempest/api/compute/admin/test_live_migration.py#L293\n[2]https://paste.opendev.org/show/bWM0ldffmbHk7DTHDSkb/\n[3]https://paste.opendev.org/show/bk9mTsrq9GrGHsjjhTK3/\n[4]https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_d4e/841838/69/check/neutron-ovs-tempest-multinode-full/d4e2c13/testr_results.html\n","commit_id":"89d1f52b7a08b697d2f6fcfd0eb6aab23d083278"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"a1aadeda7baba188abe58598c2380b92f0347dfb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"52249c8d_a5c3a0a2","updated":"2022-11-22 06:58:58.000000000","message":"it would be nice to not need a new config option for this, but rely on the os-vif version or something like that","commit_id":"ca52af597b04243e37795c6b6c231d768091a0c1"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"3791c2bc07cf6c1f654f9f2bbbdc465a6fdc141b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"dabf774a_92942f9d","updated":"2022-11-21 09:03:23.000000000","message":"recheck neutron-ovs-tempest-multinode-full","commit_id":"ca52af597b04243e37795c6b6c231d768091a0c1"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"353e6356bb9fe0286a1aba8bd9bf7ea6bef54165","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"5da70853_0a2a701a","in_reply_to":"52249c8d_a5c3a0a2","updated":"2022-11-23 11:45:50.000000000","message":"We can\u0027t (we shouldn\u0027t) do this kind of check during the execution.\n\nIn any case this is temporary until we enforce this version in Nova: https://review.opendev.org/c/openstack/nova/+/865031\n\nThat was also discussed during the drivers meeting and was voted as the less intrusive implementation.","commit_id":"ca52af597b04243e37795c6b6c231d768091a0c1"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"2871626c59e95f95da32b5290dc92a4d967f11f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"722879c6_b466d729","updated":"2022-11-24 16:06:39.000000000","message":"TODO: because [1] is merged, to remove the config option \n\n\n[1]https://review.opendev.org/c/openstack/nova/+/865031","commit_id":"3a6678e3c746de11772cbe0fe70c227f44f0b3be"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e09b4a0ee63d5961192bf2fc8f576e1e19a9c587","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"00ef2e52_c032605e","updated":"2022-11-24 17:32:33.000000000","message":"recheck rally (I don\u0027t know what happened on these jobs...)","commit_id":"3a6678e3c746de11772cbe0fe70c227f44f0b3be"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f43832d2e71c1ef84878ce166c0458e052e8a5d8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"9c989cb6_e74a39e8","updated":"2022-11-28 13:41:07.000000000","message":"Hi folks, this is affecting Nova CI","commit_id":"33de608f04dcc8117eeba63876598dc2ae93013a"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"ba48f16e27cd4d46e3819a00bf05c876258e1c5a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"a9bcf3a1_bd977bf6","updated":"2022-11-28 16:13:43.000000000","message":"Looks good to me","commit_id":"33de608f04dcc8117eeba63876598dc2ae93013a"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"28a5b4249dbceb67896c21f25b981931d16592cc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"4964cf26_ae516d8a","updated":"2022-11-28 15:34:05.000000000","message":"Thanks","commit_id":"33de608f04dcc8117eeba63876598dc2ae93013a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c6a16a539dea6c5ecbdfa6761ae51ffb0dbf8883","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"b084bb2e_e2b1db74","updated":"2022-11-25 14:54:40.000000000","message":"extra testing: https://review.opendev.org/c/openstack/neutron/+/865039","commit_id":"33de608f04dcc8117eeba63876598dc2ae93013a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"ec0288f7f1b0a76bd4e55aebb535282fbbead900","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"5f598f92_5e57cfe8","updated":"2022-11-25 15:09:10.000000000","message":"recheck neutron-ovs-grenade-multinode","commit_id":"33de608f04dcc8117eeba63876598dc2ae93013a"}],"neutron/conf/common.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"303eb1d516ccc6bb38cec2e9bbf1cbd9bc4fe285","unresolved":true,"context_lines":[{"line_number":180,"context_line":"                      \u0027 be looked up in the keystone catalog and should be\u0027"},{"line_number":181,"context_line":"                      \u0027 one of public, internal or admin.\u0027)),"},{"line_number":182,"context_line":"    cfg.BoolOpt(\u0027os_vif_deletes_trunk_bridges\u0027,"},{"line_number":183,"context_line":"                default\u003dFalse,"},{"line_number":184,"context_line":"                help\u003d_(\u0027If True, both the creation and deletion of trunk \u0027"},{"line_number":185,"context_line":"                       \u0027bridges is performed by os-vif. This options can be \u0027"},{"line_number":186,"context_line":"                       \u0027enabled if the os-vif patch \u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"28918a7c_bc8ebe71","line":183,"range":{"start_line":183,"start_character":24,"end_line":183,"end_character":29},"updated":"2022-08-01 07:43:44.000000000","message":"Was this tested with \u0027os_vif_deletes_trunk_bridges\u0027 set to True?","commit_id":"c8d9329b85ea9baf0aa67cad2ea0d6dc0f0dd1ea"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"28de0e252b1e4f8a8af4036553f8bf570e290279","unresolved":true,"context_lines":[{"line_number":180,"context_line":"                      \u0027 be looked up in the keystone catalog and should be\u0027"},{"line_number":181,"context_line":"                      \u0027 one of public, internal or admin.\u0027)),"},{"line_number":182,"context_line":"    cfg.BoolOpt(\u0027os_vif_deletes_trunk_bridges\u0027,"},{"line_number":183,"context_line":"                default\u003dFalse,"},{"line_number":184,"context_line":"                help\u003d_(\u0027If True, both the creation and deletion of trunk \u0027"},{"line_number":185,"context_line":"                       \u0027bridges is performed by os-vif. This options can be \u0027"},{"line_number":186,"context_line":"                       \u0027enabled if the os-vif patch \u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"8f105047_dce7cf72","line":183,"range":{"start_line":183,"start_character":24,"end_line":183,"end_character":29},"in_reply_to":"28918a7c_bc8ebe71","updated":"2022-08-01 22:06:34.000000000","message":"Yes in the neutron-ovs-tempest-multinode-full job. In the latest patchset, I also added the neutron-ovs-tempest-dvr-ha-multinode-full job: https://review.opendev.org/c/openstack/neutron/+/837780/11/zuul.d/tempest-multinode.yaml","commit_id":"c8d9329b85ea9baf0aa67cad2ea0d6dc0f0dd1ea"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"692cda148f447e4a76258d7a22d42c866595a1c6","unresolved":false,"context_lines":[{"line_number":180,"context_line":"                      \u0027 be looked up in the keystone catalog and should be\u0027"},{"line_number":181,"context_line":"                      \u0027 one of public, internal or admin.\u0027)),"},{"line_number":182,"context_line":"    cfg.BoolOpt(\u0027os_vif_deletes_trunk_bridges\u0027,"},{"line_number":183,"context_line":"                default\u003dFalse,"},{"line_number":184,"context_line":"                help\u003d_(\u0027If True, both the creation and deletion of trunk \u0027"},{"line_number":185,"context_line":"                       \u0027bridges is performed by os-vif. This options can be \u0027"},{"line_number":186,"context_line":"                       \u0027enabled if the os-vif patch \u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"3c204992_ab87fb34","line":183,"range":{"start_line":183,"start_character":24,"end_line":183,"end_character":29},"in_reply_to":"8f105047_dce7cf72","updated":"2022-11-24 16:06:09.000000000","message":"I\u0027m removing this config option in the next PS because [1] was merged\n\n[1]https://review.opendev.org/c/openstack/nova/+/865031","commit_id":"c8d9329b85ea9baf0aa67cad2ea0d6dc0f0dd1ea"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"cba5a63de077a9e5eda909654acb132d10c939ef","unresolved":true,"context_lines":[{"line_number":185,"context_line":"                       \u0027bridges is performed by os-vif. This options can be \u0027"},{"line_number":186,"context_line":"                       \u0027enabled if the os-vif patch \u0027"},{"line_number":187,"context_line":"                       \u0027https://review.opendev.org/c/openstack/os-vif/+/841499\u0027"},{"line_number":188,"context_line":"                       \u0027 is in place. This option is temporary and will be \u0027"},{"line_number":189,"context_line":"                       \u0027removed in the A cycle and the behavior will be \u0027"},{"line_number":190,"context_line":"                       \u0027\"True\"\u0027),"},{"line_number":191,"context_line":"                deprecated_for_removal\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":15,"id":"d0071f87_3b4f1207","line":188,"range":{"start_line":188,"start_character":24,"end_line":188,"end_character":25},"updated":"2022-11-23 20:58:48.000000000","message":"nitty nit: space should be at the end of the line above","commit_id":"adc79d90b3cfba01c2d9fb3fb4c14a6d62ae8114"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"692cda148f447e4a76258d7a22d42c866595a1c6","unresolved":false,"context_lines":[{"line_number":185,"context_line":"                       \u0027bridges is performed by os-vif. This options can be \u0027"},{"line_number":186,"context_line":"                       \u0027enabled if the os-vif patch \u0027"},{"line_number":187,"context_line":"                       \u0027https://review.opendev.org/c/openstack/os-vif/+/841499\u0027"},{"line_number":188,"context_line":"                       \u0027 is in place. This option is temporary and will be \u0027"},{"line_number":189,"context_line":"                       \u0027removed in the A cycle and the behavior will be \u0027"},{"line_number":190,"context_line":"                       \u0027\"True\"\u0027),"},{"line_number":191,"context_line":"                deprecated_for_removal\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":15,"id":"cde1bfc5_ff636371","line":188,"range":{"start_line":188,"start_character":24,"end_line":188,"end_character":25},"in_reply_to":"d0071f87_3b4f1207","updated":"2022-11-24 16:06:09.000000000","message":"Done","commit_id":"adc79d90b3cfba01c2d9fb3fb4c14a6d62ae8114"}],"neutron/services/trunk/drivers/openvswitch/agent/trunk_manager.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"5accef3677fe47c908a3a04e6f7b2953e041e5d4","unresolved":true,"context_lines":[{"line_number":138,"context_line":"        ovsdb \u003d self.bridge.ovsdb"},{"line_number":139,"context_line":"        with ovsdb.transaction() as txn:"},{"line_number":140,"context_line":"            if (not cfg.CONF.nova.os_vif_deletes_trunk_bridges and"},{"line_number":141,"context_line":"                self.bridge.exists()):"},{"line_number":142,"context_line":"                txn.add(ovsdb.del_br(self.bridge.br_name))"},{"line_number":143,"context_line":"            txn.add(ovsdb.del_port(self.patch_port_int_name,"},{"line_number":144,"context_line":"                                   bridge.br_name))"}],"source_content_type":"text/x-python","patch_set":8,"id":"d58a2d44_b4a26927","line":141,"updated":"2022-07-26 07:28:47.000000000","message":"Error:\n\n     AttributeError: \u0027OVSBridge\u0027 object has no attribute \u0027exists\u0027\n     \nin the functional tests is caused by this line","commit_id":"8f25c9756a06f668acbd47cab5eea2357c3f8187"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"28de0e252b1e4f8a8af4036553f8bf570e290279","unresolved":false,"context_lines":[{"line_number":138,"context_line":"        ovsdb \u003d self.bridge.ovsdb"},{"line_number":139,"context_line":"        with ovsdb.transaction() as txn:"},{"line_number":140,"context_line":"            if (not cfg.CONF.nova.os_vif_deletes_trunk_bridges and"},{"line_number":141,"context_line":"                self.bridge.exists()):"},{"line_number":142,"context_line":"                txn.add(ovsdb.del_br(self.bridge.br_name))"},{"line_number":143,"context_line":"            txn.add(ovsdb.del_port(self.patch_port_int_name,"},{"line_number":144,"context_line":"                                   bridge.br_name))"}],"source_content_type":"text/x-python","patch_set":8,"id":"4683a480_2b2e9ad3","line":141,"in_reply_to":"d58a2d44_b4a26927","updated":"2022-08-01 22:06:34.000000000","message":"Done","commit_id":"8f25c9756a06f668acbd47cab5eea2357c3f8187"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"cba5a63de077a9e5eda909654acb132d10c939ef","unresolved":true,"context_lines":[{"line_number":138,"context_line":"        ovsdb \u003d self.bridge.ovsdb"},{"line_number":139,"context_line":"        with ovsdb.transaction() as txn:"},{"line_number":140,"context_line":"            if (not cfg.CONF.nova.os_vif_deletes_trunk_bridges and"},{"line_number":141,"context_line":"                    self.bridge.exists()):"},{"line_number":142,"context_line":"                txn.add(ovsdb.del_br(self.bridge.br_name))"},{"line_number":143,"context_line":"            txn.add(ovsdb.del_port(self.patch_port_int_name,"},{"line_number":144,"context_line":"                                   bridge.br_name))"}],"source_content_type":"text/x-python","patch_set":15,"id":"9d631448_cfe55315","line":141,"updated":"2022-11-23 20:58:48.000000000","message":"instead of check if bridge exists, can we always call \"del_br\" with \"if_exists\"?","commit_id":"adc79d90b3cfba01c2d9fb3fb4c14a6d62ae8114"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"692cda148f447e4a76258d7a22d42c866595a1c6","unresolved":false,"context_lines":[{"line_number":138,"context_line":"        ovsdb \u003d self.bridge.ovsdb"},{"line_number":139,"context_line":"        with ovsdb.transaction() as txn:"},{"line_number":140,"context_line":"            if (not cfg.CONF.nova.os_vif_deletes_trunk_bridges and"},{"line_number":141,"context_line":"                    self.bridge.exists()):"},{"line_number":142,"context_line":"                txn.add(ovsdb.del_br(self.bridge.br_name))"},{"line_number":143,"context_line":"            txn.add(ovsdb.del_port(self.patch_port_int_name,"},{"line_number":144,"context_line":"                                   bridge.br_name))"}],"source_content_type":"text/x-python","patch_set":15,"id":"f9f49ec2_cf9fd14f","line":141,"in_reply_to":"9d631448_cfe55315","updated":"2022-11-24 16:06:09.000000000","message":"I would prefer not. I don\u0027t remember where we discussed this but this will raise an exception in the middle of the transaction. It is better to delete it if we know it exists.","commit_id":"adc79d90b3cfba01c2d9fb3fb4c14a6d62ae8114"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"cba5a63de077a9e5eda909654acb132d10c939ef","unresolved":true,"context_lines":[{"line_number":141,"context_line":"                    self.bridge.exists()):"},{"line_number":142,"context_line":"                txn.add(ovsdb.del_br(self.bridge.br_name))"},{"line_number":143,"context_line":"            txn.add(ovsdb.del_port(self.patch_port_int_name,"},{"line_number":144,"context_line":"                                   bridge.br_name))"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"class SubPort(TrunkParentPort):"}],"source_content_type":"text/x-python","patch_set":15,"id":"c8b36dcd_dd885539","line":144,"updated":"2022-11-23 20:58:48.000000000","message":"do we need to delete port after bridge is deleted?","commit_id":"adc79d90b3cfba01c2d9fb3fb4c14a6d62ae8114"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"692cda148f447e4a76258d7a22d42c866595a1c6","unresolved":false,"context_lines":[{"line_number":141,"context_line":"                    self.bridge.exists()):"},{"line_number":142,"context_line":"                txn.add(ovsdb.del_br(self.bridge.br_name))"},{"line_number":143,"context_line":"            txn.add(ovsdb.del_port(self.patch_port_int_name,"},{"line_number":144,"context_line":"                                   bridge.br_name))"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"class SubPort(TrunkParentPort):"}],"source_content_type":"text/x-python","patch_set":15,"id":"d41727a8_8ef76837","line":144,"in_reply_to":"c8b36dcd_dd885539","updated":"2022-11-24 16:06:09.000000000","message":"This is the other side of the patch port, the port in the integration bridge.","commit_id":"adc79d90b3cfba01c2d9fb3fb4c14a6d62ae8114"}]}