)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"0292472e1fd0b2a53a908877e999ebfd5763ab4e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2f613c30_00cfe5ef","updated":"2022-04-26 16:03:08.000000000","message":"Should probably test in functional suite that db_clear works as expected.","commit_id":"2f10b785fb16392326ba3c7de99781a0687f037f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5719a5cdb7e8e48d8ffe5f0d107e5537e9b33e6f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d3262b1a_f3d98609","updated":"2022-04-20 23:11:49.000000000","message":"recheck neutron-functional-with-uwsgi","commit_id":"2f10b785fb16392326ba3c7de99781a0687f037f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a89d9cdfac521169747d7e67e6bc26ff2f2ebffc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"af5a8b97_e5ccdd66","updated":"2022-06-02 06:57:25.000000000","message":"Minor pep8 error.\n\nCode looks OK, waiting for the next PS.","commit_id":"243a6418b4ce67f9cf3c239f3c4f0516c9921a40"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"84d93523c01fd9bc8ea0d647c9b9d1e0c0fe4794","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d987782f_0dddda2c","in_reply_to":"af5a8b97_e5ccdd66","updated":"2022-06-03 20:43:51.000000000","message":"Done.","commit_id":"243a6418b4ce67f9cf3c239f3c4f0516c9921a40"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"55bacb31bb27e12f6fdb32dc1d12e66bf93c5960","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"36e97732_ce52f401","updated":"2022-06-28 17:07:08.000000000","message":"Anything holding this from merging?..","commit_id":"ffd64df9d306bf56091b2f3ae8a8f579f578de53"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"f5527cfd3e24d251efaeef55dc06d2b40a6e803e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a1a910be_72e2519d","updated":"2022-06-21 13:20:44.000000000","message":"Thanks for keeping an eye on it, and reverting if it is not as effective as it is and not leaving a half working half maintained chunk in code tree","commit_id":"ffd64df9d306bf56091b2f3ae8a8f579f578de53"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/maintenance.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a89d9cdfac521169747d7e67e6bc26ff2f2ebffc","unresolved":true,"context_lines":[{"line_number":276,"context_line":"    # The migration will run just once per neutron-server instance. If the lock"},{"line_number":277,"context_line":"    # is held by some other neutron-server instance in the cloud, we\u0027ll attempt"},{"line_number":278,"context_line":"    # to perform the migration every 10 seconds until completed."},{"line_number":279,"context_line":"    # TODO(ihrachys): Remove the migration to stateful fips at some point."},{"line_number":280,"context_line":"    @periodics.periodic(spacing\u003d10, run_immediately\u003dTrue)"},{"line_number":281,"context_line":"    @rerun_on_schema_updates"},{"line_number":282,"context_line":"    def migrate_to_stateful_fips(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"76a30db2_cecca638","line":279,"range":{"start_line":279,"start_character":22,"end_line":279,"end_character":74},"updated":"2022-06-02 06:57:25.000000000","message":"Let\u0027s propose a candidate release for this (and write it the comment). For example Z+4 (4 releases should be enough to make this change permanent).","commit_id":"243a6418b4ce67f9cf3c239f3c4f0516c9921a40"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"12643caec48be73b7038e22ed1aeb9fd64f14990","unresolved":true,"context_lines":[{"line_number":276,"context_line":"    # The migration will run just once per neutron-server instance. If the lock"},{"line_number":277,"context_line":"    # is held by some other neutron-server instance in the cloud, we\u0027ll attempt"},{"line_number":278,"context_line":"    # to perform the migration every 10 seconds until completed."},{"line_number":279,"context_line":"    # TODO(ihrachys): Remove the migration to stateful fips at some point."},{"line_number":280,"context_line":"    @periodics.periodic(spacing\u003d10, run_immediately\u003dTrue)"},{"line_number":281,"context_line":"    @rerun_on_schema_updates"},{"line_number":282,"context_line":"    def migrate_to_stateful_fips(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"62eecf23_d492e5c1","line":279,"range":{"start_line":279,"start_character":22,"end_line":279,"end_character":74},"in_reply_to":"15d39bf6_3c023071","updated":"2022-06-08 18:13:28.000000000","message":"If so, I don\u0027t see a reason to keep the rule in Z+1 since users must first upgrade to Z that will migrate all nat objects as needed. Updated the comment accordingly.","commit_id":"243a6418b4ce67f9cf3c239f3c4f0516c9921a40"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ef2cf61de57ada70ff5ea98f3c2f1cc7960fc609","unresolved":false,"context_lines":[{"line_number":276,"context_line":"    # The migration will run just once per neutron-server instance. If the lock"},{"line_number":277,"context_line":"    # is held by some other neutron-server instance in the cloud, we\u0027ll attempt"},{"line_number":278,"context_line":"    # to perform the migration every 10 seconds until completed."},{"line_number":279,"context_line":"    # TODO(ihrachys): Remove the migration to stateful fips at some point."},{"line_number":280,"context_line":"    @periodics.periodic(spacing\u003d10, run_immediately\u003dTrue)"},{"line_number":281,"context_line":"    @rerun_on_schema_updates"},{"line_number":282,"context_line":"    def migrate_to_stateful_fips(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ea41bdc3_46909ecb","line":279,"range":{"start_line":279,"start_character":22,"end_line":279,"end_character":74},"in_reply_to":"62eecf23_d492e5c1","updated":"2022-06-08 21:07:20.000000000","message":"Ack","commit_id":"243a6418b4ce67f9cf3c239f3c4f0516c9921a40"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0d15aacbe068940e53d086a1bb65bc34e85bc0a8","unresolved":true,"context_lines":[{"line_number":276,"context_line":"    # The migration will run just once per neutron-server instance. If the lock"},{"line_number":277,"context_line":"    # is held by some other neutron-server instance in the cloud, we\u0027ll attempt"},{"line_number":278,"context_line":"    # to perform the migration every 10 seconds until completed."},{"line_number":279,"context_line":"    # TODO(ihrachys): Remove the migration to stateful fips at some point."},{"line_number":280,"context_line":"    @periodics.periodic(spacing\u003d10, run_immediately\u003dTrue)"},{"line_number":281,"context_line":"    @rerun_on_schema_updates"},{"line_number":282,"context_line":"    def migrate_to_stateful_fips(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dbe0dd61_4b718df8","line":279,"range":{"start_line":279,"start_character":22,"end_line":279,"end_character":74},"in_reply_to":"76a30db2_cecca638","updated":"2022-06-02 13:32:31.000000000","message":"that seam very long.\ni dont have the full context but we shoudl be able to deprecate this in Z an dremove in AA or AB\n\nso Z+1 or Z+2 the new life cycle will only come into effect form AA to CC and as long as we deprecate in Z or AA we can drop it in B so why z+4 that more then double what is required.","commit_id":"243a6418b4ce67f9cf3c239f3c4f0516c9921a40"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e65310a4a98d38ea559a8bb0294b45135204ca99","unresolved":true,"context_lines":[{"line_number":276,"context_line":"    # The migration will run just once per neutron-server instance. If the lock"},{"line_number":277,"context_line":"    # is held by some other neutron-server instance in the cloud, we\u0027ll attempt"},{"line_number":278,"context_line":"    # to perform the migration every 10 seconds until completed."},{"line_number":279,"context_line":"    # TODO(ihrachys): Remove the migration to stateful fips at some point."},{"line_number":280,"context_line":"    @periodics.periodic(spacing\u003d10, run_immediately\u003dTrue)"},{"line_number":281,"context_line":"    @rerun_on_schema_updates"},{"line_number":282,"context_line":"    def migrate_to_stateful_fips(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9c4cd58d_b2a33ed0","line":279,"range":{"start_line":279,"start_character":22,"end_line":279,"end_character":74},"in_reply_to":"97ec4464_9f74ced7","updated":"2022-06-03 20:45:57.000000000","message":"Sorry, my math is flaky. :) But you get the point. To answer when we can drop the migration code, I should know how far neutron allows to skip releases, if at all.","commit_id":"243a6418b4ce67f9cf3c239f3c4f0516c9921a40"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"14c36d4ca889522a19579dc1d49cfa03ec209462","unresolved":true,"context_lines":[{"line_number":276,"context_line":"    # The migration will run just once per neutron-server instance. If the lock"},{"line_number":277,"context_line":"    # is held by some other neutron-server instance in the cloud, we\u0027ll attempt"},{"line_number":278,"context_line":"    # to perform the migration every 10 seconds until completed."},{"line_number":279,"context_line":"    # TODO(ihrachys): Remove the migration to stateful fips at some point."},{"line_number":280,"context_line":"    @periodics.periodic(spacing\u003d10, run_immediately\u003dTrue)"},{"line_number":281,"context_line":"    @rerun_on_schema_updates"},{"line_number":282,"context_line":"    def migrate_to_stateful_fips(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"15d39bf6_3c023071","line":279,"range":{"start_line":279,"start_character":22,"end_line":279,"end_character":74},"in_reply_to":"9c4cd58d_b2a33ed0","updated":"2022-06-07 12:58:06.000000000","message":"upstream neutron only support n to n+1\n\nffu is not supported by upstream projects.\n\nso our minium deprecation is 1 cycle then we can remove in the next.\n\nthat will change in the CC release.\n\nAA will be our tick release and in CC we will only be able to remove things that were deprecated in zed or AA. we will no be able to remove things deprecated in BB since it was not depercated in teh previous tick\n\nbut we will be able to drop things in DD that were deprecated in BB sicne the deprecation will have been included in CC.\n\nso if we deprecate something in zed it can be removedin AA or BB\nif we deprecate in AA it can be remvoed in BB or CC\nif we deprecte in BB or CC it can be removed in DD or later.\nsince removals under the new lifcycle policy will require deprecation in the a tick release before they can be removed.\n\n\n\nso no we do not allow skiping releases today and never have.\nin the future we will alow skipping exactly one release but the first release to supprot that will be CC which woudl allow skiping form AA to CC skiping BB.","commit_id":"243a6418b4ce67f9cf3c239f3c4f0516c9921a40"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"84d93523c01fd9bc8ea0d647c9b9d1e0c0fe4794","unresolved":true,"context_lines":[{"line_number":276,"context_line":"    # The migration will run just once per neutron-server instance. If the lock"},{"line_number":277,"context_line":"    # is held by some other neutron-server instance in the cloud, we\u0027ll attempt"},{"line_number":278,"context_line":"    # to perform the migration every 10 seconds until completed."},{"line_number":279,"context_line":"    # TODO(ihrachys): Remove the migration to stateful fips at some point."},{"line_number":280,"context_line":"    @periodics.periodic(spacing\u003d10, run_immediately\u003dTrue)"},{"line_number":281,"context_line":"    @rerun_on_schema_updates"},{"line_number":282,"context_line":"    def migrate_to_stateful_fips(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"97ec4464_9f74ced7","line":279,"range":{"start_line":279,"start_character":22,"end_line":279,"end_character":74},"in_reply_to":"dbe0dd61_4b718df8","updated":"2022-06-03 20:43:51.000000000","message":"What\u0027s the upstream neutron upgrade procedure? Whatever the number of releases allowed to skip between upgrades without running maintenance tasks, the number of releases to carry the migration code should be this number *2, no?\n\nSo if e.g. we don\u0027t allow to skip releases, users will get the maintenance task with Z and we can safely remove it for AA, 0*2 releases later. But if we e.g. allow to skip 1 release, we can remove it only in AB since we would be sure that if a user didn\u0027t receive the migration path with Z, they definitely received it with AA.\n\nIs the upgrade between releases documented anywhere? Also, LTS releases, if any, should be considered.","commit_id":"243a6418b4ce67f9cf3c239f3c4f0516c9921a40"}]}