)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"cfc0b92fe359f3f559def0b4063b73e6996bbdbf","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change is updating the vlanmanager data structure to handle for a"},{"line_number":10,"context_line":"given network more than one vlan mapping. This is a prerequisite work needed"},{"line_number":11,"context_line":"to progress on accepting several segments per network."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The work done here is trying to avoid changing logic in the"},{"line_number":14,"context_line":"current implementation. Unit test should not have value updated,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":27,"id":"56ef71a7_d516e631","line":11,"range":{"start_line":11,"start_character":25,"end_line":11,"end_character":53},"updated":"2022-08-08 06:27:08.000000000","message":"nit: + per host","commit_id":"ca3aae34244e9d017abd5776effc20a91e30c345"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"8e3ac4e725390044e69cbad455a4dce93296e355","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change is updating the vlanmanager data structure to handle for a"},{"line_number":10,"context_line":"given network more than one vlan mapping. This is a prerequisite work needed"},{"line_number":11,"context_line":"to progress on accepting several segments per network."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The work done here is trying to avoid changing logic in the"},{"line_number":14,"context_line":"current implementation. Unit test should not have value updated,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":27,"id":"bc1550a0_0a2a9a5a","line":11,"range":{"start_line":11,"start_character":25,"end_line":11,"end_character":53},"in_reply_to":"56ef71a7_d516e631","updated":"2022-08-29 09:10:53.000000000","message":"Sure. I have used \u0027physnet\u0027 instead of \u0027host\u0027 I hope that makes sense.","commit_id":"ca3aae34244e9d017abd5776effc20a91e30c345"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"72236a052071785d12e7d639ab4fe0470c1fb5d9","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change is updating the vlanmanager data structure to handle for a"},{"line_number":10,"context_line":"given network more than one vlan mapping. This is a prerequisite work"},{"line_number":11,"context_line":"needed to progress on accepting several segments per network per"},{"line_number":12,"context_line":"physnet."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"The work done here is trying to avoid changing logic in the"},{"line_number":15,"context_line":"current implementation. Unit test should not have value updated,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":28,"id":"2b51bc0f_182799a8","line":12,"range":{"start_line":11,"start_character":22,"end_line":12,"end_character":7},"updated":"2022-08-31 09:29:20.000000000","message":"this is confusing - both related bugs say about several segments per host, why you say about physnet?","commit_id":"b74d019ed094d658d1a81dedee731941bd674030"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"d9be1ffb4fc88d6431b63e43ea836aea2294d5f6","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change is updating the vlanmanager data structure to handle for a"},{"line_number":10,"context_line":"given network more than one vlan mapping. This is a prerequisite work"},{"line_number":11,"context_line":"needed to progress on accepting several segments per network per"},{"line_number":12,"context_line":"physnet."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"The work done here is trying to avoid changing logic in the"},{"line_number":15,"context_line":"current implementation. Unit test should not have value updated,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":28,"id":"cd8578c8_337deb3a","line":12,"range":{"start_line":11,"start_character":22,"end_line":12,"end_character":7},"in_reply_to":"2b51bc0f_182799a8","updated":"2022-09-01 12:48:45.000000000","message":"From my understand we can have several physnets that map bridges on a host. And a network is related to one physnet. But I understand that usually we have one physnet per host and so the usage of host. Not big deal I can change that point and switch to host.","commit_id":"b74d019ed094d658d1a81dedee731941bd674030"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"159e33d475dc5b15f33c2bd4119f7c442d3c53c2","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change is updating the vlanmanager data structure to handle for a"},{"line_number":10,"context_line":"given network more than one vlan mapping. This is a prerequisite work"},{"line_number":11,"context_line":"needed to progress on accepting several segments per network per"},{"line_number":12,"context_line":"physnet."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"The work done here is trying to avoid changing logic in the"},{"line_number":15,"context_line":"current implementation. Unit test should not have value updated,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":28,"id":"3eb6a2da_099f8693","line":12,"range":{"start_line":11,"start_character":22,"end_line":12,"end_character":7},"in_reply_to":"cd8578c8_337deb3a","updated":"2022-09-01 13:07:35.000000000","message":"I saw hosts with many physnets many times. So it is several segments per network per host","commit_id":"b74d019ed094d658d1a81dedee731941bd674030"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"e76bc5343b27fa21f4fec2b4e04ec7f0c71fbf9d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"76bf3a70_b341a429","updated":"2022-05-09 18:14:34.000000000","message":"recheck functional test_dvr_update_gateway_port_with_no_gw_port_in_namespace","commit_id":"cbf0817feaf8d6f785f334f20aba64d06ae810a1"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"6a0b582e49de7992e1cd198460697b4cb13767c3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b34b8ca3_502e1476","updated":"2022-05-09 11:56:22.000000000","message":"recheck functional test_dvr_update_gateway_port_with_no_gw_port_in_namespace","commit_id":"cbf0817feaf8d6f785f334f20aba64d06ae810a1"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"d2b89746da9036b38ae022cdf6ec656aa8c4049a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"503dc1a8_ba2230c9","updated":"2022-05-12 05:56:37.000000000","message":"recheck","commit_id":"741afce85b89bfbf3b158c57a48225ae5e2886df"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"5dfad94d3c090b9205336dab86011cfe9a5293ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"05b975d3_5f7be694","updated":"2022-07-01 09:36:17.000000000","message":"till rally job is broken, you have to rebase on top of https://review.opendev.org/c/openstack/neutron/+/847989","commit_id":"ae0ca42cb79b410afa406e71b28d7e073843756a"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"8a347429c6dd820b3804cc777d1038e72a142a3d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"fe4edf68_2ee4a0ea","in_reply_to":"05b975d3_5f7be694","updated":"2022-07-04 07:20:46.000000000","message":"Thanks Lajos for the heads-up. The CI is green for the two previous ones. I will wait a bit to see whether I get comments :-)","commit_id":"ae0ca42cb79b410afa406e71b28d7e073843756a"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"07b63cfa00afe85fe804686664c8cc1b2d47a84a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"a5489b1a_6f3a0c1c","updated":"2022-07-05 09:04:56.000000000","message":"It seems for me that the same jobs and same tests are still failing in the same way on all patches in the relation chain. Please check it before rechecking as this seems like related to that patch probably.","commit_id":"a6e78edcdeec4be511b3ab36da4cdc843fee1576"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"2946a54bc38f67b4f22c3b540e875ccbf1ef5e32","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"a64a361f_d75e6ed4","in_reply_to":"a5489b1a_6f3a0c1c","updated":"2022-07-07 08:03:05.000000000","message":"Yes I tried to rebased but same issues... i\u0027m investigating that","commit_id":"a6e78edcdeec4be511b3ab36da4cdc843fee1576"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"0265b42a01a10ed4fc440fdbb363b33681d62730","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"1b418bd8_77c52c5d","updated":"2022-07-11 09:41:54.000000000","message":"I fixed one CI test, the other ones looks to be strange as on the following patches they failed differently, let4s make a retry","commit_id":"f73356a2a58b879a9af45a0b410d3768b3ff6dd3"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"283834c95f9fa28b58f833467768478929204e1b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"df3dd943_6feb9c6b","updated":"2022-07-11 09:42:00.000000000","message":"recheck","commit_id":"f73356a2a58b879a9af45a0b410d3768b3ff6dd3"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"d3530ac97c0e63ceb2bf7c19c9374417cfa212ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"d17df6a0_4a4397bf","updated":"2022-07-20 07:36:11.000000000","message":"It is exactly the same issue reported here:\n\nhttps://bugs.launchpad.net/neutron/+bug/1981963\n\n\nThis patch:\nhttps://5d23c9084a7141eb203e-58239e1a4b15f03947d788f659988886.ssl.cf1.rackcdn.com/839479/20/check/neutron-ovs-grenade-dvr-multinode/5d9d1dd/testr_results.html\n\nFrom the reported bug:\nhttps://d0b0b53d30de16fbad20-5f381a9e8c14b627196c6ef3340b4d4e.ssl.cf5.rackcdn.com/849122/8/check/neutron-ovs-grenade-dvr-multinode/2a568da/testr_results.html","commit_id":"fd978fec19a8a3eb486c69bb2ada18d48fa11c3d"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"85bc17962e713f651b4288bee96a575192ea9c3e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"93a576e9_745f6412","updated":"2022-07-20 07:36:17.000000000","message":"recheck","commit_id":"fd978fec19a8a3eb486c69bb2ada18d48fa11c3d"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"8c0314bed79f4c13403be581f9a9e0130cca7c57","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"f40279c8_a5e9651a","updated":"2022-08-31 14:36:02.000000000","message":"Please address Oleg\u0027s comments and it will be LGTM for me 😊","commit_id":"b74d019ed094d658d1a81dedee731941bd674030"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"fab8093d1c44d9c60890c07befada017321804e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"d4fa3850_443eba85","updated":"2022-08-31 07:06:41.000000000","message":"looks ok for me.","commit_id":"b74d019ed094d658d1a81dedee731941bd674030"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"f0c6043e4c2fa8f0fa99c602dbb43f1e6caa98cd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"de4d766e_bba4ed7e","updated":"2022-09-02 07:32:36.000000000","message":"Thanks!","commit_id":"6ec0bc70a7907ab2d83d1dfe0b177ddf17c79d61"}],"neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"32b3c80d9d266529eb230dc92d6a0be75eb1c158","unresolved":true,"context_lines":[{"line_number":1959,"context_line":"                if tun_ofport in lvm.tun_ofports:"},{"line_number":1960,"context_line":"                    # still used"},{"line_number":1961,"context_line":"                    return"},{"line_number":1962,"context_line":"        # If not, remove it"},{"line_number":1963,"context_line":"        items \u003d list(self.tun_br_ofports[tunnel_type].items())"},{"line_number":1964,"context_line":"        for remote_ip, ofport in items:"},{"line_number":1965,"context_line":"            if ofport \u003d\u003d tun_ofport:"},{"line_number":1966,"context_line":"                port_name \u003d self.get_tunnel_name("},{"line_number":1967,"context_line":"                    tunnel_type, self.local_ip, remote_ip)"},{"line_number":1968,"context_line":"                br.delete_port(port_name)"},{"line_number":1969,"context_line":"                br.cleanup_tunnel_port(ofport)"},{"line_number":1970,"context_line":"                self.tun_br_ofports[tunnel_type].pop("},{"line_number":1971,"context_line":"                    remote_ip, None)"},{"line_number":1972,"context_line":""},{"line_number":1973,"context_line":"    def treat_devices_added_or_updated(self, devices, provisioning_needed,"},{"line_number":1974,"context_line":"                                       re_added):"}],"source_content_type":"text/x-python","patch_set":23,"id":"d1dbf93c_858bd07c","line":1971,"range":{"start_line":1962,"start_character":8,"end_line":1971,"end_character":36},"updated":"2022-07-21 10:32:45.000000000","message":"hmmm, I would indent it under the inner for loop, have you tried that?","commit_id":"116da010e6019d37ff9af7f6149178946f7f5927"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"72236a052071785d12e7d639ab4fe0470c1fb5d9","unresolved":true,"context_lines":[{"line_number":1959,"context_line":"                if tun_ofport in lvm.tun_ofports:"},{"line_number":1960,"context_line":"                    # still used"},{"line_number":1961,"context_line":"                    return"},{"line_number":1962,"context_line":"        # If not, remove it"},{"line_number":1963,"context_line":"        items \u003d list(self.tun_br_ofports[tunnel_type].items())"},{"line_number":1964,"context_line":"        for remote_ip, ofport in items:"},{"line_number":1965,"context_line":"            if ofport \u003d\u003d tun_ofport:"},{"line_number":1966,"context_line":"                port_name \u003d self.get_tunnel_name("},{"line_number":1967,"context_line":"                    tunnel_type, self.local_ip, remote_ip)"},{"line_number":1968,"context_line":"                br.delete_port(port_name)"},{"line_number":1969,"context_line":"                br.cleanup_tunnel_port(ofport)"},{"line_number":1970,"context_line":"                self.tun_br_ofports[tunnel_type].pop("},{"line_number":1971,"context_line":"                    remote_ip, None)"},{"line_number":1972,"context_line":""},{"line_number":1973,"context_line":"    def treat_devices_added_or_updated(self, devices, provisioning_needed,"},{"line_number":1974,"context_line":"                                       re_added):"}],"source_content_type":"text/x-python","patch_set":23,"id":"a27641f2_e0b8f1ed","line":1971,"range":{"start_line":1962,"start_character":8,"end_line":1971,"end_character":36},"in_reply_to":"239b682f_f473f808","updated":"2022-08-31 09:29:20.000000000","message":"Seems ok to me as it is now","commit_id":"116da010e6019d37ff9af7f6149178946f7f5927"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"d9be1ffb4fc88d6431b63e43ea836aea2294d5f6","unresolved":false,"context_lines":[{"line_number":1959,"context_line":"                if tun_ofport in lvm.tun_ofports:"},{"line_number":1960,"context_line":"                    # still used"},{"line_number":1961,"context_line":"                    return"},{"line_number":1962,"context_line":"        # If not, remove it"},{"line_number":1963,"context_line":"        items \u003d list(self.tun_br_ofports[tunnel_type].items())"},{"line_number":1964,"context_line":"        for remote_ip, ofport in items:"},{"line_number":1965,"context_line":"            if ofport \u003d\u003d tun_ofport:"},{"line_number":1966,"context_line":"                port_name \u003d self.get_tunnel_name("},{"line_number":1967,"context_line":"                    tunnel_type, self.local_ip, remote_ip)"},{"line_number":1968,"context_line":"                br.delete_port(port_name)"},{"line_number":1969,"context_line":"                br.cleanup_tunnel_port(ofport)"},{"line_number":1970,"context_line":"                self.tun_br_ofports[tunnel_type].pop("},{"line_number":1971,"context_line":"                    remote_ip, None)"},{"line_number":1972,"context_line":""},{"line_number":1973,"context_line":"    def treat_devices_added_or_updated(self, devices, provisioning_needed,"},{"line_number":1974,"context_line":"                                       re_added):"}],"source_content_type":"text/x-python","patch_set":23,"id":"793c5e7f_ee75ea30","line":1971,"range":{"start_line":1962,"start_character":8,"end_line":1971,"end_character":36},"in_reply_to":"a27641f2_e0b8f1ed","updated":"2022-09-01 12:48:45.000000000","message":"Done","commit_id":"116da010e6019d37ff9af7f6149178946f7f5927"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"cb1fa862b4eac81a53c3b51c828927a4680e362d","unresolved":true,"context_lines":[{"line_number":1959,"context_line":"                if tun_ofport in lvm.tun_ofports:"},{"line_number":1960,"context_line":"                    # still used"},{"line_number":1961,"context_line":"                    return"},{"line_number":1962,"context_line":"        # If not, remove it"},{"line_number":1963,"context_line":"        items \u003d list(self.tun_br_ofports[tunnel_type].items())"},{"line_number":1964,"context_line":"        for remote_ip, ofport in items:"},{"line_number":1965,"context_line":"            if ofport \u003d\u003d tun_ofport:"},{"line_number":1966,"context_line":"                port_name \u003d self.get_tunnel_name("},{"line_number":1967,"context_line":"                    tunnel_type, self.local_ip, remote_ip)"},{"line_number":1968,"context_line":"                br.delete_port(port_name)"},{"line_number":1969,"context_line":"                br.cleanup_tunnel_port(ofport)"},{"line_number":1970,"context_line":"                self.tun_br_ofports[tunnel_type].pop("},{"line_number":1971,"context_line":"                    remote_ip, None)"},{"line_number":1972,"context_line":""},{"line_number":1973,"context_line":"    def treat_devices_added_or_updated(self, devices, provisioning_needed,"},{"line_number":1974,"context_line":"                                       re_added):"}],"source_content_type":"text/x-python","patch_set":23,"id":"239b682f_f473f808","line":1971,"range":{"start_line":1962,"start_character":8,"end_line":1971,"end_character":36},"in_reply_to":"d1dbf93c_858bd07c","updated":"2022-07-21 18:34:50.000000000","message":"hm, if we do that, we don\u0027t go through all ofports before to consider this tunnel port not used anymore, right?\n\nOr perhaps I have not entirely understood your suggestion :-)","commit_id":"116da010e6019d37ff9af7f6149178946f7f5927"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"9f4c115d2579ff19dca94221f4ef98e77f95b9d3","unresolved":true,"context_lines":[{"line_number":498,"context_line":"            # to update the segmentation id. We still support it if only one"},{"line_number":499,"context_line":"            # segment per network."},{"line_number":500,"context_line":"            LOG.warning(\"Can\u0027t update segmentation id on no uniq segment \""},{"line_number":501,"context_line":"                        \"for a network. (network\u003d%s)\", network[\u0027id\u0027])"},{"line_number":502,"context_line":"            return"},{"line_number":503,"context_line":""},{"line_number":504,"context_line":"        if segmentation_id_old is None:"}],"source_content_type":"text/x-python","patch_set":25,"id":"204934e2_3a4035f6","line":501,"updated":"2022-08-01 12:29:13.000000000","message":"nitty nit: something like:\n\n    \"for a network %s\"\n    \nwould be enough.","commit_id":"c0185775aecfd696139364e2619cf7835907f2d4"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"16e2ab0f9a2e31b6369c7ac61679162c3fc73151","unresolved":false,"context_lines":[{"line_number":498,"context_line":"            # to update the segmentation id. We still support it if only one"},{"line_number":499,"context_line":"            # segment per network."},{"line_number":500,"context_line":"            LOG.warning(\"Can\u0027t update segmentation id on no uniq segment \""},{"line_number":501,"context_line":"                        \"for a network. (network\u003d%s)\", network[\u0027id\u0027])"},{"line_number":502,"context_line":"            return"},{"line_number":503,"context_line":""},{"line_number":504,"context_line":"        if segmentation_id_old is None:"}],"source_content_type":"text/x-python","patch_set":25,"id":"d6214dac_47acca8e","line":501,"in_reply_to":"204934e2_3a4035f6","updated":"2022-08-04 13:41:37.000000000","message":"Done","commit_id":"c0185775aecfd696139364e2619cf7835907f2d4"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"cfc0b92fe359f3f559def0b4063b73e6996bbdbf","unresolved":true,"context_lines":[{"line_number":489,"context_line":"        if network.get(provider_net.NETWORK_TYPE) !\u003d n_const.TYPE_VLAN:"},{"line_number":490,"context_line":"            return"},{"line_number":491,"context_line":""},{"line_number":492,"context_line":"        try:"},{"line_number":493,"context_line":"            segmentation_id_old, lvm \u003d ("},{"line_number":494,"context_line":"                self.vlan_manager.update_segmentation_id("},{"line_number":495,"context_line":"                    network[\u0027id\u0027], network[provider_net.SEGMENTATION_ID]))"},{"line_number":496,"context_line":"        except vlanmanager.NotUniqMapping:"},{"line_number":497,"context_line":"            # There is a design issue, the RPC update network should not accept"},{"line_number":498,"context_line":"            # to update the segmentation id. We still support it if only one"}],"source_content_type":"text/x-python","patch_set":27,"id":"b968ca1b_08af607f","line":495,"range":{"start_line":492,"start_character":8,"end_line":495,"end_character":74},"updated":"2022-08-08 06:27:08.000000000","message":"does it need to handle MappingNotFound as in original code?","commit_id":"ca3aae34244e9d017abd5776effc20a91e30c345"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"8e3ac4e725390044e69cbad455a4dce93296e355","unresolved":false,"context_lines":[{"line_number":489,"context_line":"        if network.get(provider_net.NETWORK_TYPE) !\u003d n_const.TYPE_VLAN:"},{"line_number":490,"context_line":"            return"},{"line_number":491,"context_line":""},{"line_number":492,"context_line":"        try:"},{"line_number":493,"context_line":"            segmentation_id_old, lvm \u003d ("},{"line_number":494,"context_line":"                self.vlan_manager.update_segmentation_id("},{"line_number":495,"context_line":"                    network[\u0027id\u0027], network[provider_net.SEGMENTATION_ID]))"},{"line_number":496,"context_line":"        except vlanmanager.NotUniqMapping:"},{"line_number":497,"context_line":"            # There is a design issue, the RPC update network should not accept"},{"line_number":498,"context_line":"            # to update the segmentation id. We still support it if only one"}],"source_content_type":"text/x-python","patch_set":27,"id":"0c50b606_b5fc38f2","line":495,"range":{"start_line":492,"start_character":8,"end_line":495,"end_character":74},"in_reply_to":"b968ca1b_08af607f","updated":"2022-08-29 09:10:53.000000000","message":"It\u0027s not needed anymore, the new function update_segmentation_id is doing the whole job.","commit_id":"ca3aae34244e9d017abd5776effc20a91e30c345"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"cfc0b92fe359f3f559def0b4063b73e6996bbdbf","unresolved":true,"context_lines":[{"line_number":494,"context_line":"                self.vlan_manager.update_segmentation_id("},{"line_number":495,"context_line":"                    network[\u0027id\u0027], network[provider_net.SEGMENTATION_ID]))"},{"line_number":496,"context_line":"        except vlanmanager.NotUniqMapping:"},{"line_number":497,"context_line":"            # There is a design issue, the RPC update network should not accept"},{"line_number":498,"context_line":"            # to update the segmentation id. We still support it if only one"},{"line_number":499,"context_line":"            # segment per network."},{"line_number":500,"context_line":"            LOG.warning(\"Can\u0027t update segmentation id on no uniq segment \""},{"line_number":501,"context_line":"                        \"for a network %s\", network[\u0027id\u0027])"},{"line_number":502,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":27,"id":"e22a1243_9f53f524","line":499,"range":{"start_line":497,"start_character":14,"end_line":499,"end_character":34},"updated":"2022-08-08 06:27:08.000000000","message":"Please help me understand why is it a design issue: if I have a net with one segment (I don\u0027t need multisegment) - why can\u0027t I update segmentation id of my net?","commit_id":"ca3aae34244e9d017abd5776effc20a91e30c345"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"8e3ac4e725390044e69cbad455a4dce93296e355","unresolved":false,"context_lines":[{"line_number":494,"context_line":"                self.vlan_manager.update_segmentation_id("},{"line_number":495,"context_line":"                    network[\u0027id\u0027], network[provider_net.SEGMENTATION_ID]))"},{"line_number":496,"context_line":"        except vlanmanager.NotUniqMapping:"},{"line_number":497,"context_line":"            # There is a design issue, the RPC update network should not accept"},{"line_number":498,"context_line":"            # to update the segmentation id. We still support it if only one"},{"line_number":499,"context_line":"            # segment per network."},{"line_number":500,"context_line":"            LOG.warning(\"Can\u0027t update segmentation id on no uniq segment \""},{"line_number":501,"context_line":"                        \"for a network %s\", network[\u0027id\u0027])"},{"line_number":502,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":27,"id":"07106e70_aad477ee","line":499,"range":{"start_line":497,"start_character":14,"end_line":499,"end_character":34},"in_reply_to":"e22a1243_9f53f524","updated":"2022-08-29 09:10:53.000000000","message":"Sure, I may miss something but updating segments should be an API related to the subnets, not the network.","commit_id":"ca3aae34244e9d017abd5776effc20a91e30c345"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"cfc0b92fe359f3f559def0b4063b73e6996bbdbf","unresolved":true,"context_lines":[{"line_number":1347,"context_line":"            LOG.info(\u0027net_uuid %s not managed by VLAN manager\u0027,"},{"line_number":1348,"context_line":"                     net_uuid)"},{"line_number":1349,"context_line":"            if net_uuid:"},{"line_number":1350,"context_line":"                # TODO(sahid); This needs to be fixed. It supposes a segement"},{"line_number":1351,"context_line":"                # per network. Basically this code is to avoid changing logic"},{"line_number":1352,"context_line":"                # which is not the aim of this commit."},{"line_number":1353,"context_line":"                segs \u003d self.vlan_manager.get_segments(net_uuid)"},{"line_number":1354,"context_line":"                lvm \u003d self.vlan_manager.get(net_uuid, list(segs.keys())[0])"}],"source_content_type":"text/x-python","patch_set":27,"id":"eb481db3_6d4e7d2c","line":1351,"range":{"start_line":1350,"start_character":55,"end_line":1351,"end_character":29},"updated":"2022-08-08 06:27:08.000000000","message":"+ per host","commit_id":"ca3aae34244e9d017abd5776effc20a91e30c345"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"8e3ac4e725390044e69cbad455a4dce93296e355","unresolved":false,"context_lines":[{"line_number":1347,"context_line":"            LOG.info(\u0027net_uuid %s not managed by VLAN manager\u0027,"},{"line_number":1348,"context_line":"                     net_uuid)"},{"line_number":1349,"context_line":"            if net_uuid:"},{"line_number":1350,"context_line":"                # TODO(sahid); This needs to be fixed. It supposes a segement"},{"line_number":1351,"context_line":"                # per network. Basically this code is to avoid changing logic"},{"line_number":1352,"context_line":"                # which is not the aim of this commit."},{"line_number":1353,"context_line":"                segs \u003d self.vlan_manager.get_segments(net_uuid)"},{"line_number":1354,"context_line":"                lvm \u003d self.vlan_manager.get(net_uuid, list(segs.keys())[0])"}],"source_content_type":"text/x-python","patch_set":27,"id":"56a670fa_8dc1febf","line":1351,"range":{"start_line":1350,"start_character":55,"end_line":1351,"end_character":29},"in_reply_to":"eb481db3_6d4e7d2c","updated":"2022-08-29 09:10:53.000000000","message":"Done","commit_id":"ca3aae34244e9d017abd5776effc20a91e30c345"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"72236a052071785d12e7d639ab4fe0470c1fb5d9","unresolved":true,"context_lines":[{"line_number":1348,"context_line":"        lvm, vif_port, net_uuid \u003d self._get_port_lvm_and_vif(vif_id, net_uuid)"},{"line_number":1349,"context_line":"        if not lvm:"},{"line_number":1350,"context_line":"            return"},{"line_number":1351,"context_line":""},{"line_number":1352,"context_line":"        if vif_port and vif_id in lvm.vif_ports:"},{"line_number":1353,"context_line":"            self.dvr_agent.unbind_port_from_dvr(vif_port, lvm)"},{"line_number":1354,"context_line":"        lvm.vif_ports.pop(vif_id, None)"}],"source_content_type":"text/x-python","patch_set":28,"id":"e0b9f4f0_9db2edc8","side":"PARENT","line":1351,"updated":"2022-08-31 09:29:20.000000000","message":"unrelated, please undo","commit_id":"7dfe41ab8f9ecf6266c7a51c0223ff8f8822c16f"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"d9be1ffb4fc88d6431b63e43ea836aea2294d5f6","unresolved":false,"context_lines":[{"line_number":1348,"context_line":"        lvm, vif_port, net_uuid \u003d self._get_port_lvm_and_vif(vif_id, net_uuid)"},{"line_number":1349,"context_line":"        if not lvm:"},{"line_number":1350,"context_line":"            return"},{"line_number":1351,"context_line":""},{"line_number":1352,"context_line":"        if vif_port and vif_id in lvm.vif_ports:"},{"line_number":1353,"context_line":"            self.dvr_agent.unbind_port_from_dvr(vif_port, lvm)"},{"line_number":1354,"context_line":"        lvm.vif_ports.pop(vif_id, None)"}],"source_content_type":"text/x-python","patch_set":28,"id":"3319db45_7e9ec0b4","side":"PARENT","line":1351,"in_reply_to":"e0b9f4f0_9db2edc8","updated":"2022-09-01 12:48:45.000000000","message":"Done","commit_id":"7dfe41ab8f9ecf6266c7a51c0223ff8f8822c16f"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"fab8093d1c44d9c60890c07befada017321804e7","unresolved":true,"context_lines":[{"line_number":1348,"context_line":"                     net_uuid)"},{"line_number":1349,"context_line":"            if net_uuid:"},{"line_number":1350,"context_line":"                # TODO(sahid); This needs to be fixed. It supposes a segment"},{"line_number":1351,"context_line":"                # per network per phynet. Basically this code is to avoid"},{"line_number":1352,"context_line":"                # changing logic which is not the aim of this commit."},{"line_number":1353,"context_line":"                segs \u003d self.vlan_manager.get_segments(net_uuid)"},{"line_number":1354,"context_line":"                lvm \u003d self.vlan_manager.get(net_uuid, list(segs.keys())[0])"}],"source_content_type":"text/x-python","patch_set":28,"id":"51e22e38_94be0409","line":1351,"range":{"start_line":1351,"start_character":34,"end_line":1351,"end_character":40},"updated":"2022-08-31 07:06:41.000000000","message":"nit: physnet","commit_id":"b74d019ed094d658d1a81dedee731941bd674030"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"d9be1ffb4fc88d6431b63e43ea836aea2294d5f6","unresolved":false,"context_lines":[{"line_number":1348,"context_line":"                     net_uuid)"},{"line_number":1349,"context_line":"            if net_uuid:"},{"line_number":1350,"context_line":"                # TODO(sahid); This needs to be fixed. It supposes a segment"},{"line_number":1351,"context_line":"                # per network per phynet. Basically this code is to avoid"},{"line_number":1352,"context_line":"                # changing logic which is not the aim of this commit."},{"line_number":1353,"context_line":"                segs \u003d self.vlan_manager.get_segments(net_uuid)"},{"line_number":1354,"context_line":"                lvm \u003d self.vlan_manager.get(net_uuid, list(segs.keys())[0])"}],"source_content_type":"text/x-python","patch_set":28,"id":"5003e319_3caecfcd","line":1351,"range":{"start_line":1351,"start_character":34,"end_line":1351,"end_character":40},"in_reply_to":"51e22e38_94be0409","updated":"2022-09-01 12:48:45.000000000","message":"replaced with \u0027host\u0027","commit_id":"b74d019ed094d658d1a81dedee731941bd674030"}],"neutron/plugins/ml2/drivers/openvswitch/agent/vlanmanager.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"9f4c115d2579ff19dca94221f4ef98e77f95b9d3","unresolved":true,"context_lines":[{"line_number":103,"context_line":"        self.mapping[net_id][segmentation_id] \u003d LocalVLANMapping("},{"line_number":104,"context_line":"            vlan, network_type, physical_network, segmentation_id, vif_ports)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def get_net_uuid(self, vif_id, net_uuid\u003dNone):"},{"line_number":107,"context_line":"        # TODO(sahid): We should improve algorithm is net_uuid is passed."},{"line_number":108,"context_line":"        for network_id, vlan_mappings in self.mapping.items():"},{"line_number":109,"context_line":"            for segmentation_id, vlan_mapping in vlan_mappings.items():"}],"source_content_type":"text/x-python","patch_set":25,"id":"c0ed9a9c_4db52c50","line":106,"updated":"2022-08-01 12:29:13.000000000","message":"technically speaking this isn\u0027t get_net_uuid anymore but more \"get_net_and_segmentation_id\" or something like that","commit_id":"c0185775aecfd696139364e2619cf7835907f2d4"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"16e2ab0f9a2e31b6369c7ac61679162c3fc73151","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        self.mapping[net_id][segmentation_id] \u003d LocalVLANMapping("},{"line_number":104,"context_line":"            vlan, network_type, physical_network, segmentation_id, vif_ports)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def get_net_uuid(self, vif_id, net_uuid\u003dNone):"},{"line_number":107,"context_line":"        # TODO(sahid): We should improve algorithm is net_uuid is passed."},{"line_number":108,"context_line":"        for network_id, vlan_mappings in self.mapping.items():"},{"line_number":109,"context_line":"            for segmentation_id, vlan_mapping in vlan_mappings.items():"}],"source_content_type":"text/x-python","patch_set":25,"id":"032fc0a0_7f8ed034","line":106,"in_reply_to":"c0ed9a9c_4db52c50","updated":"2022-08-04 13:41:37.000000000","message":"Done","commit_id":"c0185775aecfd696139364e2619cf7835907f2d4"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"9f4c115d2579ff19dca94221f4ef98e77f95b9d3","unresolved":true,"context_lines":[{"line_number":134,"context_line":"        \"\"\"Returns tuple with segmentation id, lvm in success or None, None\"\"\""},{"line_number":135,"context_line":"        if len(self.mapping[net_id]) !\u003d 1:"},{"line_number":136,"context_line":"            # Update of segmentation id can work only if network has one"},{"line_number":137,"context_line":"            # network. This is a design issue that should be fixed in"},{"line_number":138,"context_line":"            # future. We should not accept segmentation update from a"},{"line_number":139,"context_line":"            # network."},{"line_number":140,"context_line":"            raise NotUniqMapping(net_id\u003dnet_id)"}],"source_content_type":"text/x-python","patch_set":25,"id":"088407c6_a9348a49","line":137,"range":{"start_line":137,"start_character":14,"end_line":137,"end_character":21},"updated":"2022-08-01 12:29:13.000000000","message":"segment probably","commit_id":"c0185775aecfd696139364e2619cf7835907f2d4"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"16e2ab0f9a2e31b6369c7ac61679162c3fc73151","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        \"\"\"Returns tuple with segmentation id, lvm in success or None, None\"\"\""},{"line_number":135,"context_line":"        if len(self.mapping[net_id]) !\u003d 1:"},{"line_number":136,"context_line":"            # Update of segmentation id can work only if network has one"},{"line_number":137,"context_line":"            # network. This is a design issue that should be fixed in"},{"line_number":138,"context_line":"            # future. We should not accept segmentation update from a"},{"line_number":139,"context_line":"            # network."},{"line_number":140,"context_line":"            raise NotUniqMapping(net_id\u003dnet_id)"}],"source_content_type":"text/x-python","patch_set":25,"id":"bcf879cf_8185cc77","line":137,"range":{"start_line":137,"start_character":14,"end_line":137,"end_character":21},"in_reply_to":"088407c6_a9348a49","updated":"2022-08-04 13:41:37.000000000","message":"Done","commit_id":"c0185775aecfd696139364e2619cf7835907f2d4"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"cfc0b92fe359f3f559def0b4063b73e6996bbdbf","unresolved":true,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"class NotUniqMapping(exceptions.NeutronException):"},{"line_number":39,"context_line":"    message \u003d _(\u0027Mapping VLAN for network %(net_id)s should be uniq.\u0027)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"class LocalVLANMapping(object):"}],"source_content_type":"text/x-python","patch_set":27,"id":"d18b3b5d_1cc6ce56","line":39,"range":{"start_line":39,"start_character":63,"end_line":39,"end_character":67},"updated":"2022-08-08 06:27:08.000000000","message":"nit: unique","commit_id":"ca3aae34244e9d017abd5776effc20a91e30c345"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"8e3ac4e725390044e69cbad455a4dce93296e355","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"class NotUniqMapping(exceptions.NeutronException):"},{"line_number":39,"context_line":"    message \u003d _(\u0027Mapping VLAN for network %(net_id)s should be uniq.\u0027)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"class LocalVLANMapping(object):"}],"source_content_type":"text/x-python","patch_set":27,"id":"d870f8b5_e67a8e42","line":39,"range":{"start_line":39,"start_character":63,"end_line":39,"end_character":67},"in_reply_to":"d18b3b5d_1cc6ce56","updated":"2022-08-29 09:10:53.000000000","message":"Done","commit_id":"ca3aae34244e9d017abd5776effc20a91e30c345"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"cfc0b92fe359f3f559def0b4063b73e6996bbdbf","unresolved":true,"context_lines":[{"line_number":104,"context_line":"            vlan, network_type, physical_network, segmentation_id, vif_ports)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def get_net_and_segmentation_id(self, vif_id, net_uuid\u003dNone):"},{"line_number":107,"context_line":"        # TODO(sahid): We should improve algorithm is net_uuid is passed."},{"line_number":108,"context_line":"        for network_id, vlan_mappings in self.mapping.items():"},{"line_number":109,"context_line":"            for segmentation_id, vlan_mapping in vlan_mappings.items():"},{"line_number":110,"context_line":"                if vif_id in vlan_mapping.vif_ports:"}],"source_content_type":"text/x-python","patch_set":27,"id":"f38d4953_4d39985b","line":107,"range":{"start_line":107,"start_character":51,"end_line":107,"end_character":53},"updated":"2022-08-08 06:27:08.000000000","message":"if","commit_id":"ca3aae34244e9d017abd5776effc20a91e30c345"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"8e3ac4e725390044e69cbad455a4dce93296e355","unresolved":false,"context_lines":[{"line_number":104,"context_line":"            vlan, network_type, physical_network, segmentation_id, vif_ports)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def get_net_and_segmentation_id(self, vif_id, net_uuid\u003dNone):"},{"line_number":107,"context_line":"        # TODO(sahid): We should improve algorithm is net_uuid is passed."},{"line_number":108,"context_line":"        for network_id, vlan_mappings in self.mapping.items():"},{"line_number":109,"context_line":"            for segmentation_id, vlan_mapping in vlan_mappings.items():"},{"line_number":110,"context_line":"                if vif_id in vlan_mapping.vif_ports:"}],"source_content_type":"text/x-python","patch_set":27,"id":"aa8e4f82_20e04a4c","line":107,"range":{"start_line":107,"start_character":51,"end_line":107,"end_character":53},"in_reply_to":"f38d4953_4d39985b","updated":"2022-08-29 09:10:53.000000000","message":"Done","commit_id":"ca3aae34244e9d017abd5776effc20a91e30c345"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"cfc0b92fe359f3f559def0b4063b73e6996bbdbf","unresolved":true,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def update_segmentation_id(self, net_id, segmentation_id):"},{"line_number":134,"context_line":"        \"\"\"Returns tuple with segmentation id, lvm in success or None, None\"\"\""},{"line_number":135,"context_line":"        if len(self.mapping[net_id]) !\u003d 1:"},{"line_number":136,"context_line":"            # Update of segmentation id can work only if network has one"},{"line_number":137,"context_line":"            # network. This is a design issue that should be fixed in"},{"line_number":138,"context_line":"            # future. We should not accept segmentation update from a"}],"source_content_type":"text/x-python","patch_set":27,"id":"4d3ed60c_10835511","line":135,"range":{"start_line":135,"start_character":15,"end_line":135,"end_character":35},"updated":"2022-08-08 06:27:08.000000000","message":"possible KeyError","commit_id":"ca3aae34244e9d017abd5776effc20a91e30c345"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"8e3ac4e725390044e69cbad455a4dce93296e355","unresolved":false,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def update_segmentation_id(self, net_id, segmentation_id):"},{"line_number":134,"context_line":"        \"\"\"Returns tuple with segmentation id, lvm in success or None, None\"\"\""},{"line_number":135,"context_line":"        if len(self.mapping[net_id]) !\u003d 1:"},{"line_number":136,"context_line":"            # Update of segmentation id can work only if network has one"},{"line_number":137,"context_line":"            # network. This is a design issue that should be fixed in"},{"line_number":138,"context_line":"            # future. We should not accept segmentation update from a"}],"source_content_type":"text/x-python","patch_set":27,"id":"8ebe2a3a_4c313523","line":135,"range":{"start_line":135,"start_character":15,"end_line":135,"end_character":35},"in_reply_to":"4d3ed60c_10835511","updated":"2022-08-29 09:10:53.000000000","message":"Done","commit_id":"ca3aae34244e9d017abd5776effc20a91e30c345"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"cfc0b92fe359f3f559def0b4063b73e6996bbdbf","unresolved":true,"context_lines":[{"line_number":134,"context_line":"        \"\"\"Returns tuple with segmentation id, lvm in success or None, None\"\"\""},{"line_number":135,"context_line":"        if len(self.mapping[net_id]) !\u003d 1:"},{"line_number":136,"context_line":"            # Update of segmentation id can work only if network has one"},{"line_number":137,"context_line":"            # network. This is a design issue that should be fixed in"},{"line_number":138,"context_line":"            # future. We should not accept segmentation update from a"},{"line_number":139,"context_line":"            # network."},{"line_number":140,"context_line":"            raise NotUniqMapping(net_id\u003dnet_id)"}],"source_content_type":"text/x-python","patch_set":27,"id":"ffba508a_0aa74a97","line":137,"range":{"start_line":137,"start_character":14,"end_line":137,"end_character":21},"updated":"2022-08-08 06:27:08.000000000","message":"segment","commit_id":"ca3aae34244e9d017abd5776effc20a91e30c345"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"8e3ac4e725390044e69cbad455a4dce93296e355","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        \"\"\"Returns tuple with segmentation id, lvm in success or None, None\"\"\""},{"line_number":135,"context_line":"        if len(self.mapping[net_id]) !\u003d 1:"},{"line_number":136,"context_line":"            # Update of segmentation id can work only if network has one"},{"line_number":137,"context_line":"            # network. This is a design issue that should be fixed in"},{"line_number":138,"context_line":"            # future. We should not accept segmentation update from a"},{"line_number":139,"context_line":"            # network."},{"line_number":140,"context_line":"            raise NotUniqMapping(net_id\u003dnet_id)"}],"source_content_type":"text/x-python","patch_set":27,"id":"c8c2e7a9_5e8abf69","line":137,"range":{"start_line":137,"start_character":14,"end_line":137,"end_character":21},"in_reply_to":"ffba508a_0aa74a97","updated":"2022-08-29 09:10:53.000000000","message":"Done","commit_id":"ca3aae34244e9d017abd5776effc20a91e30c345"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"72236a052071785d12e7d639ab4fe0470c1fb5d9","unresolved":true,"context_lines":[{"line_number":135,"context_line":"        if len(self.mapping.get(net_id, [])) !\u003d 1:"},{"line_number":136,"context_line":"            # Update of segmentation id can work only if network has one"},{"line_number":137,"context_line":"            # segment. This is a design issue that should be fixed in"},{"line_number":138,"context_line":"            # future. We should not accept segmentation update from a"},{"line_number":139,"context_line":"            # network."},{"line_number":140,"context_line":"            raise NotUniqMapping(net_id\u003dnet_id)"},{"line_number":141,"context_line":"        mapping \u003d list(self.mapping[net_id].values())[0]"}],"source_content_type":"text/x-python","patch_set":28,"id":"8e0d358a_2abeaf3f","line":138,"range":{"start_line":138,"start_character":63,"end_line":138,"end_character":67},"updated":"2022-08-31 09:29:20.000000000","message":"for","commit_id":"b74d019ed094d658d1a81dedee731941bd674030"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"d9be1ffb4fc88d6431b63e43ea836aea2294d5f6","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        if len(self.mapping.get(net_id, [])) !\u003d 1:"},{"line_number":136,"context_line":"            # Update of segmentation id can work only if network has one"},{"line_number":137,"context_line":"            # segment. This is a design issue that should be fixed in"},{"line_number":138,"context_line":"            # future. We should not accept segmentation update from a"},{"line_number":139,"context_line":"            # network."},{"line_number":140,"context_line":"            raise NotUniqMapping(net_id\u003dnet_id)"},{"line_number":141,"context_line":"        mapping \u003d list(self.mapping[net_id].values())[0]"}],"source_content_type":"text/x-python","patch_set":28,"id":"4d4e72df_f7299f1d","line":138,"range":{"start_line":138,"start_character":63,"end_line":138,"end_character":67},"in_reply_to":"8e0d358a_2abeaf3f","updated":"2022-09-01 12:48:45.000000000","message":"Done","commit_id":"b74d019ed094d658d1a81dedee731941bd674030"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"72236a052071785d12e7d639ab4fe0470c1fb5d9","unresolved":true,"context_lines":[{"line_number":137,"context_line":"            # segment. This is a design issue that should be fixed in"},{"line_number":138,"context_line":"            # future. We should not accept segmentation update from a"},{"line_number":139,"context_line":"            # network."},{"line_number":140,"context_line":"            raise NotUniqMapping(net_id\u003dnet_id)"},{"line_number":141,"context_line":"        mapping \u003d list(self.mapping[net_id].values())[0]"},{"line_number":142,"context_line":"        if mapping.segmentation_id \u003d\u003d segmentation_id:"},{"line_number":143,"context_line":"            # No need to update"}],"source_content_type":"text/x-python","patch_set":28,"id":"7b91803e_5600320f","line":140,"range":{"start_line":140,"start_character":18,"end_line":140,"end_character":32},"updated":"2022-08-31 09:29:20.000000000","message":"NotUniqMapping might be misleading if net_id does not exist in mapping at all. Please handle this case as well (raising MappingNotFound, like in get_segments())","commit_id":"b74d019ed094d658d1a81dedee731941bd674030"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"8c0314bed79f4c13403be581f9a9e0130cca7c57","unresolved":true,"context_lines":[{"line_number":137,"context_line":"            # segment. This is a design issue that should be fixed in"},{"line_number":138,"context_line":"            # future. We should not accept segmentation update from a"},{"line_number":139,"context_line":"            # network."},{"line_number":140,"context_line":"            raise NotUniqMapping(net_id\u003dnet_id)"},{"line_number":141,"context_line":"        mapping \u003d list(self.mapping[net_id].values())[0]"},{"line_number":142,"context_line":"        if mapping.segmentation_id \u003d\u003d segmentation_id:"},{"line_number":143,"context_line":"            # No need to update"}],"source_content_type":"text/x-python","patch_set":28,"id":"e52073a5_ac3a5722","line":140,"range":{"start_line":140,"start_character":18,"end_line":140,"end_character":32},"in_reply_to":"7b91803e_5600320f","updated":"2022-08-31 14:36:02.000000000","message":"+1","commit_id":"b74d019ed094d658d1a81dedee731941bd674030"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"d9be1ffb4fc88d6431b63e43ea836aea2294d5f6","unresolved":false,"context_lines":[{"line_number":137,"context_line":"            # segment. This is a design issue that should be fixed in"},{"line_number":138,"context_line":"            # future. We should not accept segmentation update from a"},{"line_number":139,"context_line":"            # network."},{"line_number":140,"context_line":"            raise NotUniqMapping(net_id\u003dnet_id)"},{"line_number":141,"context_line":"        mapping \u003d list(self.mapping[net_id].values())[0]"},{"line_number":142,"context_line":"        if mapping.segmentation_id \u003d\u003d segmentation_id:"},{"line_number":143,"context_line":"            # No need to update"}],"source_content_type":"text/x-python","patch_set":28,"id":"e58f58fa_88180c00","line":140,"range":{"start_line":140,"start_character":18,"end_line":140,"end_character":32},"in_reply_to":"e52073a5_ac3a5722","updated":"2022-09-01 12:48:45.000000000","message":"Done","commit_id":"b74d019ed094d658d1a81dedee731941bd674030"}]}