)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"577202b82ab12477006febfee9ff69b408fc262f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c502816a_ded535b3","updated":"2022-04-28 15:10:00.000000000","message":"-1 just to discuss the new proposal","commit_id":"51df858b159d7631c54ca35b4063898f4191438f"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"a2aab8b5f9fa11fff87efc6aac273686117ef93f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b1384790_ede1bcf7","updated":"2022-05-04 07:58:53.000000000","message":"LGTM","commit_id":"8df2f69b6f93fd964cc96efb42d085063b90a8e6"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"4a851ea67c46f16bd6d9151bd042e948b9888dfc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4f5be01d_17d12e74","updated":"2022-05-02 20:35:05.000000000","message":"recheck - No Such Device netlink error in functional tests","commit_id":"8df2f69b6f93fd964cc96efb42d085063b90a8e6"}],"neutron/db/agentschedulers_db.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"efad9ebd0d07e8b0c2a2c97be33d8c536641d09f","unresolved":true,"context_lines":[{"line_number":433,"context_line":"                      \"Probably it was removed concurrently by other server.\","},{"line_number":434,"context_line":"                      network_id, id)"},{"line_number":435,"context_line":"            return"},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"        if not notify:"},{"line_number":438,"context_line":"            return"},{"line_number":439,"context_line":"        dhcp_notifier \u003d self.agent_notifiers.get(constants.AGENT_TYPE_DHCP)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5261cc8b_17037984","line":436,"updated":"2022-04-28 15:09:46.000000000","message":"Let me propose you an alternative solution.\n\nInstead of:\n1) retrieving the NetworkDhcpAgentBinding object\n2) update the ports\n3) Delete the NetworkDhcpAgentBinding object\n4) Notify the event\n\nWe can at the start of the method, call NetworkDhcpAgentBinding.delete_objects(). With the proper filter, this method can return:\n- 1: the object has been deleted, continue with the method.\n- 0: no object has been deleted (it was already by other server); in this case, raise NetworkNotHostedByDhcpAgent as we do now.","commit_id":"51df858b159d7631c54ca35b4063898f4191438f"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"1f370d9510b81fc77aed0fb7dc08cbd58f744fdf","unresolved":false,"context_lines":[{"line_number":433,"context_line":"                      \"Probably it was removed concurrently by other server.\","},{"line_number":434,"context_line":"                      network_id, id)"},{"line_number":435,"context_line":"            return"},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"        if not notify:"},{"line_number":438,"context_line":"            return"},{"line_number":439,"context_line":"        dhcp_notifier \u003d self.agent_notifiers.get(constants.AGENT_TYPE_DHCP)"}],"source_content_type":"text/x-python","patch_set":1,"id":"f9764b92_9492e441","line":436,"in_reply_to":"5261cc8b_17037984","updated":"2022-05-02 10:27:55.000000000","message":"Done","commit_id":"51df858b159d7631c54ca35b4063898f4191438f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"be9884c7d3e5ed04451f1b414412470ab1b39e52","unresolved":true,"context_lines":[{"line_number":405,"context_line":"    def remove_network_from_dhcp_agent(self, context, id, network_id,"},{"line_number":406,"context_line":"                                       notify\u003dTrue):"},{"line_number":407,"context_line":"        agent \u003d self._get_agent(context, id)"},{"line_number":408,"context_line":"        deleted_bindings \u003d network.NetworkDhcpAgentBinding.delete_objects("},{"line_number":409,"context_line":"            context, network_id\u003dnetwork_id, dhcp_agent_id\u003did)"},{"line_number":410,"context_line":"        if not deleted_bindings:"},{"line_number":411,"context_line":"            raise das_exc.NetworkNotHostedByDhcpAgent("}],"source_content_type":"text/x-python","patch_set":2,"id":"c54b16a9_e7ff3c34","line":408,"range":{"start_line":408,"start_character":8,"end_line":408,"end_character":24},"updated":"2022-05-04 14:46:23.000000000","message":"Exactly, this is what I was proposing. Thanks!","commit_id":"8df2f69b6f93fd964cc96efb42d085063b90a8e6"}]}