)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"1f67fa3f2ab8cb3c5ae84eac4efde304c8a6ee5d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"5d136690_e4153720","updated":"2022-05-02 09:41:17.000000000","message":"It looks ok. As this patch now for ovn, it should have no effect on other stadium projects","commit_id":"21d8f6e816aab55376c63b19efcadc94c9972cd2"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"0740d3f4df97072574c10d2e6d885d4609996df3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"8be88070_940a06c3","updated":"2022-05-03 17:06:30.000000000","message":"recheck neutron-functional-with-uwsgi timeout","commit_id":"128f4347bbe07976e8240f973ef4ac44a6188a25"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"232adba000e5b19b6a613a9aec4342cdf47eb17c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"8c76b7be_d61528c8","updated":"2022-05-04 15:40:40.000000000","message":"recheck neutron-functional-with-uwsgi timeout","commit_id":"f5287ba2ddab4b74661472038d168c7ae62d494e"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"3faa890990c3327f2b4376857305395538310d43","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"ae242d47_e8c2a1f3","updated":"2022-05-04 14:05:11.000000000","message":"recheck neutron-functional-with-uwsgi timeout","commit_id":"f5287ba2ddab4b74661472038d168c7ae62d494e"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"88e6d065088c8c072dcdb611ef0dad0d03ba9893","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"1128fb75_c09c0a91","updated":"2022-05-06 11:20:21.000000000","message":"Nice patch. Thanks!","commit_id":"227c5f8568d0b2499db0d20c36eb65a07e56a893"}],"neutron/agent/ovn/metadata/agent.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"eae2b1cbea1f6fbaba4060c7f7940b7bb733bac9","unresolved":true,"context_lines":[{"line_number":200,"context_line":"    # NOTE (froyo): call just here just to allow the resolution of"},{"line_number":201,"context_line":"    # decorator tenacity arguments in method register_metadata_agent,"},{"line_number":202,"context_line":"    # decorator is resolved as soon as import module is called"},{"line_number":203,"context_line":"    config.register_common_opts()"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"    def __init__(self, conf):"},{"line_number":206,"context_line":"        self.conf \u003d conf"}],"source_content_type":"text/x-python","patch_set":7,"id":"d55a288b_d30cc7fd","line":203,"updated":"2022-04-29 15:03:56.000000000","message":"It still creates a side-effect when the class object is created","commit_id":"a1b128d4ec028d0d85a17042bf491645dc87ae9d"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"6cb4d1e80ced3df48294984dbfabb1fd8b1f236b","unresolved":false,"context_lines":[{"line_number":200,"context_line":"    # NOTE (froyo): call just here just to allow the resolution of"},{"line_number":201,"context_line":"    # decorator tenacity arguments in method register_metadata_agent,"},{"line_number":202,"context_line":"    # decorator is resolved as soon as import module is called"},{"line_number":203,"context_line":"    config.register_common_opts()"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"    def __init__(self, conf):"},{"line_number":206,"context_line":"        self.conf \u003d conf"}],"source_content_type":"text/x-python","patch_set":7,"id":"1181fa5a_7754369d","line":203,"in_reply_to":"d55a288b_d30cc7fd","updated":"2022-05-04 20:07:30.000000000","message":"Done","commit_id":"a1b128d4ec028d0d85a17042bf491645dc87ae9d"}],"neutron/agent/ovn/metadata/ovsdb.py":[{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"48aae60f56bb34368c44d1fd8ded200ae2afc7b5","unresolved":true,"context_lines":[{"line_number":54,"context_line":"        if events:"},{"line_number":55,"context_line":"            self.notify_handler.watch_events(events)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    @ovn_utils.retry()"},{"line_number":58,"context_line":"    def _get_ovsdb_helper(self, connection_string):"},{"line_number":59,"context_line":"        return idlutils.get_schema_helper(connection_string, self.SCHEMA)"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"60584c2b_fbc611f6","line":57,"updated":"2022-05-03 11:21:39.000000000","message":"According to new function defined should be @ovn_utils.retry(max_\u003d180)","commit_id":"f6baf9f048df6264d2ba5ce2d2647ad37de32463"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"49140ff88d955d5a71e1399734bf9843fa659b34","unresolved":true,"context_lines":[{"line_number":54,"context_line":"        if events:"},{"line_number":55,"context_line":"            self.notify_handler.watch_events(events)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    @ovn_utils.retry()"},{"line_number":58,"context_line":"    def _get_ovsdb_helper(self, connection_string):"},{"line_number":59,"context_line":"        return idlutils.get_schema_helper(connection_string, self.SCHEMA)"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"d3a91a18_9de44a9b","line":57,"in_reply_to":"60584c2b_fbc611f6","updated":"2022-05-03 14:30:06.000000000","message":"I just see that default value that new function will get from default option \u0027ovsdb_retry_max_interval\u0027 is 180, so just keep to fixed 180 to not be overwrote in case another setup would be defined","commit_id":"f6baf9f048df6264d2ba5ce2d2647ad37de32463"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"6a831838b0d2d65cce448ff947914263fb393d42","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        if events:"},{"line_number":55,"context_line":"            self.notify_handler.watch_events(events)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    @ovn_utils.retry()"},{"line_number":58,"context_line":"    def _get_ovsdb_helper(self, connection_string):"},{"line_number":59,"context_line":"        return idlutils.get_schema_helper(connection_string, self.SCHEMA)"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"0bcb0659_64434e9d","line":57,"in_reply_to":"d3a91a18_9de44a9b","updated":"2022-05-04 12:14:25.000000000","message":"Done","commit_id":"f6baf9f048df6264d2ba5ce2d2647ad37de32463"}],"neutron/common/ovn/utils.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"95a2fad293d73bd34b0fc781d9a309f5d2a2013b","unresolved":true,"context_lines":[{"line_number":696,"context_line":"            return \u0027p\u0027 + _dict[\u0027proto\u0027] + \u0027:\u0027 + _dict[\u0027file\u0027]"},{"line_number":697,"context_line":""},{"line_number":698,"context_line":""},{"line_number":699,"context_line":"def retry(max_\u003dNone):"},{"line_number":700,"context_line":"    def inner(func):"},{"line_number":701,"context_line":"        def wrapper(*args, **kwargs):"},{"line_number":702,"context_line":"            local_max \u003d max_ or ovn_conf.get_ovn_ovsdb_retry_max_interval()"}],"source_content_type":"text/x-python","patch_set":12,"id":"325d426d_3197ffb6","line":699,"range":{"start_line":699,"start_character":0,"end_line":699,"end_character":21},"updated":"2022-05-04 06:05:37.000000000","message":"How is it related to registering config options? Consider describe in commit message please","commit_id":"128f4347bbe07976e8240f973ef4ac44a6188a25"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"0eb7dd833fd5309039101f0bf0d3ccbf5ae4b1a4","unresolved":true,"context_lines":[{"line_number":696,"context_line":"            return \u0027p\u0027 + _dict[\u0027proto\u0027] + \u0027:\u0027 + _dict[\u0027file\u0027]"},{"line_number":697,"context_line":""},{"line_number":698,"context_line":""},{"line_number":699,"context_line":"def retry(max_\u003dNone):"},{"line_number":700,"context_line":"    def inner(func):"},{"line_number":701,"context_line":"        def wrapper(*args, **kwargs):"},{"line_number":702,"context_line":"            local_max \u003d max_ or ovn_conf.get_ovn_ovsdb_retry_max_interval()"}],"source_content_type":"text/x-python","patch_set":12,"id":"a925d88a_f3736c46","line":699,"updated":"2022-05-03 15:54:08.000000000","message":"I\u0027m thinking that we should make tests for this decorator.","commit_id":"128f4347bbe07976e8240f973ef4ac44a6188a25"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"fbdb47c882cb92ed54733310b4cf4ce465877209","unresolved":false,"context_lines":[{"line_number":696,"context_line":"            return \u0027p\u0027 + _dict[\u0027proto\u0027] + \u0027:\u0027 + _dict[\u0027file\u0027]"},{"line_number":697,"context_line":""},{"line_number":698,"context_line":""},{"line_number":699,"context_line":"def retry(max_\u003dNone):"},{"line_number":700,"context_line":"    def inner(func):"},{"line_number":701,"context_line":"        def wrapper(*args, **kwargs):"},{"line_number":702,"context_line":"            local_max \u003d max_ or ovn_conf.get_ovn_ovsdb_retry_max_interval()"}],"source_content_type":"text/x-python","patch_set":12,"id":"8568cb1b_b3768c54","line":699,"range":{"start_line":699,"start_character":0,"end_line":699,"end_character":21},"in_reply_to":"325d426d_3197ffb6","updated":"2022-05-04 12:13:24.000000000","message":"Done","commit_id":"128f4347bbe07976e8240f973ef4ac44a6188a25"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"7da6943df83ce003054c366691a0d5b5abc7778b","unresolved":true,"context_lines":[{"line_number":696,"context_line":"            return \u0027p\u0027 + _dict[\u0027proto\u0027] + \u0027:\u0027 + _dict[\u0027file\u0027]"},{"line_number":697,"context_line":""},{"line_number":698,"context_line":""},{"line_number":699,"context_line":"def retry(max_\u003dNone):"},{"line_number":700,"context_line":"    def inner(func):"},{"line_number":701,"context_line":"        def wrapper(*args, **kwargs):"},{"line_number":702,"context_line":"            local_max \u003d max_ or ovn_conf.get_ovn_ovsdb_retry_max_interval()"}],"source_content_type":"text/x-python","patch_set":12,"id":"9f80732c_0138c278","line":699,"in_reply_to":"94a8e198_33de7857","updated":"2022-05-04 21:41:58.000000000","message":"I went ahead and wrote something I think should do a better coverage and make sure the decorator actually works. Feel free to revert if you think the PS14 is better.","commit_id":"128f4347bbe07976e8240f973ef4ac44a6188a25"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"7586cfe880fcaec119f5c26ff803016b381c2095","unresolved":false,"context_lines":[{"line_number":696,"context_line":"            return \u0027p\u0027 + _dict[\u0027proto\u0027] + \u0027:\u0027 + _dict[\u0027file\u0027]"},{"line_number":697,"context_line":""},{"line_number":698,"context_line":""},{"line_number":699,"context_line":"def retry(max_\u003dNone):"},{"line_number":700,"context_line":"    def inner(func):"},{"line_number":701,"context_line":"        def wrapper(*args, **kwargs):"},{"line_number":702,"context_line":"            local_max \u003d max_ or ovn_conf.get_ovn_ovsdb_retry_max_interval()"}],"source_content_type":"text/x-python","patch_set":12,"id":"09254ba8_50be0f9d","line":699,"in_reply_to":"9f80732c_0138c278","updated":"2022-05-05 07:51:29.000000000","message":"totally right, I couldn\u0027t find a way to test the tenacity.retry stop that you have covered in the test success with catching StopIteration. ++","commit_id":"128f4347bbe07976e8240f973ef4ac44a6188a25"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"fbdb47c882cb92ed54733310b4cf4ce465877209","unresolved":true,"context_lines":[{"line_number":696,"context_line":"            return \u0027p\u0027 + _dict[\u0027proto\u0027] + \u0027:\u0027 + _dict[\u0027file\u0027]"},{"line_number":697,"context_line":""},{"line_number":698,"context_line":""},{"line_number":699,"context_line":"def retry(max_\u003dNone):"},{"line_number":700,"context_line":"    def inner(func):"},{"line_number":701,"context_line":"        def wrapper(*args, **kwargs):"},{"line_number":702,"context_line":"            local_max \u003d max_ or ovn_conf.get_ovn_ovsdb_retry_max_interval()"}],"source_content_type":"text/x-python","patch_set":12,"id":"94a8e198_33de7857","line":699,"in_reply_to":"a925d88a_f3736c46","updated":"2022-05-04 12:13:24.000000000","message":"unit tests added just to test if ovn_conf.get_ovn_ovsdb_retry_max_interval() is called or not according to max_ params. The iterative behaviour of the tenacity.retry is complicated to test as there is no stop condition configured.","commit_id":"128f4347bbe07976e8240f973ef4ac44a6188a25"}],"neutron/conf/plugins/ml2/drivers/ovn/ovn_conf.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"eae2b1cbea1f6fbaba4060c7f7940b7bb733bac9","unresolved":true,"context_lines":[{"line_number":217,"context_line":"    if _COMMON_OPTIONS_ALREADY_REGISTERED:"},{"line_number":218,"context_line":"        return"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    cfg.CONF.register_opts(ovn_opts, group\u003d\u0027ovn\u0027)"},{"line_number":221,"context_line":"    ovs_conf.register_ovs_agent_opts()"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"    _COMMON_OPTIONS_ALREADY_REGISTERED \u003d True"}],"source_content_type":"text/x-python","patch_set":7,"id":"654c2809_b1106ad1","line":220,"updated":"2022-04-29 15:03:56.000000000","message":"I think we should call this specifically for OVN services (from the mech driver and ovn agent only) instead of wrapping it with a function. These are not common opts","commit_id":"a1b128d4ec028d0d85a17042bf491645dc87ae9d"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"6cb4d1e80ced3df48294984dbfabb1fd8b1f236b","unresolved":false,"context_lines":[{"line_number":217,"context_line":"    if _COMMON_OPTIONS_ALREADY_REGISTERED:"},{"line_number":218,"context_line":"        return"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    cfg.CONF.register_opts(ovn_opts, group\u003d\u0027ovn\u0027)"},{"line_number":221,"context_line":"    ovs_conf.register_ovs_agent_opts()"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"    _COMMON_OPTIONS_ALREADY_REGISTERED \u003d True"}],"source_content_type":"text/x-python","patch_set":7,"id":"7be37de8_419d9b00","line":220,"in_reply_to":"654c2809_b1106ad1","updated":"2022-05-04 20:07:30.000000000","message":"Done","commit_id":"a1b128d4ec028d0d85a17042bf491645dc87ae9d"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/impl_idl_ovn.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"2d56a630cad26aedcab645034a0c20f0222609b5","unresolved":true,"context_lines":[{"line_number":233,"context_line":"class OvsdbNbOvnIdl(nb_impl_idl.OvnNbApiIdlImpl, Backend):"},{"line_number":234,"context_line":"    def __init__(self, connection):"},{"line_number":235,"context_line":"        super(OvsdbNbOvnIdl, self).__init__(connection)"},{"line_number":236,"context_line":"        cfg.register_common_opts()"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"    @n_utils.classproperty"},{"line_number":239,"context_line":"    def connection_string(cls):"}],"source_content_type":"text/x-python","patch_set":3,"id":"370652dd_65dc202b","line":236,"range":{"start_line":236,"start_character":12,"end_line":236,"end_character":32},"updated":"2022-04-29 07:00:18.000000000","message":"Why do we need to register the options at the initial method of a class? Those options should have been registered before, at the beginning of the process, in the main method.","commit_id":"605e90bbc085b5b18c13b1fb547444f26b8da421"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"5b2401915195a2915cd72bdfcd30662f1992e5bd","unresolved":false,"context_lines":[{"line_number":233,"context_line":"class OvsdbNbOvnIdl(nb_impl_idl.OvnNbApiIdlImpl, Backend):"},{"line_number":234,"context_line":"    def __init__(self, connection):"},{"line_number":235,"context_line":"        super(OvsdbNbOvnIdl, self).__init__(connection)"},{"line_number":236,"context_line":"        cfg.register_common_opts()"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"    @n_utils.classproperty"},{"line_number":239,"context_line":"    def connection_string(cls):"}],"source_content_type":"text/x-python","patch_set":3,"id":"61eb60b8_869630f9","line":236,"range":{"start_line":236,"start_character":12,"end_line":236,"end_character":32},"in_reply_to":"370652dd_65dc202b","updated":"2022-04-29 15:06:20.000000000","message":"Yes, I understood your approach and after reviewing the first commit several calls to the register method were not necessary. I think that only the strictly necessary ones are left.","commit_id":"605e90bbc085b5b18c13b1fb547444f26b8da421"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/maintenance.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"2d56a630cad26aedcab645034a0c20f0222609b5","unresolved":true,"context_lines":[{"line_number":138,"context_line":"        self._idl.set_lock(\u0027ovn_db_inconsistencies_periodics\u0027)"},{"line_number":139,"context_line":"        self._sync_timer \u003d timeutils.StopWatch()"},{"line_number":140,"context_line":"        super(DBInconsistenciesPeriodics, self).__init__(ovn_client)"},{"line_number":141,"context_line":"        ovn_conf.register_common_opts()"},{"line_number":142,"context_line":"        self._resources_func_map \u003d {"},{"line_number":143,"context_line":"            ovn_const.TYPE_NETWORKS: {"},{"line_number":144,"context_line":"                \u0027neutron_get\u0027: self._ovn_client._plugin.get_network,"}],"source_content_type":"text/x-python","patch_set":3,"id":"78cecc0b_67d079c0","line":141,"range":{"start_line":141,"start_character":17,"end_line":141,"end_character":37},"updated":"2022-04-29 07:00:18.000000000","message":"ditto","commit_id":"605e90bbc085b5b18c13b1fb547444f26b8da421"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"5b2401915195a2915cd72bdfcd30662f1992e5bd","unresolved":false,"context_lines":[{"line_number":138,"context_line":"        self._idl.set_lock(\u0027ovn_db_inconsistencies_periodics\u0027)"},{"line_number":139,"context_line":"        self._sync_timer \u003d timeutils.StopWatch()"},{"line_number":140,"context_line":"        super(DBInconsistenciesPeriodics, self).__init__(ovn_client)"},{"line_number":141,"context_line":"        ovn_conf.register_common_opts()"},{"line_number":142,"context_line":"        self._resources_func_map \u003d {"},{"line_number":143,"context_line":"            ovn_const.TYPE_NETWORKS: {"},{"line_number":144,"context_line":"                \u0027neutron_get\u0027: self._ovn_client._plugin.get_network,"}],"source_content_type":"text/x-python","patch_set":3,"id":"a1269f1e_f2b91184","line":141,"range":{"start_line":141,"start_character":17,"end_line":141,"end_character":37},"in_reply_to":"78cecc0b_67d079c0","updated":"2022-04-29 15:06:20.000000000","message":"Ack","commit_id":"605e90bbc085b5b18c13b1fb547444f26b8da421"}],"neutron/tests/functional/base.py":[{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"48aae60f56bb34368c44d1fd8ded200ae2afc7b5","unresolved":true,"context_lines":[{"line_number":191,"context_line":"        self.addCleanup(exts.PluginAwareExtensionManager.clear_instance)"},{"line_number":192,"context_line":"        self.ovsdb_server_mgr \u003d None"},{"line_number":193,"context_line":"        self._service_plugins \u003d service_plugins"},{"line_number":194,"context_line":"        ovn_conf.register_opts()"},{"line_number":195,"context_line":"        super(TestOVNFunctionalBase, self).setUp()"},{"line_number":196,"context_line":"        self.test_log_dir \u003d os.path.join(DEFAULT_LOG_DIR, self.id())"},{"line_number":197,"context_line":"        base.setup_test_logging("}],"source_content_type":"text/x-python","patch_set":9,"id":"ec412b65_7e429184","line":194,"updated":"2022-05-03 11:21:39.000000000","message":"This line should be in L186 in order to not get NoSuchGroupError","commit_id":"f6baf9f048df6264d2ba5ce2d2647ad37de32463"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"6a831838b0d2d65cce448ff947914263fb393d42","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        self.addCleanup(exts.PluginAwareExtensionManager.clear_instance)"},{"line_number":192,"context_line":"        self.ovsdb_server_mgr \u003d None"},{"line_number":193,"context_line":"        self._service_plugins \u003d service_plugins"},{"line_number":194,"context_line":"        ovn_conf.register_opts()"},{"line_number":195,"context_line":"        super(TestOVNFunctionalBase, self).setUp()"},{"line_number":196,"context_line":"        self.test_log_dir \u003d os.path.join(DEFAULT_LOG_DIR, self.id())"},{"line_number":197,"context_line":"        base.setup_test_logging("}],"source_content_type":"text/x-python","patch_set":9,"id":"a9fe1dcd_a31317e0","line":194,"in_reply_to":"ec412b65_7e429184","updated":"2022-05-04 12:14:25.000000000","message":"Done","commit_id":"f6baf9f048df6264d2ba5ce2d2647ad37de32463"}],"neutron/tests/unit/common/ovn/test_utils.py":[{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"48aae60f56bb34368c44d1fd8ded200ae2afc7b5","unresolved":true,"context_lines":[{"line_number":414,"context_line":"        self.assertEqual([\u00271.2.3.4\u0027, \u00275.6.7.8\u0027], dns_servers)"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"        # DNS servers from config parameter."},{"line_number":417,"context_line":"        cfg.CONF.set_override(\u0027dns_servers\u0027,"},{"line_number":418,"context_line":"                              \u00271.1.2.2,3.3.4.4\u0027, group\u003d\u0027ovn\u0027)"},{"line_number":419,"context_line":"        dns_servers \u003d utils.get_dhcp_dns_servers({})"},{"line_number":420,"context_line":"        self.assertEqual([\u00271.1.2.2\u0027, \u00273.3.4.4\u0027], dns_servers)"}],"source_content_type":"text/x-python","patch_set":9,"id":"00c02676_677ae7d1","line":417,"updated":"2022-05-03 11:21:39.000000000","message":"should we remove the setup? IMO if we remove the setUp (calling to ovn_conf.register_opts) and the scope of BaseTestCase should not call it as it is a case-specific configuration, then this line will show error \"oslo_config.cfg.NoSuchGroupError: no such group [ovn]\"","commit_id":"f6baf9f048df6264d2ba5ce2d2647ad37de32463"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"49140ff88d955d5a71e1399734bf9843fa659b34","unresolved":true,"context_lines":[{"line_number":414,"context_line":"        self.assertEqual([\u00271.2.3.4\u0027, \u00275.6.7.8\u0027], dns_servers)"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"        # DNS servers from config parameter."},{"line_number":417,"context_line":"        cfg.CONF.set_override(\u0027dns_servers\u0027,"},{"line_number":418,"context_line":"                              \u00271.1.2.2,3.3.4.4\u0027, group\u003d\u0027ovn\u0027)"},{"line_number":419,"context_line":"        dns_servers \u003d utils.get_dhcp_dns_servers({})"},{"line_number":420,"context_line":"        self.assertEqual([\u00271.1.2.2\u0027, \u00273.3.4.4\u0027], dns_servers)"}],"source_content_type":"text/x-python","patch_set":9,"id":"ac9ca2df_cb6fb344","line":417,"in_reply_to":"00c02676_677ae7d1","updated":"2022-05-03 14:30:06.000000000","message":"Only those tests are failing after patch 11, recover setUp on patch 12 and leave open comment in case I\u0027m missing something","commit_id":"f6baf9f048df6264d2ba5ce2d2647ad37de32463"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"6a831838b0d2d65cce448ff947914263fb393d42","unresolved":false,"context_lines":[{"line_number":414,"context_line":"        self.assertEqual([\u00271.2.3.4\u0027, \u00275.6.7.8\u0027], dns_servers)"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"        # DNS servers from config parameter."},{"line_number":417,"context_line":"        cfg.CONF.set_override(\u0027dns_servers\u0027,"},{"line_number":418,"context_line":"                              \u00271.1.2.2,3.3.4.4\u0027, group\u003d\u0027ovn\u0027)"},{"line_number":419,"context_line":"        dns_servers \u003d utils.get_dhcp_dns_servers({})"},{"line_number":420,"context_line":"        self.assertEqual([\u00271.1.2.2\u0027, \u00273.3.4.4\u0027], dns_servers)"}],"source_content_type":"text/x-python","patch_set":9,"id":"c621afe0_c2aad1ec","line":417,"in_reply_to":"ac9ca2df_cb6fb344","updated":"2022-05-04 12:14:25.000000000","message":"Done","commit_id":"f6baf9f048df6264d2ba5ce2d2647ad37de32463"}]}