)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"f9a956ca5d96777735fa4ce25227b42a23fef07c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"86bf0be1_baef137f","updated":"2022-05-13 06:24:35.000000000","message":"Please add a unit test for the change","commit_id":"bb9eb350abdd53197df962880a5774c8410c9e0d"},{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"5ec7fb10c3a81ba20e0e42d8735f017727ba18fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"04b9517b_bad4ef49","updated":"2022-05-10 14:09:50.000000000","message":"recheck","commit_id":"bb9eb350abdd53197df962880a5774c8410c9e0d"},{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"3d38bf2da286586c7ee66f86b7ea1e829aa82f84","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6027d2f6_da89cd0a","updated":"2022-05-12 01:46:54.000000000","message":"recheck\n\nrandom failure of wait_until_ha_router_has_state(router, \u0027primary\u0027) timing out\n","commit_id":"bb9eb350abdd53197df962880a5774c8410c9e0d"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"1ab4d2f73561b9f67783c1e9ae73ffdef874cd8a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"30a3c7dd_2b19488a","updated":"2022-05-12 09:52:59.000000000","message":"recheck fullstack test_router_fip_qos_after_admin_state_down_up timeout","commit_id":"bb9eb350abdd53197df962880a5774c8410c9e0d"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"621a3c113b373ee91ebb41daf74cb92b613e3af4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"88a147b6_1abe4dd1","updated":"2022-05-26 10:49:31.000000000","message":"Just few nits which can be addressed in follow up patch if needed 😊","commit_id":"d1fe14d366e501869addff17e851ac03a599adca"},{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"29fd22a35aeea62f0d8b2a933793da38139b9ea3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"14e9488d_7798901c","updated":"2022-05-28 02:46:55.000000000","message":"nitpick addressed in followed up patch https://review.opendev.org/c/openstack/neutron/+/843698","commit_id":"d1fe14d366e501869addff17e851ac03a599adca"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"3917c7b2c223f08db2f331672ebd1b0b735ccb2a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"1cc512d1_6d42f9b8","updated":"2022-05-25 07:02:41.000000000","message":"recheck functional test_conntrack_disassociate_fip_ha_router timeout","commit_id":"d1fe14d366e501869addff17e851ac03a599adca"}],"neutron/plugins/ml2/managers.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"f9a956ca5d96777735fa4ce25227b42a23fef07c","unresolved":true,"context_lines":[{"line_number":183,"context_line":"            network[provider.SEGMENTATION_ID] \u003d segment["},{"line_number":184,"context_line":"                api.SEGMENTATION_ID]"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def get_segments_from_network(self, network):"},{"line_number":187,"context_line":"        multiple_segments \u003d network.pop(mpnet_apidef.SEGMENTS, [])"},{"line_number":188,"context_line":"        if multiple_segments:"},{"line_number":189,"context_line":"            network_segments \u003d multiple_segments"}],"source_content_type":"text/x-python","patch_set":3,"id":"a4166fdb_85d7cef4","line":186,"range":{"start_line":186,"start_character":8,"end_line":186,"end_character":11},"updated":"2022-05-13 06:24:35.000000000","message":"consider \"pop_segments_from_network\" as it\u0027s actually what this method does","commit_id":"bb9eb350abdd53197df962880a5774c8410c9e0d"},{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"2dc1fd3e7624862fbc74d9ed1bf192bcbd296adc","unresolved":false,"context_lines":[{"line_number":183,"context_line":"            network[provider.SEGMENTATION_ID] \u003d segment["},{"line_number":184,"context_line":"                api.SEGMENTATION_ID]"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def get_segments_from_network(self, network):"},{"line_number":187,"context_line":"        multiple_segments \u003d network.pop(mpnet_apidef.SEGMENTS, [])"},{"line_number":188,"context_line":"        if multiple_segments:"},{"line_number":189,"context_line":"            network_segments \u003d multiple_segments"}],"source_content_type":"text/x-python","patch_set":3,"id":"4cc8d638_a73cab8e","line":186,"range":{"start_line":186,"start_character":8,"end_line":186,"end_character":11},"in_reply_to":"a4166fdb_85d7cef4","updated":"2022-05-16 02:56:14.000000000","message":"Good catch, 100% agree.","commit_id":"bb9eb350abdd53197df962880a5774c8410c9e0d"}],"neutron/plugins/ml2/plugin.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c0e7e42d4c0992f979732d1099997a2aa5311458","unresolved":true,"context_lines":[{"line_number":2523,"context_line":"                                                    context, segment):"},{"line_number":2524,"context_line":"        network \u003d self.get_network(context, segment[\u0027network_id\u0027])"},{"line_number":2525,"context_line":""},{"line_number":2526,"context_line":"        if event in [events.PRECOMMIT_CREATE, events.PRECOMMIT_DELETE]:"},{"line_number":2527,"context_line":"            network_copy \u003d dict(network)"},{"line_number":2528,"context_line":"            if event \u003d\u003d events.PRECOMMIT_CREATE:"},{"line_number":2529,"context_line":"                self.type_manager.remove_segment_from_network("}],"source_content_type":"text/x-python","patch_set":1,"id":"e28f9a2a_88244f58","line":2526,"updated":"2022-05-03 13:09:21.000000000","message":"Hmmm, IMO, this implementation is a bit complicated.\n\nI would:\n- Make a network copy\n- Pop the segments into a list\n- If create: remove the segment and call \"_extend_network_dict_provider\"\n- If delete: add the segment and call \"_extend_network_dict_provider\"","commit_id":"b62903f1c6b88f28fa17871f9d1d65243fad56dc"},{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"a1b01730800891ef921eb460c3a4775f81e4cccd","unresolved":false,"context_lines":[{"line_number":2523,"context_line":"                                                    context, segment):"},{"line_number":2524,"context_line":"        network \u003d self.get_network(context, segment[\u0027network_id\u0027])"},{"line_number":2525,"context_line":""},{"line_number":2526,"context_line":"        if event in [events.PRECOMMIT_CREATE, events.PRECOMMIT_DELETE]:"},{"line_number":2527,"context_line":"            network_copy \u003d dict(network)"},{"line_number":2528,"context_line":"            if event \u003d\u003d events.PRECOMMIT_CREATE:"},{"line_number":2529,"context_line":"                self.type_manager.remove_segment_from_network("}],"source_content_type":"text/x-python","patch_set":1,"id":"23c3f555_78b90357","line":2526,"in_reply_to":"29b628eb_4b26f268","updated":"2022-05-06 18:46:07.000000000","message":"Ack","commit_id":"b62903f1c6b88f28fa17871f9d1d65243fad56dc"},{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"23dfd87dfe1f8aed3273c91de27c5f05bed5bce1","unresolved":true,"context_lines":[{"line_number":2523,"context_line":"                                                    context, segment):"},{"line_number":2524,"context_line":"        network \u003d self.get_network(context, segment[\u0027network_id\u0027])"},{"line_number":2525,"context_line":""},{"line_number":2526,"context_line":"        if event in [events.PRECOMMIT_CREATE, events.PRECOMMIT_DELETE]:"},{"line_number":2527,"context_line":"            network_copy \u003d dict(network)"},{"line_number":2528,"context_line":"            if event \u003d\u003d events.PRECOMMIT_CREATE:"},{"line_number":2529,"context_line":"                self.type_manager.remove_segment_from_network("}],"source_content_type":"text/x-python","patch_set":1,"id":"29b628eb_4b26f268","line":2526,"in_reply_to":"e28f9a2a_88244f58","updated":"2022-05-04 13:52:18.000000000","message":"I agree, thats why my FIXME comment in other file. However, its not as simple. Its hard to see from the code(wish we used Python type hints) but the segment in network uses provider:* keys while the segment in this function is NetworkSegment object (slightly different keys). So just popping or appending to a list will result in slightly different segment objects, if you can image what I am talking about. Anyway, I\u0027ll try to simplify it but I would rather do it in manager.py as this might make this function too long.","commit_id":"b62903f1c6b88f28fa17871f9d1d65243fad56dc"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"fb72d5a353469ecf523abf487666fd3b9884fabe","unresolved":true,"context_lines":[{"line_number":2519,"context_line":"                          \"\u0027%(segment)s\u0027\","},{"line_number":2520,"context_line":"                          {\u0027event\u0027: event, \u0027segment\u0027: segment[\u0027id\u0027]})"},{"line_number":2521,"context_line":""},{"line_number":2522,"context_line":"    def _build_original_network(self, network, event, segment):"},{"line_number":2523,"context_line":"        \"\"\"Constructs a copy of the given network where the given"},{"line_number":2524,"context_line":"        segment will be either removed(precommit_create) or added"},{"line_number":2525,"context_line":"        (precommit_delete) to the copied network"}],"source_content_type":"text/x-python","patch_set":6,"id":"8eb1240f_48831c25","line":2522,"range":{"start_line":2522,"start_character":54,"end_line":2522,"end_character":61},"updated":"2022-05-24 06:47:45.000000000","message":"nit: consider \u0027changed_segment\u0027 for readability","commit_id":"3f818b7f62b0356f89618b2f48dbc4169e008046"},{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"1e497af1876fc6713a38a9eab9a56f91794a1819","unresolved":false,"context_lines":[{"line_number":2519,"context_line":"                          \"\u0027%(segment)s\u0027\","},{"line_number":2520,"context_line":"                          {\u0027event\u0027: event, \u0027segment\u0027: segment[\u0027id\u0027]})"},{"line_number":2521,"context_line":""},{"line_number":2522,"context_line":"    def _build_original_network(self, network, event, segment):"},{"line_number":2523,"context_line":"        \"\"\"Constructs a copy of the given network where the given"},{"line_number":2524,"context_line":"        segment will be either removed(precommit_create) or added"},{"line_number":2525,"context_line":"        (precommit_delete) to the copied network"}],"source_content_type":"text/x-python","patch_set":6,"id":"6720e4de_12ab0672","line":2522,"range":{"start_line":2522,"start_character":54,"end_line":2522,"end_character":61},"in_reply_to":"8eb1240f_48831c25","updated":"2022-05-24 21:36:01.000000000","message":"Ack","commit_id":"3f818b7f62b0356f89618b2f48dbc4169e008046"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"fb72d5a353469ecf523abf487666fd3b9884fabe","unresolved":true,"context_lines":[{"line_number":2542,"context_line":"                    segment[api.NETWORK_TYPE] and"},{"line_number":2543,"context_line":"                    network_segment[api.PHYSICAL_NETWORK] \u003d\u003d"},{"line_number":2544,"context_line":"                    segment[api.PHYSICAL_NETWORK])]"},{"line_number":2545,"context_line":"        if event \u003d\u003d events.PRECOMMIT_DELETE:"},{"line_number":2546,"context_line":"            network_segments.append(segment)"},{"line_number":2547,"context_line":""},{"line_number":2548,"context_line":"        self.type_manager.extend_network_with_provider_segments("}],"source_content_type":"text/x-python","patch_set":6,"id":"6632a8d9_4f619056","line":2545,"range":{"start_line":2545,"start_character":20,"end_line":2545,"end_character":43},"updated":"2022-05-24 06:47:45.000000000","message":"Do we even need to do anything in case PRECOMMIT_DELETE? Seems pop and then re-add same segments is redundant, what am I missing?","commit_id":"3f818b7f62b0356f89618b2f48dbc4169e008046"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"fb72d5a353469ecf523abf487666fd3b9884fabe","unresolved":true,"context_lines":[{"line_number":2542,"context_line":"                    segment[api.NETWORK_TYPE] and"},{"line_number":2543,"context_line":"                    network_segment[api.PHYSICAL_NETWORK] \u003d\u003d"},{"line_number":2544,"context_line":"                    segment[api.PHYSICAL_NETWORK])]"},{"line_number":2545,"context_line":"        if event \u003d\u003d events.PRECOMMIT_DELETE:"},{"line_number":2546,"context_line":"            network_segments.append(segment)"},{"line_number":2547,"context_line":""},{"line_number":2548,"context_line":"        self.type_manager.extend_network_with_provider_segments("}],"source_content_type":"text/x-python","patch_set":6,"id":"9ae6c32b_012af8ce","line":2545,"range":{"start_line":2545,"start_character":8,"end_line":2545,"end_character":10},"updated":"2022-05-24 06:47:45.000000000","message":"nit: elif","commit_id":"3f818b7f62b0356f89618b2f48dbc4169e008046"},{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"1e497af1876fc6713a38a9eab9a56f91794a1819","unresolved":true,"context_lines":[{"line_number":2542,"context_line":"                    segment[api.NETWORK_TYPE] and"},{"line_number":2543,"context_line":"                    network_segment[api.PHYSICAL_NETWORK] \u003d\u003d"},{"line_number":2544,"context_line":"                    segment[api.PHYSICAL_NETWORK])]"},{"line_number":2545,"context_line":"        if event \u003d\u003d events.PRECOMMIT_DELETE:"},{"line_number":2546,"context_line":"            network_segments.append(segment)"},{"line_number":2547,"context_line":""},{"line_number":2548,"context_line":"        self.type_manager.extend_network_with_provider_segments("}],"source_content_type":"text/x-python","patch_set":6,"id":"f2a6f020_86a16f89","line":2545,"range":{"start_line":2545,"start_character":20,"end_line":2545,"end_character":43},"in_reply_to":"6632a8d9_4f619056","updated":"2022-05-24 21:36:01.000000000","message":"Its not very obvious but we are not popping and then re-adding the same segment. We are popping any existing segment(s) from the network and adding the \u0027changed_segment\u0027 to it.\nI added comment to my   test_precommit_delete_builds_multisegment_original_network test to better reflect that","commit_id":"3f818b7f62b0356f89618b2f48dbc4169e008046"},{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"1e497af1876fc6713a38a9eab9a56f91794a1819","unresolved":false,"context_lines":[{"line_number":2542,"context_line":"                    segment[api.NETWORK_TYPE] and"},{"line_number":2543,"context_line":"                    network_segment[api.PHYSICAL_NETWORK] \u003d\u003d"},{"line_number":2544,"context_line":"                    segment[api.PHYSICAL_NETWORK])]"},{"line_number":2545,"context_line":"        if event \u003d\u003d events.PRECOMMIT_DELETE:"},{"line_number":2546,"context_line":"            network_segments.append(segment)"},{"line_number":2547,"context_line":""},{"line_number":2548,"context_line":"        self.type_manager.extend_network_with_provider_segments("}],"source_content_type":"text/x-python","patch_set":6,"id":"de4a5ce2_df3be0d7","line":2545,"range":{"start_line":2545,"start_character":8,"end_line":2545,"end_character":10},"in_reply_to":"9ae6c32b_012af8ce","updated":"2022-05-24 21:36:01.000000000","message":"Ack","commit_id":"3f818b7f62b0356f89618b2f48dbc4169e008046"},{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"29fd22a35aeea62f0d8b2a933793da38139b9ea3","unresolved":false,"context_lines":[{"line_number":2542,"context_line":"                    segment[api.NETWORK_TYPE] and"},{"line_number":2543,"context_line":"                    network_segment[api.PHYSICAL_NETWORK] \u003d\u003d"},{"line_number":2544,"context_line":"                    segment[api.PHYSICAL_NETWORK])]"},{"line_number":2545,"context_line":"        if event \u003d\u003d events.PRECOMMIT_DELETE:"},{"line_number":2546,"context_line":"            network_segments.append(segment)"},{"line_number":2547,"context_line":""},{"line_number":2548,"context_line":"        self.type_manager.extend_network_with_provider_segments("}],"source_content_type":"text/x-python","patch_set":6,"id":"6c53b9fd_a59c70ed","line":2545,"range":{"start_line":2545,"start_character":20,"end_line":2545,"end_character":43},"in_reply_to":"f2a6f020_86a16f89","updated":"2022-05-28 02:46:55.000000000","message":"Done","commit_id":"3f818b7f62b0356f89618b2f48dbc4169e008046"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"621a3c113b373ee91ebb41daf74cb92b613e3af4","unresolved":true,"context_lines":[{"line_number":2527,"context_line":"            original_network\u003dnetwork_with_segments)"},{"line_number":2528,"context_line":"        if event in [events.PRECOMMIT_CREATE, events.PRECOMMIT_DELETE]:"},{"line_number":2529,"context_line":"            self.mechanism_manager.update_network_precommit(mech_context)"},{"line_number":2530,"context_line":"        elif event in [events.AFTER_CREATE, events.AFTER_DELETE]:"},{"line_number":2531,"context_line":"            self.mechanism_manager.update_network_postcommit(mech_context)"},{"line_number":2532,"context_line":""},{"line_number":2533,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":8,"id":"7cd98e8d_072404c0","side":"PARENT","line":2530,"range":{"start_line":2530,"start_character":8,"end_line":2530,"end_character":12},"updated":"2022-05-26 10:49:31.000000000","message":"nitty nit: I don\u0027t think this change is really needed but it\u0027s not big issue for sure","commit_id":"42ce0ea42cc345ab0305e344a1f46a8893772e22"},{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"29fd22a35aeea62f0d8b2a933793da38139b9ea3","unresolved":false,"context_lines":[{"line_number":2527,"context_line":"            original_network\u003dnetwork_with_segments)"},{"line_number":2528,"context_line":"        if event in [events.PRECOMMIT_CREATE, events.PRECOMMIT_DELETE]:"},{"line_number":2529,"context_line":"            self.mechanism_manager.update_network_precommit(mech_context)"},{"line_number":2530,"context_line":"        elif event in [events.AFTER_CREATE, events.AFTER_DELETE]:"},{"line_number":2531,"context_line":"            self.mechanism_manager.update_network_postcommit(mech_context)"},{"line_number":2532,"context_line":""},{"line_number":2533,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":8,"id":"cd6338ec_2128c5fb","side":"PARENT","line":2530,"range":{"start_line":2530,"start_character":8,"end_line":2530,"end_character":12},"in_reply_to":"7cd98e8d_072404c0","updated":"2022-05-28 02:46:55.000000000","message":"Ack","commit_id":"42ce0ea42cc345ab0305e344a1f46a8893772e22"}],"neutron/tests/unit/plugins/ml2/test_plugin.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"fb72d5a353469ecf523abf487666fd3b9884fabe","unresolved":true,"context_lines":[{"line_number":3715,"context_line":"        physical_network \u003d self.physnet"},{"line_number":3716,"context_line":"        segmentation_id \u003d 2"},{"line_number":3717,"context_line":""},{"line_number":3718,"context_line":"        new_segment \u003d {driver_api.NETWORK_TYPE: network_type,"},{"line_number":3719,"context_line":"                       driver_api.PHYSICAL_NETWORK: physical_network,"},{"line_number":3720,"context_line":"                       driver_api.SEGMENTATION_ID: segmentation_id}"},{"line_number":3721,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"017706b5_4efd9542","line":3718,"range":{"start_line":3718,"start_character":8,"end_line":3718,"end_character":19},"updated":"2022-05-24 06:47:45.000000000","message":"deleted_segment?","commit_id":"3f818b7f62b0356f89618b2f48dbc4169e008046"},{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"1e497af1876fc6713a38a9eab9a56f91794a1819","unresolved":false,"context_lines":[{"line_number":3715,"context_line":"        physical_network \u003d self.physnet"},{"line_number":3716,"context_line":"        segmentation_id \u003d 2"},{"line_number":3717,"context_line":""},{"line_number":3718,"context_line":"        new_segment \u003d {driver_api.NETWORK_TYPE: network_type,"},{"line_number":3719,"context_line":"                       driver_api.PHYSICAL_NETWORK: physical_network,"},{"line_number":3720,"context_line":"                       driver_api.SEGMENTATION_ID: segmentation_id}"},{"line_number":3721,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"45d3dac0_2b553223","line":3718,"range":{"start_line":3718,"start_character":8,"end_line":3718,"end_character":19},"in_reply_to":"017706b5_4efd9542","updated":"2022-05-24 21:36:01.000000000","message":"Ack","commit_id":"3f818b7f62b0356f89618b2f48dbc4169e008046"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"621a3c113b373ee91ebb41daf74cb92b613e3af4","unresolved":true,"context_lines":[{"line_number":3654,"context_line":"        physical_network \u003d self.physnet"},{"line_number":3655,"context_line":"        segmentation_id \u003d 2"},{"line_number":3656,"context_line":""},{"line_number":3657,"context_line":"        network_segments \u003d [{pnet.NETWORK_TYPE: \u0027vlan\u0027,"},{"line_number":3658,"context_line":"                             pnet.PHYSICAL_NETWORK: self.physnet2,"},{"line_number":3659,"context_line":"                             pnet.SEGMENTATION_ID: 1},"},{"line_number":3660,"context_line":"                            {pnet.NETWORK_TYPE: network_type,"}],"source_content_type":"text/x-python","patch_set":8,"id":"ad73fc11_2097a6e1","line":3657,"range":{"start_line":3657,"start_character":49,"end_line":3657,"end_character":53},"updated":"2022-05-26 10:49:31.000000000","message":"nit: why You don\u0027t use \"network_type\" variable here?","commit_id":"d1fe14d366e501869addff17e851ac03a599adca"},{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"29fd22a35aeea62f0d8b2a933793da38139b9ea3","unresolved":false,"context_lines":[{"line_number":3654,"context_line":"        physical_network \u003d self.physnet"},{"line_number":3655,"context_line":"        segmentation_id \u003d 2"},{"line_number":3656,"context_line":""},{"line_number":3657,"context_line":"        network_segments \u003d [{pnet.NETWORK_TYPE: \u0027vlan\u0027,"},{"line_number":3658,"context_line":"                             pnet.PHYSICAL_NETWORK: self.physnet2,"},{"line_number":3659,"context_line":"                             pnet.SEGMENTATION_ID: 1},"},{"line_number":3660,"context_line":"                            {pnet.NETWORK_TYPE: network_type,"}],"source_content_type":"text/x-python","patch_set":8,"id":"76ec6992_4dd384df","line":3657,"range":{"start_line":3657,"start_character":49,"end_line":3657,"end_character":53},"in_reply_to":"ad73fc11_2097a6e1","updated":"2022-05-28 02:46:55.000000000","message":"Ack","commit_id":"d1fe14d366e501869addff17e851ac03a599adca"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"621a3c113b373ee91ebb41daf74cb92b613e3af4","unresolved":true,"context_lines":[{"line_number":3683,"context_line":"        physical_network \u003d self.physnet"},{"line_number":3684,"context_line":"        segmentation_id \u003d 3"},{"line_number":3685,"context_line":""},{"line_number":3686,"context_line":"        network_segments \u003d [{pnet.NETWORK_TYPE: \u0027vlan\u0027,"},{"line_number":3687,"context_line":"                             pnet.PHYSICAL_NETWORK: self.physnet2,"},{"line_number":3688,"context_line":"                             pnet.SEGMENTATION_ID: 1},"},{"line_number":3689,"context_line":"                            {pnet.NETWORK_TYPE: \u0027vlan\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"a2b444d7_91448df1","line":3686,"range":{"start_line":3686,"start_character":49,"end_line":3686,"end_character":53},"updated":"2022-05-26 10:49:31.000000000","message":"same nit here","commit_id":"d1fe14d366e501869addff17e851ac03a599adca"},{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"29fd22a35aeea62f0d8b2a933793da38139b9ea3","unresolved":false,"context_lines":[{"line_number":3683,"context_line":"        physical_network \u003d self.physnet"},{"line_number":3684,"context_line":"        segmentation_id \u003d 3"},{"line_number":3685,"context_line":""},{"line_number":3686,"context_line":"        network_segments \u003d [{pnet.NETWORK_TYPE: \u0027vlan\u0027,"},{"line_number":3687,"context_line":"                             pnet.PHYSICAL_NETWORK: self.physnet2,"},{"line_number":3688,"context_line":"                             pnet.SEGMENTATION_ID: 1},"},{"line_number":3689,"context_line":"                            {pnet.NETWORK_TYPE: \u0027vlan\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"a04280e4_ad0e8357","line":3686,"range":{"start_line":3686,"start_character":49,"end_line":3686,"end_character":53},"in_reply_to":"a2b444d7_91448df1","updated":"2022-05-28 02:46:55.000000000","message":"Ack","commit_id":"d1fe14d366e501869addff17e851ac03a599adca"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"621a3c113b373ee91ebb41daf74cb92b613e3af4","unresolved":true,"context_lines":[{"line_number":3686,"context_line":"        network_segments \u003d [{pnet.NETWORK_TYPE: \u0027vlan\u0027,"},{"line_number":3687,"context_line":"                             pnet.PHYSICAL_NETWORK: self.physnet2,"},{"line_number":3688,"context_line":"                             pnet.SEGMENTATION_ID: 1},"},{"line_number":3689,"context_line":"                            {pnet.NETWORK_TYPE: \u0027vlan\u0027,"},{"line_number":3690,"context_line":"                             pnet.PHYSICAL_NETWORK: self.physnet3,"},{"line_number":3691,"context_line":"                             pnet.SEGMENTATION_ID: 2},"},{"line_number":3692,"context_line":"                            {pnet.NETWORK_TYPE: network_type,"}],"source_content_type":"text/x-python","patch_set":8,"id":"e5c21cd8_bd874113","line":3689,"range":{"start_line":3689,"start_character":49,"end_line":3689,"end_character":53},"updated":"2022-05-26 10:49:31.000000000","message":"and here","commit_id":"d1fe14d366e501869addff17e851ac03a599adca"},{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"29fd22a35aeea62f0d8b2a933793da38139b9ea3","unresolved":false,"context_lines":[{"line_number":3686,"context_line":"        network_segments \u003d [{pnet.NETWORK_TYPE: \u0027vlan\u0027,"},{"line_number":3687,"context_line":"                             pnet.PHYSICAL_NETWORK: self.physnet2,"},{"line_number":3688,"context_line":"                             pnet.SEGMENTATION_ID: 1},"},{"line_number":3689,"context_line":"                            {pnet.NETWORK_TYPE: \u0027vlan\u0027,"},{"line_number":3690,"context_line":"                             pnet.PHYSICAL_NETWORK: self.physnet3,"},{"line_number":3691,"context_line":"                             pnet.SEGMENTATION_ID: 2},"},{"line_number":3692,"context_line":"                            {pnet.NETWORK_TYPE: network_type,"}],"source_content_type":"text/x-python","patch_set":8,"id":"3c674770_5e35685a","line":3689,"range":{"start_line":3689,"start_character":49,"end_line":3689,"end_character":53},"in_reply_to":"e5c21cd8_bd874113","updated":"2022-05-28 02:46:55.000000000","message":"Ack","commit_id":"d1fe14d366e501869addff17e851ac03a599adca"}]}