)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"618e8dd3586d32053e5b8302f53425548b84f920","unresolved":true,"context_lines":[{"line_number":7,"context_line":"[OVN] Add baremetal support with Neutron DHCP agent"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch now creates OVN \"external\" ports for Neutron ports with"},{"line_number":10,"context_line":"VNIC_BAREMETAL. This ports will be scheduled on the controller nodes (or"},{"line_number":11,"context_line":"gateway nodes) and are responsible for replying to the ARP requests"},{"line_number":12,"context_line":"coming from the baremetal nodes."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch also disables OVN\u0027s built-in DHCP server for VNIC_BAREMETAL"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"a77350d2_625f67fd","line":11,"range":{"start_line":10,"start_character":52,"end_line":11,"end_character":13},"updated":"2022-05-04 07:48:32.000000000","message":"I\u0027m saying this because I had this issue before: I prefer to differentiate between OpenStack Controller and OVN controller. This is an OpenStack controller (or an OVN gateway node), correct?","commit_id":"c5f4d21c1dd6fc94725f8cb59ef9b60ab768f8c9"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"cd201b5c43a849bd5c64cd123e8c415376feeacf","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[OVN] Add baremetal support with Neutron DHCP agent"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch now creates OVN \"external\" ports for Neutron ports with"},{"line_number":10,"context_line":"VNIC_BAREMETAL. This ports will be scheduled on the controller nodes (or"},{"line_number":11,"context_line":"gateway nodes) and are responsible for replying to the ARP requests"},{"line_number":12,"context_line":"coming from the baremetal nodes."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch also disables OVN\u0027s built-in DHCP server for VNIC_BAREMETAL"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3ffd04f9_23159c8f","line":11,"range":{"start_line":10,"start_character":52,"end_line":11,"end_character":13},"in_reply_to":"524277f7_4e6369f2","updated":"2022-05-04 07:57:59.000000000","message":"Done","commit_id":"c5f4d21c1dd6fc94725f8cb59ef9b60ab768f8c9"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"d20b6140166a9bd3bdcffe122f339f44ffea3c73","unresolved":true,"context_lines":[{"line_number":7,"context_line":"[OVN] Add baremetal support with Neutron DHCP agent"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch now creates OVN \"external\" ports for Neutron ports with"},{"line_number":10,"context_line":"VNIC_BAREMETAL. This ports will be scheduled on the controller nodes (or"},{"line_number":11,"context_line":"gateway nodes) and are responsible for replying to the ARP requests"},{"line_number":12,"context_line":"coming from the baremetal nodes."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch also disables OVN\u0027s built-in DHCP server for VNIC_BAREMETAL"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"524277f7_4e6369f2","line":11,"range":{"start_line":10,"start_character":52,"end_line":11,"end_character":13},"in_reply_to":"a77350d2_625f67fd","updated":"2022-05-04 07:54:23.000000000","message":"Precisely! It\u0027s an OpenStack controller which acts as an OVN gateway node. I will update the commit message to be more on point about this.","commit_id":"c5f4d21c1dd6fc94725f8cb59ef9b60ab768f8c9"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6c2ba84f6b83de0527bf57c2a8537556010741d7","unresolved":true,"context_lines":[{"line_number":7,"context_line":"[OVN] Add baremetal support with Neutron DHCP agent"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch now creates OVN \"external\" ports for Neutron ports with"},{"line_number":10,"context_line":"VNIC_BAREMETAL. This ports will be scheduled on the OpenStack Controller"},{"line_number":11,"context_line":"nodes (or OVN Gateway nodes) and are responsible for replying to the"},{"line_number":12,"context_line":"ARP requests coming from the baremetal nodes."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch also disables OVN\u0027s built-in DHCP server for VNIC_BAREMETAL"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"82c54d5d_34a9902a","line":11,"range":{"start_line":10,"start_character":52,"end_line":11,"end_character":29},"updated":"2022-05-04 10:33:55.000000000","message":"+1 !","commit_id":"243c209eb2cf75570e6c850b7d5becb468e8d1ab"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"82977a1fdf4f361d746215f199b3560f28a5dbe0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"be1041ba_6e351095","updated":"2022-05-03 13:47:04.000000000","message":"I confirm that this helps and we tested it together in a real environment.","commit_id":"c5f4d21c1dd6fc94725f8cb59ef9b60ab768f8c9"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"618e8dd3586d32053e5b8302f53425548b84f920","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d5b01ec4_0fe6e335","updated":"2022-05-04 07:48:32.000000000","message":"Some questions:\n- what is OVN doing with the baremetal ports traffic?\n- do we need to spawn a DHCP agent?","commit_id":"c5f4d21c1dd6fc94725f8cb59ef9b60ab768f8c9"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"bb58a4ee033fa7af64a12c997dd0f5045aeec7fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"dda2ec72_cb9dce8b","in_reply_to":"73b52a55_11b532d4","updated":"2022-05-04 10:35:03.000000000","message":"Perfect, so those are \"similar\" to SRIOV ports. Now I have a better picture.","commit_id":"c5f4d21c1dd6fc94725f8cb59ef9b60ab768f8c9"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"d20b6140166a9bd3bdcffe122f339f44ffea3c73","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"73b52a55_11b532d4","in_reply_to":"d5b01ec4_0fe6e335","updated":"2022-05-04 07:54:23.000000000","message":"Q: what is OVN doing with the baremetal ports traffic?\n\nWith the external ports we know reply to ARPs from the baremetal node, as well allows it to access the OVN metadata agent. Just like SR-IOV nodes would.\n\nQ: do we need to spawn a DHCP agent?\n\nYes, we need to have the Neutron DHCP agent running on the OpenStack controller nodes to serve the baremetal node with DHCP and allows it to chainload from PXE to iPXE.\n\nIn a soon feature we want this to be handled by OVN controller itself, but at the moment the chainloading part is not fully implemented yet.","commit_id":"c5f4d21c1dd6fc94725f8cb59ef9b60ab768f8c9"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"129a0209606f986cf297b31dc4d4ade46dc02120","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"25d606ef_db9b1932","updated":"2022-05-05 10:04:12.000000000","message":"recheck","commit_id":"243c209eb2cf75570e6c850b7d5becb468e8d1ab"}],"neutron/common/ovn/constants.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"618e8dd3586d32053e5b8302f53425548b84f920","unresolved":true,"context_lines":[{"line_number":397,"context_line":"                            portbindings.VNIC_MACVTAP,"},{"line_number":398,"context_line":"                            portbindings.VNIC_VHOST_VDPA,"},{"line_number":399,"context_line":"                            portbindings.VNIC_REMOTE_MANAGED,"},{"line_number":400,"context_line":"                            portbindings.VNIC_BAREMETAL]"}],"source_content_type":"text/x-python","patch_set":1,"id":"be5b1ed9_65028c7e","line":400,"range":{"start_line":400,"start_character":55,"end_line":400,"end_character":56},"updated":"2022-05-04 07:48:32.000000000","message":"micro nit: please, leave the parenthesis in the next line (to keep the git history). Same comment in L377","commit_id":"c5f4d21c1dd6fc94725f8cb59ef9b60ab768f8c9"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"d20b6140166a9bd3bdcffe122f339f44ffea3c73","unresolved":false,"context_lines":[{"line_number":397,"context_line":"                            portbindings.VNIC_MACVTAP,"},{"line_number":398,"context_line":"                            portbindings.VNIC_VHOST_VDPA,"},{"line_number":399,"context_line":"                            portbindings.VNIC_REMOTE_MANAGED,"},{"line_number":400,"context_line":"                            portbindings.VNIC_BAREMETAL]"}],"source_content_type":"text/x-python","patch_set":1,"id":"c963e52f_552cfcca","line":400,"range":{"start_line":400,"start_character":55,"end_line":400,"end_character":56},"in_reply_to":"be5b1ed9_65028c7e","updated":"2022-05-04 07:54:23.000000000","message":"Done","commit_id":"c5f4d21c1dd6fc94725f8cb59ef9b60ab768f8c9"}]}