)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"e0f8ed3074009a2a80e73361937e94eaa68dc638","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"0c427e67_6f64bc08","updated":"2022-08-04 13:40:42.000000000","message":"Now it\u0027s neutron-functional-with-uwsgi failling where it was passing previously","commit_id":"ba72563dee76a5865d1e4cc70070535634521f25"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"f9af6cccac83548f4533c036d95aace23c808d03","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"552c702d_da7fa7c4","updated":"2022-08-03 17:15:12.000000000","message":"failing each time with a different error, let\u0027s make an other try","commit_id":"ba72563dee76a5865d1e4cc70070535634521f25"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"33a8869f76fe03f8dfe8b2590369238b425e8fa2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"c4f58dac_60136cb0","updated":"2022-08-04 06:59:11.000000000","message":"neutron-ovs-tempest-dvr-ha-multinode-full is not passing this time where it was passing previously.\n\nThe tempest functional tests wich was not passing previsously, passed this time","commit_id":"ba72563dee76a5865d1e4cc70070535634521f25"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"5154f0aea291dc198dec50f27bd09b917a9c84c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"15b5ae58_c0bd4b60","updated":"2022-08-04 06:59:18.000000000","message":"recheck","commit_id":"ba72563dee76a5865d1e4cc70070535634521f25"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"15eaff96e8f06bd71bbf48d2e3b2f6afc0780569","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"3493e22e_ad2c0dc7","updated":"2022-08-03 06:27:24.000000000","message":"recheck","commit_id":"ba72563dee76a5865d1e4cc70070535634521f25"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"45b08192d7ae7e69588f83a0b139f5074f3ddcb4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"a2fce71e_24fb40b4","updated":"2022-08-04 13:40:48.000000000","message":"recheck","commit_id":"ba72563dee76a5865d1e4cc70070535634521f25"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"7859bfc4cb188c1e3f7743971a5f807e520f40e4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"a9e9c413_de3b0bb0","updated":"2022-08-03 17:15:19.000000000","message":"recheck","commit_id":"ba72563dee76a5865d1e4cc70070535634521f25"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"b962c667d0683d6d96bce64582034dd8de37bf0e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"c25d9995_0a4bc7ea","updated":"2022-08-03 11:40:57.000000000","message":"recheck","commit_id":"ba72563dee76a5865d1e4cc70070535634521f25"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"4ae5055534ca483db9c93056a703da73c578951a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"5b431f56_1fbb121f","updated":"2022-09-02 14:29:14.000000000","message":"We definitely need more automated tests","commit_id":"6db791ac0fde866a61d8cfbf9679dbd02d327635"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"a231211f19fada445b4195269c63fccbfbf073d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"aade371b_bcec316f","updated":"2022-09-02 14:16:53.000000000","message":"recheck unrelated neutron-ovs-tempest-multinode-full test_live_migration_with_trunk failure","commit_id":"6db791ac0fde866a61d8cfbf9679dbd02d327635"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"dbe3dc3cd55198a8c52c5bea830a36913158d4eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"525b4edd_c2d8b06a","updated":"2022-09-05 06:20:42.000000000","message":"recheck unrelated neutron-ovs-tempest-multinode-full test_resize_server_from_manual_to_auto FAILURE","commit_id":"6db791ac0fde866a61d8cfbf9679dbd02d327635"}],"neutron/plugins/ml2/drivers/mech_agent.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"7b0942c66ca5bd4b403f9d76b7b5f44fe787d0bd","unresolved":true,"context_lines":[{"line_number":107,"context_line":"            # that they belong to first."},{"line_number":108,"context_line":"            for segment in context.segments_to_bind:"},{"line_number":109,"context_line":"                for subnet in subnets:"},{"line_number":110,"context_line":"                    seg_id \u003d subnet.get(\u0027segment_id\u0027)"},{"line_number":111,"context_line":"                    # If subnet is not attached to any segment, let\u0027s use"},{"line_number":112,"context_line":"                    # default behavior."},{"line_number":113,"context_line":"                    if seg_id is None or seg_id \u003d\u003d segment[api.ID]:"},{"line_number":114,"context_line":"                        allowed_binding_segments.append(segment)"},{"line_number":115,"context_line":"        else:"},{"line_number":116,"context_line":"            allowed_binding_segments \u003d context.segments_to_bind"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"adb33cf0_d720078a","line":114,"range":{"start_line":110,"start_character":0,"end_line":114,"end_character":64},"updated":"2022-08-10 20:44:43.000000000","message":"In a routed network, all the subnets must be associated to a segment.You cannot mix with subnets not associated to segments. Doesn\u0027t this code make it possible such mixing?","commit_id":"ba72563dee76a5865d1e4cc70070535634521f25"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"d518d08db221cb1f439d5efa809133eff6702f83","unresolved":true,"context_lines":[{"line_number":107,"context_line":"            # that they belong to first."},{"line_number":108,"context_line":"            for segment in context.segments_to_bind:"},{"line_number":109,"context_line":"                for subnet in subnets:"},{"line_number":110,"context_line":"                    seg_id \u003d subnet.get(\u0027segment_id\u0027)"},{"line_number":111,"context_line":"                    # If subnet is not attached to any segment, let\u0027s use"},{"line_number":112,"context_line":"                    # default behavior."},{"line_number":113,"context_line":"                    if seg_id is None or seg_id \u003d\u003d segment[api.ID]:"},{"line_number":114,"context_line":"                        allowed_binding_segments.append(segment)"},{"line_number":115,"context_line":"        else:"},{"line_number":116,"context_line":"            allowed_binding_segments \u003d context.segments_to_bind"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"fbe00053_d3affc6b","line":114,"range":{"start_line":110,"start_character":0,"end_line":114,"end_character":64},"in_reply_to":"adb33cf0_d720078a","updated":"2022-09-01 16:29:25.000000000","message":"Hum... yes this code is not preventing the case that you mention.\n\nI\u0027m wondering whether we should and how. Currently the API is providing to us that way to configure multisegments.\n\n1 - openstack subnet create ...\n2 - openstack network segment create ...\n3 - openstack subnet set --segment-network ...\n\nIf we prevent this in that part I\u0027m not sure about what will be the behavior. What do you think?","commit_id":"ba72563dee76a5865d1e4cc70070535634521f25"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"fd3774d37a9d209e1dc601c1dd1d030e334051c1","unresolved":true,"context_lines":[{"line_number":107,"context_line":"            # that they belong to first."},{"line_number":108,"context_line":"            for segment in context.segments_to_bind:"},{"line_number":109,"context_line":"                for subnet in subnets:"},{"line_number":110,"context_line":"                    seg_id \u003d subnet.get(\u0027segment_id\u0027)"},{"line_number":111,"context_line":"                    # If subnet is not attached to any segment, let\u0027s use"},{"line_number":112,"context_line":"                    # default behavior."},{"line_number":113,"context_line":"                    if seg_id is None or seg_id \u003d\u003d segment[api.ID]:"},{"line_number":114,"context_line":"                        allowed_binding_segments.append(segment)"},{"line_number":115,"context_line":"        else:"},{"line_number":116,"context_line":"            allowed_binding_segments \u003d context.segments_to_bind"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"0bfc18db_09e05b8b","line":114,"range":{"start_line":110,"start_character":0,"end_line":114,"end_character":64},"in_reply_to":"e519141d_78cca2c1","updated":"2022-09-05 04:01:20.000000000","message":"Thanks for testing it. Changing my vote","commit_id":"ba72563dee76a5865d1e4cc70070535634521f25"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"4ae5055534ca483db9c93056a703da73c578951a","unresolved":true,"context_lines":[{"line_number":107,"context_line":"            # that they belong to first."},{"line_number":108,"context_line":"            for segment in context.segments_to_bind:"},{"line_number":109,"context_line":"                for subnet in subnets:"},{"line_number":110,"context_line":"                    seg_id \u003d subnet.get(\u0027segment_id\u0027)"},{"line_number":111,"context_line":"                    # If subnet is not attached to any segment, let\u0027s use"},{"line_number":112,"context_line":"                    # default behavior."},{"line_number":113,"context_line":"                    if seg_id is None or seg_id \u003d\u003d segment[api.ID]:"},{"line_number":114,"context_line":"                        allowed_binding_segments.append(segment)"},{"line_number":115,"context_line":"        else:"},{"line_number":116,"context_line":"            allowed_binding_segments \u003d context.segments_to_bind"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"e519141d_78cca2c1","line":114,"range":{"start_line":110,"start_character":0,"end_line":114,"end_character":64},"in_reply_to":"fbe00053_d3affc6b","updated":"2022-09-02 14:29:14.000000000","message":"I tried it and (perhaps I missed something so would be good if somebody else can check if I understand well) but:\n* I have one net, one segment (from https://docs.openstack.org/neutron/latest/admin/config-routed-networks.html )\n* openstack subnet create --network multisegment1  --ip-version 4 --subnet-range 203.0.114.0/24 multisegment1-no-segment\nBadRequestException: 400: Client Error for url: http://100.109.0.113:9696/networking/v2.0/subnets, All of the subnets on network \u00277f8d886f-cd13-450e-b1ca-ad065580c0d9\u0027 must either all be associated with segments or all not associated with any segment.\n\nSo it will not happen, and it is coming from here: https://opendev.org/openstack/neutron/src/branch/master/neutron/db/ipam_backend_mixin.py#L357 (look for SubnetsNotAllAssociatedWithSegments)","commit_id":"ba72563dee76a5865d1e4cc70070535634521f25"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"4ae5055534ca483db9c93056a703da73c578951a","unresolved":true,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        subnets \u003d self.get_subnets_from_fixed_ips(context)"},{"line_number":105,"context_line":"        if subnets:"},{"line_number":106,"context_line":"            # In case that fixed IPs is provided, filter segments per subnet"},{"line_number":107,"context_line":"            # that they belong to first."},{"line_number":108,"context_line":"            for segment in context.segments_to_bind:"},{"line_number":109,"context_line":"                for subnet in subnets:"}],"source_content_type":"text/x-python","patch_set":30,"id":"2ca6d8e5_95cd533f","line":106,"range":{"start_line":106,"start_character":37,"end_line":106,"end_character":39},"updated":"2022-09-02 14:29:14.000000000","message":"nit: are","commit_id":"584f82008d6efa0f7ebf4a324fbdb596cc686466"}]}