)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f4b4fb2aa63f8d20936fe4cab3ef975d589fc6b7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"062717f6_ae799a1b","updated":"2022-05-13 14:33:54.000000000","message":"Interesting bug :)","commit_id":"a3e70d034f0012b57ff28b27548896ae77686487"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4eea7123a7dfedfa1f2e5916e273988790411861","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d2b0f968_f4a2329f","updated":"2022-05-13 12:41:54.000000000","message":"This patch looks promising. I\u0027m re-checking it again just to be sure.","commit_id":"a3e70d034f0012b57ff28b27548896ae77686487"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"7ea5aa3567320732debfb298b6679d4a5a2f5f52","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"849a0bff_c8f538d4","updated":"2022-05-13 14:27:23.000000000","message":"and green again, +2 for this patch","commit_id":"a3e70d034f0012b57ff28b27548896ae77686487"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"80d689d3c72b5dc15b86195a58d8c51e03a408a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5fc06e65_f4f657c8","updated":"2022-05-13 12:41:09.000000000","message":"recheck","commit_id":"a3e70d034f0012b57ff28b27548896ae77686487"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"392c190e367eed826f936af6591bd02e97b8f38e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"de841eae_7a786e5c","updated":"2022-05-13 15:07:26.000000000","message":"Thanks Slawek!","commit_id":"cd8bf18150c8b0a4bc64979d800726483d9cdb6e"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"80c2fc49b1e33b115882c9f2cae083cc68048d98","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9a2e274d_86f17b51","updated":"2022-05-14 06:12:42.000000000","message":"recheck - test test_interface_added_after_initilization failed, I need to investigate this failure but it\u0027s not related to that patch for sure","commit_id":"cd8bf18150c8b0a4bc64979d800726483d9cdb6e"}],"neutron/api/rpc/handlers/l3_rpc.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f4b4fb2aa63f8d20936fe4cab3ef975d589fc6b7","unresolved":true,"context_lines":[{"line_number":221,"context_line":"            # that one of its routers moved to the active state."},{"line_number":222,"context_line":"            else:"},{"line_number":223,"context_line":"                if not port.get(portbindings.HOST_ID):"},{"line_number":224,"context_line":"                    active_host \u003d ("},{"line_number":225,"context_line":"                        self.l3plugin.get_active_host_for_ha_router("},{"line_number":226,"context_line":"                            context, router_id))"},{"line_number":227,"context_line":"                    if not active_host:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aadeddc_0c69cb06","line":224,"range":{"start_line":224,"start_character":20,"end_line":224,"end_character":31},"updated":"2022-05-13 14:33:54.000000000","message":"nit: guess you could have just used \u0027host\u0027 here since there is no re-assignment of it any more below.","commit_id":"a3e70d034f0012b57ff28b27548896ae77686487"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"62ea616aaff6c7bb3b467cd3eb468e5f198cf730","unresolved":false,"context_lines":[{"line_number":221,"context_line":"            # that one of its routers moved to the active state."},{"line_number":222,"context_line":"            else:"},{"line_number":223,"context_line":"                if not port.get(portbindings.HOST_ID):"},{"line_number":224,"context_line":"                    active_host \u003d ("},{"line_number":225,"context_line":"                        self.l3plugin.get_active_host_for_ha_router("},{"line_number":226,"context_line":"                            context, router_id))"},{"line_number":227,"context_line":"                    if not active_host:"}],"source_content_type":"text/x-python","patch_set":2,"id":"dd77be5e_95b23ecf","line":224,"range":{"start_line":224,"start_character":20,"end_line":224,"end_character":31},"in_reply_to":"34177bb9_a4381688","updated":"2022-05-13 15:02:41.000000000","message":"Ack","commit_id":"a3e70d034f0012b57ff28b27548896ae77686487"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"be635bf23b7a911e742cdb6f06d31467f686fece","unresolved":true,"context_lines":[{"line_number":221,"context_line":"            # that one of its routers moved to the active state."},{"line_number":222,"context_line":"            else:"},{"line_number":223,"context_line":"                if not port.get(portbindings.HOST_ID):"},{"line_number":224,"context_line":"                    active_host \u003d ("},{"line_number":225,"context_line":"                        self.l3plugin.get_active_host_for_ha_router("},{"line_number":226,"context_line":"                            context, router_id))"},{"line_number":227,"context_line":"                    if not active_host:"}],"source_content_type":"text/x-python","patch_set":2,"id":"34177bb9_a4381688","line":224,"range":{"start_line":224,"start_character":20,"end_line":224,"end_character":31},"in_reply_to":"9aadeddc_0c69cb06","updated":"2022-05-13 14:45:43.000000000","message":"I would prefer to name it active_host to make it clear what host it should be","commit_id":"a3e70d034f0012b57ff28b27548896ae77686487"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f4b4fb2aa63f8d20936fe4cab3ef975d589fc6b7","unresolved":true,"context_lines":[{"line_number":227,"context_line":"                    if not active_host:"},{"line_number":228,"context_line":"                        LOG.debug(\"Router %s is not active an any host. \""},{"line_number":229,"context_line":"                                  \"Port %s will not be updated now.\","},{"line_number":230,"context_line":"                                  router_id, port[\u0027id\u0027])"},{"line_number":231,"context_line":"                        return"},{"line_number":232,"context_line":"                    # If there is currently no active router instance (For"},{"line_number":233,"context_line":"                    # example it\u0027s a new router), the host that requested"}],"source_content_type":"text/x-python","patch_set":2,"id":"894e84b6_858c52fc","line":230,"updated":"2022-05-13 14:33:54.000000000","message":"super nit: other LOGs here used dicts.","commit_id":"a3e70d034f0012b57ff28b27548896ae77686487"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"be635bf23b7a911e742cdb6f06d31467f686fece","unresolved":false,"context_lines":[{"line_number":227,"context_line":"                    if not active_host:"},{"line_number":228,"context_line":"                        LOG.debug(\"Router %s is not active an any host. \""},{"line_number":229,"context_line":"                                  \"Port %s will not be updated now.\","},{"line_number":230,"context_line":"                                  router_id, port[\u0027id\u0027])"},{"line_number":231,"context_line":"                        return"},{"line_number":232,"context_line":"                    # If there is currently no active router instance (For"},{"line_number":233,"context_line":"                    # example it\u0027s a new router), the host that requested"}],"source_content_type":"text/x-python","patch_set":2,"id":"01d941af_9b14505c","line":230,"in_reply_to":"894e84b6_858c52fc","updated":"2022-05-13 14:45:43.000000000","message":"Done","commit_id":"a3e70d034f0012b57ff28b27548896ae77686487"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f4b4fb2aa63f8d20936fe4cab3ef975d589fc6b7","unresolved":true,"context_lines":[{"line_number":233,"context_line":"                    # example it\u0027s a new router), the host that requested"},{"line_number":234,"context_line":"                    # the routers (Essentially a random host) will do. The"},{"line_number":235,"context_line":"                    # port binding will be corrected when an active is"},{"line_number":236,"context_line":"                    # elected."},{"line_number":237,"context_line":"                    try:"},{"line_number":238,"context_line":"                        LOG.debug(\"Updating router %(router)s port %(port)s \""},{"line_number":239,"context_line":"                                  \"binding host %(host)s\","}],"source_content_type":"text/x-python","patch_set":2,"id":"5d962e85_bbcdc455","line":236,"updated":"2022-05-13 14:33:54.000000000","message":"Does this comment still apply? We won\u0027t update using passed \u0027host\u0027 value if there is no active host any more.","commit_id":"a3e70d034f0012b57ff28b27548896ae77686487"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"be635bf23b7a911e742cdb6f06d31467f686fece","unresolved":true,"context_lines":[{"line_number":233,"context_line":"                    # example it\u0027s a new router), the host that requested"},{"line_number":234,"context_line":"                    # the routers (Essentially a random host) will do. The"},{"line_number":235,"context_line":"                    # port binding will be corrected when an active is"},{"line_number":236,"context_line":"                    # elected."},{"line_number":237,"context_line":"                    try:"},{"line_number":238,"context_line":"                        LOG.debug(\"Updating router %(router)s port %(port)s \""},{"line_number":239,"context_line":"                                  \"binding host %(host)s\","}],"source_content_type":"text/x-python","patch_set":2,"id":"d5bb376f_0c72f014","line":236,"in_reply_to":"5d962e85_bbcdc455","updated":"2022-05-13 14:45:43.000000000","message":"No, removed. Thx, good catch","commit_id":"a3e70d034f0012b57ff28b27548896ae77686487"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"62ea616aaff6c7bb3b467cd3eb468e5f198cf730","unresolved":true,"context_lines":[{"line_number":225,"context_line":"                        self.l3plugin.get_active_host_for_ha_router("},{"line_number":226,"context_line":"                            context, router_id))"},{"line_number":227,"context_line":"                    if not active_host:"},{"line_number":228,"context_line":"                        LOG.debug(\"Router %(router)s is not active an any \""},{"line_number":229,"context_line":"                                  \"host. Port %(port)s will not be updated \""},{"line_number":230,"context_line":"                                  \"now.\","},{"line_number":231,"context_line":"                                  {\u0027router\u0027: router_id, \u0027port\u0027: port[\u0027id\u0027]})"}],"source_content_type":"text/x-python","patch_set":3,"id":"d74c873e_274462b7","line":228,"range":{"start_line":228,"start_character":67,"end_line":228,"end_character":69},"updated":"2022-05-13 15:02:41.000000000","message":"s/on","commit_id":"6e5868e465e91826d3cd8aa9128f5e381c6bcf07"}]}