)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"e913c8fd0290344cfcc26da267694668caa15266","unresolved":true,"context_lines":[{"line_number":7,"context_line":"ovn-migration: Remove second tripleo-update call"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The second tripleo-update call was there only to update hiera data on"},{"line_number":10,"context_line":"the nodes. However the action did the whole deploy for all nodes in the"},{"line_number":11,"context_line":"environment, which can take hours to finish. This patch fetches"},{"line_number":12,"context_line":"currently configured integration bridge on the nodes and later updates"},{"line_number":13,"context_line":"just the hieara data."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"90b7e1cd_b8ba416a","line":11,"range":{"start_line":10,"start_character":11,"end_line":11,"end_character":44},"updated":"2022-06-15 10:56:48.000000000","message":"for this case if second run is done with --update-plan-only then that shouldn\u0027t take much time. For 16.2 that should work, but need to check for wallaby+ as that option is deprecated.","commit_id":"15c65afb7489d0c38ede68aa6fa8fd0d2f6f7493"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"5f567e13499fbc8f701a70f9730fd39184a0420a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"ovn-migration: Remove second tripleo-update call"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The second tripleo-update call was there only to update hiera data on"},{"line_number":10,"context_line":"the nodes. However the action did the whole deploy for all nodes in the"},{"line_number":11,"context_line":"environment, which can take hours to finish. This patch fetches"},{"line_number":12,"context_line":"currently configured integration bridge on the nodes and later updates"},{"line_number":13,"context_line":"just the hieara data."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fc09c521_6bcf0540","line":11,"range":{"start_line":10,"start_character":11,"end_line":11,"end_character":44},"in_reply_to":"90b7e1cd_b8ba416a","updated":"2022-06-23 19:20:45.000000000","message":"Done","commit_id":"15c65afb7489d0c38ede68aa6fa8fd0d2f6f7493"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"126f7692dba7575cc74e1ae568a8a7dd757995ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1bf4461a_1e4a2f69","updated":"2022-06-02 00:52:58.000000000","message":"Tested on my dev environment and works as expected\nrecheck","commit_id":"15c65afb7489d0c38ede68aa6fa8fd0d2f6f7493"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"5c4e139356a6640f12f9297e9053182bb5cbc0c8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"206241d8_26f43f74","updated":"2022-06-14 18:57:38.000000000","message":"Thanks Yatin for your review, please see my question.","commit_id":"15c65afb7489d0c38ede68aa6fa8fd0d2f6f7493"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"4cd9074f1b4dbfe44848fb0a27b8e6cb22766718","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"53931cda_3a64ccd7","updated":"2022-06-13 20:37:45.000000000","message":"recheck","commit_id":"15c65afb7489d0c38ede68aa6fa8fd0d2f6f7493"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"66867115ce312893ac95a1a2e72bbe987d2a0953","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8cac9b67_a870d3c7","updated":"2022-06-24 05:28:44.000000000","message":"Thanks @Jakub, @Rabi looks much better now including it in THT.","commit_id":"60fade43de9555aab110d898ca27684bcaa975be"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"5cca2eeb2d0ef2200cd952ef2bd3830f06c92c41","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f0af0f55_e6f8d19e","updated":"2022-06-28 10:28:57.000000000","message":"recheck tht patch merged","commit_id":"60fade43de9555aab110d898ca27684bcaa975be"}],"tools/ovn_migration/tripleo_environment/playbooks/ovn-migration.yml":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"0d5a1ce459460e94c57178e6bb85127fd6a6a42a","unresolved":true,"context_lines":[{"line_number":65,"context_line":"  tags:"},{"line_number":66,"context_line":"    - migration"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"#"},{"line_number":69,"context_line":"# Step to make sure tripleo knows about OVNIntegrationBridge \u003d\u003d br-int."},{"line_number":70,"context_line":"#"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"- name: Update hieradata with original integration bridge"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"77fa4e95_a926e5d7","line":69,"range":{"start_line":68,"start_character":1,"end_line":69,"end_character":71},"updated":"2022-06-14 08:01:40.000000000","message":"the comment doesn\u0027t match with the below task as OVNIntegrationBridge depending on {{ ovs_integration_bridge.stdout }}","commit_id":"15c65afb7489d0c38ede68aa6fa8fd0d2f6f7493"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"5f567e13499fbc8f701a70f9730fd39184a0420a","unresolved":false,"context_lines":[{"line_number":65,"context_line":"  tags:"},{"line_number":66,"context_line":"    - migration"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"#"},{"line_number":69,"context_line":"# Step to make sure tripleo knows about OVNIntegrationBridge \u003d\u003d br-int."},{"line_number":70,"context_line":"#"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"- name: Update hieradata with original integration bridge"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"a30349a9_b2f3f072","line":69,"range":{"start_line":68,"start_character":1,"end_line":69,"end_character":71},"in_reply_to":"77fa4e95_a926e5d7","updated":"2022-06-23 19:20:45.000000000","message":"Done","commit_id":"15c65afb7489d0c38ede68aa6fa8fd0d2f6f7493"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"0d5a1ce459460e94c57178e6bb85127fd6a6a42a","unresolved":true,"context_lines":[{"line_number":69,"context_line":"# Step to make sure tripleo knows about OVNIntegrationBridge \u003d\u003d br-int."},{"line_number":70,"context_line":"#"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"- name: Update hieradata with original integration bridge"},{"line_number":73,"context_line":"  hosts: ovn-controllers"},{"line_number":74,"context_line":"  tasks:"},{"line_number":75,"context_line":"    - name: \"write {{ ovs_integration_bridge.stdout }} to hiera data\""},{"line_number":76,"context_line":"      lineinfile:"},{"line_number":77,"context_line":"        path: /etc/puppet/hieradata/service_configs.json"},{"line_number":78,"context_line":"        regexp: \u0027\"ovn::controller::ovn_bridge\":\u0027"},{"line_number":79,"context_line":"        line: \u0027    \"ovn::controller::ovn_bridge\": \"{{ ovs_integration_bridge.stdout }}\",\u0027"},{"line_number":80,"context_line":"  tags:"},{"line_number":81,"context_line":"    - setup"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3a10049a_91699cd8","line":79,"range":{"start_line":72,"start_character":0,"end_line":79,"end_character":89},"updated":"2022-06-14 08:01:40.000000000","message":"doesn\u0027t look good directly writing to hieradata as it will not persist with next overcloud deploy/update if OVNIntegrationBridge !\u003d \"{{ ovs_integration_bridge.stdout }}\"\nIt will get reset in next overcloud deploy/update to \"br-migration\" or i am missing something?","commit_id":"15c65afb7489d0c38ede68aa6fa8fd0d2f6f7493"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"3186c65f6a9288e88d7c5ef6b5035eafa7d2e380","unresolved":true,"context_lines":[{"line_number":69,"context_line":"# Step to make sure tripleo knows about OVNIntegrationBridge \u003d\u003d br-int."},{"line_number":70,"context_line":"#"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"- name: Update hieradata with original integration bridge"},{"line_number":73,"context_line":"  hosts: ovn-controllers"},{"line_number":74,"context_line":"  tasks:"},{"line_number":75,"context_line":"    - name: \"write {{ ovs_integration_bridge.stdout }} to hiera data\""},{"line_number":76,"context_line":"      lineinfile:"},{"line_number":77,"context_line":"        path: /etc/puppet/hieradata/service_configs.json"},{"line_number":78,"context_line":"        regexp: \u0027\"ovn::controller::ovn_bridge\":\u0027"},{"line_number":79,"context_line":"        line: \u0027    \"ovn::controller::ovn_bridge\": \"{{ ovs_integration_bridge.stdout }}\",\u0027"},{"line_number":80,"context_line":"  tags:"},{"line_number":81,"context_line":"    - setup"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"70969b7d_03439826","line":79,"range":{"start_line":72,"start_character":0,"end_line":79,"end_character":89},"in_reply_to":"07772f97_e1c04e9b","updated":"2022-06-16 12:07:25.000000000","message":"@jakub confirmed both the points with ramishra:-\n\u003cykarel\u003e ramishra, releases where ephemeral heat is not used, if during initial deployment if we pass a parameter_defaults: x\u003dy(which mainly used to set hieradata on nodes)\n\u003cykarel\u003e what happens if we miss the passing that parameter in next overcloud deploy/update?\n\u003cykarel\u003e it takes the default from templates or what was passed in previous run (as it get\u0027s stored in plan)\n\u003cykarel\u003e more context in https://review.opendev.org/c/openstack/neutron/+/841801\n\n\u003cramishra\u003e ykarel: we use PATCH update of heat stack, so the parameter would persist unless provided in the next update\n\u003cykarel\u003e ramishra, Thanks, and now in recent release where swift is not there, how it happens now?\n\u003cramishra\u003e ykarel: parameters are in heat stack environments, PATCH update merges them, with ephemeral heat it won\u0027t be the case, the default for the parameter would be used","commit_id":"15c65afb7489d0c38ede68aa6fa8fd0d2f6f7493"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"742f37a821eba0a92e5434021daa10418d8f52f8","unresolved":true,"context_lines":[{"line_number":69,"context_line":"# Step to make sure tripleo knows about OVNIntegrationBridge \u003d\u003d br-int."},{"line_number":70,"context_line":"#"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"- name: Update hieradata with original integration bridge"},{"line_number":73,"context_line":"  hosts: ovn-controllers"},{"line_number":74,"context_line":"  tasks:"},{"line_number":75,"context_line":"    - name: \"write {{ ovs_integration_bridge.stdout }} to hiera data\""},{"line_number":76,"context_line":"      lineinfile:"},{"line_number":77,"context_line":"        path: /etc/puppet/hieradata/service_configs.json"},{"line_number":78,"context_line":"        regexp: \u0027\"ovn::controller::ovn_bridge\":\u0027"},{"line_number":79,"context_line":"        line: \u0027    \"ovn::controller::ovn_bridge\": \"{{ ovs_integration_bridge.stdout }}\",\u0027"},{"line_number":80,"context_line":"  tags:"},{"line_number":81,"context_line":"    - setup"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"99abf74a_93e3d2c3","line":79,"range":{"start_line":72,"start_character":0,"end_line":79,"end_character":89},"in_reply_to":"0d9895a5_d5fefcb8","updated":"2022-06-22 15:26:45.000000000","message":"Thanks Yatin. Does it mean we\u0027re good here?","commit_id":"15c65afb7489d0c38ede68aa6fa8fd0d2f6f7493"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"5c4e139356a6640f12f9297e9053182bb5cbc0c8","unresolved":true,"context_lines":[{"line_number":69,"context_line":"# Step to make sure tripleo knows about OVNIntegrationBridge \u003d\u003d br-int."},{"line_number":70,"context_line":"#"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"- name: Update hieradata with original integration bridge"},{"line_number":73,"context_line":"  hosts: ovn-controllers"},{"line_number":74,"context_line":"  tasks:"},{"line_number":75,"context_line":"    - name: \"write {{ ovs_integration_bridge.stdout }} to hiera data\""},{"line_number":76,"context_line":"      lineinfile:"},{"line_number":77,"context_line":"        path: /etc/puppet/hieradata/service_configs.json"},{"line_number":78,"context_line":"        regexp: \u0027\"ovn::controller::ovn_bridge\":\u0027"},{"line_number":79,"context_line":"        line: \u0027    \"ovn::controller::ovn_bridge\": \"{{ ovs_integration_bridge.stdout }}\",\u0027"},{"line_number":80,"context_line":"  tags:"},{"line_number":81,"context_line":"    - setup"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"a75b8014_11dce42b","line":79,"range":{"start_line":72,"start_character":0,"end_line":79,"end_character":89},"in_reply_to":"3a10049a_91699cd8","updated":"2022-06-14 18:57:38.000000000","message":"Maybe it\u0027s just lack of my knowledge of TripleO. The purpose of this patch is to avoid exactly that. That means, if we run \u0027overcloud deploy\u0027 with customized OVNIntegrationBridge and then in the next update we don\u0027t define OVNIntegrationBridge and leave it unset, where it will take the br-migration from? When I asked around, I understood it will use whatever is currently set in the hieradata, therefore this patch.","commit_id":"15c65afb7489d0c38ede68aa6fa8fd0d2f6f7493"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"fa1a386ff4bfb9f05d8ac5f667ac455078bce598","unresolved":true,"context_lines":[{"line_number":69,"context_line":"# Step to make sure tripleo knows about OVNIntegrationBridge \u003d\u003d br-int."},{"line_number":70,"context_line":"#"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"- name: Update hieradata with original integration bridge"},{"line_number":73,"context_line":"  hosts: ovn-controllers"},{"line_number":74,"context_line":"  tasks:"},{"line_number":75,"context_line":"    - name: \"write {{ ovs_integration_bridge.stdout }} to hiera data\""},{"line_number":76,"context_line":"      lineinfile:"},{"line_number":77,"context_line":"        path: /etc/puppet/hieradata/service_configs.json"},{"line_number":78,"context_line":"        regexp: \u0027\"ovn::controller::ovn_bridge\":\u0027"},{"line_number":79,"context_line":"        line: \u0027    \"ovn::controller::ovn_bridge\": \"{{ ovs_integration_bridge.stdout }}\",\u0027"},{"line_number":80,"context_line":"  tags:"},{"line_number":81,"context_line":"    - setup"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"0d9895a5_d5fefcb8","line":79,"range":{"start_line":72,"start_character":0,"end_line":79,"end_character":89},"in_reply_to":"42c46c0e_ab80f207","updated":"2022-06-22 15:21:25.000000000","message":"@jakub It doesn\u0027t matter if ovn-extras is used during upgrade/update, as overcloud plan already contains OVNIntegrationBridge from ovn-extras during the migration, it will get used for further update/upgrades unless it get\u0027s reset, before this patch it used to be reset by second tripleo-update call. This only applies to releases before wallaby, with wallaby+ there is no plan, so whatever explicitly pass will be used","commit_id":"15c65afb7489d0c38ede68aa6fa8fd0d2f6f7493"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"bcf4e471a6f22e6da6cf85b2a201c5d109697322","unresolved":true,"context_lines":[{"line_number":69,"context_line":"# Step to make sure tripleo knows about OVNIntegrationBridge \u003d\u003d br-int."},{"line_number":70,"context_line":"#"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"- name: Update hieradata with original integration bridge"},{"line_number":73,"context_line":"  hosts: ovn-controllers"},{"line_number":74,"context_line":"  tasks:"},{"line_number":75,"context_line":"    - name: \"write {{ ovs_integration_bridge.stdout }} to hiera data\""},{"line_number":76,"context_line":"      lineinfile:"},{"line_number":77,"context_line":"        path: /etc/puppet/hieradata/service_configs.json"},{"line_number":78,"context_line":"        regexp: \u0027\"ovn::controller::ovn_bridge\":\u0027"},{"line_number":79,"context_line":"        line: \u0027    \"ovn::controller::ovn_bridge\": \"{{ ovs_integration_bridge.stdout }}\",\u0027"},{"line_number":80,"context_line":"  tags:"},{"line_number":81,"context_line":"    - setup"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"8d85417a_e428f342","line":79,"range":{"start_line":72,"start_character":0,"end_line":79,"end_character":89},"in_reply_to":"650378db_965d2303","updated":"2022-06-23 14:51:59.000000000","message":"Forgot to mention you don\u0027t need any plan, stack, heiradata update. That environment is always used and it would override what\u0027s there in plan/stack in next update (unless user environment has it).","commit_id":"15c65afb7489d0c38ede68aa6fa8fd0d2f6f7493"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"f48ac318a9f9d19dc15c1b6a518ade69a5788b6c","unresolved":true,"context_lines":[{"line_number":69,"context_line":"# Step to make sure tripleo knows about OVNIntegrationBridge \u003d\u003d br-int."},{"line_number":70,"context_line":"#"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"- name: Update hieradata with original integration bridge"},{"line_number":73,"context_line":"  hosts: ovn-controllers"},{"line_number":74,"context_line":"  tasks:"},{"line_number":75,"context_line":"    - name: \"write {{ ovs_integration_bridge.stdout }} to hiera data\""},{"line_number":76,"context_line":"      lineinfile:"},{"line_number":77,"context_line":"        path: /etc/puppet/hieradata/service_configs.json"},{"line_number":78,"context_line":"        regexp: \u0027\"ovn::controller::ovn_bridge\":\u0027"},{"line_number":79,"context_line":"        line: \u0027    \"ovn::controller::ovn_bridge\": \"{{ ovs_integration_bridge.stdout }}\",\u0027"},{"line_number":80,"context_line":"  tags:"},{"line_number":81,"context_line":"    - setup"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"42c46c0e_ab80f207","line":79,"range":{"start_line":72,"start_character":0,"end_line":79,"end_character":89},"in_reply_to":"70969b7d_03439826","updated":"2022-06-22 14:38:23.000000000","message":"I\u0027m not sure I understand. Just note that ovn-extras is only used for the migration. The deploy command during upgrade/update must not use the ovn-extras, therefore OVNIntegrationBridge won\u0027t be set anywhere explicitly.","commit_id":"15c65afb7489d0c38ede68aa6fa8fd0d2f6f7493"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"d53ab0113fc6b9b2ec45513b8eb50886701d9746","unresolved":true,"context_lines":[{"line_number":69,"context_line":"# Step to make sure tripleo knows about OVNIntegrationBridge \u003d\u003d br-int."},{"line_number":70,"context_line":"#"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"- name: Update hieradata with original integration bridge"},{"line_number":73,"context_line":"  hosts: ovn-controllers"},{"line_number":74,"context_line":"  tasks:"},{"line_number":75,"context_line":"    - name: \"write {{ ovs_integration_bridge.stdout }} to hiera data\""},{"line_number":76,"context_line":"      lineinfile:"},{"line_number":77,"context_line":"        path: /etc/puppet/hieradata/service_configs.json"},{"line_number":78,"context_line":"        regexp: \u0027\"ovn::controller::ovn_bridge\":\u0027"},{"line_number":79,"context_line":"        line: \u0027    \"ovn::controller::ovn_bridge\": \"{{ ovs_integration_bridge.stdout }}\",\u0027"},{"line_number":80,"context_line":"  tags:"},{"line_number":81,"context_line":"    - setup"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"d04a493b_4deb6e4b","line":79,"range":{"start_line":72,"start_character":0,"end_line":79,"end_character":89},"in_reply_to":"8d85417a_e428f342","updated":"2022-06-23 18:27:21.000000000","message":"Thanks Rabi, I think that\u0027s the best and fastest solution. I\u0027ll send patches and request backporst.","commit_id":"15c65afb7489d0c38ede68aa6fa8fd0d2f6f7493"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"eb3e5d564c82e4f00c302d5eb275ad8d510e4244","unresolved":true,"context_lines":[{"line_number":69,"context_line":"# Step to make sure tripleo knows about OVNIntegrationBridge \u003d\u003d br-int."},{"line_number":70,"context_line":"#"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"- name: Update hieradata with original integration bridge"},{"line_number":73,"context_line":"  hosts: ovn-controllers"},{"line_number":74,"context_line":"  tasks:"},{"line_number":75,"context_line":"    - name: \"write {{ ovs_integration_bridge.stdout }} to hiera data\""},{"line_number":76,"context_line":"      lineinfile:"},{"line_number":77,"context_line":"        path: /etc/puppet/hieradata/service_configs.json"},{"line_number":78,"context_line":"        regexp: \u0027\"ovn::controller::ovn_bridge\":\u0027"},{"line_number":79,"context_line":"        line: \u0027    \"ovn::controller::ovn_bridge\": \"{{ ovs_integration_bridge.stdout }}\",\u0027"},{"line_number":80,"context_line":"  tags:"},{"line_number":81,"context_line":"    - setup"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"650378db_965d2303","line":79,"range":{"start_line":72,"start_character":0,"end_line":79,"end_character":89},"in_reply_to":"99abf74a_93e3d2c3","updated":"2022-06-23 14:46:11.000000000","message":"If you want br-int (or whatever the user provides) and not br-migration to be used in the next update (after migration), we can set the default \u0027br-int\u0027 in https://github.com/openstack/tripleo-heat-templates/blob/stable/train/overcloud-resource-registry-puppet.j2.yaml#L377. That would be used in every deploy unless overridden with -e ovn-extras.yaml and we don\u0027t need any hack here.\n\nThis will work for OSP17 too.\n\nOVNIntegrationBridge: br-int","commit_id":"15c65afb7489d0c38ede68aa6fa8fd0d2f6f7493"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"e913c8fd0290344cfcc26da267694668caa15266","unresolved":true,"context_lines":[{"line_number":69,"context_line":"# Step to make sure tripleo knows about OVNIntegrationBridge \u003d\u003d br-int."},{"line_number":70,"context_line":"#"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"- name: Update hieradata with original integration bridge"},{"line_number":73,"context_line":"  hosts: ovn-controllers"},{"line_number":74,"context_line":"  tasks:"},{"line_number":75,"context_line":"    - name: \"write {{ ovs_integration_bridge.stdout }} to hiera data\""},{"line_number":76,"context_line":"      lineinfile:"},{"line_number":77,"context_line":"        path: /etc/puppet/hieradata/service_configs.json"},{"line_number":78,"context_line":"        regexp: \u0027\"ovn::controller::ovn_bridge\":\u0027"},{"line_number":79,"context_line":"        line: \u0027    \"ovn::controller::ovn_bridge\": \"{{ ovs_integration_bridge.stdout }}\",\u0027"},{"line_number":80,"context_line":"  tags:"},{"line_number":81,"context_line":"    - setup"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"07772f97_e1c04e9b","line":79,"range":{"start_line":72,"start_character":0,"end_line":79,"end_character":89},"in_reply_to":"a75b8014_11dce42b","updated":"2022-06-15 10:56:48.000000000","message":"@jakub you are right wrt hieradata is used, but hieradata get\u0027s generated during deploy/update and for this case it will be based on value of parameter \"OVNIntegrationBridge\". Since it was set to br-migration in previous step, the plan have that value so even if you drop \"-e ovn-extras.yaml\" from overcloud-deploy command the values are used from what\u0027s in the plan, and to fix it either update the plan with the expected value or pass -e ovn-extras.yaml with correct params(br-int) in overcloud deploy command.\n\nThis is my understanding but i will confirm with guys have more understanding, also now i have doubt on how it will work where swift/heat are removed from undercloud i.e with ephemeral heat based deployments(may be it will just work as it relies on whatever passed to deploy command, as no plan now), so will check that too with TripleO guys.","commit_id":"15c65afb7489d0c38ede68aa6fa8fd0d2f6f7493"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"5f567e13499fbc8f701a70f9730fd39184a0420a","unresolved":false,"context_lines":[{"line_number":69,"context_line":"# Step to make sure tripleo knows about OVNIntegrationBridge \u003d\u003d br-int."},{"line_number":70,"context_line":"#"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"- name: Update hieradata with original integration bridge"},{"line_number":73,"context_line":"  hosts: ovn-controllers"},{"line_number":74,"context_line":"  tasks:"},{"line_number":75,"context_line":"    - name: \"write {{ ovs_integration_bridge.stdout }} to hiera data\""},{"line_number":76,"context_line":"      lineinfile:"},{"line_number":77,"context_line":"        path: /etc/puppet/hieradata/service_configs.json"},{"line_number":78,"context_line":"        regexp: \u0027\"ovn::controller::ovn_bridge\":\u0027"},{"line_number":79,"context_line":"        line: \u0027    \"ovn::controller::ovn_bridge\": \"{{ ovs_integration_bridge.stdout }}\",\u0027"},{"line_number":80,"context_line":"  tags:"},{"line_number":81,"context_line":"    - setup"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"2f12fbd2_144abbcb","line":79,"range":{"start_line":72,"start_character":0,"end_line":79,"end_character":89},"in_reply_to":"d04a493b_4deb6e4b","updated":"2022-06-23 19:20:45.000000000","message":"Done","commit_id":"15c65afb7489d0c38ede68aa6fa8fd0d2f6f7493"}]}