)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"52c8b3d8633e2ce982d31e4e097c1910f1af30a5","unresolved":true,"context_lines":[{"line_number":15,"context_line":"it is a regular router or HA. The benefits are"},{"line_number":16,"context_line":"we do not need to loop over every router available in"},{"line_number":17,"context_line":"environment. Another reason for doing this is that"},{"line_number":18,"context_line":"IMO get_router_agents_count is used solely to heal"},{"line_number":19,"context_line":"routers with less than required agents so number of"},{"line_number":20,"context_line":"routers with less agents is small for most of the times."},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"b94d69b7_81612bfd","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":4},"updated":"2022-06-08 11:54:18.000000000","message":"We can\u0027t use this in a commit. We must be sure.\n\nThis method is used only in the scheduler: https://codesearch.openstack.org/?q\u003dget_router_agents_count\u0026i\u003dnope\u0026literal\u003dnope\u0026files\u003d\u0026excludeFiles\u003d\u0026repos\u003d","commit_id":"2967914ec5e517b914198340eabdc2b47d9b030c"},{"author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"change_message_id":"2d6bb4f73c75eb938831b896294c543933703008","unresolved":false,"context_lines":[{"line_number":15,"context_line":"it is a regular router or HA. The benefits are"},{"line_number":16,"context_line":"we do not need to loop over every router available in"},{"line_number":17,"context_line":"environment. Another reason for doing this is that"},{"line_number":18,"context_line":"IMO get_router_agents_count is used solely to heal"},{"line_number":19,"context_line":"routers with less than required agents so number of"},{"line_number":20,"context_line":"routers with less agents is small for most of the times."},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5e22bc1b_37befd43","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":4},"in_reply_to":"b94d69b7_81612bfd","updated":"2023-02-17 01:22:39.000000000","message":"Done","commit_id":"2967914ec5e517b914198340eabdc2b47d9b030c"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"830a79d8e8fedd080bbeee0610c9ec00e2e865ca","unresolved":true,"context_lines":[{"line_number":19,"context_line":"routers with less than required agents so number of"},{"line_number":20,"context_line":"routers with less agents is small for most of the times."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Related-Bug: #1973656"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: Ic29275815a8c32cee7a6470509687a18fa594514"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9fb17a94_312ef38f","line":22,"range":{"start_line":22,"start_character":13,"end_line":22,"end_character":21},"updated":"2022-06-20 12:32:56.000000000","message":"The bug speaks about \"meaning of option router_auto_schedule is ambiguous\", is this really related?","commit_id":"2967914ec5e517b914198340eabdc2b47d9b030c"},{"author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"change_message_id":"2d6bb4f73c75eb938831b896294c543933703008","unresolved":true,"context_lines":[{"line_number":19,"context_line":"routers with less than required agents so number of"},{"line_number":20,"context_line":"routers with less agents is small for most of the times."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Related-Bug: #1973656"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: Ic29275815a8c32cee7a6470509687a18fa594514"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"e53bb690_cb8ee904","line":22,"range":{"start_line":22,"start_character":13,"end_line":22,"end_character":21},"in_reply_to":"9fb17a94_312ef38f","updated":"2023-02-17 01:22:39.000000000","message":"maybe not so obvious. but if user does not change this setting and got many l3 agents, then users could be affected during agents reboots.","commit_id":"2967914ec5e517b914198340eabdc2b47d9b030c"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"78869dc40130b281b62fd644160048189d4277e6","unresolved":true,"context_lines":[{"line_number":19,"context_line":"routers with less than required agents so number of"},{"line_number":20,"context_line":"routers with less agents is small for most of the times."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Related-Bug: #1973656"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: Ic29275815a8c32cee7a6470509687a18fa594514"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"8d69a4c0_c3a48d5c","line":22,"range":{"start_line":22,"start_character":13,"end_line":22,"end_character":21},"in_reply_to":"e53bb690_cb8ee904","updated":"2023-03-17 16:02:29.000000000","message":"ack","commit_id":"2967914ec5e517b914198340eabdc2b47d9b030c"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"73672d02b8688aa82e996b13c64808b39475ebf3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f647a040_ecc090ee","updated":"2022-12-07 16:04:16.000000000","message":"Hi Norman, will you push a new patch?","commit_id":"2967914ec5e517b914198340eabdc2b47d9b030c"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"830a79d8e8fedd080bbeee0610c9ec00e2e865ca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"de57e4f9_42f35674","updated":"2022-06-20 12:32:56.000000000","message":"Please consider Rodolfo\u0027s comment also","commit_id":"2967914ec5e517b914198340eabdc2b47d9b030c"},{"author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"change_message_id":"4a14217f74c90686f4392f1bbe4d513c6c22d6f3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7bade2bd_ad2179f8","in_reply_to":"f647a040_ecc090ee","updated":"2022-12-08 00:03:05.000000000","message":"Ah sorry, I fogot this PS.. Let me implement some unit tests..","commit_id":"2967914ec5e517b914198340eabdc2b47d9b030c"},{"author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"change_message_id":"f2e7c9bd0fcca5f93d88a026ec9bb8e51a8a7a5b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"6fd7ea86_df3b88d1","updated":"2023-03-13 03:21:40.000000000","message":"ping","commit_id":"3a4bcc1e68a597cec4bd795ca55eaff4f44a9419"},{"author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"change_message_id":"bef84ec4ee971af03fbb394231072fe7920cd47a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"8bed5dad_54960da8","updated":"2023-03-28 09:57:21.000000000","message":"recheck","commit_id":"3a4bcc1e68a597cec4bd795ca55eaff4f44a9419"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"5360b3fbdaa0dbd878aa274c835e1eca7eadcdfb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"96d127c4_91ec3d49","updated":"2023-03-27 09:58:53.000000000","message":"recheck fullstack","commit_id":"3a4bcc1e68a597cec4bd795ca55eaff4f44a9419"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5fab58b01c47a1fb738f687c12cd8d0e4fbc4500","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"311dfa9f_a4505b5b","updated":"2023-03-28 13:54:25.000000000","message":"recheck unrelated functional failure","commit_id":"3a4bcc1e68a597cec4bd795ca55eaff4f44a9419"},{"author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"change_message_id":"accfe9723020e8d3d0a3ab19d64d7da94ac2bfb5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"29536881_863b8f7a","updated":"2023-04-01 00:05:00.000000000","message":"recheck","commit_id":"d4654e3011d22b6d789215fcaa1f15f2d7b9a99a"},{"author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"change_message_id":"e23134411a75d18046fdf4a9398bbef06bb3871b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"85b4df18_da136de1","updated":"2023-04-12 01:29:51.000000000","message":"recheck","commit_id":"d4654e3011d22b6d789215fcaa1f15f2d7b9a99a"},{"author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"change_message_id":"b474548594e8b1231b74fe25ad10ef8414085c28","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"ccb6c1e9_27fe2642","updated":"2023-04-03 22:03:12.000000000","message":"recheck","commit_id":"d4654e3011d22b6d789215fcaa1f15f2d7b9a99a"},{"author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"change_message_id":"421ad96837b230a7e08823b9fa907fd8cf0edbda","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"456a09c9_4b8dca3d","updated":"2023-03-31 14:24:29.000000000","message":"recheck\n","commit_id":"d4654e3011d22b6d789215fcaa1f15f2d7b9a99a"}],"neutron/objects/router.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"52c8b3d8633e2ce982d31e4e097c1910f1af30a5","unresolved":true,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    @classmethod"},{"line_number":112,"context_line":"    @db_api.CONTEXT_READER"},{"line_number":113,"context_line":"    def get_router_agents_count(cls, context, ha\u003dFalse, less_than\u003d0):"},{"line_number":114,"context_line":"        # TODO(sshank): This is pulled out from l3_agentschedulers_db.py"},{"line_number":115,"context_line":"        # until a way to handle joins is figured out."},{"line_number":116,"context_line":"        binding_model \u003d rb_model.RouterL3AgentBinding"}],"source_content_type":"text/x-python","patch_set":4,"id":"9c501984_3e409905","line":113,"range":{"start_line":113,"start_character":8,"end_line":113,"end_character":31},"updated":"2022-06-08 11:54:18.000000000","message":"Please, implement a UT testing this method. This query is complex enough to deserve at least one test.","commit_id":"2967914ec5e517b914198340eabdc2b47d9b030c"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"830a79d8e8fedd080bbeee0610c9ec00e2e865ca","unresolved":true,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    @classmethod"},{"line_number":112,"context_line":"    @db_api.CONTEXT_READER"},{"line_number":113,"context_line":"    def get_router_agents_count(cls, context, ha\u003dFalse, less_than\u003d0):"},{"line_number":114,"context_line":"        # TODO(sshank): This is pulled out from l3_agentschedulers_db.py"},{"line_number":115,"context_line":"        # until a way to handle joins is figured out."},{"line_number":116,"context_line":"        binding_model \u003d rb_model.RouterL3AgentBinding"}],"source_content_type":"text/x-python","patch_set":4,"id":"e7707d66_e8c4c900","line":113,"range":{"start_line":113,"start_character":8,"end_line":113,"end_character":31},"in_reply_to":"9c501984_3e409905","updated":"2022-06-20 12:32:56.000000000","message":"+1","commit_id":"2967914ec5e517b914198340eabdc2b47d9b030c"},{"author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"change_message_id":"2d6bb4f73c75eb938831b896294c543933703008","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    @classmethod"},{"line_number":112,"context_line":"    @db_api.CONTEXT_READER"},{"line_number":113,"context_line":"    def get_router_agents_count(cls, context, ha\u003dFalse, less_than\u003d0):"},{"line_number":114,"context_line":"        # TODO(sshank): This is pulled out from l3_agentschedulers_db.py"},{"line_number":115,"context_line":"        # until a way to handle joins is figured out."},{"line_number":116,"context_line":"        binding_model \u003d rb_model.RouterL3AgentBinding"}],"source_content_type":"text/x-python","patch_set":4,"id":"5514540f_3c857e22","line":113,"range":{"start_line":113,"start_character":8,"end_line":113,"end_character":31},"in_reply_to":"e7707d66_e8c4c900","updated":"2023-02-17 01:22:39.000000000","message":"Done","commit_id":"2967914ec5e517b914198340eabdc2b47d9b030c"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"830a79d8e8fedd080bbeee0610c9ec00e2e865ca","unresolved":true,"context_lines":[{"line_number":114,"context_line":"        # TODO(sshank): This is pulled out from l3_agentschedulers_db.py"},{"line_number":115,"context_line":"        # until a way to handle joins is figured out."},{"line_number":116,"context_line":"        binding_model \u003d rb_model.RouterL3AgentBinding"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        sub_query \u003d (context.session.query("},{"line_number":119,"context_line":"            binding_model.router_id,"},{"line_number":120,"context_line":"            func.count(binding_model.router_id).label(\u0027count\u0027))."}],"source_content_type":"text/x-python","patch_set":4,"id":"8a98f711_50c6490f","line":117,"updated":"2022-06-20 12:32:56.000000000","message":"nit: is this new line necessary here?","commit_id":"2967914ec5e517b914198340eabdc2b47d9b030c"},{"author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"change_message_id":"2d6bb4f73c75eb938831b896294c543933703008","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        # TODO(sshank): This is pulled out from l3_agentschedulers_db.py"},{"line_number":115,"context_line":"        # until a way to handle joins is figured out."},{"line_number":116,"context_line":"        binding_model \u003d rb_model.RouterL3AgentBinding"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        sub_query \u003d (context.session.query("},{"line_number":119,"context_line":"            binding_model.router_id,"},{"line_number":120,"context_line":"            func.count(binding_model.router_id).label(\u0027count\u0027))."}],"source_content_type":"text/x-python","patch_set":4,"id":"27eb636e_423ac803","line":117,"in_reply_to":"8a98f711_50c6490f","updated":"2023-02-17 01:22:39.000000000","message":"Done","commit_id":"2967914ec5e517b914198340eabdc2b47d9b030c"}],"neutron/scheduler/l3_agent_scheduler.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"368ebf25ebe8643648aaa332827a36fb2a2356d4","unresolved":true,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        for router, count in plugin.get_routers_l3_agents_count("},{"line_number":114,"context_line":"                context, ha\u003dTrue, less_than\u003dmax_agents_for_ha):"},{"line_number":115,"context_line":"            if count \u003c max_agents_for_ha:"},{"line_number":116,"context_line":"                # it\u0027s an HA router and it was under-scheduled (scheduled to"},{"line_number":117,"context_line":"                # less than max_agents_for_ha). Either way, it should be added"},{"line_number":118,"context_line":"                # to the list of routers we want to handle."}],"source_content_type":"text/x-python","patch_set":1,"id":"b3a23de8_6b07a7c2","line":115,"range":{"start_line":115,"start_character":21,"end_line":115,"end_character":23},"updated":"2022-05-17 15:40:39.000000000","message":"Should be \"\u003c\u003d\" (less or equal)? Because you are filtering this query by \"query.filter(count \u003c less_than)\"","commit_id":"26422f9ff680677f7412d646998a79d80061e78d"},{"author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"change_message_id":"82a7e61d6a4969ded8384bb6e6340df0b039bbc4","unresolved":true,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        for router, count in plugin.get_routers_l3_agents_count("},{"line_number":114,"context_line":"                context, ha\u003dTrue, less_than\u003dmax_agents_for_ha):"},{"line_number":115,"context_line":"            if count \u003c max_agents_for_ha:"},{"line_number":116,"context_line":"                # it\u0027s an HA router and it was under-scheduled (scheduled to"},{"line_number":117,"context_line":"                # less than max_agents_for_ha). Either way, it should be added"},{"line_number":118,"context_line":"                # to the list of routers we want to handle."}],"source_content_type":"text/x-python","patch_set":1,"id":"e1e6e492_064c2703","line":115,"range":{"start_line":115,"start_character":21,"end_line":115,"end_character":23},"in_reply_to":"b3a23de8_6b07a7c2","updated":"2022-05-17 22:26:29.000000000","message":"I think it should still be \"\u003c\". IMO after \"query.filter(count \u003c less_than)\", the remaining routers should all have less than max_agents_for_ha routers.","commit_id":"26422f9ff680677f7412d646998a79d80061e78d"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"52c8b3d8633e2ce982d31e4e097c1910f1af30a5","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        for router, count in plugin.get_routers_l3_agents_count("},{"line_number":114,"context_line":"                context, ha\u003dTrue, less_than\u003dmax_agents_for_ha):"},{"line_number":115,"context_line":"            if count \u003c max_agents_for_ha:"},{"line_number":116,"context_line":"                # it\u0027s an HA router and it was under-scheduled (scheduled to"},{"line_number":117,"context_line":"                # less than max_agents_for_ha). Either way, it should be added"},{"line_number":118,"context_line":"                # to the list of routers we want to handle."}],"source_content_type":"text/x-python","patch_set":1,"id":"3cc0e012_bafe38c4","line":115,"range":{"start_line":115,"start_character":21,"end_line":115,"end_character":23},"in_reply_to":"e1e6e492_064c2703","updated":"2022-06-08 11:54:18.000000000","message":"You are right","commit_id":"26422f9ff680677f7412d646998a79d80061e78d"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"830a79d8e8fedd080bbeee0610c9ec00e2e865ca","unresolved":true,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        # since working out a unified SQL is hard for both regular and"},{"line_number":106,"context_line":"        # ha routers. Split its up and run queries separately"},{"line_number":107,"context_line":"        for router, count in plugin.get_routers_l3_agents_count("},{"line_number":108,"context_line":"                context, ha\u003dFalse, less_than\u003d1):"},{"line_number":109,"context_line":"            if count \u003c 1:"},{"line_number":110,"context_line":"                # the router was un-scheduled (scheduled to 0 agents),"},{"line_number":111,"context_line":"                underscheduled_routers.append(router)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        for router, count in plugin.get_routers_l3_agents_count("},{"line_number":114,"context_line":"                context, ha\u003dTrue, less_than\u003dmax_agents_for_ha):"},{"line_number":115,"context_line":"            if count \u003c max_agents_for_ha:"},{"line_number":116,"context_line":"                # it\u0027s an HA router and it was under-scheduled (scheduled to"},{"line_number":117,"context_line":"                # less than max_agents_for_ha). Either way, it should be added"},{"line_number":118,"context_line":"                # to the list of routers we want to handle."}],"source_content_type":"text/x-python","patch_set":4,"id":"9fba8067_18623b5b","line":115,"range":{"start_line":107,"start_character":0,"end_line":115,"end_character":41},"updated":"2022-06-20 12:32:56.000000000","message":"for me this looks really good idea for optimization","commit_id":"2967914ec5e517b914198340eabdc2b47d9b030c"},{"author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"change_message_id":"2d6bb4f73c75eb938831b896294c543933703008","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        # since working out a unified SQL is hard for both regular and"},{"line_number":106,"context_line":"        # ha routers. Split its up and run queries separately"},{"line_number":107,"context_line":"        for router, count in plugin.get_routers_l3_agents_count("},{"line_number":108,"context_line":"                context, ha\u003dFalse, less_than\u003d1):"},{"line_number":109,"context_line":"            if count \u003c 1:"},{"line_number":110,"context_line":"                # the router was un-scheduled (scheduled to 0 agents),"},{"line_number":111,"context_line":"                underscheduled_routers.append(router)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        for router, count in plugin.get_routers_l3_agents_count("},{"line_number":114,"context_line":"                context, ha\u003dTrue, less_than\u003dmax_agents_for_ha):"},{"line_number":115,"context_line":"            if count \u003c max_agents_for_ha:"},{"line_number":116,"context_line":"                # it\u0027s an HA router and it was under-scheduled (scheduled to"},{"line_number":117,"context_line":"                # less than max_agents_for_ha). Either way, it should be added"},{"line_number":118,"context_line":"                # to the list of routers we want to handle."}],"source_content_type":"text/x-python","patch_set":4,"id":"78f33a1f_22733eb6","line":115,"range":{"start_line":107,"start_character":0,"end_line":115,"end_character":41},"in_reply_to":"9fba8067_18623b5b","updated":"2023-02-17 01:22:39.000000000","message":"Done","commit_id":"2967914ec5e517b914198340eabdc2b47d9b030c"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"78869dc40130b281b62fd644160048189d4277e6","unresolved":true,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        # since working out a unified SQL is hard for both regular and"},{"line_number":106,"context_line":"        # ha routers. Split its up and run queries separately"},{"line_number":107,"context_line":"        for router, count in plugin.get_routers_l3_agents_count("},{"line_number":108,"context_line":"                context, ha\u003dFalse, less_than\u003d1):"},{"line_number":109,"context_line":"            if count \u003c 1:"},{"line_number":110,"context_line":"                # the router was un-scheduled (scheduled to 0 agents),"},{"line_number":111,"context_line":"                underscheduled_routers.append(router)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        for router, count in plugin.get_routers_l3_agents_count("},{"line_number":114,"context_line":"                context, ha\u003dTrue, less_than\u003dmax_agents_for_ha):"}],"source_content_type":"text/x-python","patch_set":7,"id":"d104d038_8f8a861c","line":111,"range":{"start_line":107,"start_character":2,"end_line":111,"end_character":53},"updated":"2023-03-17 16:02:29.000000000","message":"with splitting up it can happen that the router is added twice to the list underscheduled_routers, am I right?","commit_id":"3a4bcc1e68a597cec4bd795ca55eaff4f44a9419"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"afa2d563d514ee631cb989a78ec7b33e6283fef6","unresolved":true,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        # since working out a unified SQL is hard for both regular and"},{"line_number":106,"context_line":"        # ha routers. Split its up and run queries separately"},{"line_number":107,"context_line":"        for router, count in plugin.get_routers_l3_agents_count("},{"line_number":108,"context_line":"                context, ha\u003dFalse, less_than\u003d1):"},{"line_number":109,"context_line":"            if count \u003c 1:"},{"line_number":110,"context_line":"                # the router was un-scheduled (scheduled to 0 agents),"},{"line_number":111,"context_line":"                underscheduled_routers.append(router)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        for router, count in plugin.get_routers_l3_agents_count("},{"line_number":114,"context_line":"                context, ha\u003dTrue, less_than\u003dmax_agents_for_ha):"}],"source_content_type":"text/x-python","patch_set":7,"id":"659453d0_49b885aa","line":111,"range":{"start_line":107,"start_character":2,"end_line":111,"end_character":53},"in_reply_to":"9a733783_80f1f5e9","updated":"2023-03-23 15:19:30.000000000","message":"yes, router can\u0027t be ha and non-ha at the same time","commit_id":"3a4bcc1e68a597cec4bd795ca55eaff4f44a9419"},{"author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"change_message_id":"731aa2cb3ded529e77d74beb5c19a62ee5be784f","unresolved":true,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        # since working out a unified SQL is hard for both regular and"},{"line_number":106,"context_line":"        # ha routers. Split its up and run queries separately"},{"line_number":107,"context_line":"        for router, count in plugin.get_routers_l3_agents_count("},{"line_number":108,"context_line":"                context, ha\u003dFalse, less_than\u003d1):"},{"line_number":109,"context_line":"            if count \u003c 1:"},{"line_number":110,"context_line":"                # the router was un-scheduled (scheduled to 0 agents),"},{"line_number":111,"context_line":"                underscheduled_routers.append(router)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        for router, count in plugin.get_routers_l3_agents_count("},{"line_number":114,"context_line":"                context, ha\u003dTrue, less_than\u003dmax_agents_for_ha):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a733783_80f1f5e9","line":111,"range":{"start_line":107,"start_character":2,"end_line":111,"end_character":53},"in_reply_to":"d104d038_8f8a861c","updated":"2023-03-20 07:37:04.000000000","message":"it shouldn\u0027t unless ha and un-ha are mutually exclusive.","commit_id":"3a4bcc1e68a597cec4bd795ca55eaff4f44a9419"}]}